From b37ed2f4c138f2f81b37038b8f2a5914a4e49de5 Mon Sep 17 00:00:00 2001
From: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Date: Tue, 21 Jul 2026 12:26:35 +0200
Subject: [PATCH] GH-3618: Ban JUnit4 imports

---
 pom.xml | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/pom.xml b/pom.xml
index d49e27de5a..39cda88c61 100644
--- a/pom.xml
+++ b/pom.xml
@@ -310,6 +310,13 @@
 
         <plugin>
           <artifactId>maven-enforcer-plugin</artifactId>
+          <dependencies>
+            <dependency>
+              <groupId>de.skuzzle.enforcer</groupId>
+              <artifactId>restrict-imports-enforcer-rule</artifactId>
+              <version>3.0.0</version>
+            </dependency>
+          </dependencies>
           <executions>
             <execution>
               <id>enforce-banned-dependencies</id>
@@ -328,6 +335,34 @@
                 <fail>true</fail>
               </configuration>
             </execution>
+            <execution>
+              <id>enforce-banned-junit4-imports</id>
+              <phase>process-test-sources</phase>
+              <goals>
+                <goal>enforce</goal>
+              </goals>
+              <configuration>
+                <rules>
+                  <RestrictImports>
+                    <reason>Use JUnit 5 (org.junit.jupiter.*) and AssertJ instead of JUnit 4</reason>
+                    <includeTestCode>true</includeTestCode>
+                    <bannedImports>
+                      <bannedImport>org.junit.**</bannedImport>
+                      <bannedImport>junit.framework.**</bannedImport>
+                    </bannedImports>
+                    <allowedImports>
+                      <allowedImport>org.junit.jupiter.**</allowedImport>
+                      <allowedImport>org.junit.platform.**</allowedImport>
+                    </allowedImports>
+                    <!-- Benchmark tests rely on JUnit 4 @Rule via junit-benchmarks with jupiter migration support -->
+                    <exclusions>
+                      <exclusion>org.apache.parquet.column.values.**.benchmark.**</exclusion>
+                    </exclusions>
+                  </RestrictImports>
+                </rules>
+                <fail>true</fail>
+              </configuration>
+            </execution>
           </executions>
         </plugin>
         <plugin>