From 5adf134ed190f6043a7e86fb6107aaa77cf31da4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Rou=C3=A9l?= Date: Thu, 2 Apr 2026 18:54:59 +0200 Subject: [PATCH] Avoid Long boxing on the write path --- .../parquet/hadoop/InternalParquetRecordWriter.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java index 41b068d01a..7674cab757 100644 --- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java +++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java @@ -171,7 +171,9 @@ public long getDataSize() { private void checkBlockSizeReached() throws IOException { if (recordCount >= rowGroupRecordCountThreshold) { - LOG.debug("record count reaches threshold: flushing {} records to disk.", recordCount); + if (LOG.isDebugEnabled()) { + LOG.debug("record count reaches threshold: flushing {} records to disk.", recordCount); + } flushRowGroupToStore(); initStore(); recordCountForNextMemCheck = min( @@ -185,7 +187,9 @@ private void checkBlockSizeReached() throws IOException { // flush the row group if it is within ~2 records of the limit // it is much better to be slightly under size than to be over at all if (memSize > (nextRowGroupSize - 2 * recordSize)) { - LOG.debug("mem size {} > {}: flushing {} records to disk.", memSize, nextRowGroupSize, recordCount); + if (LOG.isDebugEnabled()) { + LOG.debug("mem size {} > {}: flushing {} records to disk.", memSize, nextRowGroupSize, recordCount); + } flushRowGroupToStore(); initStore(); recordCountForNextMemCheck = min( @@ -201,7 +205,9 @@ private void checkBlockSizeReached() throws IOException { recordCount + props.getMaxRowCountForPageSizeCheck() // will not look more than max records ahead ); - LOG.debug("Checked mem at {} will check again at: {}", recordCount, recordCountForNextMemCheck); + if (LOG.isDebugEnabled()) { + LOG.debug("Checked mem at {} will check again at: {}", recordCount, recordCountForNextMemCheck); + } } } }