From c9af89e5fe3e66f619ac4a1dcb130e578cc79565 Mon Sep 17 00:00:00 2001 From: Jan Friedrich Date: Sun, 16 Aug 2026 21:25:38 +0200 Subject: [PATCH 1/2] mark log4net.Ext.Mail as CLS compliant (#307) --- src/Directory.Build.props | 7 +++++++ src/log4net.Ext.Mail/Appender/SmtpAppender.cs | 7 +++++++ src/log4net/AssemblyInfo.cs | 1 - 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 8c4ab3ac8..126deb498 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -31,4 +31,11 @@ + + + + <_Parameter1>true + + \ No newline at end of file diff --git a/src/log4net.Ext.Mail/Appender/SmtpAppender.cs b/src/log4net.Ext.Mail/Appender/SmtpAppender.cs index 53f07aa4f..54ce6a917 100644 --- a/src/log4net.Ext.Mail/Appender/SmtpAppender.cs +++ b/src/log4net.Ext.Mail/Appender/SmtpAppender.cs @@ -356,6 +356,13 @@ protected virtual void SendEmail(string messageBody) /// /// the body text to include in the mail /// the message to send + /// + /// + /// Not CLS compliant, because comes from MimeKit, which does not + /// declare itself CLS compliant. + /// + /// + [CLSCompliant(false)] protected virtual MimeMessage CreateMessage(string messageBody) { MimeMessage message = new(); diff --git a/src/log4net/AssemblyInfo.cs b/src/log4net/AssemblyInfo.cs index 58f9ab7ec..8c87d7d9b 100644 --- a/src/log4net/AssemblyInfo.cs +++ b/src/log4net/AssemblyInfo.cs @@ -19,7 +19,6 @@ // log4net makes use of static methods which cannot be made com visible [assembly: System.Runtime.InteropServices.ComVisible(false)] -[assembly: System.CLSCompliant(true)] // If log4net is strongly named it still allows partially trusted callers [assembly: System.Security.AllowPartiallyTrustedCallers] From fe5997b1904bb9c1f32c18e639ac7a4f40608251 Mon Sep 17 00:00:00 2001 From: Jan Friedrich Date: Sun, 16 Aug 2026 21:44:43 +0200 Subject: [PATCH 2/2] fix macos CI build --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 564337a35..f2af14e8e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -45,7 +45,7 @@ jobs: uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # 4.1.7 - name: Set up dotnet - uses: actions/setup-dotnet@6bd8b7f7774af54e05809fcc5431931b3eb1ddee # 4.0.1 + uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # 6.0.0 with: dotnet-version: 10 dotnet-quality: ga