Skip to content

branch-4.0: [fix](be) Fix time-sharing executor queued task count#65043

Open
Jungzhang wants to merge 2 commits into
apache:branch-4.0from
Jungzhang:pick-64855-branch-4.0
Open

branch-4.0: [fix](be) Fix time-sharing executor queued task count#65043
Jungzhang wants to merge 2 commits into
apache:branch-4.0from
Jungzhang:pick-64855-branch-4.0

Conversation

@Jungzhang

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #63568

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Keep the executor queued-task metric consistent when queued splits are removed before execution. The fix routes queue offer/remove operations through helpers that update _total_queued_tasks together with the split queue and token state.

Add a regression test that enqueues splits with no worker threads, removes their tasks, and verifies the queue count returns to zero so later submissions are not rejected as full.
@Jungzhang
Jungzhang requested a review from morningman as a code owner June 30, 2026 10:33
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jungzhang

Copy link
Copy Markdown
Contributor Author

run buildall

@Jungzhang

Copy link
Copy Markdown
Contributor Author

run p0

@Jungzhang

Copy link
Copy Markdown
Contributor Author

run external

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.33% (28/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (25567/35760)
Line Coverage 54.38% (271182/498658)
Region Coverage 51.83% (224285/432747)
Branch Coverage 53.31% (96678/181335)

@Jungzhang

Copy link
Copy Markdown
Contributor Author

run p0

@Jungzhang

Copy link
Copy Markdown
Contributor Author

run external

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.33% (28/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (25567/35760)
Line Coverage 54.38% (271173/498658)
Region Coverage 51.83% (224313/432747)
Branch Coverage 53.31% (96677/181335)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.33% (28/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (25567/35760)
Line Coverage 54.38% (271175/498658)
Region Coverage 51.83% (224314/432747)
Branch Coverage 53.32% (96679/181335)

@Jungzhang

Copy link
Copy Markdown
Contributor Author

Hi @morningman PR #65043 is ready for review. The relevant formatting and compilation checks have passed. Could you please review and merge it when convenient? Thank you!

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 93.33% (28/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.55% (19582/36568)
Line Coverage 36.61% (183274/500554)
Region Coverage 33.18% (142514/429501)
Branch Coverage 34.04% (61614/181024)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.33% (28/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.61% (25620/35775)
Line Coverage 54.48% (271794/498900)
Region Coverage 52.02% (225230/432929)
Branch Coverage 53.51% (97096/181446)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants