chore: remove dead Parquet parallel-IO configs#4981
Merged
Conversation
These configs were consumed by the JVM-side Parquet reader that has since been removed. They are referenced nowhere in current native or JVM code and mislead operators tuning benchmarks. Removed configs: - spark.comet.parquet.read.parallel.io.enabled - spark.comet.parquet.read.parallel.io.thread-pool.size - spark.comet.parquet.read.io.mergeRanges - spark.comet.parquet.read.io.mergeRanges.delta - spark.comet.parquet.read.io.adjust.readRange.skew Also removes the stale ParquetReadSuite "test merge scan range" test, which only asserted that the (dead) config propagated to the Hadoop conf. Refs apache#4842.
Contributor
|
Can you nab "spark.comet.use.lazyMaterialization" as well? |
Contributor
|
Actually, CI is green, we can get it in a followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially addresses #4842 (Item #9 in the remediation section: "Delete or implement the dead IO configs (
parallel.io.*,mergeRanges) so benchmarking isn't misled").Rationale for this change
The following configs are defined in
CometConf.scalabut referenced nowhere in current native or JVM code. They were consumed by the JVM-side Parquet reader that has since been removed:spark.comet.parquet.read.parallel.io.enabled(defaulttrue)spark.comet.parquet.read.parallel.io.thread-pool.size(default16)spark.comet.parquet.read.io.mergeRanges(defaulttrue)spark.comet.parquet.read.io.mergeRanges.delta(default8 MB)spark.comet.parquet.read.io.adjust.readRange.skew(defaultfalse)These are a trap: they appear tunable but change nothing. Anyone benchmarking "Comet with IO tuning" is tuning a no-op.
What changes are included in this PR?
CometConf.scala.ParquetReadSuite"test merge scan range" test, which only asserted that the (dead) config propagated to the Hadoop conf.The auto-generated
configs.mdwill be regenerated on the next docs build and will no longer list these entries.How are these changes tested?
Compile-checked against
spark-3.5. No behavior change — these configs were no-ops in current code.