Skip to content

ORCA: handle INDF predicate in PdxlnMergeJoin #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yjhjstz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ORCA: handle INDF predicate in PdxlnMergeJoin #1756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 28 additions & 23 deletions src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4964,41 +4964,46 @@ CTranslatorExprToDXL::PdxlnMergeJoin(CExpression *pexprMJ,
// At this point, they all better be merge joinable
GPOS_ASSERT(CPhysicalJoin::FMergeJoinCompatible(
pexprPred, pexprOuterChild, pexprInnerChild));
CExpression *pexprPredOuter = (*pexprPred)[0];
CExpression *pexprPredInner = (*pexprPred)[1];

// align extracted columns with outer and inner children of the join
CColRefSet *pcrsOuterChild = pexprOuterChild->DeriveOutputColumns();
CColRefSet *pcrsPredInner = pexprPredInner->DeriveUsedColumns();
// Extract the two key columns out of pexprPred. Plain equality
// is `a = b` (binary ScalarCmp) but NULL-safe equality (INDF) is
// `NOT (a IS DISTINCT FROM b)`, a *unary* NOT around the binary
// IsDistinctFrom. Indexing [0]/[1] directly works for equality
// but accesses out of bounds for INDF.
CExpression *pexprPredOuter = nullptr;
CExpression *pexprPredInner = nullptr;
IMDId *mdid_scop = nullptr;
CPhysicalJoin::AlignJoinKeyOuterInner(pexprPred, pexprOuterChild,
pexprInnerChild, &pexprPredOuter,
&pexprPredInner, &mdid_scop);

#ifdef GPOS_DEBUG
CColRefSet *pcrsOuterChild = pexprOuterChild->DeriveOutputColumns();
CColRefSet *pcrsInnerChild = pexprInnerChild->DeriveOutputColumns();
CColRefSet *pcrsPredOuter = pexprPredOuter->DeriveUsedColumns();
CColRefSet *pcrsPredInner = pexprPredInner->DeriveUsedColumns();
GPOS_ASSERT(pcrsOuterChild->ContainsAll(pcrsPredOuter) &&
pcrsInnerChild->ContainsAll(pcrsPredInner) &&
"merge join keys are not aligned with children");
#endif

if (pcrsOuterChild->ContainsAll(pcrsPredInner))
pexprPredOuter->AddRef();
pexprPredInner->AddRef();
CExpression *pexprPredNew;
if (CPredicateUtils::IsEqualityOp(pexprPred))
{
GPOS_ASSERT(pcrsInnerChild->ContainsAll(pcrsPredOuter));
std::swap(pexprPredOuter, pexprPredInner);
#ifdef GPOS_DEBUG
std::swap(pcrsPredOuter, pcrsPredInner);
#endif

pexprPredOuter->AddRef();
pexprPredInner->AddRef();
pexprPred =
CUtils::PexprScalarEqCmp(m_mp, pexprPredOuter, pexprPredInner);
pexprPredNew = CUtils::PexprScalarCmp(m_mp, pexprPredOuter,
pexprPredInner, mdid_scop);
}
else
{
pexprPred->AddRef();
GPOS_ASSERT(CPredicateUtils::FINDF(pexprPred));
Comment thread
yjhjstz marked this conversation as resolved.
pexprPredNew = CUtils::PexprINDF(m_mp, pexprPredOuter,
pexprPredInner, mdid_scop);
}

GPOS_ASSERT(pcrsOuterChild->ContainsAll(pcrsPredOuter) &&
pcrsInnerChild->ContainsAll(pcrsPredInner) &&
"merge join keys are not aligned with children");

dxlnode_merge_conds->AddChild(PdxlnScalar(pexprPred));
pexprPred->Release();
dxlnode_merge_conds->AddChild(PdxlnScalar(pexprPredNew));
pexprPredNew->Release();
}
pdrgpexprPredicates->Release();

Expand Down
Loading