GH-1196: Write NO_COMPRESSION_LENGTH sentinel for empty buffers in compress()#1248
Open
PG1204 wants to merge 1 commit into
Open
GH-1196: Write NO_COMPRESSION_LENGTH sentinel for empty buffers in compress()#1248PG1204 wants to merge 1 commit into
PG1204 wants to merge 1 commit into
Conversation
PG1204
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
July 24, 2026 17:10
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Author
Notes for reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
AbstractCompressionCodec.compress()wrote a length prefix of0for empty buffers. The Arrow IPC compression format only defines a positive length (compressed) or-1/NO_COMPRESSION_LENGTH(stored uncompressed); a0prefix is undefined. As a result, C++/PyArrow reject Java-produced streams that contain empty buffers, even though Java itself accepts them on read.This changes the empty-buffer shortcut in
compress()to writeCompressionUtil.NO_COMPRESSION_LENGTH(-1) instead of0.decompress()is intentionally left unchanged:NO_COMPRESSION_LENGTHbranch handles the new output, anddecompressedLength == 0branch remains for backward-compatible reads of older Java-produced streams.Added a parameterized test (
testEmptyBufferWritesUncompressedSentinel, covering LZ4 and ZSTD) that compresses an empty buffer, asserts the prefix equalsNO_COMPRESSION_LENGTH, and asserts it round-trips back to a zero-length buffer. The pre-existingtestEmptyBuffercontinues to pass with empty buffers now routed through the-1path.Closes #1196.