Bug
The documented frontend verification commands do not work cleanly on main.
Reproduction
From a clean checkout:
cd frontend
npm run typecheck
Observed result:
forge.config.ts(33,51): error TS2339: Property 'osxNotarize' does not exist on type 'ForgePackagerOptions | undefined'.
The repo guidance also tells contributors to run:
cd frontend
npm run build
but frontend/package.json does not define a build script.
Root Cause
forge.config.ts casts the keychain-profile notarization branch through ForgeConfig["packagerConfig"]["osxNotarize"]. Because packagerConfig is optional on the public Forge config type, TypeScript rejects that indexed access.
The frontend workflow currently skips typecheck because of this pre-existing type error, so frontend PRs can pass CI while TypeScript regressions remain hidden.
Fix
Use the installed notarization credential type directly for the keychain-profile branch, add a real frontend build script, and restore npm run typecheck in the frontend CI workflow.
Impact
Contributors can run the documented frontend checks locally, and CI regains the TypeScript safety net for frontend changes.
Bug
The documented frontend verification commands do not work cleanly on
main.Reproduction
From a clean checkout:
cd frontend npm run typecheckObserved result:
The repo guidance also tells contributors to run:
cd frontend npm run buildbut
frontend/package.jsondoes not define abuildscript.Root Cause
forge.config.tscasts the keychain-profile notarization branch throughForgeConfig["packagerConfig"]["osxNotarize"]. BecausepackagerConfigis optional on the public Forge config type, TypeScript rejects that indexed access.The frontend workflow currently skips typecheck because of this pre-existing type error, so frontend PRs can pass CI while TypeScript regressions remain hidden.
Fix
Use the installed notarization credential type directly for the keychain-profile branch, add a real frontend
buildscript, and restorenpm run typecheckin the frontend CI workflow.Impact
Contributors can run the documented frontend checks locally, and CI regains the TypeScript safety net for frontend changes.