Skip to content

Fix QuantityValue number comments - #1729

Open
lipchev wants to merge 1 commit into
angularsen:masterfrom
lipchev:codex/fix-quantityvalue-number-comments
Open

Fix QuantityValue number comments#1729
lipchev wants to merge 1 commit into
angularsen:masterfrom
lipchev:codex/fix-quantityvalue-number-comments

Conversation

@lipchev

@lipchev lipchev commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Fix QuantityValue number comments

PR Classification

Documentation update to clarify the XML comments for the IsNegative and IsPositive methods.

PR Summary

This pull request improves the clarity of XML documentation for the IsNegative and IsPositive methods to accurately describe their behavior.

  • Updated XML documentation comments for IsNegative and IsPositive methods to clarify their purpose and remove ambiguous references to "negative real number" and "(positive) zero or a positive real number".

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98%. Comparing base (3bf1ef4) to head (b1ea4ca).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1729   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files         515     515           
  Lines       24092   24092           
======================================
  Hits        23692   23692           
  Misses        400     400           
Flag Coverage Δ
net48 97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lipchev

lipchev commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

I almost felt guilty kicking off all this compute for just a simple comment change but, yeah I guess this is where we're at..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant