Skip to content

refactor-jasmine-vitest does not include describe if xdescribe was used #33021

@advgal

Description

@advgal

Command

generate

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

I used
ng g @schematics/angular:refactor-jasmine-vitest --add-imports
the tests that was marked with xdescribe where converted to describe.skip but describe was not imported.

Minimal Reproduction

generate a project with karma, mark a test with xdescribe and start the command I mentioned

Exception or Error


Your Environment

_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI       : 21.2.7
Angular           : 21.2.9
Node.js           : 24.12.0
Package Manager   : npm 11.6.2
Operating System  : linux x64

┌───────────────────────────────────┬───────────────────┬───────────────────┐
│ Package                           │ Installed Version │ Requested Version │
├───────────────────────────────────┼───────────────────┼───────────────────┤
│ @angular/animations               │ 21.2.9            │ ^21.2.9           │
│ @angular/build                    │ 21.2.7            │ ^21.2.7           │
│ @angular/cli                      │ 21.2.7            │ ~21.2.7           │
│ @angular/common                   │ 21.2.9            │ ^21.2.9           │
│ @angular/compiler                 │ 21.2.9            │ ^21.2.9           │
│ @angular/compiler-cli             │ 21.2.9            │ ^21.2.9           │
│ @angular/core                     │ 21.2.9            │ ^21.2.9           │
│ @angular/forms                    │ 21.2.9            │ ^21.2.9           │
│ @angular/localize                 │ 21.2.9            │ ^21.2.9           │
│ @angular/platform-browser         │ 21.2.9            │ ^21.2.9           │
│ @angular/platform-browser-dynamic │ 21.2.9            │ ^21.2.9           │
│ @angular/router                   │ 21.2.9            │ ^21.2.9           │
│ ng-packagr                        │ 21.2.2            │ ^21.2.2           │
│ rxjs                              │ 7.8.2             │ ~7.8.1            │
│ typescript                        │ 5.9.3             │ ~5.9.3            │
│ vitest                            │ 4.1.4             │ ^4.1.4            │
│ zone.js                           │ 0.15.1            │ ~0.15.1           │
└───────────────────────────────────┴───────────────────┴───────────────────┘

Anything else relevant?

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions