From 6f2844f7fd28a0e14506cfac9469efea11af8a18 Mon Sep 17 00:00:00 2001 From: cpovirk Date: Wed, 16 Sep 2026 19:28:45 -0700 Subject: [PATCH] Remove null checks on the result of `Class.forName`. The method never returns `null`; it either fails or returns the `Class`. As a result, I am making calls like this into errors in https://github.com/google/error-prone/pull/6093. PiperOrigin-RevId: 982869904 --- .../java/androidx/test/ext/junit/runners/AndroidJUnit4.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java b/ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java index 95cbf9432..b40f3f795 100644 --- a/ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java +++ b/ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java @@ -71,7 +71,8 @@ && hasClass("org.robolectric.RobolectricTestRunner")) { private static boolean hasClass(String className) { try { - return Class.forName(className) != null; + Class unused = Class.forName(className); + return true; } catch (ClassNotFoundException e) { return false; }