fix(ci): include v prefix in release_version output for Ketryx#565
Merged
Conversation
Ketryx version names start with "v" (e.g. v1.3.0), but the get-release-version step was stripping it by capturing only the part after "v" in the regex match. This caused the version passed to the Ketryx compliance check to be bare semver (e.g. 1.3.0). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
olivermeyer
requested review from
a team and
helmut-hoffer-von-ankershoffen
as code owners
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release/CI metadata used by the SDK and the CI/CD pipeline, primarily to provide Ketryx with a v-prefixed release version derived from release/vX.Y.Z branch names.
Changes:
- Add a CI step to derive
release_versionfromrelease/v*branches and pass it to the Ketryx reporting workflow. - Extend the Ketryx reusable workflow to accept an optional
versioninput (in addition tocommit-sha) and forward it to the Ketryx GitHub Action. - Bump the project version from
1.2.0to1.3.0across release/version metadata files.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
VERSION |
Bumps the repo’s version marker to 1.3.0. |
uv.lock |
Updates locked package version metadata to 1.3.0. |
sonar-project.properties |
Updates Sonar project version to 1.3.0. |
pyproject.toml |
Updates project version and bumpversion current_version to 1.3.0. |
examples/notebook.py |
Updates example pin to aignostics==1.3.0. |
docs/source/conf.py |
Updates Sphinx docs version to 1.3.0. |
CLI_REFERENCE.md |
Updates rendered CLI banner to v1.3.0. |
aignostics.spec |
Updates app bundle version to 1.3.0. |
.github/workflows/ci-cd.yml |
Adds release_version output (with v prefix) and passes it to Ketryx; expands PR branch filters. |
.github/workflows/_ketryx_report_and_check.yml |
Adds version input support and conditionally uses it vs commit-sha. |
Codecov Report✅ All modified and coverable lines are covered by tests. |
arne-aignx
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
get-release-versionCI step was outputting a bare semver (e.g.1.3.0) when extracting the version from arelease/vX.Y.Zbranch name. Ketryx expects version names prefixed withv(e.g.v1.3.0), so the compliance check was receiving a version string in the wrong format.How?
Prepend
vto the captured regex group when writing to$GITHUB_OUTPUT, and add a comment explaining the requirement. The regex already strips thevby capturing only the part after it, so the fix is a minimal one-character change at the output line.