Skip to content

ci: pass release version to Ketryx on release/v* branches#562

Merged
olivermeyer merged 2 commits into
release/v1.3.0from
fix/ketryx-version
Apr 24, 2026
Merged

ci: pass release version to Ketryx on release/v* branches#562
olivermeyer merged 2 commits into
release/v1.3.0from
fix/ketryx-version

Conversation

@olivermeyer

Copy link
Copy Markdown
Collaborator

Why?
When CI runs on a release/v* branch, Ketryx should associate the build with the named release version (e.g. 1.2.3) rather than a transient commit SHA, so that compliance approvals collected during the prepare-release phase are correctly linked. PRs targeting release branches should also trigger the full CI/CD pipeline.

How?
The get-commit-message job now extracts the semver from the branch name and exposes it as release_version. This is forwarded to _ketryx_report_and_check.yml as a new optional version input; when set, it is passed to the Ketryx action and commit-sha is omitted. On all other contexts (PRs to main, main pushes, tags) the existing commit-SHA behaviour is unchanged. The pull_request trigger is also extended to include release/v* base branches.

Copilot AI review requested due to automatic review settings April 24, 2026 07:12
@olivermeyer olivermeyer added skip:test:long_running Skip long-running tests (≥5min) and removed skip:test:long_running Skip long-running tests (≥5min) labels Apr 24, 2026
@olivermeyer olivermeyer added the skip:test:long_running Skip long-running tests (≥5min) label Apr 24, 2026
@olivermeyer olivermeyer changed the base branch from main to release/v1.3.0 April 24, 2026 07:14
olivermeyer and others added 2 commits April 24, 2026 09:14
When CI/CD runs on a release/v* branch, extract the semver from the
branch name and pass it as the Ketryx `version` input instead of
`commit-sha`. This associates the build with the correct Ketryx release
entry rather than a transient commit SHA, enabling proper compliance
approval collection during the prepare-release phase.

On all other contexts (PRs, main, tags), the existing commit-sha
behaviour is unchanged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI/CD workflows so that runs on release/v* branches can report a stable release version to Ketryx (instead of a commit SHA), and ensures PRs targeting release branches trigger the full pipeline.

Changes:

  • Extend pull_request triggers to include release/v* base branches.
  • Extract a release_version from the branch name and forward it into the Ketryx reporting workflow.
  • Add an optional version input to the reusable Ketryx workflow and conditionally prefer it over commit-sha.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/ci-cd.yml Adds PR trigger for release/v* and computes/forwards release_version to Ketryx reporting.
.github/workflows/_ketryx_report_and_check.yml Adds version input and updates Ketryx action invocation to prefer version over commit-sha.

Comment thread .github/workflows/ci-cd.yml
Comment thread .github/workflows/_ketryx_report_and_check.yml
Comment thread .github/workflows/_ketryx_report_and_check.yml
@sonarqubecloud

Copy link
Copy Markdown

@olivermeyer olivermeyer enabled auto-merge (rebase) April 24, 2026 07:35
@olivermeyer olivermeyer merged commit 2eb340f into release/v1.3.0 Apr 24, 2026
24 checks passed
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 21 files with indirect coverage changes

@olivermeyer olivermeyer deleted the fix/ketryx-version branch April 24, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip:test:long_running Skip long-running tests (≥5min)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants