iter57 cluster-065: Lark CardKit Task.Run signal-only + actor-side rich continuation (#939)#940
Merged
loning merged 2 commits intoMay 24, 2026
Conversation
…ch continuation (#939) Phase 9 r4 consensus(structural framing,reflector retry-fix narrowing 后): - Task.Run helpers 改 signal-only(operation_id + minimal raw result) - Rich continuation(错误码/字段 mapping/timestamps)全在 actor handler 拼装 - typed LarkCardOperationCompletedEvent proto event 替代原 helper 内 rich continuation - architecture_guards.sh 新增 source guard 防 helper 内业务 mapping - 补 unit test 覆盖 signal-only payload + actor-side reconstruction closes #939 local PASS:architecture + test_stability + LarkCard unit tests(2 passed) ⟦AI:AUTO-LOOP⟧
Contributor
Author
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
Contributor
Author
📊 状态卡片 — fix 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
Contributor
Author
📊 codex 进展 review-pr940-omnibus-r1 (⏳ 进行中; 已跑 5 min)
|
⟦AI:AUTO-LOOP⟧
Contributor
Author
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
Contributor
Author
|
Verified r3 against head 10c8eb3. Checks performed:
Verdict: approve. ⟦AI:AUTO-LOOP⟧ |
Contributor
Author
📊 codex 进展 review-pr940-omnibus-r3 (⏳ 进行中; 已跑 8 min)
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## auto-refact-dev #940 +/- ##
===================================================
+ Coverage 82.83% 83.52% +0.69%
===================================================
Files 998 988 -10
Lines 63092 63645 +553
Branches 8161 8220 +59
===================================================
+ Hits 52261 53160 +899
+ Misses 7304 6924 -380
- Partials 3527 3561 +34
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced May 24, 2026
This was referenced May 24, 2026
loning
added a commit
that referenced
this pull request
May 24, 2026
…eaming + Nyx relay (#946) (#950) * iter57 cluster-068: 扩展 #940 LarkCardOperationCompletedEvent typed-signal 至 text streaming + Nyx relay (#946) Phase 9 r3 consensus(reflector r1 救场 + r2/r3 converge): - 扩展 #940 LarkCardOperationCompletedEvent typed-signal 到 ConversationGAgent text streaming + Nyx relay text 操作 - 删 unsafe execution shape(rich continuation 移到 actor handler) - actor-owned in-flight text operation state + generation matching + timeout + stale rejection + coalescing - 保留 CardKit/text behavior + CI guard 覆盖新 signal-only text helper - 不引入 new actor / port / envelope / topology / docs/canon closes #946 local PASS:architecture + test_stability + build + LarkCardOperationSignalTests + ConversationGAgentDedupTests ⟦AI:AUTO-LOOP⟧ * iter57 cluster-068 fix r2: sanitize NyxRelayTextOperationTimeoutFiredEvent payload(不泄露 reply_token) PR #950 r1 reject blocker: - timeout payload Chunk = chunk.Clone() 把 runtime-only reply_token / reply_token_expires_at_unix_ms 写入 durable scheduler state - 泄露 Nyx relay credentials 修: - timeout payload sanitize,只 carry typed fields needed for reconciliation - 不带 reply_token / expires_at 进 durable payload - 新增 NyxRelayTextOperationTimeoutPayloadTests:capture scheduled callback,验证 typed + serialized bytes 不含 credentials - 826/826 tests pass ⟦AI:AUTO-LOOP⟧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
iter57 cluster-065(severity:high)— Lark CardKit Task.Run signal-only + actor-side rich continuation
ConversationGAgent.LarkCardStreaming.cs:367,426,494三个Task.Runhelper 在 actor turn 外构造 rich continuation(错误码 classification、summary、card_id mapping、timestamps),违反 "Actor 单线程事实边界"operation_id + minimal raw result),所有 rich continuation 在 actor handler 拼装;新增 typedLarkCardOperationCompletedEventproto event违反:CLAUDE.md「Actor 设计 / 生命周期 / 执行模型 — 回调只发信号」「业务推进内聚」
Phase 9 共识链路
META_RESOLVED:retry-fix(CLAUDE "回调只发信号" 已覆盖 signal-only,narrow 到 rich continuation 构造点)META_JUDGE_DONE:consensus:structural✅详见 issue #939。
Scope
agents/Aevatar.GAgents.Channel.Runtime/Conversation/ConversationGAgent.LarkCardStreaming.cs(+/− major)agents/Aevatar.GAgents.Channel.Runtime/protos/conversation_events.proto(新 LarkCardOperationCompletedEvent typed event)test/Aevatar.GAgents.ChannelRuntime.Tests/LarkCardOperationSignalTests.cs(新)test/Aevatar.GAgents.Channel.Protocol.Tests/ConversationGAgentDedupTests.cstools/ci/architecture_guards.sh(新增 source guard)5 files changed, +886 / −315。
local PASS:architecture_guards + test_stability_guards + LarkCard unit tests(2 passed)
closes #939
🤖 Generated with Claude Code via codex-refactor-loop iter57
⟦AI:AUTO-LOOP⟧