requirements.txt and azure-pipelines.yml not in sync

[armijnhemel]

Description

requirements.txt and azure-pipelines.yml are not in sync with respect to click and possibly other packages.

requirements.txt says:

click==8.3.1

azure-pipelines.yml says:

    - template: etc/ci/azure-posix.yml
      parameters:
          job_name: ubuntu22_test_all_supported_click_versions
          image_name: ubuntu-22.04
          python_versions: ['3.10', '3.11', '3.12', '3.13', '3.14']
          python_architecture: x64
          test_suites:
              click_versions: |
                for clk_ver in 8.3.0 8.2.0 8.2.1 8.1.7 8.1.6 8.1.5 8.1.4 8.1.3 8.1.2 8.1.1 8.1.0 8.0.4 8.0.2 8.0.3 8.0.1 7.1.2 7.1.1 7.1 6.7;
                 do
                  venv/bin/pip install click==$clk_ver;
                  venv/bin/scancode -i samples/ -n3 --json foo.json;
                  venv/bin/scancode -i --verbose samples/ -n3 --json foo.json;
                 done

Some of these versions are really really old and the version of click that is in requirements.txt is missing.

[pombredanne]

Some of these versions are really really old and the version of click that is in requirements.txt is missing.

@armijnhemel the purpose of that test is to test with a bunch of older versions that were problematic. The current version in use in the built app is in the requirements alright, so this setup is by design and is not a problem. Though we can likely drop testing on some old Click versions, that may break the compat of some users using this code as a library: we should do this in a next major release

[armijnhemel]

But this doesn't address the fact that the version in requirements.txt is not being tested with, even though that was a problematic version if I recall correctly.

[pombredanne]

But this doesn't address the fact that the version in requirements.txt is not being tested with, even though that was a problematic version if I recall correctly.

The version in requirements.txt is the version that is tested for the full test suite all the times:

• this part runs our standard configure script https://github.com/aboutcode-org/scancode-toolkit/blob/develop/etc/ci/azure-posix.yml#L35 before running tests
• ... which installs all these requirements

  scancode-toolkit/configure

  Line 151 in 6570c13

  # Requirement arguments passed to pip and used by default or with --dev.

• ... which are then used for running all the 80K tests on each commit

[armijnhemel]

But this doesn't address the fact that the version in requirements.txt is not being tested with, even though that was a problematic version if I recall correctly.

The version in requirements.txt is the version that is tested for the full test suite all the times:

Huh. That was totally not clear from an outside view. I would still recommend ditching the old versions of click though....