ci: require two approvers for release-please PRs#1144
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
ishymko
force-pushed
the
ci/release-pr-approval-gate
branch
from
July 23, 2026 15:22
a92c40b to
3649343
Compare
holtskinner
approved these changes
Jul 23, 2026
ishymko
added a commit
to a2aproject/a2a-js
that referenced
this pull request
Jul 24, 2026
Port of a2aproject/a2a-python#1144, see description there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safety net pipeline to protect from accidental release creation which recognizes
release-pleasePRs based on thea2a-botauthor andrelease-please--branch name prefix and requires 2 approvers with at leastwritelevel access. This is an addition on top of built-in GitHub write access check. Release PRs could never be merged by non-maintainers, but now the requirement is 2 maintainers.Published via a commit status instead of a workflow failure to avoid "spam" emails of workflow failures, this check will be added as mandatory. For non-release PRs passes immediately.
Tested on fork: