Conversation
…sing getDependencyName() only recognized >, <, and = as version operator characters, causing ~ from ~= (compatibility) and ! from != (exclusion) to be included in the package name (e.g. "urllib3~", "click!"). Replaced the three-index approach with a loop that recognizes all PEP 508 version operator characters (>, <, =, ~, !). Fixes TC-4041 Assisted-by: Claude Code
Test Results453 tests 451 ✅ 1m 14s ⏱️ Results for commit d897b3c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDependencyName()to recognize~and!as PEP 508 version operator characters, preventing them from being included in the package name (e.g.urllib3~=1.26.0was parsed as packageurllib3~instead ofurllib3)getFirstSign()approach with a simple loop over all PEP 508 operator characters (>,<,=,~,!)~=) and exclusion (!=) operators, including combined extras + special operatorsImplements TC-4041
Test plan
~=and!=parsingrequirements.txtfrom the ticket produces correct SBOM🤖 Generated with Claude Code