Preserve existing package source mappings in XSAddNugetSource.prgx#1945
Closed
Copilot wants to merge 1 commit into
Closed
Preserve existing package source mappings in XSAddNugetSource.prgx#1945Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/8428819e-b1b2-4ad3-8c64-2c054715861d Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
RobertvanderHulst
May 22, 2026 14:09
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script was unconditionally adding/overwriting
packageSourceMappingentries on every run, causing pre-existing third-party source mappings to be lost.Changes
Main body — conditional mapping logic
packageSourceMappingsection already exists: only update/add theXSharp.*→XSharp Offline Packagesentry; all other mappings are left untouchedpackageSourceMappingsection exists: create it fresh with both*→nuget.organdXSharp.*→XSharp Offline Packages(addingnuget.orgas a package source too if absent)GetSetSourceMapping— true update semantics<packageSource>element and adds the pattern if absent — making the function a genuine "update or add"