Code Quality: Remove conditions identified as always false - #13676
arshidkv12 wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The `if ( $interim_login )` check was located inside an `if ( ! $interim_login && ... )` block, so it would always be `false`. Developed in #13676. Follow-up to r52058. Props arshidkv12, SergeyBiryukov. See #65817. git-svn-id: https://develop.svn.wordpress.org/trunk@63930 602fd350-edb4-49c9-b593-d223f7449a82
The `if ( $interim_login )` check was located inside an `if ( ! $interim_login && ... )` block, so it would always be `false`. Developed in WordPress/wordpress-develop#13676. Follow-up to r52058. Props arshidkv12, SergeyBiryukov. See #65817. Built from https://develop.svn.wordpress.org/trunk@63930 git-svn-id: http://core.svn.wordpress.org/trunk@63096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Thanks for the PR!
P.S. Please include a Trac ticket URL in the PR description, so that it is linked to the correct ticket for easier review. I've edited this PR as an example. Thanks! |
|
Thank you. I’ll add the tracking URL in the next PR. |
Remove several conditions identified by PHPStan as always false.
wp-admin/install.php.wp-includes/template.php.interim-loginconditional inwp-login.php.Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Luna
Used for: Reviewing the changes and drafting the commit message and pull request description. The final implementation was reviewed and edited by me.