From 2420a2aab1a283d8464c35691eb848ecec47bfca Mon Sep 17 00:00:00 2001
From: Bashar Qassis <23612682+bashar-qassis@users.noreply.github.com>
Date: Wed, 20 Oct 2021 14:16:55 +0300
Subject: [PATCH 001/129] handling cases where only a non-polymorphic changeset
 error exists

---
 lib/polymorphic_embed.ex | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 244ffbb..10a1912 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -360,6 +360,8 @@ defmodule PolymorphicEmbed do
     |> merge_polymorphic_keys(changes, types, msg_func)
   end
 
+  def traverse_errors(%{}, msg_func) when is_function(msg_func, 1) or is_function(msg_func, 3), do: %{}
+
   defp merge_polymorphic_keys(map, changes, types, msg_func) do
     Enum.reduce types, map, fn
       {field, {:parameterized, PolymorphicEmbed, _opts}}, acc ->

From 0e7aaf5defb199fc46286aa7d16ac64d252cb353 Mon Sep 17 00:00:00 2001
From: Hamza Hejja <hamzahejja@hotmail.com>
Date: Thu, 4 Nov 2021 07:15:42 +0200
Subject: [PATCH 002/129] extend merge_polymorphic_keys to look for
 PolymorphicEmbed inside ecto embedded schemas

---
 lib/polymorphic_embed.ex | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 10a1912..a29e0e9 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -246,7 +246,8 @@ defmodule PolymorphicEmbed do
 
   def load(data, loader, params) when is_map(data), do: do_load(data, loader, params)
 
-  def load(data, loader, params) when is_binary(data), do: do_load(Jason.decode!(data), loader, params)
+  def load(data, loader, params) when is_binary(data),
+    do: do_load(Jason.decode!(data), loader, params)
 
   def do_load(data, _loader, %{types_metadata: types_metadata, type_field: type_field}) do
     case do_get_polymorphic_module_from_map(data, type_field, types_metadata) do
@@ -355,15 +356,15 @@ defmodule PolymorphicEmbed do
 
   def traverse_errors(%Ecto.Changeset{changes: changes, types: types} = changeset, msg_func)
       when is_function(msg_func, 1) or is_function(msg_func, 3) do
-
     Ecto.Changeset.traverse_errors(changeset, msg_func)
     |> merge_polymorphic_keys(changes, types, msg_func)
   end
 
-  def traverse_errors(%{}, msg_func) when is_function(msg_func, 1) or is_function(msg_func, 3), do: %{}
+  def traverse_errors(%{}, msg_func) when is_function(msg_func, 1) or is_function(msg_func, 3),
+    do: %{}
 
   defp merge_polymorphic_keys(map, changes, types, msg_func) do
-    Enum.reduce types, map, fn
+    Enum.reduce(types, map, fn
       {field, {:parameterized, PolymorphicEmbed, _opts}}, acc ->
         if changeset = Map.get(changes, field) do
           case traverse_errors(changeset, msg_func) do
@@ -383,15 +384,25 @@ defmodule PolymorphicEmbed do
             end)
 
           case all_empty? do
-            true  -> acc
+            true -> acc
             false -> Map.put(acc, field, errors)
           end
         else
           acc
         end
 
-     {_, _}, acc ->
-      acc
-    end
+      {field, {:embed, %Ecto.Embedded{field: field}}}, acc ->
+        if changeset = Map.get(changes, field) do
+          case traverse_errors(changeset, msg_func) do
+            errors when errors == %{} -> acc
+            errors -> Map.put(acc, field, errors)
+          end
+        else
+          acc
+        end
+
+      {_, _}, acc ->
+        acc
+    end)
   end
 end

From e85b2b03316c89ab46f31313dae99c52ded3f7de Mon Sep 17 00:00:00 2001
From: Hamza Hejja <hamzahejja@hotmail.com>
Date: Sun, 7 Nov 2021 17:32:17 +0200
Subject: [PATCH 003/129] handle Ecto Embedded with cardinality: :many in
 traverse_errors

---
 lib/polymorphic_embed.ex | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index a29e0e9..bbf1d1e 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -391,7 +391,11 @@ defmodule PolymorphicEmbed do
           acc
         end
 
-      {field, {:embed, %Ecto.Embedded{field: field}}}, acc ->
+      # `Ecto.Schema.embeds_one()` field(s) inside of ecto-based schemas gets translated
+      # to the changeset type {:embed, %Ecto.Embedded{cardinality: :one, field: field}}
+      # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
+      # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
+      {field, {:embed, %Ecto.Embedded{cardinality: :one, field: field}}}, acc ->
         if changeset = Map.get(changes, field) do
           case traverse_errors(changeset, msg_func) do
             errors when errors == %{} -> acc
@@ -401,6 +405,24 @@ defmodule PolymorphicEmbed do
           acc
         end
 
+      # `Ecto.Schema.embeds_many()` field(s) inside of ecto-based schemas gets translated
+      # to the changeset type {:embed, %Ecto.Embedded{cardinality: :many, field: field}}
+      # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
+      # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
+      {field, {:embed, %Ecto.Embedded{cardinality: :many, field: field}}}, acc ->
+        with multiple_changesets when not is_nil(multiple_changesets) <- Map.get(changes, field) do
+          Enum.each(multiple_changesets, fn changeset ->
+            case traverse_errors(changeset, msg_func) do
+              errors when errors == %{} -> acc
+              errors -> Map.put(acc, field, errors)
+            end
+          end)
+
+          acc
+        else
+          nil -> acc
+        end
+
       {_, _}, acc ->
         acc
     end)

From f03d3ee1ba61432c5eba193912440afaf6a1dfb5 Mon Sep 17 00:00:00 2001
From: Hamza Hejja <hamzahejja@hotmail.com>
Date: Mon, 8 Nov 2021 11:46:00 +0200
Subject: [PATCH 004/129] use if instead of with for compact form

---
 lib/polymorphic_embed.ex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index bbf1d1e..d8ee2da 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -410,7 +410,7 @@ defmodule PolymorphicEmbed do
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
       # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
       {field, {:embed, %Ecto.Embedded{cardinality: :many, field: field}}}, acc ->
-        with multiple_changesets when not is_nil(multiple_changesets) <- Map.get(changes, field) do
+        if multiple_changesets = Map.get(changes, field) do
           Enum.each(multiple_changesets, fn changeset ->
             case traverse_errors(changeset, msg_func) do
               errors when errors == %{} -> acc
@@ -420,7 +420,7 @@ defmodule PolymorphicEmbed do
 
           acc
         else
-          nil -> acc
+          acc
         end
 
       {_, _}, acc ->

From 06fb45e0114a40526e710b54bc2045e8645daa53 Mon Sep 17 00:00:00 2001
From: Hamza Hejja <hamzahejja@hotmail.com>
Date: Mon, 8 Nov 2021 11:52:00 +0200
Subject: [PATCH 005/129] ensure that change is indeed a list and not nil

---
 lib/polymorphic_embed.ex | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index d8ee2da..fafb3d3 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -410,7 +410,9 @@ defmodule PolymorphicEmbed do
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
       # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
       {field, {:embed, %Ecto.Embedded{cardinality: :many, field: field}}}, acc ->
-        if multiple_changesets = Map.get(changes, field) do
+        multiple_changesets = Map.get(changes, field)
+
+        if not is_nil(multiple_changesets) and is_list(multiple_changesets) do
           Enum.each(multiple_changesets, fn changeset ->
             case traverse_errors(changeset, msg_func) do
               errors when errors == %{} -> acc

From fddf4f57559ea980ef73f2f1f9dc3f1e6300fb24 Mon Sep 17 00:00:00 2001
From: Bashar Qassis <23612682+bashar-qassis@users.noreply.github.com>
Date: Mon, 31 Jan 2022 11:11:01 +0200
Subject: [PATCH 006/129] Adding capability to customize traverse_errors per
 module for parameterized types

---
 lib/polymorphic_embed.ex | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index fafb3d3..34e20c9 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -375,6 +375,11 @@ defmodule PolymorphicEmbed do
           acc
         end
 
+      {field, {:parameterized, parameterized_type, _opts}}, acc ->
+        if function_exported?(parameterized_type, :traverse_errors, 4),
+          do: parameterized_type.traverse_errors(field, changes, msg_func, acc),
+          else: acc
+
       {field, {:array, {:parameterized, PolymorphicEmbed, _opts}}}, acc ->
         if changesets = Map.get(changes, field) do
           {errors, all_empty?} =

From 0d22e90ae03480dd61d4855670eac29157db9678 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Sun, 9 Oct 2022 18:12:52 +0900
Subject: [PATCH 007/129] fix type determination for default and custom type
 fields

---
 lib/polymorphic_embed/html/form.ex            | 14 +++-
 test/polymorphic_embed_test.exs               | 65 +++++++++++++++++--
 .../20000101000000_create_tables.exs          |  2 +
 test/support/models/polymorphic/reminder.ex   | 17 +++++
 4 files changed, 90 insertions(+), 8 deletions(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index c6ac550..767626b 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -14,7 +14,19 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
         %_{} = value ->
           PolymorphicEmbed.get_polymorphic_type(schema, field, value)
 
-        _ ->
+        %{} = map ->
+          case PolymorphicEmbed.get_polymorphic_module(schema, field, map) do
+            nil ->
+              nil
+
+            module ->
+              PolymorphicEmbed.get_polymorphic_type(schema, field, module)
+          end
+
+        list when is_list(list) ->
+          nil
+
+        nil ->
           nil
       end
     end
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index dd98de6..87377e6 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -2045,7 +2045,7 @@ defmodule PolymorphicEmbedTest do
   end
 
   describe "Form.get_polymorphic_type/3" do
-    test "returns type from changeset" do
+    test "returns type from changeset via identify_by_fields" do
       reminder_module = get_module(Reminder, :polymorphic)
 
       attrs = %{
@@ -2094,9 +2094,9 @@ defmodule PolymorphicEmbedTest do
       end)
     end
 
-    test "returns type from string parameters" do
+    test "returns type from changeset via custom type field" do
       reminder_module = get_module(Reminder, :polymorphic)
-      attrs = %{"channel" => %{"my_type_field" => "email"}}
+      attrs = %{"channel" => %{"my_type_field" => "sms"}}
 
       changeset =
         reminder_module
@@ -2105,15 +2105,32 @@ defmodule PolymorphicEmbedTest do
 
       safe_form_for(changeset, fn f ->
         assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+                 :sms
+
+        text_input(f, :text)
+      end)
+    end
+
+    test "returns type from map with default type field (string)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+      attrs = %{"channel2" => %{"__type__" => "email"}}
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      safe_form_for(changeset, fn f ->
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel2) ==
                  :email
 
         text_input(f, :text)
       end)
     end
 
-    test "returns type from atom parameters" do
+    test "returns type from map with default type field (atom)" do
       reminder_module = get_module(Reminder, :polymorphic)
-      attrs = %{channel: %{my_type_field: :email}}
+      attrs = %{"channel2" => %{__type__: :email}}
 
       changeset =
         reminder_module
@@ -2121,14 +2138,48 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel2) ==
+                 :email
+
+        text_input(f, :text)
+      end)
+    end
+
+    test "returns type from map with custom type field (string)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+      attrs = %{"channel3" => %{"my_type_field" => "email"}}
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      safe_form_for(changeset, fn f ->
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel3) ==
+                 :email
+
+        text_input(f, :text)
+      end)
+    end
+
+    test "returns type from map with custom type field (atom)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+      attrs = %{"channel3" => %{my_type_field: "email"}}
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      safe_form_for(changeset, fn f ->
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel3) ==
                  :email
 
         text_input(f, :text)
       end)
     end
 
-    test "returns type from parameters while type field is custom" do
+    test "returns nil with map when custom type field is configured and default type field is set" do
       reminder_module = get_module(Reminder, :polymorphic)
       attrs = %{channel: %{__type__: :email}}
 
diff --git a/test/support/migrations/20000101000000_create_tables.exs b/test/support/migrations/20000101000000_create_tables.exs
index 53be4e2..e1167f9 100644
--- a/test/support/migrations/20000101000000_create_tables.exs
+++ b/test/support/migrations/20000101000000_create_tables.exs
@@ -7,6 +7,8 @@ defmodule PolymorphicEmbed.CreateTables do
       add(:text, :text, null: false)
 
       add(:channel, :map)
+      add(:channel2, :map)
+      add(:channel3, :map)
       add(:contexts, :map)
       add(:contexts2, :map)
 
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 520f73b..0bc7386 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -20,6 +20,23 @@ defmodule PolymorphicEmbed.Reminder do
       type_field: :my_type_field
     )
 
+    polymorphic_embeds_one(:channel2,
+      types: [
+        sms: PolymorphicEmbed.Channel.SMS,
+        email: PolymorphicEmbed.Channel.Email
+      ],
+      on_replace: :update
+    )
+
+    polymorphic_embeds_one(:channel3,
+      types: [
+        sms: PolymorphicEmbed.Channel.SMS,
+        email: PolymorphicEmbed.Channel.Email
+      ],
+      on_replace: :update,
+      type_field: :my_type_field
+    )
+
     polymorphic_embeds_many(:contexts,
       types: [
         location: PolymorphicEmbed.Reminder.Context.Location,

From 7c8871b3190b204d9828630b852c9b4a2710904d Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Sun, 13 Nov 2022 15:38:44 +0900
Subject: [PATCH 008/129] ignore .elixir_ls folder

---
 .gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitignore b/.gitignore
index 03d70f1..0993e91 100644
--- a/.gitignore
+++ b/.gitignore
@@ -28,3 +28,5 @@ polymorphic_embed-*.tar
 
 # Ignore Dialyzer plts file
 .plts
+
+.elixir_ls

From 27c2668238b29eb10f1148691d260d0497933613 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Sun, 13 Nov 2022 15:46:38 +0900
Subject: [PATCH 009/129] split CI workflow

---
 .github/workflows/ci.yml | 38 +++++++++++++++++++++++++++++++++++---
 1 file changed, 35 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5931fef..3147b33 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,5 +1,9 @@
 name: CI
 
+env:
+  ELIXIR_VERSION: "1.14"
+  OTP_VERSION: "25.1"
+
 on:
   push:
     branches:
@@ -11,7 +15,7 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
+    name: Test OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
     strategy:
       matrix:
         otp: ["24.3", "25.1"]
@@ -39,6 +43,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: erlef/setup-beam@v1
+        id: beam
         with:
           otp-version: ${{matrix.otp}}
           elixir-version: ${{matrix.elixir}}
@@ -50,6 +55,35 @@ jobs:
             deps
           key: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-mix-${{ hashFiles('mix.lock') }}
           restore-keys: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-
+      - name: Install Dependencies
+        run: |
+          mix local.rebar --force
+          mix local.hex --force
+          mix deps.get
+      - name: Run Tests
+        run: mix coveralls.github
+
+  lint:
+    runs-on: ubuntu-latest
+    name: Lint
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: erlef/setup-beam@v1
+        id: beam
+        with:
+          otp-version: ${{ env.OTP_VERSION }}
+          elixir-version: ${{ env.ELIXIR_VERSION}}
+      - name: Restore dependencies and build cache
+        uses: actions/cache@v3
+        with:
+          path: |
+            _build
+            deps
+          key: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-mix-${{ hashFiles('mix.lock') }}
+          restore-keys: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-
       - name: Restore PLT cache
         uses: actions/cache@v3
         id: plt_cache
@@ -75,5 +109,3 @@ jobs:
         run: mix hex.audit
       - name: Generate docs
         run: mix docs
-      - name: Run Tests
-        run: mix coveralls.github

From 8e5007c7e0fa6297be8d6cf58bc52a28b3223892 Mon Sep 17 00:00:00 2001
From: Bashar Qassis <23612682+bashar-qassis@users.noreply.github.com>
Date: Tue, 31 Jan 2023 16:54:52 +0200
Subject: [PATCH 010/129] remove extra new line

---
 config/dev.exs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config/dev.exs b/config/dev.exs
index 8b13789..e69de29 100644
--- a/config/dev.exs
+++ b/config/dev.exs
@@ -1 +0,0 @@
-

From 7c0fb107cada82a1c320bdf671a4573879cd21c3 Mon Sep 17 00:00:00 2001
From: Bashar Qassis <23612682+bashar-qassis@users.noreply.github.com>
Date: Tue, 31 Jan 2023 16:57:49 +0200
Subject: [PATCH 011/129] suppress failing tests errors

---
 config/dev.exs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config/dev.exs b/config/dev.exs
index e69de29..f047d12 100644
--- a/config/dev.exs
+++ b/config/dev.exs
@@ -0,0 +1 @@
+# dummy comment to suppress failing tests

From fdec5fccb9de254814657232a4f4dde606acda0f Mon Sep 17 00:00:00 2001
From: Bashar Qassis <23612682+bashar-qassis@users.noreply.github.com>
Date: Tue, 31 Jan 2023 17:07:18 +0200
Subject: [PATCH 012/129] downgrade json to 1.2

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index 9e50af8..c41b46b 100644
--- a/mix.exs
+++ b/mix.exs
@@ -48,7 +48,7 @@ defmodule PolymorphicEmbed.MixProject do
   defp deps do
     [
       {:ecto, "~> 3.9"},
-      {:jason, "~> 1.4"},
+      {:jason, "~> 1.2"},
       {:phoenix_html, "~> 2.14 or ~> 3.2", optional: true},
       {:ex_doc, "~> 0.28", only: :dev},
       {:ecto_sql, "~> 3.9", only: :test},

From 813e0f6959373d7e46e3d1f59fddd7e7b99543d8 Mon Sep 17 00:00:00 2001
From: Emily Elmseld Hansson <emily.elmseld@drdropin.no>
Date: Fri, 31 Mar 2023 16:28:55 +0200
Subject: [PATCH 013/129] Remove error from example code

---
 README.md                          | 20 ++++++++++++++------
 lib/polymorphic_embed/html/form.ex | 11 ++++++-----
 2 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index ef3c9b7..dd133f5 100644
--- a/README.md
+++ b/README.md
@@ -62,7 +62,7 @@ defmodule MyApp.Channel.Email do
 
   def changeset(email, params) do
     email
-    |> cast(params, ~w(address confirmed)a)
+    |> cast(params, [:address, :confirmed])
     |> validate_required(:address)
     |> validate_length(:address, min: 4)
   end
@@ -72,12 +72,19 @@ end
 ```elixir
 defmodule MyApp.Channel.SMS do
   use Ecto.Schema
+  import Ecto.Changeset
 
   @primary_key false
 
   embedded_schema do
     field :number, :string
   end
+
+  def changeset(sms, params) do
+    sms
+    |> cast(params, [:number])
+    |> validate_required(:number)
+  end
 end
 ```
 
@@ -171,7 +178,7 @@ polymorphic_embeds_many :contexts,
 
 The library comes with a form helper in order to build form inputs for polymorphic embeds and display changeset errors.
 
-In the entrypoint defining your web interface (`lib/your_app_web.ex` file), add the following import:
+In the entrypoint defining your web interface (`lib/your_app_web.ex` file), add the following import, change `view` to the one your component use, ex. `liew_view`:
 
 ```elixir
 def view do
@@ -190,7 +197,7 @@ Here is an example form using the imported function:
 <%= inputs_for f, :reminders, fn reminder_form -> %>
   <%= polymorphic_embed_inputs_for reminder_form, :channel, :sms, fn sms_form -> %>
     <div class="sms-inputs">
-      <label>Number<label>
+      <label>Number</label>
       <%= text_input sms_form, :number %>
       <div class="error">
         <%= error_tag sms_form, :number %>
@@ -221,14 +228,15 @@ You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
   <%= for channel_form <- polymorphic_embed_inputs_for f, :channel do %>
     <%= hidden_inputs_for(channel_form) %>
 
-    <%= case get_polymorphic_type(channel_form, Reminder, :channel) do %>
+    <%= case get_polymorphic_type(f, Reminder, :channel) do %>
       <% :sms -> %>
         <%= label channel_form, :number %>
         <%= text_input channel_form, :number %>
 
       <% :email -> %>
-        <%= label channel_form, :email %>
-        <%= text_input channel_form, :email %>
+        <%= label channel_form, :email_address %>
+        <%= text_input channel_form, :adress %>
+    <% end %>
   <% end %>
 </.form>
 ```
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index c6ac550..3dcde61 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -40,14 +40,15 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
           <%= for channel_form <- polymorphic_embed_inputs_for f, :channel do %>
             <%= hidden_inputs_for(channel_form) %>
 
-            <%= case get_polymorphic_type(channel_form, Reminder, :channel) do %>
+            <%= case get_polymorphic_type(f, Reminder, :channel) do %>
               <% :sms -> %>
                 <%= label channel_form, :number %>
                 <%= text_input channel_form, :number %>
 
               <% :email -> %>
-                <%= label channel_form, :email %>
-                <%= text_input channel_form, :email %>
+                <%= label channel_form, :email_address %>
+                <%= text_input channel_form, :address %>
+            <% end %>
           <% end %>
         </.form>
     """
@@ -73,8 +74,8 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
                 <%= text_input poly_form, :number %>
 
               <% :email -> %>
-                <%= label poly_form, :email %>
-                <%= text_input poly_form, :email %>
+                <%= label poly_form, :email_address %>
+                <%= text_input poly_form, :address %>
             <% end %>
           <% end %>
         <% end %>

From eccb0ef75e76125d41241080100b2669fda85aeb Mon Sep 17 00:00:00 2001
From: Tamara Adeeb <tamara.adeeb1@gmail.com>
Date: Thu, 13 Apr 2023 11:20:53 +0200
Subject: [PATCH 014/129] fix error traversing from :embed type fields with
 many cardinality and limit traverse error loop

---
 lib/polymorphic_embed.ex | 36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index a5402ea..f68aa2d 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -1,6 +1,8 @@
 defmodule PolymorphicEmbed do
   use Ecto.ParameterizedType
 
+  @relations [:embed, :assoc]
+
   defmacro polymorphic_embeds_one(field_name, opts) do
     quote do
       field(unquote(field_name), PolymorphicEmbed, unquote(opts))
@@ -418,10 +420,14 @@ defmodule PolymorphicEmbed do
   defp raise_cannot_infer_type_from_data(data),
     do: raise("could not infer polymorphic embed from data #{inspect(data)}")
 
-  def traverse_errors(%Ecto.Changeset{changes: changes, types: types} = changeset, msg_func)
+  def traverse_errors(
+        %Ecto.Changeset{changes: changes, types: types, errors: errors} = changeset,
+        msg_func
+      )
       when is_function(msg_func, 1) or is_function(msg_func, 3) do
-    changeset
-    |> Ecto.Changeset.traverse_errors(msg_func)
+    errors
+    |> Enum.reverse()
+    |> merge_keyword_keys(msg_func, changeset)
     |> merge_polymorphic_keys(changes, types, msg_func)
   end
 
@@ -433,6 +439,20 @@ defmodule PolymorphicEmbed do
     %{}
   end
 
+  defp merge_keyword_keys(keyword_list, msg_func, _) when is_function(msg_func, 1) do
+    Enum.reduce(keyword_list, %{}, fn {key, val}, acc ->
+      val = msg_func.(val)
+      Map.update(acc, key, [val], &[val | &1])
+    end)
+  end
+
+  defp merge_keyword_keys(keyword_list, msg_func, changeset) when is_function(msg_func, 3) do
+    Enum.reduce(keyword_list, %{}, fn {key, val}, acc ->
+      val = msg_func.(changeset, key, val)
+      Map.update(acc, key, [val], &[val | &1])
+    end)
+  end
+
   defp merge_polymorphic_keys(map, changes, types, msg_func) do
     Enum.reduce(types, map, fn
       {field, {:parameterized, PolymorphicEmbed, _opts}}, acc ->
@@ -470,7 +490,7 @@ defmodule PolymorphicEmbed do
       # to the changeset type {:embed, %Ecto.Embedded{cardinality: :one, field: field}}
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
       # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
-      {field, {:embed, %Ecto.Embedded{cardinality: :one, field: field}}}, acc ->
+      {field, {tag, %Ecto.Embedded{cardinality: :one, field: field}}}, acc when tag in @relations ->
         if changeset = Map.get(changes, field) do
           case traverse_errors(changeset, msg_func) do
             errors when errors == %{} -> acc
@@ -484,18 +504,16 @@ defmodule PolymorphicEmbed do
       # to the changeset type {:embed, %Ecto.Embedded{cardinality: :many, field: field}}
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
       # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
-      {field, {:embed, %Ecto.Embedded{cardinality: :many, field: field}}}, acc ->
+      {field, {tag, %Ecto.Embedded{cardinality: :many, field: field}}}, acc when tag in @relations ->
         multiple_changesets = Map.get(changes, field)
 
         if not is_nil(multiple_changesets) and is_list(multiple_changesets) do
-          Enum.each(multiple_changesets, fn changeset ->
+          Enum.reduce(multiple_changesets, acc, fn changeset, acc ->
             case traverse_errors(changeset, msg_func) do
               errors when errors == %{} -> acc
-              errors -> Map.put(acc, field, errors)
+              errors -> Map.update(acc, field, [errors], &[errors | &1])
             end
           end)
-
-          acc
         else
           acc
         end

From ade58191ba28df2adcea3aad447ac21057b9e970 Mon Sep 17 00:00:00 2001
From: Tamara Adeeb <tamara.adeeb1@gmail.com>
Date: Thu, 13 Apr 2023 12:07:41 +0200
Subject: [PATCH 015/129] handle :assoc field type with :one amd :many
 cardinality

---
 lib/polymorphic_embed.ex | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index f68aa2d..48deebf 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -488,9 +488,11 @@ defmodule PolymorphicEmbed do
 
       # `Ecto.Schema.embeds_one()` field(s) inside of ecto-based schemas gets translated
       # to the changeset type {:embed, %Ecto.Embedded{cardinality: :one, field: field}}
+      # and `Ecto.Schema.belongs_to()` get translated to
+      # {:assoc, %Ecto.Association.Has{cardinality: :one, field: field}}
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
-      # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
-      {field, {tag, %Ecto.Embedded{cardinality: :one, field: field}}}, acc when tag in @relations ->
+      # pattern-matched in order to distinguish between `one` and `many` cardinality
+      {field, {tag, %{cardinality: :one, field: field}}}, acc when tag in @relations ->
         if changeset = Map.get(changes, field) do
           case traverse_errors(changeset, msg_func) do
             errors when errors == %{} -> acc
@@ -502,9 +504,11 @@ defmodule PolymorphicEmbed do
 
       # `Ecto.Schema.embeds_many()` field(s) inside of ecto-based schemas gets translated
       # to the changeset type {:embed, %Ecto.Embedded{cardinality: :many, field: field}}
+      # and `Ecto.Schema.has_many()` get translated to
+      # {:assoc, %Ecto.Association.Has{cardinality: :many, field: field}}
       # where the :cardinality atom can be one of: `:one` or `:many`, hence can be
-      # pattern-matched in order to distinguish between `embeds_one` and `embeds_many`
-      {field, {tag, %Ecto.Embedded{cardinality: :many, field: field}}}, acc when tag in @relations ->
+      # pattern-matched in order to distinguish between `one` and `many` cardinality
+      {field, {tag, %{cardinality: :many, field: field}}}, acc when tag in @relations ->
         multiple_changesets = Map.get(changes, field)
 
         if not is_nil(multiple_changesets) and is_list(multiple_changesets) do
@@ -518,7 +522,7 @@ defmodule PolymorphicEmbed do
           acc
         end
 
-      {_, _}, acc ->
+      data, acc ->
         acc
     end)
   end

From 043bfe26e9223d29970530c9f423474ca9d6456f Mon Sep 17 00:00:00 2001
From: Tamara Adeeb <tamara.adeeb1@gmail.com>
Date: Thu, 13 Apr 2023 12:49:01 +0200
Subject: [PATCH 016/129] fix failed Compilation due to warning: variable data
 is unused

---
 lib/polymorphic_embed.ex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 48deebf..4c78f83 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -522,7 +522,7 @@ defmodule PolymorphicEmbed do
           acc
         end
 
-      data, acc ->
+      {_, _}, acc ->
         acc
     end)
   end

From 6d6cb78e6b7ea020b48f18fb13efd3645002f5b9 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Sun, 9 Oct 2022 18:39:55 +0900
Subject: [PATCH 017/129] add tests for rendering hidden inputs for custom type
 field

---
 test/polymorphic_embed_test.exs | 71 ++++++++++++++++++++++++++++++++-
 1 file changed, 69 insertions(+), 2 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 87377e6..5b05065 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1582,7 +1582,7 @@ defmodule PolymorphicEmbedTest do
   end
 
   describe "polymorphic_embed_inputs_for/2" do
-    test "generates forms that can be rendered" do
+    test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
 
       attrs = %{
@@ -1606,14 +1606,81 @@ defmodule PolymorphicEmbedTest do
           %{changeset: changeset, field: :channel}
         )
         |> Floki.parse_fragment!()
+        |> dbg()
 
-      assert [input] = Floki.find(html, "#reminder_channel___type__")
+      assert [input] = Floki.find(html, "#reminder_channel_my_type_field")
+      assert Floki.attribute(input, "name") == ["reminder[channel][my_type_field]"]
       assert Floki.attribute(input, "type") == ["hidden"]
       assert Floki.attribute(input, "value") == ["email"]
 
       assert [input] = Floki.find(html, "#reminder_channel_number")
       assert Floki.attribute(input, "type") == ["text"]
     end
+
+    test "generates forms that can be rendered (custom type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel3: %{
+          my_type_field: "email"
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form/1,
+          %{changeset: changeset, field: :channel3}
+        )
+        |> Floki.parse_fragment!()
+        |> dbg()
+
+      assert [input] = Floki.find(html, "#reminder_channel3_my_type_field")
+      assert Floki.attribute(input, "name") == ["reminder[channel3][my_type_field]"]
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+    end
+
+    test "generates forms that can be rendered (default type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel2: %{
+          __type__: "email",
+          address: "a",
+          valid: true,
+          confirmed: true
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form/1,
+          %{changeset: changeset, field: :channel2}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, "#reminder_channel2___type__")
+      assert Floki.attribute(input, "name") == ["reminder[channel2][__type__]"]
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+
+      assert [input] = Floki.find(html, "#reminder_channel2_number")
+      assert Floki.attribute(input, "type") == ["text"]
+    end
   end
 
   test "inputs_for/4" do

From 26e3300df4072a1ba3f4e862f161e8d6a9ac7f74 Mon Sep 17 00:00:00 2001
From: Steffen Deusch <steffen.deusch@teaminternet.com>
Date: Wed, 7 Dec 2022 22:58:33 +0100
Subject: [PATCH 018/129] finish implementation of hidden input name
 hidden-input-for-type

---
 lib/polymorphic_embed.ex           | 8 ++++++--
 lib/polymorphic_embed/html/form.ex | 5 ++++-
 test/polymorphic_embed_test.exs    | 9 ++++-----
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index d6ebfa4..d44d49a 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -46,11 +46,14 @@ defmodule PolymorphicEmbed do
           }
       end)
 
+    type_field = Keyword.get(opts, :type_field, :__type__)
+
     %{
       default: Keyword.get(opts, :default, nil),
       on_replace: Keyword.fetch!(opts, :on_replace),
       on_type_not_found: Keyword.get(opts, :on_type_not_found, :changeset_error),
-      type_field: Keyword.get(opts, :type_field, :__type__) |> to_string(),
+      type_field: type_field |> to_string(),
+      type_field_atom: type_field,
       types_metadata: types_metadata
     }
   end
@@ -384,7 +387,8 @@ defmodule PolymorphicEmbed do
     Enum.find(types_metadata, &(type == to_string(&1.type)))
   end
 
-  defp get_field_options(schema, field) do
+  @doc false
+  def get_field_options(schema, field) do
     try do
       schema.__schema__(:type, field)
     rescue
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 767626b..398229c 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -153,6 +153,9 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
             valid?: errors == []
         }
 
+        %schema{} = form.source.data
+        %{type_field_atom: type_field} = PolymorphicEmbed.get_field_options(schema, field)
+
         %Phoenix.HTML.Form{
           source: changeset,
           impl: Phoenix.HTML.FormData.Ecto.Changeset,
@@ -162,7 +165,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
           errors: errors,
           data: data,
           params: params,
-          hidden: [__type__: to_string(type)],
+          hidden: [{type_field, to_string(type)}],
           options: options
         }
       end)
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 5b05065..893aae2 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1606,7 +1606,6 @@ defmodule PolymorphicEmbedTest do
           %{changeset: changeset, field: :channel}
         )
         |> Floki.parse_fragment!()
-        |> dbg()
 
       assert [input] = Floki.find(html, "#reminder_channel_my_type_field")
       assert Floki.attribute(input, "name") == ["reminder[channel][my_type_field]"]
@@ -1711,7 +1710,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
           else:
             ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
         )
@@ -1732,7 +1731,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
           else:
             ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
         )
@@ -1774,7 +1773,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
           else:
             ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
         )
@@ -1795,7 +1794,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
           else:
             ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
         )

From 16f010130e2e7e8ddb3d1dab2c184aae13ab14ea Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Thu, 16 Mar 2023 21:43:28 +0900
Subject: [PATCH 019/129] remove dbg

---
 test/polymorphic_embed_test.exs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 893aae2..f7615be 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1638,7 +1638,6 @@ defmodule PolymorphicEmbedTest do
           %{changeset: changeset, field: :channel3}
         )
         |> Floki.parse_fragment!()
-        |> dbg()
 
       assert [input] = Floki.find(html, "#reminder_channel3_my_type_field")
       assert Floki.attribute(input, "name") == ["reminder[channel3][my_type_field]"]

From 4cd2ae458314d45ae774d52bd746eb72dbcfd333 Mon Sep 17 00:00:00 2001
From: Adam Kirk <atomkirk@gmail.com>
Date: Fri, 8 Dec 2023 14:50:25 -0700
Subject: [PATCH 020/129] fixing docs

---
 lib/polymorphic_embed/html/form.ex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index c6ac550..ef7807a 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -67,7 +67,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
 
         <%= inputs_for f, :reminders, fn reminder_form -> %>
           <%= polymorphic_embed_inputs_for reminder_form, :channel, fn channel_form -> %>
-            <%= case get_polymorphic_type(channel_form, Reminder, :channel) do %>
+            <%= case get_polymorphic_type(reminder_form, Reminder, :channel) do %>
               <% :sms -> %>
                 <%= label poly_form, :number %>
                 <%= text_input poly_form, :number %>

From 01afba5341f2e60e0af2dbbc947b55ce664005bc Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:07:18 +0900
Subject: [PATCH 021/129] update credo to 1.7.4

---
 mix.lock | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mix.lock b/mix.lock
index 7a1ba79..877f515 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,11 +1,11 @@
 %{
-  "bunt": {:hex, :bunt, "0.2.1", "e2d4792f7bc0ced7583ab54922808919518d0e57ee162901a16a1b6664ef3b14", [:mix], [], "hexpm", "a330bfb4245239787b15005e66ae6845c9cd524a288f0d141c148b02603777a5"},
+  "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "0.1.18", "deb5b9ab02400561b6f5708f3e7660fc35ca2d51bfc6a940d2f513f89c2975fc", [:mix], [], "hexpm", "61bbaf6452b782ef80b33cdb45701afbcf0a918a45ebe7e73f1130d661e66a06"},
   "certifi": {:hex, :certifi, "2.9.0", "6f2a475689dd47f19fb74334859d460a2dc4e3252a3324bd2111b8f0429e7e21", [:rebar3], [], "hexpm", "266da46bdb06d6c6d35fde799bcb28d36d985d424ad7c08b5bb48f5b5cdd4641"},
   "connection": {:hex, :connection, "1.1.0", "ff2a49c4b75b6fb3e674bfc5536451607270aac754ffd1bdfe175abe4a6d7a68", [:mix], [], "hexpm", "722c1eb0a418fbe91ba7bd59a47e28008a189d47e37e0e7bb85585a016b2869c"},
-  "credo": {:hex, :credo, "1.6.7", "323f5734350fd23a456f2688b9430e7d517afb313fbd38671b8a4449798a7854", [:mix], [{:bunt, "~> 0.2.1", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2.8", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "41e110bfb007f7eda7f897c10bf019ceab9a0b269ce79f015d54b0dcf4fc7dd3"},
+  "credo": {:hex, :credo, "1.7.4", "68ca5cf89071511c12fd9919eb84e388d231121988f6932756596195ccf7fd35", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "9cf776d062c78bbe0f0de1ecaee183f18f2c3ec591326107989b054b7dddefc2"},
   "db_connection": {:hex, :db_connection, "2.4.2", "f92e79aff2375299a16bcb069a14ee8615c3414863a6fef93156aee8e86c2ff3", [:mix], [{:connection, "~> 1.0", [hex: :connection, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "4fe53ca91b99f55ea249693a0229356a08f4d1a7931d8ffa79289b145fe83668"},
-  "decimal": {:hex, :decimal, "2.0.0", "a78296e617b0f5dd4c6caf57c714431347912ffb1d0842e998e9792b5642d697", [:mix], [], "hexpm", "34666e9c55dea81013e77d9d87370fe6cb6291d1ef32f46a1600230b1d44f577"},
+  "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dialyxir": {:hex, :dialyxir, "1.2.0", "58344b3e87c2e7095304c81a9ae65cb68b613e28340690dfe1a5597fd08dec37", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "61072136427a851674cab81762be4dbeae7679f85b1272b6d25c3a839aff8463"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.27", "755da957e2b980618ba3397d3f923004d85bac244818cf92544eaa38585cb3a8", [:mix], [], "hexpm", "8d02465c243ee96bdd655e7c9a91817a2a80223d63743545b2861023c4ff39ac"},
   "ecto": {:hex, :ecto, "3.9.0", "7c74fc0d950a700eb7019057ff32d047ed7f19b57c1b2ca260cf0e565829101d", [:mix], [{:decimal, "~> 1.6 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "fed5ebc5831378b916afd0b5852a0c5bb3e7390665cc2b0ec8ab0c712495b73d"},
@@ -13,12 +13,12 @@
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "ex_doc": {:hex, :ex_doc, "0.28.5", "3e52a6d2130ce74d096859e477b97080c156d0926701c13870a4e1f752363279", [:mix], [{:earmark_parser, "~> 1.4.19", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "d2c4b07133113e9aa3e9ba27efb9088ba900e9e51caa383919676afdf09ab181"},
   "excoveralls": {:hex, :excoveralls, "0.15.0", "ac941bf85f9f201a9626cc42b2232b251ad8738da993cf406a4290cacf562ea4", [:mix], [{:hackney, "~> 1.16", [hex: :hackney, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "9631912006b27eca30a2f3c93562bc7ae15980afb014ceb8147dc5cdd8f376f1"},
-  "file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"},
+  "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
   "floki": {:hex, :floki, "0.33.1", "f20f1eb471e726342b45ccb68edb9486729e7df94da403936ea94a794f072781", [:mix], [{:html_entities, "~> 0.5.0", [hex: :html_entities, repo: "hexpm", optional: false]}], "hexpm", "461035fd125f13fdf30f243c85a0b1e50afbec876cbf1ceefe6fddd2e6d712c6"},
   "hackney": {:hex, :hackney, "1.18.1", "f48bf88f521f2a229fc7bae88cf4f85adc9cd9bcf23b5dc8eb6a1788c662c4f6", [:rebar3], [{:certifi, "~>2.9.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~>6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~>1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~>1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.3.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~>1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "a4ecdaff44297e9b5894ae499e9a070ea1888c84afdd1fd9b7b2bc384950128e"},
   "html_entities": {:hex, :html_entities, "0.5.2", "9e47e70598da7de2a9ff6af8758399251db6dbb7eebe2b013f2bbd2515895c3c", [:mix], [], "hexpm", "c53ba390403485615623b9531e97696f076ed415e8d8058b1dbaa28181f4fdcc"},
   "idna": {:hex, :idna, "6.1.1", "8a63070e9f7d0c62eb9d9fcb360a7de382448200fbbd1b106cc96d3d8099df8d", [:rebar3], [{:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "92376eb7894412ed19ac475e4a86f7b413c1b9fbb5bd16dccd57934157944cea"},
-  "jason": {:hex, :jason, "1.4.0", "e855647bc964a44e2f67df589ccf49105ae039d4179db7f6271dfd3843dc27e6", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "79a3791085b2a0f743ca04cec0f7be26443738779d09302e01318f97bdb82121"},
+  "jason": {:hex, :jason, "1.4.1", "af1504e35f629ddcdd6addb3513c3853991f694921b1b9368b0bd32beb9f1b63", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "fbb01ecdfd565b56261302f7e1fcc27c4fb8f32d56eab74db621fc154604a7a1"},
   "makeup": {:hex, :makeup, "1.1.0", "6b67c8bc2882a6b6a445859952a602afc1a41c2e08379ca057c0f525366fc3ca", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "0a45ed501f4a8897f580eabf99a2e5234ea3e75a4373c8a52824f6e873be57a6"},
   "makeup_elixir": {:hex, :makeup_elixir, "0.16.0", "f8c570a0d33f8039513fbccaf7108c5d750f47d8defd44088371191b76492b0b", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "28b2cbdc13960a46ae9a8858c4bebdec3c9a6d7b4b9e7f4ed1502f8159f338e7"},
   "makeup_erlang": {:hex, :makeup_erlang, "0.1.1", "3fcb7f09eb9d98dc4d208f49cc955a34218fc41ff6b84df7c75b3e6e533cc65f", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "174d0809e98a4ef0b3309256cbf97101c6ec01c4ab0b23e926a9e17df2077cbb"},

From f527e9db20e152ba5e23a7e93851feb95174f869 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:10:51 +0900
Subject: [PATCH 022/129] update dependencies

---
 mix.exs                         |  6 ++--
 mix.lock                        | 62 ++++++++++++++-------------------
 test/polymorphic_embed_test.exs |  2 +-
 3 files changed, 31 insertions(+), 39 deletions(-)

diff --git a/mix.exs b/mix.exs
index 9e50af8..31ee8be 100644
--- a/mix.exs
+++ b/mix.exs
@@ -47,7 +47,7 @@ defmodule PolymorphicEmbed.MixProject do
 
   defp deps do
     [
-      {:ecto, "~> 3.9"},
+      {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 2.14 or ~> 3.2", optional: true},
       {:ex_doc, "~> 0.28", only: :dev},
@@ -55,11 +55,11 @@ defmodule PolymorphicEmbed.MixProject do
       {:postgrex, "~> 0.16", only: :test},
       {:query_builder, "~> 1.0", only: :test},
       {:phoenix_ecto, "~> 4.4", only: :test},
-      {:phoenix_live_view, "~> 0.18", only: :test},
+      {:phoenix_live_view, "~> 0.20", only: :test},
       {:floki, "~> 0.33", only: :test},
       {:dialyxir, "~> 1.0", only: [:dev, :test], runtime: false},
       {:excoveralls, "~> 0.15", only: :test},
-      {:credo, "~> 1.6", only: [:dev, :test], runtime: false}
+      {:credo, "~> 1.7", only: [:dev, :test], runtime: false}
     ]
   end
 
diff --git a/mix.lock b/mix.lock
index 877f515..0159a3c 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,43 +1,35 @@
 %{
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
-  "castore": {:hex, :castore, "0.1.18", "deb5b9ab02400561b6f5708f3e7660fc35ca2d51bfc6a940d2f513f89c2975fc", [:mix], [], "hexpm", "61bbaf6452b782ef80b33cdb45701afbcf0a918a45ebe7e73f1130d661e66a06"},
-  "certifi": {:hex, :certifi, "2.9.0", "6f2a475689dd47f19fb74334859d460a2dc4e3252a3324bd2111b8f0429e7e21", [:rebar3], [], "hexpm", "266da46bdb06d6c6d35fde799bcb28d36d985d424ad7c08b5bb48f5b5cdd4641"},
-  "connection": {:hex, :connection, "1.1.0", "ff2a49c4b75b6fb3e674bfc5536451607270aac754ffd1bdfe175abe4a6d7a68", [:mix], [], "hexpm", "722c1eb0a418fbe91ba7bd59a47e28008a189d47e37e0e7bb85585a016b2869c"},
+  "castore": {:hex, :castore, "1.0.5", "9eeebb394cc9a0f3ae56b813459f990abb0a3dedee1be6b27fdb50301930502f", [:mix], [], "hexpm", "8d7c597c3e4a64c395980882d4bca3cebb8d74197c590dc272cfd3b6a6310578"},
   "credo": {:hex, :credo, "1.7.4", "68ca5cf89071511c12fd9919eb84e388d231121988f6932756596195ccf7fd35", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "9cf776d062c78bbe0f0de1ecaee183f18f2c3ec591326107989b054b7dddefc2"},
-  "db_connection": {:hex, :db_connection, "2.4.2", "f92e79aff2375299a16bcb069a14ee8615c3414863a6fef93156aee8e86c2ff3", [:mix], [{:connection, "~> 1.0", [hex: :connection, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "4fe53ca91b99f55ea249693a0229356a08f4d1a7931d8ffa79289b145fe83668"},
+  "db_connection": {:hex, :db_connection, "2.6.0", "77d835c472b5b67fc4f29556dee74bf511bbafecdcaf98c27d27fa5918152086", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c2f992d15725e721ec7fbc1189d4ecdb8afef76648c746a8e1cad35e3b8a35f3"},
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
-  "dialyxir": {:hex, :dialyxir, "1.2.0", "58344b3e87c2e7095304c81a9ae65cb68b613e28340690dfe1a5597fd08dec37", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "61072136427a851674cab81762be4dbeae7679f85b1272b6d25c3a839aff8463"},
-  "earmark_parser": {:hex, :earmark_parser, "1.4.27", "755da957e2b980618ba3397d3f923004d85bac244818cf92544eaa38585cb3a8", [:mix], [], "hexpm", "8d02465c243ee96bdd655e7c9a91817a2a80223d63743545b2861023c4ff39ac"},
-  "ecto": {:hex, :ecto, "3.9.0", "7c74fc0d950a700eb7019057ff32d047ed7f19b57c1b2ca260cf0e565829101d", [:mix], [{:decimal, "~> 1.6 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "fed5ebc5831378b916afd0b5852a0c5bb3e7390665cc2b0ec8ab0c712495b73d"},
-  "ecto_sql": {:hex, :ecto_sql, "3.9.0", "2bb21210a2a13317e098a420a8c1cc58b0c3421ab8e3acfa96417dab7817918c", [:mix], [{:db_connection, "~> 2.5 or ~> 2.4.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.9.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a8f3f720073b8b1ac4c978be25fa7960ed7fd44997420c304a4a2e200b596453"},
+  "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
+  "earmark_parser": {:hex, :earmark_parser, "1.4.39", "424642f8335b05bb9eb611aa1564c148a8ee35c9c8a8bba6e129d51a3e3c6769", [:mix], [], "hexpm", "06553a88d1f1846da9ef066b87b57c6f605552cfbe40d20bd8d59cc6bde41944"},
+  "ecto": {:hex, :ecto, "3.11.1", "4b4972b717e7ca83d30121b12998f5fcdc62ba0ed4f20fd390f16f3270d85c3e", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ebd3d3772cd0dfcd8d772659e41ed527c28b2a8bde4b00fe03e0463da0f1983b"},
+  "ecto_sql": {:hex, :ecto_sql, "3.11.1", "e9abf28ae27ef3916b43545f9578b4750956ccea444853606472089e7d169470", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 0.17.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ce14063ab3514424276e7e360108ad6c2308f6d88164a076aac8a387e1fea634"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
-  "ex_doc": {:hex, :ex_doc, "0.28.5", "3e52a6d2130ce74d096859e477b97080c156d0926701c13870a4e1f752363279", [:mix], [{:earmark_parser, "~> 1.4.19", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "d2c4b07133113e9aa3e9ba27efb9088ba900e9e51caa383919676afdf09ab181"},
-  "excoveralls": {:hex, :excoveralls, "0.15.0", "ac941bf85f9f201a9626cc42b2232b251ad8738da993cf406a4290cacf562ea4", [:mix], [{:hackney, "~> 1.16", [hex: :hackney, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "9631912006b27eca30a2f3c93562bc7ae15980afb014ceb8147dc5cdd8f376f1"},
+  "ex_doc": {:hex, :ex_doc, "0.31.1", "8a2355ac42b1cc7b2379da9e40243f2670143721dd50748bf6c3b1184dae2089", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.1", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "3178c3a407c557d8343479e1ff117a96fd31bafe52a039079593fb0524ef61b0"},
+  "excoveralls": {:hex, :excoveralls, "0.18.0", "b92497e69465dc51bc37a6422226ee690ab437e4c06877e836f1c18daeb35da9", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "1109bb911f3cb583401760be49c02cbbd16aed66ea9509fc5479335d284da60b"},
   "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
-  "floki": {:hex, :floki, "0.33.1", "f20f1eb471e726342b45ccb68edb9486729e7df94da403936ea94a794f072781", [:mix], [{:html_entities, "~> 0.5.0", [hex: :html_entities, repo: "hexpm", optional: false]}], "hexpm", "461035fd125f13fdf30f243c85a0b1e50afbec876cbf1ceefe6fddd2e6d712c6"},
-  "hackney": {:hex, :hackney, "1.18.1", "f48bf88f521f2a229fc7bae88cf4f85adc9cd9bcf23b5dc8eb6a1788c662c4f6", [:rebar3], [{:certifi, "~>2.9.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~>6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~>1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~>1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.3.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~>1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "a4ecdaff44297e9b5894ae499e9a070ea1888c84afdd1fd9b7b2bc384950128e"},
-  "html_entities": {:hex, :html_entities, "0.5.2", "9e47e70598da7de2a9ff6af8758399251db6dbb7eebe2b013f2bbd2515895c3c", [:mix], [], "hexpm", "c53ba390403485615623b9531e97696f076ed415e8d8058b1dbaa28181f4fdcc"},
-  "idna": {:hex, :idna, "6.1.1", "8a63070e9f7d0c62eb9d9fcb360a7de382448200fbbd1b106cc96d3d8099df8d", [:rebar3], [{:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "92376eb7894412ed19ac475e4a86f7b413c1b9fbb5bd16dccd57934157944cea"},
+  "floki": {:hex, :floki, "0.35.4", "cc947b446024732c07274ac656600c5c4dc014caa1f8fb2dfff93d275b83890d", [:mix], [], "hexpm", "27fa185d3469bd8fc5947ef0f8d5c4e47f0af02eb6b070b63c868f69e3af0204"},
   "jason": {:hex, :jason, "1.4.1", "af1504e35f629ddcdd6addb3513c3853991f694921b1b9368b0bd32beb9f1b63", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "fbb01ecdfd565b56261302f7e1fcc27c4fb8f32d56eab74db621fc154604a7a1"},
-  "makeup": {:hex, :makeup, "1.1.0", "6b67c8bc2882a6b6a445859952a602afc1a41c2e08379ca057c0f525366fc3ca", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "0a45ed501f4a8897f580eabf99a2e5234ea3e75a4373c8a52824f6e873be57a6"},
-  "makeup_elixir": {:hex, :makeup_elixir, "0.16.0", "f8c570a0d33f8039513fbccaf7108c5d750f47d8defd44088371191b76492b0b", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "28b2cbdc13960a46ae9a8858c4bebdec3c9a6d7b4b9e7f4ed1502f8159f338e7"},
-  "makeup_erlang": {:hex, :makeup_erlang, "0.1.1", "3fcb7f09eb9d98dc4d208f49cc955a34218fc41ff6b84df7c75b3e6e533cc65f", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "174d0809e98a4ef0b3309256cbf97101c6ec01c4ab0b23e926a9e17df2077cbb"},
-  "metrics": {:hex, :metrics, "1.0.1", "25f094dea2cda98213cecc3aeff09e940299d950904393b2a29d191c346a8486", [:rebar3], [], "hexpm", "69b09adddc4f74a40716ae54d140f93beb0fb8978d8636eaded0c31b6f099f16"},
-  "mime": {:hex, :mime, "2.0.3", "3676436d3d1f7b81b5a2d2bd8405f412c677558c81b1c92be58c00562bb59095", [:mix], [], "hexpm", "27a30bf0db44d25eecba73755acf4068cbfe26a4372f9eb3e4ea3a45956bff6b"},
-  "mimerl": {:hex, :mimerl, "1.2.0", "67e2d3f571088d5cfd3e550c383094b47159f3eee8ffa08e64106cdf5e981be3", [:rebar3], [], "hexpm", "f278585650aa581986264638ebf698f8bb19df297f66ad91b18910dfc6e19323"},
-  "nimble_parsec": {:hex, :nimble_parsec, "1.2.3", "244836e6e3f1200c7f30cb56733fd808744eca61fd182f731eac4af635cc6d0b", [:mix], [], "hexpm", "c8d789e39b9131acf7b99291e93dae60ab48ef14a7ee9d58c6964f59efb570b0"},
-  "parse_trans": {:hex, :parse_trans, "3.3.1", "16328ab840cc09919bd10dab29e431da3af9e9e7e7e6f0089dd5a2d2820011d8", [:rebar3], [], "hexpm", "07cd9577885f56362d414e8c4c4e6bdf10d43a8767abb92d24cbe8b24c54888b"},
-  "phoenix": {:hex, :phoenix, "1.6.13", "5b3152907afdb8d3a6cdafb4b149e8aa7aabbf1422fd9f7ef4c2a67ead57d24a", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.0", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 1.0", [hex: :phoenix_view, repo: "hexpm", optional: false]}, {:plug, "~> 1.10", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.2", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "13d8806c31176e2066da4df2d7443c144211305c506ed110ad4044335b90171d"},
-  "phoenix_ecto": {:hex, :phoenix_ecto, "4.4.0", "0672ed4e4808b3fbed494dded89958e22fb882de47a97634c0b13e7b0b5f7720", [:mix], [{:ecto, "~> 3.3", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "09864e558ed31ee00bd48fcc1d4fc58ae9678c9e81649075431e69dbabb43cc1"},
-  "phoenix_html": {:hex, :phoenix_html, "3.2.0", "1c1219d4b6cb22ac72f12f73dc5fad6c7563104d083f711c3fcd8551a1f4ae11", [:mix], [{:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "36ec97ba56d25c0136ef1992c37957e4246b649d620958a1f9fa86165f8bc54f"},
-  "phoenix_live_view": {:hex, :phoenix_live_view, "0.18.1", "1e1703e26d0580dbd84e9b668e6da164a368f125dfa3d813c9a098da508e2a72", [:mix], [{:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6 or ~> 1.7", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.1", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "b785e1cc13b05e6d9482d3ca1eedfb24e8113fd6421b47996ba16b9d20869706"},
-  "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.1", "ba04e489ef03763bf28a17eb2eaddc2c20c6d217e2150a61e3298b0f4c2012b5", [:mix], [], "hexpm", "81367c6d1eea5878ad726be80808eb5a787a23dee699f96e72b1109c57cdd8d9"},
-  "phoenix_view": {:hex, :phoenix_view, "1.1.2", "1b82764a065fb41051637872c7bd07ed2fdb6f5c3bd89684d4dca6e10115c95a", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "7ae90ad27b09091266f6adbb61e1d2516a7c3d7062c6789d46a7554ec40f3a56"},
-  "plug": {:hex, :plug, "1.13.6", "187beb6b67c6cec50503e940f0434ea4692b19384d47e5fdfd701e93cadb4cc2", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "02b9c6b9955bce92c829f31d6284bf53c591ca63c4fb9ff81dfd0418667a34ff"},
-  "plug_crypto": {:hex, :plug_crypto, "1.2.3", "8f77d13aeb32bfd9e654cb68f0af517b371fb34c56c9f2b58fe3df1235c1251a", [:mix], [], "hexpm", "b5672099c6ad5c202c45f5a403f21a3411247f164e4a8fab056e5cd8a290f4a2"},
-  "postgrex": {:hex, :postgrex, "0.16.5", "fcc4035cc90e23933c5d69a9cd686e329469446ef7abba2cf70f08e2c4b69810", [:mix], [{:connection, "~> 1.1", [hex: :connection, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "edead639dc6e882618c01d8fc891214c481ab9a3788dfe38dd5e37fd1d5fb2e8"},
-  "query_builder": {:hex, :query_builder, "1.0.1", "88fac8ec002825a54a5ef2739bbef12a870098efc5e609e3baf02a2bdda6f31e", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}], "hexpm", "c6afbc439a5d825e95b938cef23bf0632d546a1507ee4b07d20098be44b98176"},
-  "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.6", "cf344f5692c82d2cd7554f5ec8fd961548d4fd09e7d22f5b62482e5aeaebd4b0", [:make, :mix, :rebar3], [], "hexpm", "bdb0d2471f453c88ff3908e7686f86f9be327d065cc1ec16fa4540197ea04680"},
-  "telemetry": {:hex, :telemetry, "1.1.0", "a589817034a27eab11144ad24d5c0f9fab1f58173274b1e9bae7074af9cbee51", [:rebar3], [], "hexpm", "b727b2a1f75614774cff2d7565b64d0dfa5bd52ba517f16543e6fc7efcc0df48"},
-  "unicode_util_compat": {:hex, :unicode_util_compat, "0.7.0", "bc84380c9ab48177092f43ac89e4dfa2c6d62b40b8bd132b1059ecc7232f9a78", [:rebar3], [], "hexpm", "25eee6d67df61960cf6a794239566599b09e17e668d3700247bc498638152521"},
+  "makeup": {:hex, :makeup, "1.1.1", "fa0bc768698053b2b3869fa8a62616501ff9d11a562f3ce39580d60860c3a55e", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "5dc62fbdd0de44de194898b6710692490be74baa02d9d108bc29f007783b0b48"},
+  "makeup_elixir": {:hex, :makeup_elixir, "0.16.1", "cc9e3ca312f1cfeccc572b37a09980287e243648108384b97ff2b76e505c3555", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "e127a341ad1b209bd80f7bd1620a15693a9908ed780c3b763bccf7d200c767c6"},
+  "makeup_erlang": {:hex, :makeup_erlang, "0.1.4", "29563475afa9b8a2add1b7a9c8fb68d06ca7737648f28398e04461f008b69521", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "f4ed47ecda66de70dd817698a703f8816daa91272e7e45812469498614ae8b29"},
+  "mime": {:hex, :mime, "2.0.5", "dc34c8efd439abe6ae0343edbb8556f4d63f178594894720607772a041b04b02", [:mix], [], "hexpm", "da0d64a365c45bc9935cc5c8a7fc5e49a0e0f9932a761c55d6c52b142780a05c"},
+  "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
+  "phoenix": {:hex, :phoenix, "1.7.11", "1d88fc6b05ab0c735b250932c4e6e33bfa1c186f76dcf623d8dd52f07d6379c7", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "b1ec57f2e40316b306708fe59b92a16b9f6f4bf50ccfa41aa8c7feb79e0ec02a"},
+  "phoenix_ecto": {:hex, :phoenix_ecto, "4.4.3", "86e9878f833829c3f66da03d75254c155d91d72a201eb56ae83482328dc7ca93", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "d36c401206f3011fefd63d04e8ef626ec8791975d9d107f9a0817d426f61ac07"},
+  "phoenix_html": {:hex, :phoenix_html, "3.3.3", "380b8fb45912b5638d2f1d925a3771b4516b9a78587249cabe394e0a5d579dc9", [:mix], [{:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "923ebe6fec6e2e3b3e569dfbdc6560de932cd54b000ada0208b5f45024bdd76c"},
+  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.9", "46d5d436d3f8ff97f066b6c45528fd842a711fd3875b2d3f706b2e769ea07c51", [:mix], [{:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "694388615ece21b70c523910cba1c633132b08a270caaf60100dd4eaf331885d"},
+  "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
+  "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
+  "plug": {:hex, :plug, "1.15.3", "712976f504418f6dff0a3e554c40d705a9bcf89a7ccef92fc6a5ef8f16a30a97", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cc4365a3c010a56af402e0809208873d113e9c38c401cabd88027ef4f5c01fd2"},
+  "plug_crypto": {:hex, :plug_crypto, "2.0.0", "77515cc10af06645abbfb5e6ad7a3e9714f805ae118fa1a70205f80d2d70fe73", [:mix], [], "hexpm", "53695bae57cc4e54566d993eb01074e4d894b65a3766f1c43e2c61a1b0f45ea9"},
+  "postgrex": {:hex, :postgrex, "0.17.4", "5777781f80f53b7c431a001c8dad83ee167bcebcf3a793e3906efff680ab62b3", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "6458f7d5b70652bc81c3ea759f91736c16a31be000f306d3c64bcdfe9a18b3cc"},
+  "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
+  "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
+  "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
+  "websock_adapter": {:hex, :websock_adapter, "0.5.5", "9dfeee8269b27e958a65b3e235b7e447769f66b5b5925385f5a569269164a210", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "4b977ba4a01918acbf77045ff88de7f6972c2a009213c515a445c48f224ffce9"},
 }
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index f7615be..f6e5190 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -2346,7 +2346,7 @@ defmodule PolymorphicEmbedTest do
   defp liveview_form(assigns) do
     ~H"""
     <.form
-      let={f}
+      :let={f}
       for={@changeset}
     >
       <%= for sms_form <- polymorphic_embed_inputs_for f, @field do %>

From 048313ec49bc0b8e2090998746af61d2e4c3044d Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:15:55 +0900
Subject: [PATCH 023/129] fix warnings, rename variables

---
 config/test.exs                                |  2 +-
 .../support/models/not_polymorphic/reminder.ex | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/config/test.exs b/config/test.exs
index 8489bba..5368763 100644
--- a/config/test.exs
+++ b/config/test.exs
@@ -1,6 +1,6 @@
 import Config
 
-config :logger, level: :warn
+config :logger, level: :warning
 
 config :phoenix, :json_library, Jason
 
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index 026b6da..bbc0832 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -9,31 +9,33 @@ defmodule PolymorphicEmbed.Regular.Reminder do
 
     embeds_one(:channel, PolymorphicEmbed.Regular.Channel.SMS, on_replace: :update)
 
-    embeds_many(:contexts, PolymorphicEmbed.Regular.Reminder.Context.Location, on_replace: :delete)
+    embeds_many(:contexts, PolymorphicEmbed.Regular.Reminder.Context.Location,
+      on_replace: :delete
+    )
 
     timestamps()
   end
 
-  def changeset(struct, values) do
+  def changeset(struct, attrs) do
     struct
-    |> cast(values, [:date, :text])
+    |> cast(attrs, [:date, :text])
     |> validate_required(:date)
     |> cast_embed(:channel)
     |> cast_embed(:contexts)
   end
 
-  def custom_changeset(struct, values) do
+  def custom_changeset(struct, attrs) do
     struct
-    |> cast(values, [:date, :text])
+    |> cast(attrs, [:date, :text])
     |> cast_embed(:channel,
-      with: {PolymorphicEmbed.Regular.Channel.SMS, :custom_changeset, ["foo", "bar"]}
+      with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset(&1, &2, "foo", "bar")
     )
     |> validate_required(:date)
   end
 
-  def custom_changeset2(struct, values) do
+  def custom_changeset2(struct, attrs) do
     struct
-    |> cast(values, [:date, :text])
+    |> cast(attrs, [:date, :text])
     |> cast_embed(:channel, with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset2/2)
     |> validate_required(:date)
   end

From 0693a57e8ca35746274f5729946fad9db7a39cdc Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:21:10 +0900
Subject: [PATCH 024/129] update phoenix_html to 4.0.0

---
 lib/polymorphic_embed/html/form.ex | 6 ++++--
 mix.exs                            | 3 ++-
 mix.lock                           | 3 ++-
 test/polymorphic_embed_test.exs    | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 398229c..0bd78a0 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -1,7 +1,9 @@
-if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) do
+if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &&
+     Code.ensure_loaded?(PhoenixHTMLHelpers.Form) do
   defmodule PolymorphicEmbed.HTML.Form do
     import Phoenix.HTML, only: [html_escape: 1]
-    import Phoenix.HTML.Form, only: [hidden_inputs_for: 1, input_value: 2]
+    import Phoenix.HTML.Form, only: [input_value: 2]
+    import PhoenixHTMLHelpers.Form, only: [hidden_inputs_for: 1]
 
     @doc """
     Returns the polymorphic type of the given field in the given form data.
diff --git a/mix.exs b/mix.exs
index 31ee8be..be043b8 100644
--- a/mix.exs
+++ b/mix.exs
@@ -49,7 +49,8 @@ defmodule PolymorphicEmbed.MixProject do
     [
       {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
-      {:phoenix_html, "~> 2.14 or ~> 3.2", optional: true},
+      {:phoenix_html, "~> 4.0", optional: true},
+      {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:ex_doc, "~> 0.28", only: :dev},
       {:ecto_sql, "~> 3.9", only: :test},
       {:postgrex, "~> 0.16", only: :test},
diff --git a/mix.lock b/mix.lock
index 0159a3c..a8a902b 100644
--- a/mix.lock
+++ b/mix.lock
@@ -21,7 +21,8 @@
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
   "phoenix": {:hex, :phoenix, "1.7.11", "1d88fc6b05ab0c735b250932c4e6e33bfa1c186f76dcf623d8dd52f07d6379c7", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "b1ec57f2e40316b306708fe59b92a16b9f6f4bf50ccfa41aa8c7feb79e0ec02a"},
   "phoenix_ecto": {:hex, :phoenix_ecto, "4.4.3", "86e9878f833829c3f66da03d75254c155d91d72a201eb56ae83482328dc7ca93", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "d36c401206f3011fefd63d04e8ef626ec8791975d9d107f9a0817d426f61ac07"},
-  "phoenix_html": {:hex, :phoenix_html, "3.3.3", "380b8fb45912b5638d2f1d925a3771b4516b9a78587249cabe394e0a5d579dc9", [:mix], [{:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "923ebe6fec6e2e3b3e569dfbdc6560de932cd54b000ada0208b5f45024bdd76c"},
+  "phoenix_html": {:hex, :phoenix_html, "4.0.0", "4857ec2edaccd0934a923c2b0ba526c44a173c86b847e8db725172e9e51d11d6", [:mix], [], "hexpm", "cee794a052f243291d92fa3ccabcb4c29bb8d236f655fb03bcbdc3a8214b8d13"},
+  "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
   "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.9", "46d5d436d3f8ff97f066b6c45528fd842a711fd3875b2d3f706b2e769ea07c51", [:mix], [{:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "694388615ece21b70c523910cba1c633132b08a270caaf60100dd4eaf331885d"},
   "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index f6e5190..b743156 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -5,7 +5,7 @@ defmodule PolymorphicEmbedTest do
 
   import Phoenix.Component
   import Phoenix.HTML
-  import Phoenix.HTML.Form
+  import PhoenixHTMLHelpers.Form
   import Phoenix.LiveViewTest
   import PolymorphicEmbed.HTML.Form
 

From eea054feb2bfb00059a203531e593454abbc6616 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:42:04 +0900
Subject: [PATCH 025/129] address credo warnings

---
 lib/polymorphic_embed.ex           | 174 ++++++++++++++++-------------
 lib/polymorphic_embed/html/form.ex |   3 +
 2 files changed, 97 insertions(+), 80 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index d44d49a..7c6f174 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -1,6 +1,8 @@
 defmodule PolymorphicEmbed do
   use Ecto.ParameterizedType
 
+  alias Ecto.Changeset
+
   defmacro polymorphic_embeds_one(field_name, opts) do
     quote do
       field(unquote(field_name), PolymorphicEmbed, unquote(opts))
@@ -70,28 +72,9 @@ defmodule PolymorphicEmbed do
     required = Keyword.get(cast_options, :required, false)
     with = Keyword.get(cast_options, :with, nil)
 
-    changeset_fun = fn
-      struct, params when is_nil(with) ->
-        struct.__struct__.changeset(struct, params)
-
-      struct, params when is_list(with) ->
-        type = do_get_polymorphic_type(struct, types_metadata)
-
-        case Keyword.get(with, type) do
-          {module, function_name, args} ->
-            apply(module, function_name, [struct, params | args])
+    changeset_fun = &changeset_fun(&1, &2, with, types_metadata)
 
-          nil ->
-            struct.__struct__.changeset(struct, params)
-
-          fun ->
-            apply(fun, [struct, params])
-        end
-    end
-
-    (changeset.params || %{})
-    |> Map.fetch(to_string(field))
-    |> case do
+    case Map.fetch(changeset.params || %{}, to_string(field)) do
       :error when required ->
         if data_for_field = Map.fetch!(changeset.data, field) do
           data_for_field = autogenerate_id(data_for_field, changeset.action)
@@ -144,6 +127,25 @@ defmodule PolymorphicEmbed do
     raise "cast_polymorphic_embed/3 only accepts a changeset as first argument"
   end
 
+  defp changeset_fun(struct, params, with, types_metadata) when is_list(with) do
+    type = do_get_polymorphic_type(struct, types_metadata)
+
+    case Keyword.get(with, type) do
+      {module, function_name, args} ->
+        apply(module, function_name, [struct, params | args])
+
+      nil ->
+        struct.__struct__.changeset(struct, params)
+
+      fun ->
+        apply(fun, [struct, params])
+    end
+  end
+
+  defp changeset_fun(struct, params, nil, _) do
+    struct.__struct__.changeset(struct, params)
+  end
+
   defp cast_polymorphic_embeds_one(changeset, field, changeset_fun, params, field_options) do
     %{
       types_metadata: types_metadata,
@@ -155,27 +157,8 @@ defmodule PolymorphicEmbed do
 
     # We support partial update of the embed. If the type cannot be inferred from the parameters, or if the found type
     # hasn't changed, pass the data to the changeset.
-    action_and_struct =
-      case do_get_polymorphic_module_from_map(params, type_field, types_metadata) do
-        nil ->
-          if data_for_field do
-            {:update, data_for_field}
-          else
-            :type_not_found
-          end
-
-        module when is_nil(data_for_field) ->
-          {:insert, struct(module)}
 
-        module ->
-          if data_for_field.__struct__ != module do
-            {:insert, struct(module)}
-          else
-            {:update, data_for_field}
-          end
-      end
-
-    case action_and_struct do
+    case action_and_struct(params, type_field, types_metadata, data_for_field) do
       :type_not_found when on_type_not_found == :raise ->
         raise_cannot_infer_type_from_data(params)
 
@@ -203,6 +186,27 @@ defmodule PolymorphicEmbed do
     end
   end
 
+  defp action_and_struct(params, type_field, types_metadata, data_for_field) do
+    case do_get_polymorphic_module_from_map(params, type_field, types_metadata) do
+      nil ->
+        if data_for_field do
+          {:update, data_for_field}
+        else
+          :type_not_found
+        end
+
+      module when is_nil(data_for_field) ->
+        {:insert, struct(module)}
+
+      module ->
+        if data_for_field.__struct__ != module do
+          {:insert, struct(module)}
+        else
+          {:update, data_for_field}
+        end
+    end
+  end
+
   defp cast_polymorphic_embeds_many(changeset, field, changeset_fun, list_params, field_options) do
     %{
       types_metadata: types_metadata,
@@ -225,16 +229,7 @@ defmodule PolymorphicEmbed do
           module ->
             embed_changeset = changeset_fun.(struct(module), params)
             embed_changeset = %{embed_changeset | action: :insert}
-
-            case embed_changeset do
-              %{valid?: true} = embed_changeset ->
-                embed_changeset
-                |> Ecto.Changeset.apply_changes()
-                |> autogenerate_id(embed_changeset.action)
-
-              %{valid?: false} = embed_changeset ->
-                embed_changeset
-            end
+            maybe_apply_changes(embed_changeset)
         end
       end)
 
@@ -259,6 +254,14 @@ defmodule PolymorphicEmbed do
     end
   end
 
+  defp maybe_apply_changes(%{valid?: true} = embed_changeset) do
+    embed_changeset
+    |> Ecto.Changeset.apply_changes()
+    |> autogenerate_id(embed_changeset.action)
+  end
+
+  defp maybe_apply_changes(%Changeset{valid?: false} = changeset), do: changeset
+
   @impl true
   def cast(_data, _params),
     do:
@@ -393,7 +396,7 @@ defmodule PolymorphicEmbed do
       schema.__schema__(:type, field)
     rescue
       _ in UndefinedFunctionError ->
-        raise ArgumentError, "#{inspect(schema)} is not an Ecto schema"
+        reraise ArgumentError, "#{inspect(schema)} is not an Ecto schema", __STACKTRACE__
     else
       {:parameterized, PolymorphicEmbed, options} -> Map.put(options, :array?, false)
       {:array, {:parameterized, PolymorphicEmbed, options}} -> Map.put(options, :array?, true)
@@ -438,38 +441,49 @@ defmodule PolymorphicEmbed do
   end
 
   defp merge_polymorphic_keys(map, changes, types, msg_func) do
-    Enum.reduce(types, map, fn
-      {field, {:parameterized, PolymorphicEmbed, _opts}}, acc ->
-        if changeset = Map.get(changes, field) do
-          case traverse_errors(changeset, msg_func) do
-            errors when errors == %{} -> acc
-            errors -> Map.put(acc, field, errors)
-          end
-        else
-          acc
-        end
+    Enum.reduce(types, map, &polymorphic_key_reducer(&1, &2, changes, msg_func))
+  end
 
-      {field, {:array, {:parameterized, PolymorphicEmbed, _opts}}}, acc ->
-        if changesets = Map.get(changes, field) do
-          {errors, all_empty?} =
-            Enum.map_reduce(changesets, true, fn changeset, all_empty? ->
-              errors = traverse_errors(changeset, msg_func)
-              {errors, all_empty? and errors == %{}}
-            end)
-
-          case all_empty? do
-            true -> acc
-            false -> Map.put(acc, field, errors)
-          end
-        else
-          acc
-        end
+  defp polymorphic_key_reducer(
+         {field, {:parameterized, PolymorphicEmbed, _opts}},
+         acc,
+         changes,
+         msg_func
+       ) do
+    if changeset = Map.get(changes, field) do
+      case traverse_errors(changeset, msg_func) do
+        errors when errors == %{} -> acc
+        errors -> Map.put(acc, field, errors)
+      end
+    else
+      acc
+    end
+  end
 
-      {_, _}, acc ->
-        acc
-    end)
+  defp polymorphic_key_reducer(
+         {field, {:array, {:parameterized, PolymorphicEmbed, _opts}}},
+         acc,
+         changes,
+         msg_func
+       ) do
+    if changesets = Map.get(changes, field) do
+      {errors, all_empty?} =
+        Enum.map_reduce(changesets, true, fn changeset, all_empty? ->
+          errors = traverse_errors(changeset, msg_func)
+          {errors, all_empty? and errors == %{}}
+        end)
+
+      case all_empty? do
+        true -> acc
+        false -> Map.put(acc, field, errors)
+      end
+    else
+      acc
+    end
   end
 
+  defp polymorphic_key_reducer({_, _}, acc, _, _), do: acc
+
   defp autogenerate_id([], _action), do: []
 
   defp autogenerate_id([schema | rest], action) do
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 0bd78a0..b788746 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -1,6 +1,9 @@
 if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &&
      Code.ensure_loaded?(PhoenixHTMLHelpers.Form) do
   defmodule PolymorphicEmbed.HTML.Form do
+    @moduledoc """
+    Defines functions for using PolymorphicEmbed with `Phoenix.HTML.Form`.
+    """
     import Phoenix.HTML, only: [html_escape: 1]
     import Phoenix.HTML.Form, only: [input_value: 2]
     import PhoenixHTMLHelpers.Form, only: [hidden_inputs_for: 1]

From a94a1fd1620da2948720b15d1fa52a84679fa129 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:43:19 +0900
Subject: [PATCH 026/129] update credo config

---
 .credo.exs | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/.credo.exs b/.credo.exs
index 9965c2f..b62ab1c 100644
--- a/.credo.exs
+++ b/.credo.exs
@@ -84,12 +84,12 @@
           #
           {Credo.Check.Design.AliasUsage,
            [priority: :low, if_nested_deeper_than: 2, if_called_more_often_than: 0]},
+          {Credo.Check.Design.TagFIXME, []},
           # You can also customize the exit_status of each check.
           # If you don't want TODO comments to cause `mix credo` to fail, just
           # set this value to 0 (zero).
           #
           {Credo.Check.Design.TagTODO, [exit_status: 2]},
-          {Credo.Check.Design.TagFIXME, []},
 
           #
           ## Readability Checks
@@ -99,7 +99,7 @@
           {Credo.Check.Readability.LargeNumbers, []},
           {Credo.Check.Readability.MaxLineLength, [priority: :low, max_length: 120]},
           {Credo.Check.Readability.ModuleAttributeNames, []},
-          {Credo.Check.Readability.ModuleDoc, []},
+          {Credo.Check.Readability.ModuleDoc, false},
           {Credo.Check.Readability.ModuleNames, []},
           {Credo.Check.Readability.ParenthesesInCondition, []},
           {Credo.Check.Readability.ParenthesesOnZeroArityDefs, []},
@@ -122,32 +122,35 @@
           {Credo.Check.Refactor.Apply, []},
           {Credo.Check.Refactor.CondStatements, []},
           {Credo.Check.Refactor.CyclomaticComplexity, []},
+          {Credo.Check.Refactor.FilterCount, []},
+          {Credo.Check.Refactor.FilterFilter, []},
           {Credo.Check.Refactor.FunctionArity, []},
           {Credo.Check.Refactor.LongQuoteBlocks, []},
-          {Credo.Check.Refactor.MatchInCondition, []},
           {Credo.Check.Refactor.MapJoin, []},
+          {Credo.Check.Refactor.MatchInCondition, []},
           {Credo.Check.Refactor.NegatedConditionsInUnless, []},
           {Credo.Check.Refactor.NegatedConditionsWithElse, []},
           {Credo.Check.Refactor.Nesting, []},
+          {Credo.Check.Refactor.RedundantWithClauseResult, []},
+          {Credo.Check.Refactor.RejectReject, []},
           {Credo.Check.Refactor.UnlessWithElse, []},
           {Credo.Check.Refactor.WithClauses, []},
-          {Credo.Check.Refactor.FilterFilter, []},
-          {Credo.Check.Refactor.RejectReject, []},
-          {Credo.Check.Refactor.RedundantWithClauseResult, []},
 
           #
           ## Warnings
           #
           {Credo.Check.Warning.ApplicationConfigInModuleAttribute, []},
           {Credo.Check.Warning.BoolOperationOnSameValues, []},
+          {Credo.Check.Warning.Dbg, []},
           {Credo.Check.Warning.ExpensiveEmptyEnumCheck, []},
           {Credo.Check.Warning.IExPry, []},
           {Credo.Check.Warning.IoInspect, []},
+          {Credo.Check.Warning.MissedMetadataKeyInLoggerConfig, []},
           {Credo.Check.Warning.OperationOnSameValues, []},
           {Credo.Check.Warning.OperationWithConstantResult, []},
           {Credo.Check.Warning.RaiseInsideRescue, []},
           {Credo.Check.Warning.SpecWithStruct, []},
-          {Credo.Check.Warning.WrongTestFileExtension, []},
+          {Credo.Check.Warning.UnsafeExec, []},
           {Credo.Check.Warning.UnusedEnumOperation, []},
           {Credo.Check.Warning.UnusedFileOperation, []},
           {Credo.Check.Warning.UnusedKeywordOperation, []},
@@ -156,11 +159,12 @@
           {Credo.Check.Warning.UnusedRegexOperation, []},
           {Credo.Check.Warning.UnusedStringOperation, []},
           {Credo.Check.Warning.UnusedTupleOperation, []},
-          {Credo.Check.Warning.UnsafeExec, []}
+          {Credo.Check.Warning.WrongTestFileExtension, []}
         ],
         disabled: [
           #
-          # Checks scheduled for next check update (opt-in for now, just replace `false` with `[]`)
+          # Checks scheduled for next check update (opt-in for now)
+          {Credo.Check.Refactor.UtcNowTruncate, []},
 
           #
           # Controversial and experimental checks (opt-in, just move the check to `:enabled`
@@ -175,6 +179,8 @@
           {Credo.Check.Readability.ImplTrue, []},
           {Credo.Check.Readability.MultiAlias, []},
           {Credo.Check.Readability.NestedFunctionCalls, []},
+          {Credo.Check.Readability.OneArityFunctionInPipe, []},
+          {Credo.Check.Readability.OnePipePerLine, []},
           {Credo.Check.Readability.SeparateAliasRequire, []},
           {Credo.Check.Readability.SingleFunctionToBlockPipe, []},
           {Credo.Check.Readability.SinglePipe, []},
@@ -189,6 +195,7 @@
           {Credo.Check.Refactor.MapMap, []},
           {Credo.Check.Refactor.ModuleDependencies, []},
           {Credo.Check.Refactor.NegatedIsNil, []},
+          {Credo.Check.Refactor.PassAsyncInTestCases, []},
           {Credo.Check.Refactor.PipeChainStart, []},
           {Credo.Check.Refactor.RejectFilter, []},
           {Credo.Check.Refactor.VariableRebinding, []},

From 094defc0cb98dbd3790622d846ccfc39e8ce5eb7 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:50:34 +0900
Subject: [PATCH 027/129] refactor

---
 lib/polymorphic_embed.ex | 38 ++++++++++++++++++--------------------
 1 file changed, 18 insertions(+), 20 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 7c6f174..920ae1e 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -62,6 +62,7 @@ defmodule PolymorphicEmbed do
 
   def cast_polymorphic_embed(changeset, field, cast_options \\ [])
 
+  # credo:disable-for-next-line
   def cast_polymorphic_embed(%Ecto.Changeset{} = changeset, field, cast_options) do
     field_options = get_field_options(changeset.data.__struct__, field)
 
@@ -100,26 +101,23 @@ defmodule PolymorphicEmbed do
       {:ok, map} when map == %{} and not array? ->
         changeset
 
-      {:ok, params_for_field} ->
-        cond do
-          array? and is_list(params_for_field) ->
-            cast_polymorphic_embeds_many(
-              changeset,
-              field,
-              changeset_fun,
-              params_for_field,
-              field_options
-            )
-
-          not array? and is_map(params_for_field) ->
-            cast_polymorphic_embeds_one(
-              changeset,
-              field,
-              changeset_fun,
-              params_for_field,
-              field_options
-            )
-        end
+      {:ok, params_for_field} when is_list(params_for_field) and array? ->
+        cast_polymorphic_embeds_many(
+          changeset,
+          field,
+          changeset_fun,
+          params_for_field,
+          field_options
+        )
+
+      {:ok, params_for_field} when is_map(params_for_field) and not array? ->
+        cast_polymorphic_embeds_one(
+          changeset,
+          field,
+          changeset_fun,
+          params_for_field,
+          field_options
+        )
     end
   end
 

From c6afd6f445bbee352ffebe5c3fed60471b828c0b Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:50:41 +0900
Subject: [PATCH 028/129] update CI workflow

---
 .github/workflows/ci.yml | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3147b33..3219bd5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,8 +1,8 @@
 name: CI
 
 env:
-  ELIXIR_VERSION: "1.14"
-  OTP_VERSION: "25.1"
+  ELIXIR_VERSION: "1.16"
+  OTP_VERSION: "26"
 
 on:
   push:
@@ -18,11 +18,16 @@ jobs:
     name: Test OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
     strategy:
       matrix:
-        otp: ["24.3", "25.1"]
-        elixir: ["1.13", "1.14"]
-        exclude:
-          - otp: "25.1"
-            elixir: "1.13"
+        include:
+          - { elixir: 1.14, otp: 23 }
+          - { elixir: 1.14, otp: 24 }
+          - { elixir: 1.14, otp: 25 }
+          - { elixir: 1.15, otp: 24 }
+          - { elixir: 1.15, otp: 25 }
+          - { elixir: 1.15, otp: 26 }
+          - { elixir: 1.16, otp: 24 }
+          - { elixir: 1.16, otp: 25 }
+          - { elixir: 1.16, otp: 26 }
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

From c97e4864fdf95cf5eb17bfaad681be46361d99d6 Mon Sep 17 00:00:00 2001
From: Mathias Polligkeit <git@woylie.de>
Date: Tue, 20 Feb 2024 17:54:40 +0900
Subject: [PATCH 029/129] update GH actions

---
 .github/workflows/ci.yml | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3219bd5..1544278 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,7 +19,6 @@ jobs:
     strategy:
       matrix:
         include:
-          - { elixir: 1.14, otp: 23 }
           - { elixir: 1.14, otp: 24 }
           - { elixir: 1.14, otp: 25 }
           - { elixir: 1.15, otp: 24 }
@@ -46,14 +45,14 @@ jobs:
           - 5432:5432
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         id: beam
         with:
           otp-version: ${{matrix.otp}}
           elixir-version: ${{matrix.elixir}}
       - name: Restore dependencies and build cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             _build
@@ -75,14 +74,14 @@ jobs:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         id: beam
         with:
           otp-version: ${{ env.OTP_VERSION }}
           elixir-version: ${{ env.ELIXIR_VERSION}}
       - name: Restore dependencies and build cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             _build
@@ -90,7 +89,7 @@ jobs:
           key: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-mix-${{ hashFiles('mix.lock') }}
           restore-keys: ${{ runner.os }}-otp-${{ steps.beam.outputs.otp-version }}-elixir-${{ steps.beam.outputs.elixir-version }}-
       - name: Restore PLT cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         id: plt_cache
         with:
           key: |

From fe99d5152a705f0d034bf3256f38b57b52849fe5 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <mett.work@gmail.com>
Date: Thu, 25 Apr 2024 21:49:38 +0200
Subject: [PATCH 030/129] Bump version to 3.0.6

---
 CHANGELOG.md | 1 +
 README.md    | 2 +-
 mix.exs      | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a9e213f..2af1b72 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 3.0.x
 
   * Default value for polymorphic list of embeds is `[]` instead of `nil` (following `embeds_many/3`)
+  * Support Phoenix HTML 4.0
 
 ### Migration from 2.x to 3.x
 
diff --git a/README.md b/README.md
index ef3c9b7..f872e14 100644
--- a/README.md
+++ b/README.md
@@ -264,7 +264,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 3.0.5"}
+    {:polymorphic_embed, "~> 3.0.6"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index be043b8..1f87e76 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "3.0.5"
+  @version "3.0.6"
 
   def project do
     [

From ec533c6f573acf6e4745ab4468f63137e0aa3e86 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 17:04:51 +0800
Subject: [PATCH 031/129] Update deps

---
 mix.exs  |  8 ++++----
 mix.lock | 16 ++++++++--------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/mix.exs b/mix.exs
index 1f87e76..32233b9 100644
--- a/mix.exs
+++ b/mix.exs
@@ -51,15 +51,15 @@ defmodule PolymorphicEmbed.MixProject do
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 4.0", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
-      {:ex_doc, "~> 0.28", only: :dev},
+      {:ex_doc, "~> 0.33", only: :dev},
       {:ecto_sql, "~> 3.9", only: :test},
-      {:postgrex, "~> 0.16", only: :test},
+      {:postgrex, "~> 0.17", only: :test},
       {:query_builder, "~> 1.0", only: :test},
       {:phoenix_ecto, "~> 4.4", only: :test},
       {:phoenix_live_view, "~> 0.20", only: :test},
-      {:floki, "~> 0.33", only: :test},
+      {:floki, "~> 0.36", only: :test},
       {:dialyxir, "~> 1.0", only: [:dev, :test], runtime: false},
-      {:excoveralls, "~> 0.15", only: :test},
+      {:excoveralls, "~> 0.18", only: :test},
       {:credo, "~> 1.7", only: [:dev, :test], runtime: false}
     ]
   end
diff --git a/mix.lock b/mix.lock
index a8a902b..54f5e13 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,7 +1,7 @@
 %{
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
-  "castore": {:hex, :castore, "1.0.5", "9eeebb394cc9a0f3ae56b813459f990abb0a3dedee1be6b27fdb50301930502f", [:mix], [], "hexpm", "8d7c597c3e4a64c395980882d4bca3cebb8d74197c590dc272cfd3b6a6310578"},
-  "credo": {:hex, :credo, "1.7.4", "68ca5cf89071511c12fd9919eb84e388d231121988f6932756596195ccf7fd35", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "9cf776d062c78bbe0f0de1ecaee183f18f2c3ec591326107989b054b7dddefc2"},
+  "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
+  "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"},
   "db_connection": {:hex, :db_connection, "2.6.0", "77d835c472b5b67fc4f29556dee74bf511bbafecdcaf98c27d27fa5918152086", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c2f992d15725e721ec7fbc1189d4ecdb8afef76648c746a8e1cad35e3b8a35f3"},
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
@@ -9,14 +9,14 @@
   "ecto": {:hex, :ecto, "3.11.1", "4b4972b717e7ca83d30121b12998f5fcdc62ba0ed4f20fd390f16f3270d85c3e", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ebd3d3772cd0dfcd8d772659e41ed527c28b2a8bde4b00fe03e0463da0f1983b"},
   "ecto_sql": {:hex, :ecto_sql, "3.11.1", "e9abf28ae27ef3916b43545f9578b4750956ccea444853606472089e7d169470", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 0.17.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ce14063ab3514424276e7e360108ad6c2308f6d88164a076aac8a387e1fea634"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
-  "ex_doc": {:hex, :ex_doc, "0.31.1", "8a2355ac42b1cc7b2379da9e40243f2670143721dd50748bf6c3b1184dae2089", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.1", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "3178c3a407c557d8343479e1ff117a96fd31bafe52a039079593fb0524ef61b0"},
-  "excoveralls": {:hex, :excoveralls, "0.18.0", "b92497e69465dc51bc37a6422226ee690ab437e4c06877e836f1c18daeb35da9", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "1109bb911f3cb583401760be49c02cbbd16aed66ea9509fc5479335d284da60b"},
+  "ex_doc": {:hex, :ex_doc, "0.33.0", "690562b153153c7e4d455dc21dab86e445f66ceba718defe64b0ef6f0bd83ba0", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "3f69adc28274cb51be37d09b03e4565232862a4b10288a3894587b0131412124"},
+  "excoveralls": {:hex, :excoveralls, "0.18.1", "a6f547570c6b24ec13f122a5634833a063aec49218f6fff27de9df693a15588c", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "d65f79db146bb20399f23046015974de0079668b9abb2f5aac074d078da60b8d"},
   "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
-  "floki": {:hex, :floki, "0.35.4", "cc947b446024732c07274ac656600c5c4dc014caa1f8fb2dfff93d275b83890d", [:mix], [], "hexpm", "27fa185d3469bd8fc5947ef0f8d5c4e47f0af02eb6b070b63c868f69e3af0204"},
+  "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},
   "jason": {:hex, :jason, "1.4.1", "af1504e35f629ddcdd6addb3513c3853991f694921b1b9368b0bd32beb9f1b63", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "fbb01ecdfd565b56261302f7e1fcc27c4fb8f32d56eab74db621fc154604a7a1"},
-  "makeup": {:hex, :makeup, "1.1.1", "fa0bc768698053b2b3869fa8a62616501ff9d11a562f3ce39580d60860c3a55e", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "5dc62fbdd0de44de194898b6710692490be74baa02d9d108bc29f007783b0b48"},
-  "makeup_elixir": {:hex, :makeup_elixir, "0.16.1", "cc9e3ca312f1cfeccc572b37a09980287e243648108384b97ff2b76e505c3555", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "e127a341ad1b209bd80f7bd1620a15693a9908ed780c3b763bccf7d200c767c6"},
-  "makeup_erlang": {:hex, :makeup_erlang, "0.1.4", "29563475afa9b8a2add1b7a9c8fb68d06ca7737648f28398e04461f008b69521", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "f4ed47ecda66de70dd817698a703f8816daa91272e7e45812469498614ae8b29"},
+  "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},
+  "makeup_elixir": {:hex, :makeup_elixir, "0.16.2", "627e84b8e8bf22e60a2579dad15067c755531fea049ae26ef1020cad58fe9578", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "41193978704763f6bbe6cc2758b84909e62984c7752b3784bd3c218bb341706b"},
+  "makeup_erlang": {:hex, :makeup_erlang, "1.0.0", "6f0eff9c9c489f26b69b61440bf1b238d95badae49adac77973cbacae87e3c2e", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "ea7a9307de9d1548d2a72d299058d1fd2339e3d398560a0e46c27dab4891e4d2"},
   "mime": {:hex, :mime, "2.0.5", "dc34c8efd439abe6ae0343edbb8556f4d63f178594894720607772a041b04b02", [:mix], [], "hexpm", "da0d64a365c45bc9935cc5c8a7fc5e49a0e0f9932a761c55d6c52b142780a05c"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
   "phoenix": {:hex, :phoenix, "1.7.11", "1d88fc6b05ab0c735b250932c4e6e33bfa1c186f76dcf623d8dd52f07d6379c7", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "b1ec57f2e40316b306708fe59b92a16b9f6f4bf50ccfa41aa8c7feb79e0ec02a"},

From 08505d06b8cf101d47e94b6cfbe67158e3b28e4a Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 17:06:38 +0800
Subject: [PATCH 032/129] Update deps

---
 mix.lock | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/mix.lock b/mix.lock
index 54f5e13..2805b25 100644
--- a/mix.lock
+++ b/mix.lock
@@ -19,18 +19,18 @@
   "makeup_erlang": {:hex, :makeup_erlang, "1.0.0", "6f0eff9c9c489f26b69b61440bf1b238d95badae49adac77973cbacae87e3c2e", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "ea7a9307de9d1548d2a72d299058d1fd2339e3d398560a0e46c27dab4891e4d2"},
   "mime": {:hex, :mime, "2.0.5", "dc34c8efd439abe6ae0343edbb8556f4d63f178594894720607772a041b04b02", [:mix], [], "hexpm", "da0d64a365c45bc9935cc5c8a7fc5e49a0e0f9932a761c55d6c52b142780a05c"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
-  "phoenix": {:hex, :phoenix, "1.7.11", "1d88fc6b05ab0c735b250932c4e6e33bfa1c186f76dcf623d8dd52f07d6379c7", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "b1ec57f2e40316b306708fe59b92a16b9f6f4bf50ccfa41aa8c7feb79e0ec02a"},
+  "phoenix": {:hex, :phoenix, "1.7.12", "1cc589e0eab99f593a8aa38ec45f15d25297dd6187ee801c8de8947090b5a9d3", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "d646192fbade9f485b01bc9920c139bfdd19d0f8df3d73fd8eaf2dfbe0d2837c"},
   "phoenix_ecto": {:hex, :phoenix_ecto, "4.4.3", "86e9878f833829c3f66da03d75254c155d91d72a201eb56ae83482328dc7ca93", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "d36c401206f3011fefd63d04e8ef626ec8791975d9d107f9a0817d426f61ac07"},
-  "phoenix_html": {:hex, :phoenix_html, "4.0.0", "4857ec2edaccd0934a923c2b0ba526c44a173c86b847e8db725172e9e51d11d6", [:mix], [], "hexpm", "cee794a052f243291d92fa3ccabcb4c29bb8d236f655fb03bcbdc3a8214b8d13"},
+  "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
   "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
-  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.9", "46d5d436d3f8ff97f066b6c45528fd842a711fd3875b2d3f706b2e769ea07c51", [:mix], [{:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "694388615ece21b70c523910cba1c633132b08a270caaf60100dd4eaf331885d"},
+  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.14", "70fa101aa0539e81bed4238777498f6215e9dda3461bdaa067cad6908110c364", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "82f6d006c5264f979ed5eb75593d808bbe39020f20df2e78426f4f2d570e2402"},
   "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
-  "plug": {:hex, :plug, "1.15.3", "712976f504418f6dff0a3e554c40d705a9bcf89a7ccef92fc6a5ef8f16a30a97", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cc4365a3c010a56af402e0809208873d113e9c38c401cabd88027ef4f5c01fd2"},
-  "plug_crypto": {:hex, :plug_crypto, "2.0.0", "77515cc10af06645abbfb5e6ad7a3e9714f805ae118fa1a70205f80d2d70fe73", [:mix], [], "hexpm", "53695bae57cc4e54566d993eb01074e4d894b65a3766f1c43e2c61a1b0f45ea9"},
+  "plug": {:hex, :plug, "1.16.0", "1d07d50cb9bb05097fdf187b31cf087c7297aafc3fed8299aac79c128a707e47", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cbf53aa1f5c4d758a7559c0bd6d59e286c2be0c6a1fac8cc3eee2f638243b93e"},
+  "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
   "postgrex": {:hex, :postgrex, "0.17.4", "5777781f80f53b7c431a001c8dad83ee167bcebcf3a793e3906efff680ab62b3", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "6458f7d5b70652bc81c3ea759f91736c16a31be000f306d3c64bcdfe9a18b3cc"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
-  "websock_adapter": {:hex, :websock_adapter, "0.5.5", "9dfeee8269b27e958a65b3e235b7e447769f66b5b5925385f5a569269164a210", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "4b977ba4a01918acbf77045ff88de7f6972c2a009213c515a445c48f224ffce9"},
+  "websock_adapter": {:hex, :websock_adapter, "0.5.6", "0437fe56e093fd4ac422de33bf8fc89f7bc1416a3f2d732d8b2c8fd54792fe60", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "e04378d26b0af627817ae84c92083b7e97aca3121196679b73c73b99d0d133ea"},
 }

From 1bcb68084abf4a6c84a1735991e9dc8efde6c15a Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 17:14:20 +0800
Subject: [PATCH 033/129] Update deps

---
 mix.exs  | 2 +-
 mix.lock | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mix.exs b/mix.exs
index 32233b9..f5ff15e 100644
--- a/mix.exs
+++ b/mix.exs
@@ -47,7 +47,7 @@ defmodule PolymorphicEmbed.MixProject do
 
   defp deps do
     [
-      {:ecto, "~> 3.11"},
+      {:ecto, "~> 3.11.2"},
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 4.0", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
diff --git a/mix.lock b/mix.lock
index 2805b25..d106abc 100644
--- a/mix.lock
+++ b/mix.lock
@@ -6,7 +6,7 @@
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.39", "424642f8335b05bb9eb611aa1564c148a8ee35c9c8a8bba6e129d51a3e3c6769", [:mix], [], "hexpm", "06553a88d1f1846da9ef066b87b57c6f605552cfbe40d20bd8d59cc6bde41944"},
-  "ecto": {:hex, :ecto, "3.11.1", "4b4972b717e7ca83d30121b12998f5fcdc62ba0ed4f20fd390f16f3270d85c3e", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ebd3d3772cd0dfcd8d772659e41ed527c28b2a8bde4b00fe03e0463da0f1983b"},
+  "ecto": {:hex, :ecto, "3.11.2", "e1d26be989db350a633667c5cda9c3d115ae779b66da567c68c80cfb26a8c9ee", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "3c38bca2c6f8d8023f2145326cc8a80100c3ffe4dcbd9842ff867f7fc6156c65"},
   "ecto_sql": {:hex, :ecto_sql, "3.11.1", "e9abf28ae27ef3916b43545f9578b4750956ccea444853606472089e7d169470", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 0.17.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ce14063ab3514424276e7e360108ad6c2308f6d88164a076aac8a387e1fea634"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "ex_doc": {:hex, :ex_doc, "0.33.0", "690562b153153c7e4d455dc21dab86e445f66ceba718defe64b0ef6f0bd83ba0", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "3f69adc28274cb51be37d09b03e4565232862a4b10288a3894587b0131412124"},

From 7192640aa864782c9c93c609f0d1eef12984c241 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 17:31:58 +0800
Subject: [PATCH 034/129] Update tests for phoenix_ecto 4.4 -> 4.5+ upgrade

---
 mix.exs                         |  6 +++---
 mix.lock                        |  6 +++---
 test/polymorphic_embed_test.exs | 13 +++++++++++--
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/mix.exs b/mix.exs
index f5ff15e..5ef49de 100644
--- a/mix.exs
+++ b/mix.exs
@@ -47,15 +47,15 @@ defmodule PolymorphicEmbed.MixProject do
 
   defp deps do
     [
-      {:ecto, "~> 3.11.2"},
+      {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 4.0", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:ex_doc, "~> 0.33", only: :dev},
-      {:ecto_sql, "~> 3.9", only: :test},
+      {:ecto_sql, "~> 3.11", only: :test},
       {:postgrex, "~> 0.17", only: :test},
       {:query_builder, "~> 1.0", only: :test},
-      {:phoenix_ecto, "~> 4.4", only: :test},
+      {:phoenix_ecto, "~> 4.6", only: :test},
       {:phoenix_live_view, "~> 0.20", only: :test},
       {:floki, "~> 0.36", only: :test},
       {:dialyxir, "~> 1.0", only: [:dev, :test], runtime: false},
diff --git a/mix.lock b/mix.lock
index d106abc..a833664 100644
--- a/mix.lock
+++ b/mix.lock
@@ -7,7 +7,7 @@
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.39", "424642f8335b05bb9eb611aa1564c148a8ee35c9c8a8bba6e129d51a3e3c6769", [:mix], [], "hexpm", "06553a88d1f1846da9ef066b87b57c6f605552cfbe40d20bd8d59cc6bde41944"},
   "ecto": {:hex, :ecto, "3.11.2", "e1d26be989db350a633667c5cda9c3d115ae779b66da567c68c80cfb26a8c9ee", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "3c38bca2c6f8d8023f2145326cc8a80100c3ffe4dcbd9842ff867f7fc6156c65"},
-  "ecto_sql": {:hex, :ecto_sql, "3.11.1", "e9abf28ae27ef3916b43545f9578b4750956ccea444853606472089e7d169470", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 0.17.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ce14063ab3514424276e7e360108ad6c2308f6d88164a076aac8a387e1fea634"},
+  "ecto_sql": {:hex, :ecto_sql, "3.11.2", "c7cc7f812af571e50b80294dc2e535821b3b795ce8008d07aa5f336591a185a8", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "73c07f995ac17dbf89d3cfaaf688fcefabcd18b7b004ac63b0dc4ef39499ed6b"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "ex_doc": {:hex, :ex_doc, "0.33.0", "690562b153153c7e4d455dc21dab86e445f66ceba718defe64b0ef6f0bd83ba0", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "3f69adc28274cb51be37d09b03e4565232862a4b10288a3894587b0131412124"},
   "excoveralls": {:hex, :excoveralls, "0.18.1", "a6f547570c6b24ec13f122a5634833a063aec49218f6fff27de9df693a15588c", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "d65f79db146bb20399f23046015974de0079668b9abb2f5aac074d078da60b8d"},
@@ -20,7 +20,7 @@
   "mime": {:hex, :mime, "2.0.5", "dc34c8efd439abe6ae0343edbb8556f4d63f178594894720607772a041b04b02", [:mix], [], "hexpm", "da0d64a365c45bc9935cc5c8a7fc5e49a0e0f9932a761c55d6c52b142780a05c"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
   "phoenix": {:hex, :phoenix, "1.7.12", "1cc589e0eab99f593a8aa38ec45f15d25297dd6187ee801c8de8947090b5a9d3", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "d646192fbade9f485b01bc9920c139bfdd19d0f8df3d73fd8eaf2dfbe0d2837c"},
-  "phoenix_ecto": {:hex, :phoenix_ecto, "4.4.3", "86e9878f833829c3f66da03d75254c155d91d72a201eb56ae83482328dc7ca93", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "d36c401206f3011fefd63d04e8ef626ec8791975d9d107f9a0817d426f61ac07"},
+  "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.1", "96798325fab2fed5a824ca204e877b81f9afd2e480f581e81f7b4b64a5a477f2", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.17", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "0ae544ff99f3c482b0807c5cec2c8289e810ecacabc04959d82c3337f4703391"},
   "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
   "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
   "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.14", "70fa101aa0539e81bed4238777498f6215e9dda3461bdaa067cad6908110c364", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "82f6d006c5264f979ed5eb75593d808bbe39020f20df2e78426f4f2d570e2402"},
@@ -28,7 +28,7 @@
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
   "plug": {:hex, :plug, "1.16.0", "1d07d50cb9bb05097fdf187b31cf087c7297aafc3fed8299aac79c128a707e47", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cbf53aa1f5c4d758a7559c0bd6d59e286c2be0c6a1fac8cc3eee2f638243b93e"},
   "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
-  "postgrex": {:hex, :postgrex, "0.17.4", "5777781f80f53b7c431a001c8dad83ee167bcebcf3a793e3906efff680ab62b3", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "6458f7d5b70652bc81c3ea759f91736c16a31be000f306d3c64bcdfe9a18b3cc"},
+  "postgrex": {:hex, :postgrex, "0.18.0", "f34664101eaca11ff24481ed4c378492fed2ff416cd9b06c399e90f321867d7e", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "a042989ba1bc1cca7383ebb9e461398e3f89f868c92ce6671feb7ef132a252d1"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index b743156..fd22870 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1921,7 +1921,11 @@ defmodule PolymorphicEmbedTest do
                               [count: 3, validation: :length, kind: :min, type: :string]}
                          ]
                 else
-                  assert f.errors == []
+                  assert f.errors == [
+                           name:
+                             {"can't be blank",
+                              [validation: :required]}
+                         ]
                 end
 
                 "from safe_inputs_for #{generator}"
@@ -2016,7 +2020,12 @@ defmodule PolymorphicEmbedTest do
             assert contents == expected_contents
 
             assert f.impl == Phoenix.HTML.FormData.Ecto.Changeset
-            assert f.errors == []
+
+            assert %{
+              number: {"can't be blank", [validation: :required]},
+              country_code: {"can't be blank", [validation: :required]},
+              provider: {"can't be blank", [validation: :required]}
+            } = Map.new(f.errors)
 
             "from safe_inputs_for #{generator}"
           end)

From b573058b543c8254d84ec9ac9e5589ca6e50cfff Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 17:33:43 +0800
Subject: [PATCH 035/129] Run mix format

---
 test/polymorphic_embed_test.exs | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index fd22870..2d2bcd0 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1922,9 +1922,7 @@ defmodule PolymorphicEmbedTest do
                          ]
                 else
                   assert f.errors == [
-                           name:
-                             {"can't be blank",
-                              [validation: :required]}
+                           name: {"can't be blank", [validation: :required]}
                          ]
                 end
 
@@ -2022,10 +2020,10 @@ defmodule PolymorphicEmbedTest do
             assert f.impl == Phoenix.HTML.FormData.Ecto.Changeset
 
             assert %{
-              number: {"can't be blank", [validation: :required]},
-              country_code: {"can't be blank", [validation: :required]},
-              provider: {"can't be blank", [validation: :required]}
-            } = Map.new(f.errors)
+                     number: {"can't be blank", [validation: :required]},
+                     country_code: {"can't be blank", [validation: :required]},
+                     provider: {"can't be blank", [validation: :required]}
+                   } = Map.new(f.errors)
 
             "from safe_inputs_for #{generator}"
           end)

From e3515802d570f4c2edc778d3bf7714c0233ace19 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:07:40 +0800
Subject: [PATCH 036/129] Avoid compile-time dependencies between parent and
 polymorphic embedded schemas

---
 CHANGELOG.md             |  1 +
 lib/polymorphic_embed.ex | 51 +++++++++++++++++++++++++++++++++++++++-
 2 files changed, 51 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2af1b72..aba0d2f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
   * Default value for polymorphic list of embeds is `[]` instead of `nil` (following `embeds_many/3`)
   * Support Phoenix HTML 4.0
+  * Avoid compile-time dependencies between parent and polymorphic embedded schemas
 
 ### Migration from 2.x to 3.x
 
diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 920ae1e..46e2450 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -1,22 +1,71 @@
 defmodule PolymorphicEmbed do
   use Ecto.ParameterizedType
 
+  require Logger
+
   alias Ecto.Changeset
 
   defmacro polymorphic_embeds_one(field_name, opts) do
+    opts = Keyword.update!(opts, :types, &expand_alias(&1, __CALLER__))
+
     quote do
       field(unquote(field_name), PolymorphicEmbed, unquote(opts))
     end
   end
 
   defmacro polymorphic_embeds_many(field_name, opts) do
-    opts = Keyword.merge(opts, default: [])
+    opts =
+      opts
+      |> Keyword.put_new(:default, [])
+      |> Keyword.update!(:types, &expand_alias(&1, __CALLER__))
 
     quote do
       field(unquote(field_name), {:array, PolymorphicEmbed}, unquote(opts))
     end
   end
 
+  # Expand module aliases to avoid creating compile-time dependencies between the
+  # parent schema that uses `polymorphic_embeds_one` or `polymorphic_embeds_many`
+  # and the embedded schemas.
+  defp expand_alias(types, env) when is_list(types) do
+    Enum.map(types, fn
+      {type_name, type_opts} when is_list(type_opts) ->
+        {type_name, Keyword.update!(type_opts, :module, &do_expand_alias(&1, env))}
+
+      {type_name, module} ->
+        {type_name, do_expand_alias(module, env)}
+    end)
+  end
+
+  # If it's not a list or a map, it means it's being defined by a reference of some kind,
+  # possibly via module attribute like:
+  # @types [twilio: PolymorphicEmbed.Channel.TwilioSMSProvider]
+  # # ...
+  #   polymorphic_embeds_one(:fallback_provider, types: @types)
+  # which means we can't expand aliases
+  defp expand_alias(types, env) do
+    Logger.warning("""
+    Aliases could not be expanded for the given types in #{inspect(env.module)}.
+
+    This likely means the types are defined using a module attribute or another reference
+    that cannot be expanded at compile time. As a result, this may lead to unnecessary
+    compile-time dependencies, causing longer compilation times and unnecessary
+    re-compilation of modules (the parent defining the embedded types).
+
+    Ensure that the types are specified directly within the macro call to avoid these issues,
+    or refactor your code to eliminate references that cannot be expanded.
+    """)
+    types
+  end
+
+  defp do_expand_alias({:__aliases__, _, _} = ast, env) do
+    Macro.expand(ast, %{env | function: {:__schema__, 2}})
+  end
+
+  defp do_expand_alias(ast, _env) do
+    ast
+  end
+
   @impl true
   def type(_params), do: :map
 

From ad450b6b3b32efc6f88c428711a42a7cfd034632 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:08:11 +0800
Subject: [PATCH 037/129] Run mix format

---
 lib/polymorphic_embed.ex | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 46e2450..433cc8c 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -55,6 +55,7 @@ defmodule PolymorphicEmbed do
     Ensure that the types are specified directly within the macro call to avoid these issues,
     or refactor your code to eliminate references that cannot be expanded.
     """)
+
     types
   end
 

From 8dcf76079c331896af40de890e9517afaa9c1d05 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:09:01 +0800
Subject: [PATCH 038/129] Bump version to 3.0.7

---
 README.md | 4 ++--
 mix.exs   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index b15f1da..1b5b70c 100644
--- a/README.md
+++ b/README.md
@@ -94,7 +94,7 @@ In your migration file, you may use the type `:map` for both `polymorphic_embeds
 add(:channel, :map)
 ```
 
-[It is not recommended](https://hexdocs.pm/ecto/3.8.4/Ecto.Schema.html#embeds_many/3) to use `{:array, :map}` for a list of embeds.
+[It is not recommended](https://hexdocs.pm/ecto/3.11.2/Ecto.Schema.html#embeds_many/3) to use `{:array, :map}` for a list of embeds.
 
 ### `cast_polymorphic_embed/3`
 
@@ -272,7 +272,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 3.0.6"}
+    {:polymorphic_embed, "~> 3.0.7"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index 5ef49de..b7d42f8 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "3.0.6"
+  @version "3.0.7"
 
   def project do
     [

From 60058bae3d19f0cc2595c5d6fd0acc3646dbb7a4 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:23:12 +0800
Subject: [PATCH 039/129] Remove unnecessary config value

---
 config/test.exs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config/test.exs b/config/test.exs
index 5368763..a4d6fd7 100644
--- a/config/test.exs
+++ b/config/test.exs
@@ -2,8 +2,6 @@ import Config
 
 config :logger, level: :warning
 
-config :phoenix, :json_library, Jason
-
 config :polymorphic_embed,
   ecto_repos: [PolymorphicEmbed.Repo]
 

From 529a0e9b8c7cfc596d2626e2e9b16af885f3df0f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:51:55 +0800
Subject: [PATCH 040/129] Update test support modules

---
 test/polymorphic_embed_test.exs                    | 2 +-
 test/support/models/not_polymorphic/channel/sms.ex | 4 ++--
 test/support/models/not_polymorphic/reminder.ex    | 8 ++++----
 test/support/models/polymorphic/channel/sms.ex     | 4 ++--
 test/support/models/polymorphic/reminder.ex        | 8 ++++----
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 2d2bcd0..4a5c490 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -774,7 +774,7 @@ defmodule PolymorphicEmbedTest do
 
     insert_result =
       struct(reminder_module)
-      |> reminder_module.custom_changeset2(sms_reminder_attrs)
+      |> reminder_module.custom_changeset(sms_reminder_attrs)
       |> Repo.insert()
 
     assert {:ok, reminder} = insert_result
diff --git a/test/support/models/not_polymorphic/channel/sms.ex b/test/support/models/not_polymorphic/channel/sms.ex
index e3379c8..a034114 100644
--- a/test/support/models/not_polymorphic/channel/sms.ex
+++ b/test/support/models/not_polymorphic/channel/sms.ex
@@ -23,13 +23,13 @@ defmodule PolymorphicEmbed.Regular.Channel.SMS do
     |> validate_required([:number, :country_code])
   end
 
-  def custom_changeset(struct, attrs, _foo, _bar) do
+  def custom_changeset(struct, attrs) do
     struct
     |> changeset(attrs)
     |> cast(attrs, [:custom])
   end
 
-  def custom_changeset2(struct, attrs) do
+  def custom_changeset2(struct, attrs, _foo, _bar) do
     struct
     |> changeset(attrs)
     |> cast(attrs, [:custom])
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index bbc0832..cdbae77 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -27,16 +27,16 @@ defmodule PolymorphicEmbed.Regular.Reminder do
   def custom_changeset(struct, attrs) do
     struct
     |> cast(attrs, [:date, :text])
-    |> cast_embed(:channel,
-      with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset(&1, &2, "foo", "bar")
-    )
+    |> cast_embed(:channel, with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset/2)
     |> validate_required(:date)
   end
 
   def custom_changeset2(struct, attrs) do
     struct
     |> cast(attrs, [:date, :text])
-    |> cast_embed(:channel, with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset2/2)
+    |> cast_embed(:channel,
+      with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset2(&1, &2, "foo", "bar")
+    )
     |> validate_required(:date)
   end
 end
diff --git a/test/support/models/polymorphic/channel/sms.ex b/test/support/models/polymorphic/channel/sms.ex
index e925b98..c01aacb 100644
--- a/test/support/models/polymorphic/channel/sms.ex
+++ b/test/support/models/polymorphic/channel/sms.ex
@@ -41,13 +41,13 @@ defmodule PolymorphicEmbed.Channel.SMS do
     |> validate_required([:number, :country_code])
   end
 
-  def custom_changeset(struct, attrs, _foo, _bar) do
+  def custom_changeset(struct, attrs) do
     struct
     |> changeset(attrs)
     |> cast(attrs, [:custom])
   end
 
-  def custom_changeset2(struct, attrs) do
+  def custom_changeset2(struct, attrs, _foo, _bar) do
     struct
     |> changeset(attrs)
     |> cast(attrs, [:custom])
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 0bc7386..cef4c3f 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -73,8 +73,7 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast(values, [:date, :text])
     |> cast_polymorphic_embed(:channel,
       with: [
-        sms: {PolymorphicEmbed.Channel.SMS, :custom_changeset, ["foo", "bar"]},
-        email: {PolymorphicEmbed.Channel.Email, :custom_changeset, ["foo", "bar"]}
+        sms: &PolymorphicEmbed.Channel.SMS.custom_changeset/2
       ]
     )
     |> validate_required(:date)
@@ -85,7 +84,8 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast(values, [:date, :text])
     |> cast_polymorphic_embed(:channel,
       with: [
-        sms: &PolymorphicEmbed.Channel.SMS.custom_changeset2/2
+        sms: {PolymorphicEmbed.Channel.SMS, :custom_changeset2, ["foo", "bar"]},
+        email: {PolymorphicEmbed.Channel.Email, :custom_changeset2, ["foo", "bar"]}
       ]
     )
     |> validate_required(:date)
@@ -96,7 +96,7 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast(values, [:date, :text])
     |> cast_polymorphic_embed(:channel,
       with: [
-        sms: &PolymorphicEmbed.Channel.SMS.custom_changeset2/2
+        sms: &PolymorphicEmbed.Channel.SMS.custom_changeset/2
       ]
     )
     |> validate_required(:date)

From 6d3561aa7eab542b1b6c16f93d13442141d37765 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 18:56:55 +0800
Subject: [PATCH 041/129] Remove unused changeset function

---
 test/support/models/polymorphic/reminder.ex | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index cef4c3f..a77efb0 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -90,15 +90,4 @@ defmodule PolymorphicEmbed.Reminder do
     )
     |> validate_required(:date)
   end
-
-  def custom_changeset3(struct, values) do
-    struct
-    |> cast(values, [:date, :text])
-    |> cast_polymorphic_embed(:channel,
-      with: [
-        sms: &PolymorphicEmbed.Channel.SMS.custom_changeset/2
-      ]
-    )
-    |> validate_required(:date)
-  end
 end

From b6954da3ccd5cbf7376f0ad65cc4603e8b741e9e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 19:25:02 +0800
Subject: [PATCH 042/129] Fix license id

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index b7d42f8..9cdc05c 100644
--- a/mix.exs
+++ b/mix.exs
@@ -80,7 +80,7 @@ defmodule PolymorphicEmbed.MixProject do
 
   defp package do
     [
-      licenses: ["Apache 2.0"],
+      licenses: ["Apache-2.0"],
       maintainers: ["Mathieu Decaffmeyer"],
       links: %{
         "GitHub" => "https://github.com/mathieuprog/polymorphic_embed",

From 512d6bf83365c76e664a8c96c57ce59d2a01d21f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 21:18:57 +0800
Subject: [PATCH 043/129] Update version matrix

---
 .github/workflows/ci.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1544278..6ed6d59 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,8 +19,6 @@ jobs:
     strategy:
       matrix:
         include:
-          - { elixir: 1.14, otp: 24 }
-          - { elixir: 1.14, otp: 25 }
           - { elixir: 1.15, otp: 24 }
           - { elixir: 1.15, otp: 25 }
           - { elixir: 1.15, otp: 26 }

From 9bc13e20a5e3a00b8223291620d36bf339f8bf32 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 21:46:16 +0800
Subject: [PATCH 044/129] Support updating while retaining ids

---
 lib/polymorphic_embed.ex        | 16 ++++++++++++++--
 test/polymorphic_embed_test.exs | 26 ++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 433cc8c..7e64891 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -262,6 +262,8 @@ defmodule PolymorphicEmbed do
       type_field: type_field
     } = field_options
 
+    list_data_for_field = Map.fetch!(changeset.data, field)
+
     embeds =
       Enum.map(list_params, fn params ->
         case do_get_polymorphic_module_from_map(params, type_field, types_metadata) do
@@ -275,8 +277,18 @@ defmodule PolymorphicEmbed do
             :ignore
 
           module ->
-            embed_changeset = changeset_fun.(struct(module), params)
-            embed_changeset = %{embed_changeset | action: :insert}
+            data_for_field =
+              Enum.find(list_data_for_field, fn datum ->
+                datum.id != nil and datum.id == params[:id] and datum.__struct__ == module
+              end)
+
+            embed_changeset =
+              if data_for_field do
+                %{changeset_fun.(data_for_field, params) | action: :update}
+              else
+                %{changeset_fun.(struct(module), params) | action: :insert}
+              end
+
             maybe_apply_changes(embed_changeset)
         end
       end)
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 4a5c490..d658271 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1260,6 +1260,32 @@ defmodule PolymorphicEmbedTest do
 
       assert Enum.at(reminder.contexts, 0).id != Enum.at(updated_reminder.contexts, 0).id
       assert Enum.at(reminder.contexts, 1).id != Enum.at(updated_reminder.contexts, 1).id
+
+      # Assert that we have same ids when the provided context element has an id
+      attrs = %{
+        contexts: [
+          %{
+            __type__: "device",
+            id: Enum.at(reminder.contexts, 0).id,
+            ref: "12345",
+            type: "cellphone",
+            address: "address"
+          },
+          %{
+            __type__: "age",
+            age: "aquarius",
+            address: "address"
+          }
+        ]
+      }
+
+      updated_reminder =
+        reminder
+        |> reminder_module.changeset(attrs)
+        |> Repo.update!()
+
+      assert Enum.at(reminder.contexts, 0).id == Enum.at(updated_reminder.contexts, 0).id
+      assert Enum.at(reminder.contexts, 1).id != Enum.at(updated_reminder.contexts, 1).id
     end
   end
 

From 6681c065df38c62208a1afc9c4a52d110f516470 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 23:07:47 +0800
Subject: [PATCH 045/129] Make it work for embeds without ids

---
 lib/polymorphic_embed.ex                      |  8 +++-
 test/polymorphic_embed_test.exs               | 41 ++++++++++++++++++-
 .../20000101000000_create_tables.exs          |  1 +
 .../models/not_polymorphic/reminder.ex        |  5 +++
 .../reminder/context/device_no_id.ex          | 21 ++++++++++
 test/support/models/polymorphic/reminder.ex   | 10 +++++
 .../reminder/context/device_no_id.ex          | 21 ++++++++++
 7 files changed, 103 insertions(+), 4 deletions(-)
 create mode 100644 test/support/models/not_polymorphic/reminder/context/device_no_id.ex
 create mode 100644 test/support/models/polymorphic/reminder/context/device_no_id.ex

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 7e64891..3f631f2 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -278,8 +278,12 @@ defmodule PolymorphicEmbed do
 
           module ->
             data_for_field =
-              Enum.find(list_data_for_field, fn datum ->
-                datum.id != nil and datum.id == params[:id] and datum.__struct__ == module
+              Enum.find(list_data_for_field, fn
+                %{id: id} = datum when not is_nil(id) ->
+                  id == params[:id] and datum.__struct__ == module
+
+                _ ->
+                  nil
               end)
 
             embed_changeset =
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index d658271..f36bd60 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1203,6 +1203,18 @@ defmodule PolymorphicEmbedTest do
             age: "aquarius",
             address: "address"
           }
+        ],
+        contexts3: [
+          %{
+            __type__: "device",
+            ref: "12345",
+            type: "cellphone"
+          },
+          %{
+            __type__: "device",
+            ref: "56789",
+            type: "laptop"
+          }
         ]
       }
 
@@ -1212,7 +1224,11 @@ defmodule PolymorphicEmbedTest do
         |> Repo.insert!()
 
       Enum.each(reminder.contexts, fn context ->
-        assert context.id
+        assert Map.has_key?(context, :id)
+      end)
+
+      Enum.each(reminder.contexts3, fn context ->
+        refute Map.has_key?(context, :id)
       end)
 
       reminder =
@@ -1223,7 +1239,7 @@ defmodule PolymorphicEmbedTest do
       assert reminder.contexts |> length() == 2
 
       Enum.each(reminder.contexts, fn context ->
-        assert context.id
+        assert Map.has_key?(context, :id)
       end)
 
       if polymorphic?(generator) do
@@ -1286,6 +1302,27 @@ defmodule PolymorphicEmbedTest do
 
       assert Enum.at(reminder.contexts, 0).id == Enum.at(updated_reminder.contexts, 0).id
       assert Enum.at(reminder.contexts, 1).id != Enum.at(updated_reminder.contexts, 1).id
+
+      # Make sure it also works for embeds without ids (`@primary_key false`)
+      attrs = %{
+        contexts3: [
+          %{
+            __type__: "device",
+            ref: "12345",
+            type: "cellphone"
+          },
+          %{
+            __type__: "device",
+            ref: "56789",
+            type: "laptop"
+          }
+        ]
+      }
+
+      assert {:ok, _} =
+               reminder
+               |> reminder_module.changeset(attrs)
+               |> Repo.update()
     end
   end
 
diff --git a/test/support/migrations/20000101000000_create_tables.exs b/test/support/migrations/20000101000000_create_tables.exs
index e1167f9..c43cda7 100644
--- a/test/support/migrations/20000101000000_create_tables.exs
+++ b/test/support/migrations/20000101000000_create_tables.exs
@@ -11,6 +11,7 @@ defmodule PolymorphicEmbed.CreateTables do
       add(:channel3, :map)
       add(:contexts, :map)
       add(:contexts2, :map)
+      add(:contexts3, :map)
 
       timestamps()
     end
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index cdbae77..03c596a 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -13,6 +13,10 @@ defmodule PolymorphicEmbed.Regular.Reminder do
       on_replace: :delete
     )
 
+    embeds_many(:contexts3, PolymorphicEmbed.Regular.Reminder.Context.DeviceNoId,
+      on_replace: :delete
+    )
+
     timestamps()
   end
 
@@ -22,6 +26,7 @@ defmodule PolymorphicEmbed.Regular.Reminder do
     |> validate_required(:date)
     |> cast_embed(:channel)
     |> cast_embed(:contexts)
+    |> cast_embed(:contexts3)
   end
 
   def custom_changeset(struct, attrs) do
diff --git a/test/support/models/not_polymorphic/reminder/context/device_no_id.ex b/test/support/models/not_polymorphic/reminder/context/device_no_id.ex
new file mode 100644
index 0000000..d863796
--- /dev/null
+++ b/test/support/models/not_polymorphic/reminder/context/device_no_id.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Regular.Reminder.Context.DeviceNoId do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  @primary_key false
+
+  embedded_schema do
+    field :ref, :string
+    field :type, :string
+
+    embeds_one :extra, Extra do
+      field :imei, :string
+    end
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, ~w(ref type)a)
+    |> validate_required(~w(type)a)
+  end
+end
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index a77efb0..632a378 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -56,6 +56,15 @@ defmodule PolymorphicEmbed.Reminder do
       on_replace: :delete
     )
 
+    polymorphic_embeds_many(:contexts3,
+      types: [
+        location: PolymorphicEmbed.Reminder.Context.Location,
+        age: PolymorphicEmbed.Reminder.Context.Age,
+        device: PolymorphicEmbed.Reminder.Context.DeviceNoId
+      ],
+      on_replace: :delete
+    )
+
     timestamps()
   end
 
@@ -66,6 +75,7 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast_polymorphic_embed(:channel)
     |> cast_polymorphic_embed(:contexts)
     |> cast_polymorphic_embed(:contexts2)
+    |> cast_polymorphic_embed(:contexts3)
   end
 
   def custom_changeset(struct, values) do
diff --git a/test/support/models/polymorphic/reminder/context/device_no_id.ex b/test/support/models/polymorphic/reminder/context/device_no_id.ex
new file mode 100644
index 0000000..3f6f9a5
--- /dev/null
+++ b/test/support/models/polymorphic/reminder/context/device_no_id.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Reminder.Context.DeviceNoId do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  @primary_key false
+
+  embedded_schema do
+    field :ref, :string
+    field :type, :string
+
+    embeds_one :extra, Extra do
+      field :imei, :string
+    end
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, ~w(ref type)a)
+    |> validate_required(~w(type)a)
+  end
+end

From 99ee34640ba68d07d5a5c4b23b22e7f834f72f80 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 25 May 2024 23:10:09 +0800
Subject: [PATCH 046/129] Update Changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index aba0d2f..35ed408 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
   * Default value for polymorphic list of embeds is `[]` instead of `nil` (following `embeds_many/3`)
   * Support Phoenix HTML 4.0
   * Avoid compile-time dependencies between parent and polymorphic embedded schemas
+  * Support updating list of embeds while retaining ids
 
 ### Migration from 2.x to 3.x
 

From 7fc853b7a470c52d5eaf796dfe696e03e92caabc Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:19:07 +0800
Subject: [PATCH 047/129] Handle form for list of embeds

---
 lib/polymorphic_embed/html/form.ex |  63 ++++++++++--------
 test/polymorphic_embed_test.exs    | 100 ++++++++++++++++++++++++++---
 2 files changed, 126 insertions(+), 37 deletions(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index cb19375..3544ec5 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -11,6 +11,11 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
     @doc """
     Returns the polymorphic type of the given field in the given form data.
     """
+    def get_polymorphic_type(%Phoenix.HTML.Form{} = form, field) do
+      %schema{} = form.source.data
+      get_polymorphic_type(form, schema, field)
+    end
+
     def get_polymorphic_type(%Phoenix.HTML.Form{} = form, schema, field) do
       case input_value(form, field) do
         %Ecto.Changeset{data: value} ->
@@ -29,7 +34,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
           end
 
         list when is_list(list) ->
-          nil
+          raise "Cannot infer the polymorphic type as the list of embeds may contain multiple types"
 
         nil ->
           nil
@@ -72,9 +77,8 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
     def polymorphic_embed_inputs_for(form, field)
         when is_atom(field) or is_binary(field) do
       options = Keyword.take(form.options, [:multipart])
-      %schema{} = form.source.data
-      type = get_polymorphic_type(form, schema, field)
-      to_form(form.source, form, field, type, options)
+
+      to_form(form.source, form, field, options)
     end
 
     @doc """
@@ -109,9 +113,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
     def polymorphic_embed_inputs_for(form, field, fun)
         when is_atom(field) or is_binary(field) do
       options = Keyword.take(form.options, [:multipart])
-      %schema{} = form.source.data
-      type = get_polymorphic_type(form, schema, field)
-      forms = to_form(form.source, form, field, type, options)
+      forms = to_form(form.source, form, field, options)
 
       html_escape(
         Enum.map(forms, fn form ->
@@ -120,10 +122,10 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
       )
     end
 
-    def polymorphic_embed_inputs_for(form, field, type, fun)
+    def polymorphic_embed_inputs_for(form, field, type \\ nil, fun)
         when is_atom(field) or is_binary(field) do
       options = Keyword.take(form.options, [:multipart])
-      forms = to_form(form.source, form, field, type, options)
+      forms = to_form(form.source, form, field, [{:polymorphic_type, type} | options])
 
       html_escape(
         Enum.map(forms, fn form ->
@@ -132,12 +134,26 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
       )
     end
 
-    def to_form(%{action: parent_action} = source_changeset, form, field, type, options) do
+    def to_form(%{action: parent_action} = source_changeset, form, field, options) do
       id = to_string(form.id <> "_#{field}")
       name = to_string(form.name <> "[#{field}]")
 
       params = Map.get(source_changeset.params || %{}, to_string(field), %{}) |> List.wrap()
-      list_data = get_data(source_changeset, field, type) |> List.wrap()
+
+      struct = Ecto.Changeset.apply_changes(source_changeset)
+
+      list_data =
+        case Map.get(struct, field) do
+          nil ->
+            type = Keyword.get(options, :polymorphic_type, get_polymorphic_type(form, field))
+            module = PolymorphicEmbed.get_polymorphic_module(struct.__struct__, field, type)
+            if module, do: [struct(module)], else: []
+
+          data ->
+            List.wrap(data)
+        end
+
+      num_entries = length(list_data)
 
       list_data
       |> Enum.with_index()
@@ -159,15 +175,19 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
             valid?: errors == []
         }
 
-        %schema{} = form.source.data
+        %schema{} = source_changeset.data
         %{type_field_atom: type_field} = PolymorphicEmbed.get_field_options(schema, field)
 
+        index_string = Integer.to_string(i)
+
+        type = PolymorphicEmbed.get_polymorphic_type(schema, field, changeset.data)
+
         %Phoenix.HTML.Form{
           source: changeset,
           impl: Phoenix.HTML.FormData.Ecto.Changeset,
-          id: id,
-          index: if(length(list_data) > 1, do: i),
-          name: name,
+          id: if(num_entries > 1, do: id <> "_" <> index_string, else: id),
+          name: if(num_entries > 1, do: name <> "[" <> index_string <> "]", else: name),
+          index: if(num_entries > 1, do: i),
           errors: errors,
           data: data,
           params: params,
@@ -177,19 +197,6 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
       end)
     end
 
-    defp get_data(changeset, field, type) do
-      struct = Ecto.Changeset.apply_changes(changeset)
-
-      case Map.get(struct, field) do
-        nil ->
-          module = PolymorphicEmbed.get_polymorphic_module(struct.__struct__, field, type)
-          if module, do: struct(module), else: []
-
-        data ->
-          data
-      end
-    end
-
     # If the parent changeset had no action, we need to remove the action
     # from children changeset so we ignore all errors accordingly.
     defp apply_action(changeset, nil), do: %{changeset | action: nil}
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index f36bd60..6d0f6d6 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1802,6 +1802,88 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "inputs_for/4 for list of embeds" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        contexts: [
+          %{
+            __type__: "device",
+            ref: "12345",
+            type: "cellphone",
+            address: "some address"
+          },
+          %{
+            __type__: "location",
+            age: "aquarius",
+            address: "some address"
+          }
+        ],
+      }
+
+      changeset =
+        struct(reminder_module)
+        |> reminder_module.changeset(attrs)
+
+      contents =
+        safe_inputs_for(changeset, :contexts, generator, fn f ->
+          assert f.impl == Phoenix.HTML.FormData.Ecto.Changeset
+          assert f.errors == []
+          text_input(f, :address)
+        end)
+
+      expected_contents =
+        if(polymorphic?(generator),
+          do:
+            ~s"""
+            <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
+            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
+            <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
+            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+            """,
+          else:
+            ~s"""
+            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
+            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+            """
+        )
+
+      assert contents == String.replace(expected_contents, "\n", "")
+
+      contents =
+        safe_inputs_for(
+          Map.put(changeset, :action, :insert),
+          :contexts,
+          generator,
+          fn f ->
+            assert f.impl == Phoenix.HTML.FormData.Ecto.Changeset
+            text_input(f, :address)
+          end
+        )
+
+      expected_contents =
+        if(polymorphic?(generator),
+          do:
+            ~s"""
+            <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
+            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
+            <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
+            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+            """,
+          else:
+            ~s"""
+            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
+            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+            """
+            )
+
+      assert contents == String.replace(expected_contents, "\n", "")
+    end
+  end
+
   test "inputs_for/4 after invalid insert" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
@@ -2199,7 +2281,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
                  :email
 
         text_input(f, :text)
@@ -2222,7 +2304,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(%{})
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
                  :email
 
         text_input(f, :text)
@@ -2239,7 +2321,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
                  :sms
 
         text_input(f, :text)
@@ -2256,7 +2338,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel2) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel2) ==
                  :email
 
         text_input(f, :text)
@@ -2273,7 +2355,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel2) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel2) ==
                  :email
 
         text_input(f, :text)
@@ -2290,7 +2372,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel3) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel3) ==
                  :email
 
         text_input(f, :text)
@@ -2307,7 +2389,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel3) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel3) ==
                  :email
 
         text_input(f, :text)
@@ -2324,7 +2406,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(attrs)
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
                  nil
 
         text_input(f, :text)
@@ -2340,7 +2422,7 @@ defmodule PolymorphicEmbedTest do
         |> reminder_module.changeset(%{})
 
       safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, reminder_module, :channel) ==
+        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
                  nil
 
         text_input(f, :text)

From c0f759dc7d80e490c7179d7b421aa99e104e31b1 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:23:56 +0800
Subject: [PATCH 048/129] Improve test readability

---
 test/polymorphic_embed_test.exs | 100 +++++++++++++++++---------------
 1 file changed, 54 insertions(+), 46 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 6d0f6d6..1c882df 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1771,13 +1771,16 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
-          else:
-            ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
+          do: ~s"""
+          <input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email">
+          <input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">
+          """,
+          else: ~s"""
+          <input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">
+          """
         )
 
-      assert contents == expected_contents
+      assert contents == String.replace(expected_contents, "\n", "")
 
       contents =
         safe_inputs_for(
@@ -1792,13 +1795,16 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
-          else:
-            ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
+          do: ~s"""
+          <input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email">
+          <input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">
+          """,
+          else: ~s"""
+          <input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">
+          """
         )
 
-      assert contents == expected_contents
+      assert contents == String.replace(expected_contents, "\n", "")
     end
   end
 
@@ -1821,7 +1827,7 @@ defmodule PolymorphicEmbedTest do
             age: "aquarius",
             address: "some address"
           }
-        ],
+        ]
       }
 
       changeset =
@@ -1837,18 +1843,16 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s"""
-            <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
-            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
-            <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
-            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
-            """,
-          else:
-            ~s"""
-            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
-            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
-            """
+          do: ~s"""
+          <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
+          <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
+          <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
+          <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+          """,
+          else: ~s"""
+          <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
+          <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+          """
         )
 
       assert contents == String.replace(expected_contents, "\n", "")
@@ -1866,19 +1870,17 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s"""
-            <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
-            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
-            <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
-            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
-            """,
-          else:
-            ~s"""
-            <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
-            <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
-            """
-            )
+          do: ~s"""
+          <input id="reminder_contexts_0___type__" name="reminder[contexts][0][__type__]" type="hidden" value="device">
+          <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text">
+          <input id="reminder_contexts_1___type__" name="reminder[contexts][1][__type__]" type="hidden" value="location">
+          <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+          """,
+          else: ~s"""
+          <input id="reminder_contexts_0_address" name="reminder[contexts][0][address]" type="text" value="some address">
+          <input id="reminder_contexts_1_address" name="reminder[contexts][1][address]" type="text" value="some address">
+          """
+        )
 
       assert contents == String.replace(expected_contents, "\n", "")
     end
@@ -1916,13 +1918,16 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
-          else:
-            ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
+          do: ~s"""
+          <input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms">
+          <input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">
+          """,
+          else: ~s"""
+          <input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">
+          """
         )
 
-      assert contents == expected_contents
+      assert contents == String.replace(expected_contents, "\n", "")
 
       contents =
         safe_inputs_for(
@@ -1937,13 +1942,16 @@ defmodule PolymorphicEmbedTest do
 
       expected_contents =
         if(polymorphic?(generator),
-          do:
-            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
-          else:
-            ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
+          do: ~s"""
+          <input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms">
+          <input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">
+          """,
+          else: ~s"""
+          <input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">
+          """
         )
 
-      assert contents == expected_contents
+      assert contents == String.replace(expected_contents, "\n", "")
     end
   end
 

From 8fb5dfb84032f8378727a525681fcf9f11d6bc06 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:30:38 +0800
Subject: [PATCH 049/129] Remove support for custom changeset through MFA

---
 README.md                                     |  4 +-
 test/polymorphic_embed_test.exs               | 39 +------------------
 .../models/not_polymorphic/channel/sms.ex     |  6 ---
 .../models/not_polymorphic/reminder.ex        |  9 -----
 .../support/models/polymorphic/channel/sms.ex |  6 ---
 test/support/models/polymorphic/reminder.ex   | 12 ------
 6 files changed, 3 insertions(+), 73 deletions(-)

diff --git a/README.md b/README.md
index 1b5b70c..e00589a 100644
--- a/README.md
+++ b/README.md
@@ -104,12 +104,12 @@ add(:channel, :map)
 
 * `:required` – if the embed is a required field.
 
-* `:with` – allows you to specify a custom changeset. Either pass an MFA or a function:
+* `:with` – allows you to specify a custom changeset.
 ```elixir
 changeset
 |> cast_polymorphic_embed(:channel,
   with: [
-    sms: {SMS, :custom_changeset, ["hello"]},
+    sms: &SMS.custom_changeset/2,
     email: &Email.custom_changeset/2
   ]
 )
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 1c882df..cc0f34d 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -682,43 +682,6 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
-  test "custom changeset by passing MFA" do
-    for generator <- @generators do
-      reminder_module = get_module(Reminder, generator)
-      sms_module = get_module(Channel.SMS, generator)
-
-      sms_reminder_attrs = %{
-        date: ~U[2020-05-28 02:57:19Z],
-        text: "This is an SMS reminder #{generator}",
-        channel: %{
-          my_type_field: "sms",
-          number: "02/807.05.53",
-          country_code: 1,
-          attempts: [],
-          provider: %{__type__: "twilio", api_key: "somekey"},
-          custom: true
-        }
-      }
-
-      insert_result =
-        struct(reminder_module)
-        |> reminder_module.custom_changeset(sms_reminder_attrs)
-        |> Repo.insert()
-
-      assert {:ok, reminder} = insert_result
-      assert reminder.channel.custom
-
-      %reminder_module{} = reminder
-
-      reminder =
-        reminder_module
-        |> QueryBuilder.where(text: "This is an SMS reminder #{generator}")
-        |> Repo.one()
-
-      assert sms_module == reminder.channel.__struct__
-    end
-  end
-
   test "custom changeset by passing function" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
@@ -739,7 +702,7 @@ defmodule PolymorphicEmbedTest do
 
       insert_result =
         struct(reminder_module)
-        |> reminder_module.custom_changeset2(sms_reminder_attrs)
+        |> reminder_module.custom_changeset(sms_reminder_attrs)
         |> Repo.insert()
 
       assert {:ok, reminder} = insert_result
diff --git a/test/support/models/not_polymorphic/channel/sms.ex b/test/support/models/not_polymorphic/channel/sms.ex
index a034114..6536733 100644
--- a/test/support/models/not_polymorphic/channel/sms.ex
+++ b/test/support/models/not_polymorphic/channel/sms.ex
@@ -28,10 +28,4 @@ defmodule PolymorphicEmbed.Regular.Channel.SMS do
     |> changeset(attrs)
     |> cast(attrs, [:custom])
   end
-
-  def custom_changeset2(struct, attrs, _foo, _bar) do
-    struct
-    |> changeset(attrs)
-    |> cast(attrs, [:custom])
-  end
 end
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index 03c596a..294af9e 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -35,13 +35,4 @@ defmodule PolymorphicEmbed.Regular.Reminder do
     |> cast_embed(:channel, with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset/2)
     |> validate_required(:date)
   end
-
-  def custom_changeset2(struct, attrs) do
-    struct
-    |> cast(attrs, [:date, :text])
-    |> cast_embed(:channel,
-      with: &PolymorphicEmbed.Regular.Channel.SMS.custom_changeset2(&1, &2, "foo", "bar")
-    )
-    |> validate_required(:date)
-  end
 end
diff --git a/test/support/models/polymorphic/channel/sms.ex b/test/support/models/polymorphic/channel/sms.ex
index c01aacb..23ac803 100644
--- a/test/support/models/polymorphic/channel/sms.ex
+++ b/test/support/models/polymorphic/channel/sms.ex
@@ -46,10 +46,4 @@ defmodule PolymorphicEmbed.Channel.SMS do
     |> changeset(attrs)
     |> cast(attrs, [:custom])
   end
-
-  def custom_changeset2(struct, attrs, _foo, _bar) do
-    struct
-    |> changeset(attrs)
-    |> cast(attrs, [:custom])
-  end
 end
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 632a378..fd7e117 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -88,16 +88,4 @@ defmodule PolymorphicEmbed.Reminder do
     )
     |> validate_required(:date)
   end
-
-  def custom_changeset2(struct, values) do
-    struct
-    |> cast(values, [:date, :text])
-    |> cast_polymorphic_embed(:channel,
-      with: [
-        sms: {PolymorphicEmbed.Channel.SMS, :custom_changeset2, ["foo", "bar"]},
-        email: {PolymorphicEmbed.Channel.Email, :custom_changeset2, ["foo", "bar"]}
-      ]
-    )
-    |> validate_required(:date)
-  end
 end

From 5fd3bc9713ea2ed3d883e9af15e388d85fbf6071 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:39:14 +0800
Subject: [PATCH 050/129] Remove unnecessary test

---
 test/polymorphic_embed_test.exs | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index cc0f34d..dd51ae5 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -2282,23 +2282,6 @@ defmodule PolymorphicEmbedTest do
       end)
     end
 
-    test "returns type from changeset via custom type field" do
-      reminder_module = get_module(Reminder, :polymorphic)
-      attrs = %{"channel" => %{"my_type_field" => "sms"}}
-
-      changeset =
-        reminder_module
-        |> struct()
-        |> reminder_module.changeset(attrs)
-
-      safe_form_for(changeset, fn f ->
-        assert PolymorphicEmbed.HTML.Form.get_polymorphic_type(f, :channel) ==
-                 :sms
-
-        text_input(f, :text)
-      end)
-    end
-
     test "returns type from map with default type field (string)" do
       reminder_module = get_module(Reminder, :polymorphic)
       attrs = %{"channel2" => %{"__type__" => "email"}}

From 4e79485e0b03d3d443b7fffe4cd39f9c1df00364 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:49:32 +0800
Subject: [PATCH 051/129] Fix hidden input field name

---
 lib/polymorphic_embed/html/form.ex | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 3544ec5..0187ca2 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -176,7 +176,11 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
         }
 
         %schema{} = source_changeset.data
-        %{type_field_atom: type_field} = PolymorphicEmbed.get_field_options(schema, field)
+
+        field_options = PolymorphicEmbed.get_field_options(schema, field)
+        type_field_atom = Map.get(field_options, :type_field_atom, :__type__)
+        # correctly set id and name for embeds_many inputs
+        array? = Map.get(field_options, :array?, false)
 
         index_string = Integer.to_string(i)
 
@@ -185,13 +189,13 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
         %Phoenix.HTML.Form{
           source: changeset,
           impl: Phoenix.HTML.FormData.Ecto.Changeset,
-          id: if(num_entries > 1, do: id <> "_" <> index_string, else: id),
-          name: if(num_entries > 1, do: name <> "[" <> index_string <> "]", else: name),
-          index: if(num_entries > 1, do: i),
+          id: if(array?, do: id <> "_" <> index_string, else: id),
+          name: if(array?, do: name <> "[" <> index_string <> "]", else: name),
+          index: if(array?, do: i),
           errors: errors,
           data: data,
           params: params,
-          hidden: [{type_field, to_string(type)}],
+          hidden: [{type_field_atom, to_string(type)}],
           options: options
         }
       end)

From 9630814d90fb898f61a308fb2ce2033597bc8475 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:53:55 +0800
Subject: [PATCH 052/129] Remove unused variable

---
 lib/polymorphic_embed/html/form.ex | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 0187ca2..a6aee90 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -153,8 +153,6 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
             List.wrap(data)
         end
 
-      num_entries = length(list_data)
-
       list_data
       |> Enum.with_index()
       |> Enum.map(fn {data, i} ->

From aeabe3744234a5e359fc549cbdb1d507630c384f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 10:58:18 +0800
Subject: [PATCH 053/129] Fix docs

---
 README.md                          | 2 +-
 lib/polymorphic_embed/html/form.ex | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index e00589a..a1d064d 100644
--- a/README.md
+++ b/README.md
@@ -219,7 +219,7 @@ You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
 
 ```elixir
 <.form
-  let={f}
+  :let={f}
   for={@changeset}
   id="reminder-form"
   phx-change="validate"
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index a6aee90..609ad67 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -53,7 +53,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
     ## Example
 
         <.form
-          let={f}
+          :let={f}
           for={@changeset}
           id="reminder-form"
           phx-change="validate"

From 9814dfd679d267e1ead13318ccccfabdc37ad4ed Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 18:13:31 +0800
Subject: [PATCH 054/129] Support sort_ and drop_param for list of embeds

---
 lib/polymorphic_embed.ex                      | 127 +++++++--
 lib/polymorphic_embed/html/form.ex            |   6 +-
 test/polymorphic_embed_test.exs               | 263 ++++++++++++++++++
 .../models/not_polymorphic/reminder.ex        |   5 +-
 test/support/models/polymorphic/reminder.ex   |   6 +-
 5 files changed, 384 insertions(+), 23 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 3f631f2..58eef10 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -110,22 +110,39 @@ defmodule PolymorphicEmbed do
     }
   end
 
-  def cast_polymorphic_embed(changeset, field, cast_options \\ [])
+  def cast_polymorphic_embed(changeset, field, cast_opts \\ [])
 
   # credo:disable-for-next-line
-  def cast_polymorphic_embed(%Ecto.Changeset{} = changeset, field, cast_options) do
-    field_options = get_field_options(changeset.data.__struct__, field)
+  def cast_polymorphic_embed(%Ecto.Changeset{} = changeset, field, cast_opts) do
+    field_opts = get_field_opts(changeset.data.__struct__, field)
 
-    raise_if_invalid_options(field, field_options)
+    raise_if_invalid_options(field, field_opts)
 
-    %{array?: array?, types_metadata: types_metadata} = field_options
+    %{array?: array?, types_metadata: types_metadata} = field_opts
 
-    required = Keyword.get(cast_options, :required, false)
-    with = Keyword.get(cast_options, :with, nil)
+    required = Keyword.get(cast_opts, :required, false)
+    with = Keyword.get(cast_opts, :with, nil)
 
     changeset_fun = &changeset_fun(&1, &2, with, types_metadata)
 
+    # used for sort_param and drop_param support for many embeds
+    sort = param_value_for_cast_opt(:sort_param, cast_opts, changeset.params)
+    drop = param_value_for_cast_opt(:drop_param, cast_opts, changeset.params)
+
     case Map.fetch(changeset.params || %{}, to_string(field)) do
+      # consider sort and drop params even if the assoc param was not given, as in Ecto
+      :error when (array? and is_list(sort)) or is_list(drop) ->
+        create_sort_default = fn -> sort_create(Enum.into(cast_opts, %{}), field_opts) end
+        params_for_field = apply_sort_drop(%{}, sort, drop, create_sort_default)
+
+        cast_polymorphic_embeds_many(
+          changeset,
+          field,
+          changeset_fun,
+          params_for_field,
+          field_opts
+        )
+
       :error when required ->
         if data_for_field = Map.fetch!(changeset.data, field) do
           data_for_field = autogenerate_id(data_for_field, changeset.action)
@@ -151,13 +168,16 @@ defmodule PolymorphicEmbed do
       {:ok, map} when map == %{} and not array? ->
         changeset
 
-      {:ok, params_for_field} when is_list(params_for_field) and array? ->
+      {:ok, params_for_field} when array? ->
+        create_sort_default = fn -> sort_create(Enum.into(cast_opts, %{}), field_opts) end
+        params_for_field = apply_sort_drop(params_for_field, sort, drop, create_sort_default)
+
         cast_polymorphic_embeds_many(
           changeset,
           field,
           changeset_fun,
           params_for_field,
-          field_options
+          field_opts
         )
 
       {:ok, params_for_field} when is_map(params_for_field) and not array? ->
@@ -166,7 +186,7 @@ defmodule PolymorphicEmbed do
           field,
           changeset_fun,
           params_for_field,
-          field_options
+          field_opts
         )
     end
   end
@@ -175,6 +195,77 @@ defmodule PolymorphicEmbed do
     raise "cast_polymorphic_embed/3 only accepts a changeset as first argument"
   end
 
+  defp sort_create(%{sort_param: _} = cast_opts, field_opts) do
+    default_type = Map.get(cast_opts, :default_type_on_sort_create)
+    type_field_atom = Map.fetch!(field_opts, :type_field_atom)
+    types_metadata = Map.fetch!(field_opts, :types_metadata)
+
+    case default_type do
+      nil ->
+        # If type is not provided, use the first type from types_metadata
+        [first_type_metadata | _] = types_metadata
+        first_type = first_type_metadata.type
+        %{type_field_atom => first_type}
+
+      _ ->
+        # If type is provided, ensure it exists in types_metadata
+        unless Enum.find(types_metadata, &(&1.type === default_type)) do
+          raise "Incorrect type atom #{inspect(default_type)}"
+        end
+
+        %{type_field_atom => default_type}
+    end
+  end
+
+  defp sort_create(_cast_opts, _field_opts), do: nil
+
+  defp apply_sort_drop(value, sort, drop, create_sort_default) when is_map(value) do
+    drop = if is_list(drop), do: drop, else: []
+
+    {sorted, pending} =
+      if is_list(sort) do
+        Enum.map_reduce(sort -- drop, value, &Map.pop(&2, &1, create_sort_default.()))
+      else
+        {[], value}
+      end
+
+    sorted ++
+      (pending
+       |> Map.drop(drop)
+       |> Enum.map(&key_as_int/1)
+       |> Enum.sort()
+       |> Enum.map(&elem(&1, 1)))
+  end
+
+  defp apply_sort_drop(value, _sort, _drop, _default) do
+    value
+  end
+
+  defp param_value_for_cast_opt(opt, opts, params) do
+    if key = opts[opt] do
+      Map.get(params, Atom.to_string(key), nil)
+    end
+  end
+
+  defp key_as_int({key, val}) when is_binary(key) do
+    case Integer.parse(key) do
+      {key, ""} -> {key, val}
+      _ -> {key, val}
+    end
+  end
+
+  # from Ecto
+  # We check for the byte size to avoid creating unnecessary large integers
+  # which would never map to a database key (u64 is 20 digits only).
+  defp key_as_int({key, val}) when is_binary(key) and byte_size(key) < 32 do
+    case Integer.parse(key) do
+      {key, ""} -> {key, val}
+      _ -> {key, val}
+    end
+  end
+
+  defp key_as_int(key_val), do: key_val
+
   defp changeset_fun(struct, params, with, types_metadata) when is_list(with) do
     type = do_get_polymorphic_type(struct, types_metadata)
 
@@ -194,12 +285,12 @@ defmodule PolymorphicEmbed do
     struct.__struct__.changeset(struct, params)
   end
 
-  defp cast_polymorphic_embeds_one(changeset, field, changeset_fun, params, field_options) do
+  defp cast_polymorphic_embeds_one(changeset, field, changeset_fun, params, field_opts) do
     %{
       types_metadata: types_metadata,
       on_type_not_found: on_type_not_found,
       type_field: type_field
-    } = field_options
+    } = field_opts
 
     data_for_field = Map.fetch!(changeset.data, field)
 
@@ -255,12 +346,12 @@ defmodule PolymorphicEmbed do
     end
   end
 
-  defp cast_polymorphic_embeds_many(changeset, field, changeset_fun, list_params, field_options) do
+  defp cast_polymorphic_embeds_many(changeset, field, changeset_fun, list_params, field_opts) do
     %{
       types_metadata: types_metadata,
       on_type_not_found: on_type_not_found,
       type_field: type_field
-    } = field_options
+    } = field_opts
 
     list_data_for_field = Map.fetch!(changeset.data, field)
 
@@ -386,7 +477,7 @@ defmodule PolymorphicEmbed do
   end
 
   def get_polymorphic_module(schema, field, type_or_data) do
-    %{types_metadata: types_metadata, type_field: type_field} = get_field_options(schema, field)
+    %{types_metadata: types_metadata, type_field: type_field} = get_field_opts(schema, field)
 
     case type_or_data do
       map when is_map(map) ->
@@ -421,7 +512,7 @@ defmodule PolymorphicEmbed do
   end
 
   def get_polymorphic_type(schema, field, module_or_struct) do
-    %{types_metadata: types_metadata} = get_field_options(schema, field)
+    %{types_metadata: types_metadata} = get_field_opts(schema, field)
     do_get_polymorphic_type(module_or_struct, types_metadata)
   end
 
@@ -441,7 +532,7 @@ defmodule PolymorphicEmbed do
       #=> [:location, :age, :device]
   """
   def types(schema, field) do
-    %{types_metadata: types_metadata} = get_field_options(schema, field)
+    %{types_metadata: types_metadata} = get_field_opts(schema, field)
     Enum.map(types_metadata, & &1.type)
   end
 
@@ -455,7 +546,7 @@ defmodule PolymorphicEmbed do
   end
 
   @doc false
-  def get_field_options(schema, field) do
+  def get_field_opts(schema, field) do
     try do
       schema.__schema__(:type, field)
     rescue
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 609ad67..ea1baef 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -175,10 +175,10 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
 
         %schema{} = source_changeset.data
 
-        field_options = PolymorphicEmbed.get_field_options(schema, field)
-        type_field_atom = Map.get(field_options, :type_field_atom, :__type__)
+        field_opts = PolymorphicEmbed.get_field_opts(schema, field)
+        type_field_atom = Map.get(field_opts, :type_field_atom, :__type__)
         # correctly set id and name for embeds_many inputs
-        array? = Map.get(field_options, :array?, false)
+        array? = Map.get(field_opts, :array?, false)
 
         index_string = Integer.to_string(i)
 
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index dd51ae5..bc4e49b 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1607,6 +1607,269 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "supports map with number keys" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      attrs = %{
+        "date" => ~U[2020-05-28 02:57:19Z],
+        "text" => "This is a reminder with multiple contexts #{generator}",
+        "channel" => %{
+          "my_type_field" => "sms",
+          "number" => "02/807.05.53",
+          "country_code" => 1,
+          "provider" => %{
+            "__type__" => "twilio",
+            "api_key" => "foo"
+          }
+        },
+        "contexts" => %{
+          "0" => %{
+            "__type__" => "device",
+            "ref" => "12345",
+            "type" => "cellphone",
+            "address" => "address"
+          },
+          "1" => %{
+            "__type__" => "age",
+            "age" => "aquarius",
+            "address" => "address"
+          }
+        }
+      }
+
+      reminder =
+        struct(reminder_module)
+        |> reminder_module.changeset(attrs)
+        |> Repo.insert!()
+
+      Enum.each(reminder.contexts, fn context ->
+        assert context.id
+      end)
+
+      reminder =
+        reminder_module
+        |> QueryBuilder.where(text: "This is a reminder with multiple contexts #{generator}")
+        |> Repo.one()
+
+      assert reminder.contexts |> length() == 2
+
+      Enum.each(reminder.contexts, fn context ->
+        assert context.id
+      end)
+
+      if polymorphic?(generator) do
+        assert Enum.at(reminder.contexts, 0).ref == "12345"
+        assert Enum.at(reminder.contexts, 0).type == "cellphone"
+        assert Enum.at(reminder.contexts, 1).age == "aquarius"
+      else
+        assert Enum.at(reminder.contexts, 0).address == "address"
+        assert Enum.at(reminder.contexts, 1).address == "address"
+      end
+
+      # add new list of contexts and assert that we have different ids
+
+      attrs = %{
+        "contexts" => %{
+          "0" => %{
+            "__type__" => "device",
+            "ref" => "12345",
+            "type" => "cellphone",
+            "address" => "address"
+          },
+          "1" => %{
+            "__type__" => "age",
+            "age" => "aquarius",
+            "address" => "address"
+          }
+        }
+      }
+
+      updated_reminder =
+        reminder
+        |> reminder_module.changeset(attrs)
+        |> Repo.update!()
+
+      assert Enum.at(reminder.contexts, 0).id != Enum.at(updated_reminder.contexts, 0).id
+      assert Enum.at(reminder.contexts, 1).id != Enum.at(updated_reminder.contexts, 1).id
+    end
+  end
+
+  test "embeds_many with sort_param and drop_param" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      attrs = %{
+        "date" => ~U[2020-05-28 02:57:19Z],
+        "text" => "This is a reminder with multiple contexts #{generator}",
+        "channel" => %{
+          "my_type_field" => "sms",
+          "number" => "02/807.05.53",
+          "country_code" => 1,
+          "provider" => %{
+            "__type__" => "twilio",
+            "api_key" => "foo"
+          }
+        },
+        "contexts" => %{
+          "0" => %{
+            "__type__" => "device",
+            "ref" => "12345",
+            "type" => "cellphone",
+            "address" => "address"
+          },
+          "1" => %{
+            "__type__" => "age",
+            "age" => "aquarius",
+            "address" => "address"
+          },
+          "2" => %{
+            "__type__" => "age",
+            "age" => "aquarius_drop",
+            "address" => "address_drop"
+          }
+        },
+        "contexts_drop" => ["2"],
+        "contexts_sort" => ["1", "0", "2"]
+      }
+
+      reminder =
+        struct(reminder_module)
+        |> reminder_module.changeset(attrs)
+        |> Repo.insert!()
+
+      Enum.each(reminder.contexts, fn context ->
+        assert context.id
+      end)
+
+      reminder =
+        reminder_module
+        |> QueryBuilder.where(text: "This is a reminder with multiple contexts #{generator}")
+        |> Repo.one()
+
+      assert reminder.contexts |> length() == 2
+
+      Enum.each(reminder.contexts, fn context ->
+        assert context.id
+      end)
+
+      if polymorphic?(generator) do
+        assert Enum.at(reminder.contexts, 1).ref == "12345"
+        assert Enum.at(reminder.contexts, 1).type == "cellphone"
+        assert Enum.at(reminder.contexts, 0).age == "aquarius"
+      else
+        assert Enum.at(reminder.contexts, 1).address == "address"
+        assert Enum.at(reminder.contexts, 0).address == "address"
+      end
+
+      # add new list of contexts and assert that we have different ids
+
+      attrs = %{
+        "contexts" => %{
+          "0" => %{
+            "__type__" => "device",
+            "ref" => "12345",
+            "type" => "cellphone",
+            "address" => "address"
+          },
+          "1" => %{
+            "__type__" => "age",
+            "age" => "aquarius",
+            "address" => "address"
+          }
+        }
+      }
+
+      updated_reminder =
+        reminder
+        |> reminder_module.changeset(attrs)
+        |> Repo.update!()
+
+      assert Enum.at(reminder.contexts, 0).id != Enum.at(updated_reminder.contexts, 0).id
+      assert Enum.at(reminder.contexts, 1).id != Enum.at(updated_reminder.contexts, 1).id
+    end
+  end
+
+  test "embeds_many with new sort_param" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      attrs = %{
+        "date" => ~U[2020-05-28 02:57:19Z],
+        "text" => "This is a reminder with multiple contexts #{generator}",
+        "channel" => %{
+          "my_type_field" => "sms",
+          "number" => "02/807.05.53",
+          "country_code" => 1,
+          "provider" => %{
+            "__type__" => "twilio",
+            "api_key" => "foo"
+          }
+        },
+        "contexts" => %{
+          "0" => %{
+            "__type__" => "device",
+            "ref" => "12345",
+            "type" => "cellphone",
+            "address" => "address"
+          },
+          "1" => %{
+            "__type__" => "age",
+            "age" => "aquarius",
+            "address" => "address"
+          },
+          "2" => %{
+            "__type__" => "age",
+            "age" => "aquarius_drop",
+            "address" => "address_drop"
+          }
+        },
+        "contexts_drop" => ["2"],
+        "contexts_sort" => ["1", "0", "2", "new"]
+      }
+
+      assert changeset =
+               %Ecto.Changeset{valid?: false} =
+               struct(reminder_module)
+               |> reminder_module.changeset(attrs)
+
+      assert Enum.at(changeset.changes.contexts, 2).errors == [
+               address: {"can't be blank", [validation: :required]}
+             ]
+    end
+  end
+
+  test "embeds_many with sort_param but no assoc param" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      attrs = %{
+        "date" => ~U[2020-05-28 02:57:19Z],
+        "text" => "This is a reminder with multiple contexts #{generator}",
+        "channel" => %{
+          "my_type_field" => "sms",
+          "number" => "02/807.05.53",
+          "country_code" => 1,
+          "provider" => %{
+            "__type__" => "twilio",
+            "api_key" => "foo"
+          }
+        },
+        "contexts_drop" => [],
+        "contexts_sort" => ["on"]
+      }
+
+      assert changeset =
+               %Ecto.Changeset{valid?: false} =
+               struct(reminder_module)
+               |> reminder_module.changeset(attrs)
+
+      assert Enum.at(changeset.changes.contexts, 0).errors == [
+               address: {"can't be blank", [validation: :required]}
+             ]
+    end
+  end
+
   describe "polymorphic_embed_inputs_for/2" do
     test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index 294af9e..e7b4e69 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -25,7 +25,10 @@ defmodule PolymorphicEmbed.Regular.Reminder do
     |> cast(attrs, [:date, :text])
     |> validate_required(:date)
     |> cast_embed(:channel)
-    |> cast_embed(:contexts)
+    |> cast_embed(:contexts,
+      sort_param: :contexts_sort,
+      drop_param: :contexts_drop
+    )
     |> cast_embed(:contexts3)
   end
 
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index fd7e117..5192f8e 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -73,7 +73,11 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast(values, [:date, :text])
     |> validate_required(:date)
     |> cast_polymorphic_embed(:channel)
-    |> cast_polymorphic_embed(:contexts)
+    |> cast_polymorphic_embed(:contexts,
+      sort_param: :contexts_sort,
+      default_type_on_sort_create: :location,
+      drop_param: :contexts_drop
+    )
     |> cast_polymorphic_embed(:contexts2)
     |> cast_polymorphic_embed(:contexts3)
   end

From 9bd8345d961a7d5ab3d4a8813b233080355670a1 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 18:48:45 +0800
Subject: [PATCH 055/129] Allow lazy loading of default_type_on_sort_create

---
 lib/polymorphic_embed.ex                    |  6 +++++
 test/polymorphic_embed_test.exs             | 29 +++++++++++++++++++++
 test/support/models/polymorphic/reminder.ex |  6 ++++-
 3 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 58eef10..5d992a6 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -208,6 +208,12 @@ defmodule PolymorphicEmbed do
         %{type_field_atom => first_type}
 
       _ ->
+        default_type =
+          case default_type do
+            fun when is_function(fun, 0) -> fun.()
+            _ -> default_type
+          end
+
         # If type is provided, ensure it exists in types_metadata
         unless Enum.find(types_metadata, &(&1.type === default_type)) do
           raise "Incorrect type atom #{inspect(default_type)}"
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index bc4e49b..9c7cc68 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1870,6 +1870,35 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "embeds_many with sort_param but no assoc param (sort_create function)" do
+    reminder_module = get_module(Reminder, :polymorphic)
+
+    attrs = %{
+      "date" => ~U[2020-05-28 02:57:19Z],
+      "text" => "This is a reminder with multiple contexts",
+      "channel" => %{
+        "my_type_field" => "sms",
+        "number" => "02/807.05.53",
+        "country_code" => 1,
+        "provider" => %{
+          "__type__" => "twilio",
+          "api_key" => "foo"
+        }
+      },
+      "contexts2_drop" => [],
+      "contexts2_sort" => ["on"]
+    }
+
+    assert changeset =
+             %Ecto.Changeset{valid?: false} =
+             struct(reminder_module)
+             |> reminder_module.changeset(attrs)
+
+    assert Enum.at(changeset.changes.contexts2, 0).errors == [
+             address: {"can't be blank", [validation: :required]}
+           ]
+  end
+
   describe "polymorphic_embed_inputs_for/2" do
     test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 5192f8e..a7018bc 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -78,7 +78,11 @@ defmodule PolymorphicEmbed.Reminder do
       default_type_on_sort_create: :location,
       drop_param: :contexts_drop
     )
-    |> cast_polymorphic_embed(:contexts2)
+    |> cast_polymorphic_embed(:contexts2,
+      sort_param: :contexts2_sort,
+      default_type_on_sort_create: fn -> :location end,
+      drop_param: :contexts2_drop
+    )
     |> cast_polymorphic_embed(:contexts3)
   end
 

From c13f124fdf9d830e3b7f41f6fab0e069af6dbe1d Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 19:24:06 +0800
Subject: [PATCH 056/129] Add PolymorphicEmbed.HTML.Component + restructure

---
 lib/polymorphic_embed/html/component.ex | 138 ++++++++++++++++++++++++
 lib/polymorphic_embed/html/form.ex      | 123 ++-------------------
 lib/polymorphic_embed/html/helpers.ex   | 107 ++++++++++++++++++
 test/polymorphic_embed_test.exs         | 120 ++++++++++++++++++++-
 4 files changed, 369 insertions(+), 119 deletions(-)
 create mode 100644 lib/polymorphic_embed/html/component.ex
 create mode 100644 lib/polymorphic_embed/html/helpers.ex

diff --git a/lib/polymorphic_embed/html/component.ex b/lib/polymorphic_embed/html/component.ex
new file mode 100644
index 0000000..454bcb3
--- /dev/null
+++ b/lib/polymorphic_embed/html/component.ex
@@ -0,0 +1,138 @@
+if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &&
+     Code.ensure_loaded?(Phoenix.Component) do
+  defmodule PolymorphicEmbed.HTML.Component do
+    use Phoenix.Component
+
+    import PolymorphicEmbed.HTML.Helpers
+
+    @doc """
+    Renders nested form inputs for polymorphic embeds.
+
+    See `Phoenix.Component.inputs_for/1`.
+    """
+    @doc type: :component
+    attr(:field, Phoenix.HTML.FormField,
+      required: true,
+      doc: "A %Phoenix.HTML.Form{}/field name tuple, for example: {@form[:email]}."
+    )
+
+    attr(:id, :string,
+      doc: """
+      The id to be used in the form, defaults to the concatenation of the given
+      field to the parent form id.
+      """
+    )
+
+    attr(:as, :atom,
+      doc: """
+      The name to be used in the form, defaults to the concatenation of the given
+      field to the parent form name.
+      """
+    )
+
+    attr(:default, :any, doc: "The value to use if none is available.")
+
+    attr(:prepend, :list,
+      doc: """
+      The values to prepend when rendering. This only applies if the field value
+      is a list and no parameters were sent through the form.
+      """
+    )
+
+    attr(:append, :list,
+      doc: """
+      The values to append when rendering. This only applies if the field value
+      is a list and no parameters were sent through the form.
+      """
+    )
+
+    attr(:skip_hidden, :boolean,
+      default: false,
+      doc: """
+      Skip the automatic rendering of hidden fields to allow for more tight control
+      over the generated markup.
+      """
+    )
+
+    slot(:inner_block, required: true, doc: "The content rendered for each nested form.")
+
+    @persistent_id "_persistent_id"
+    def polymorphic_embed_inputs_for(assigns) do
+      %Phoenix.HTML.FormField{field: field_name, form: parent_form} = assigns.field
+      options = assigns |> Map.take([:id, :as, :default, :append, :prepend]) |> Keyword.new()
+
+      options =
+        parent_form.options
+        |> Keyword.take([:multipart])
+        |> Keyword.merge(options)
+
+      type = get_polymorphic_type(parent_form, field_name)
+
+      forms =
+        to_form(
+          parent_form.source,
+          parent_form,
+          field_name,
+          [{:polymorphic_type, type} | options]
+        )
+
+      seen_ids = for f <- forms, vid = f.params[@persistent_id], into: %{}, do: {vid, true}
+
+      {forms, _} =
+        Enum.map_reduce(forms, seen_ids, fn %Phoenix.HTML.Form{params: params} = form, seen_ids ->
+          id =
+            case params do
+              %{@persistent_id => id} -> id
+              %{} -> next_id(map_size(seen_ids), seen_ids)
+            end
+
+          form_id = "#{parent_form.id}_#{field_name}_#{id}"
+          new_params = Map.put(params, @persistent_id, id)
+          new_hidden = [{@persistent_id, id} | form.hidden]
+
+          new_form = %Phoenix.HTML.Form{
+            form
+            | id: form_id,
+              params: new_params,
+              hidden: new_hidden
+          }
+
+          {new_form, Map.put(seen_ids, id, true)}
+        end)
+
+      assigns = assign(assigns, :forms, forms)
+
+      ~H"""
+      <%= for finner <- @forms do %>
+        <%= unless @skip_hidden do %>
+          <%= for {name, value_or_values} <- finner.hidden,
+                  id = Phoenix.HTML.Form.input_id(finner, name),
+                  name = name_for_value_or_values(finner, name, value_or_values),
+                  value <- List.wrap(value_or_values) do %>
+            <input type="hidden" id={id} name={name} value={value} />
+          <% end %>
+        <% end %>
+        <%= render_slot(@inner_block, finner) %>
+      <% end %>
+      """
+    end
+
+    defp next_id(idx, %{} = seen_ids) do
+      id_str = to_string(idx)
+
+      if Map.has_key?(seen_ids, id_str) do
+        next_id(idx + 1, seen_ids)
+      else
+        id_str
+      end
+    end
+
+    defp name_for_value_or_values(form, field, values) when is_list(values) do
+      Phoenix.HTML.Form.input_name(form, field) <> "[]"
+    end
+
+    defp name_for_value_or_values(form, field, _value) do
+      Phoenix.HTML.Form.input_name(form, field)
+    end
+  end
+end
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index ea1baef..0c6ef10 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -1,45 +1,13 @@
 if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &&
      Code.ensure_loaded?(PhoenixHTMLHelpers.Form) do
   defmodule PolymorphicEmbed.HTML.Form do
-    @moduledoc """
-    Defines functions for using PolymorphicEmbed with `Phoenix.HTML.Form`.
-    """
     import Phoenix.HTML, only: [html_escape: 1]
-    import Phoenix.HTML.Form, only: [input_value: 2]
     import PhoenixHTMLHelpers.Form, only: [hidden_inputs_for: 1]
 
-    @doc """
-    Returns the polymorphic type of the given field in the given form data.
-    """
-    def get_polymorphic_type(%Phoenix.HTML.Form{} = form, field) do
-      %schema{} = form.source.data
-      get_polymorphic_type(form, schema, field)
-    end
-
-    def get_polymorphic_type(%Phoenix.HTML.Form{} = form, schema, field) do
-      case input_value(form, field) do
-        %Ecto.Changeset{data: value} ->
-          PolymorphicEmbed.get_polymorphic_type(schema, field, value)
-
-        %_{} = value ->
-          PolymorphicEmbed.get_polymorphic_type(schema, field, value)
-
-        %{} = map ->
-          case PolymorphicEmbed.get_polymorphic_module(schema, field, map) do
-            nil ->
-              nil
-
-            module ->
-              PolymorphicEmbed.get_polymorphic_type(schema, field, module)
-          end
+    defdelegate get_polymorphic_type(form, field), to: PolymorphicEmbed.HTML.Helpers
 
-        list when is_list(list) ->
-          raise "Cannot infer the polymorphic type as the list of embeds may contain multiple types"
-
-        nil ->
-          nil
-      end
-    end
+    defdelegate to_form(source_changeset, form, field, options),
+      to: PolymorphicEmbed.HTML.Helpers
 
     @doc """
     Generates a new form builder without an anonymous function.
@@ -62,15 +30,14 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
           <%= for channel_form <- polymorphic_embed_inputs_for f, :channel do %>
             <%= hidden_inputs_for(channel_form) %>
 
-            <%= case get_polymorphic_type(f, Reminder, :channel) do %>
+            <%= case get_polymorphic_type(reminder_form, Reminder, :channel) do %>
               <% :sms -> %>
                 <%= label channel_form, :number %>
                 <%= text_input channel_form, :number %>
 
               <% :email -> %>
-                <%= label channel_form, :email_address %>
-                <%= text_input channel_form, :address %>
-            <% end %>
+                <%= label channel_form, :email %>
+                <%= text_input channel_form, :email %>
           <% end %>
         </.form>
     """
@@ -95,8 +62,8 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
                 <%= text_input poly_form, :number %>
 
               <% :email -> %>
-                <%= label poly_form, :email_address %>
-                <%= text_input poly_form, :address %>
+                <%= label poly_form, :email %>
+                <%= text_input poly_form, :email %>
             <% end %>
           <% end %>
         <% end %>
@@ -133,79 +100,5 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
         end)
       )
     end
-
-    def to_form(%{action: parent_action} = source_changeset, form, field, options) do
-      id = to_string(form.id <> "_#{field}")
-      name = to_string(form.name <> "[#{field}]")
-
-      params = Map.get(source_changeset.params || %{}, to_string(field), %{}) |> List.wrap()
-
-      struct = Ecto.Changeset.apply_changes(source_changeset)
-
-      list_data =
-        case Map.get(struct, field) do
-          nil ->
-            type = Keyword.get(options, :polymorphic_type, get_polymorphic_type(form, field))
-            module = PolymorphicEmbed.get_polymorphic_module(struct.__struct__, field, type)
-            if module, do: [struct(module)], else: []
-
-          data ->
-            List.wrap(data)
-        end
-
-      list_data
-      |> Enum.with_index()
-      |> Enum.map(fn {data, i} ->
-        params = Enum.at(params, i) || %{}
-
-        changeset =
-          data
-          |> Ecto.Changeset.change()
-          |> apply_action(parent_action)
-
-        errors = get_errors(changeset)
-
-        changeset = %Ecto.Changeset{
-          changeset
-          | action: parent_action,
-            params: params,
-            errors: errors,
-            valid?: errors == []
-        }
-
-        %schema{} = source_changeset.data
-
-        field_opts = PolymorphicEmbed.get_field_opts(schema, field)
-        type_field_atom = Map.get(field_opts, :type_field_atom, :__type__)
-        # correctly set id and name for embeds_many inputs
-        array? = Map.get(field_opts, :array?, false)
-
-        index_string = Integer.to_string(i)
-
-        type = PolymorphicEmbed.get_polymorphic_type(schema, field, changeset.data)
-
-        %Phoenix.HTML.Form{
-          source: changeset,
-          impl: Phoenix.HTML.FormData.Ecto.Changeset,
-          id: if(array?, do: id <> "_" <> index_string, else: id),
-          name: if(array?, do: name <> "[" <> index_string <> "]", else: name),
-          index: if(array?, do: i),
-          errors: errors,
-          data: data,
-          params: params,
-          hidden: [{type_field_atom, to_string(type)}],
-          options: options
-        }
-      end)
-    end
-
-    # If the parent changeset had no action, we need to remove the action
-    # from children changeset so we ignore all errors accordingly.
-    defp apply_action(changeset, nil), do: %{changeset | action: nil}
-    defp apply_action(changeset, _action), do: changeset
-
-    defp get_errors(%{action: nil}), do: []
-    defp get_errors(%{action: :ignore}), do: []
-    defp get_errors(%{errors: errors}), do: errors
   end
 end
diff --git a/lib/polymorphic_embed/html/helpers.ex b/lib/polymorphic_embed/html/helpers.ex
new file mode 100644
index 0000000..dd848ff
--- /dev/null
+++ b/lib/polymorphic_embed/html/helpers.ex
@@ -0,0 +1,107 @@
+if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) do
+  defmodule PolymorphicEmbed.HTML.Helpers do
+    @doc """
+    Returns the polymorphic type of the given field in the given form data.
+    """
+    def get_polymorphic_type(%Phoenix.HTML.Form{} = form, field) do
+      %schema{} = form.source.data
+
+      case form[field] && form[field].value do
+        %Ecto.Changeset{data: value} ->
+          PolymorphicEmbed.get_polymorphic_type(schema, field, value)
+
+        %_{} = value ->
+          PolymorphicEmbed.get_polymorphic_type(schema, field, value)
+
+        %{} = map ->
+          case PolymorphicEmbed.get_polymorphic_module(schema, field, map) do
+            nil ->
+              nil
+
+            module ->
+              PolymorphicEmbed.get_polymorphic_type(schema, field, module)
+          end
+
+        list when is_list(list) ->
+          raise "Cannot infer the polymorphic type as the list of embeds may contain multiple types"
+
+        nil ->
+          nil
+      end
+    end
+
+    def to_form(%{action: parent_action} = source_changeset, form, field, options) do
+      id = to_string(form.id <> "_#{field}")
+      name = to_string(form.name <> "[#{field}]")
+
+      params = Map.get(source_changeset.params || %{}, to_string(field), %{}) |> List.wrap()
+
+      struct = Ecto.Changeset.apply_changes(source_changeset)
+
+      list_data =
+        case Map.get(struct, field) do
+          nil ->
+            type = Keyword.get(options, :polymorphic_type, get_polymorphic_type(form, field))
+            module = PolymorphicEmbed.get_polymorphic_module(struct.__struct__, field, type)
+            if module, do: [struct(module)], else: []
+
+          data ->
+            List.wrap(data)
+        end
+
+      list_data
+      |> Enum.with_index()
+      |> Enum.map(fn {data, i} ->
+        params = Enum.at(params, i) || %{}
+
+        changeset =
+          data
+          |> Ecto.Changeset.change()
+          |> apply_action(parent_action)
+
+        errors = get_errors(changeset)
+
+        changeset = %Ecto.Changeset{
+          changeset
+          | action: parent_action,
+            params: params,
+            errors: errors,
+            valid?: errors == []
+        }
+
+        %schema{} = source_changeset.data
+
+        field_opts = PolymorphicEmbed.get_field_opts(schema, field)
+        type_field_atom = Map.get(field_opts, :type_field_atom, :__type__)
+        # correctly set id and name for embeds_many inputs
+        array? = Map.get(field_opts, :array?, false)
+
+        index_string = Integer.to_string(i)
+
+        type = PolymorphicEmbed.get_polymorphic_type(schema, field, changeset.data)
+
+        %Phoenix.HTML.Form{
+          source: changeset,
+          impl: Phoenix.HTML.FormData.Ecto.Changeset,
+          id: if(array?, do: id <> "_" <> index_string, else: id),
+          name: if(array?, do: name <> "[" <> index_string <> "]", else: name),
+          index: if(array?, do: i),
+          errors: errors,
+          data: data,
+          params: params,
+          hidden: [{type_field_atom, to_string(type)}],
+          options: options
+        }
+      end)
+    end
+
+    # If the parent changeset had no action, we need to remove the action
+    # from children changeset so we ignore all errors accordingly.
+    defp apply_action(changeset, nil), do: %{changeset | action: nil}
+    defp apply_action(changeset, _action), do: changeset
+
+    defp get_errors(%{action: nil}), do: []
+    defp get_errors(%{action: :ignore}), do: []
+    defp get_errors(%{errors: errors}), do: errors
+  end
+end
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 9c7cc68..c4f07b4 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -8,6 +8,7 @@ defmodule PolymorphicEmbedTest do
   import PhoenixHTMLHelpers.Form
   import Phoenix.LiveViewTest
   import PolymorphicEmbed.HTML.Form
+  import PolymorphicEmbed.HTML.Component
 
   alias PolymorphicEmbed.Repo
 
@@ -1899,6 +1900,104 @@ defmodule PolymorphicEmbedTest do
            ]
   end
 
+  describe "polymorphic_embed_inputs_for/1" do
+    test "generates forms that can be rendered (custom type field/identify_by_fields)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel: %{
+          address: "a",
+          valid: true,
+          confirmed: true
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form/1,
+          %{changeset: changeset, field: :channel}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, "#reminder_channel_my_type_field")
+      assert Floki.attribute(input, "name") == ["reminder[channel][my_type_field]"]
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+
+      assert [input] = Floki.find(html, "#reminder_channel_number")
+      assert Floki.attribute(input, "type") == ["text"]
+    end
+
+    test "generates forms that can be rendered (custom type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel3: %{
+          my_type_field: "email"
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form_component/1,
+          %{changeset: changeset, field: :channel3}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, ~s([name="reminder[channel3][my_type_field]"]))
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+    end
+
+    test "generates forms that can be rendered (default type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel2: %{
+          __type__: "email",
+          address: "a",
+          valid: true,
+          confirmed: true
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form_component/1,
+          %{changeset: changeset, field: :channel2}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, ~s([name="reminder[channel2][__type__]"]))
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+
+      assert [input] = Floki.find(html, "#reminder_channel2_0_number")
+      assert Floki.attribute(input, "type") == ["text"]
+    end
+  end
+
   describe "polymorphic_embed_inputs_for/2" do
     test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
@@ -1999,7 +2098,7 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
-  test "inputs_for/4" do
+  test "polymorphic_embed_inputs_for/4" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
 
@@ -2063,7 +2162,7 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
-  test "inputs_for/4 for list of embeds" do
+  test "polymorphic_embed_inputs_for/4 for list of embeds" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
 
@@ -2141,7 +2240,7 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
-  test "inputs_for/4 after invalid insert" do
+  test "polymorphic_embed_inputs_for/4 after invalid insert" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
 
@@ -2210,7 +2309,7 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
-  test "inputs_for/4 after invalid insert with valid nested struct" do
+  test "polymorphic_embed_inputs_for/4 after invalid insert with valid nested struct" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
 
@@ -2755,6 +2854,19 @@ defmodule PolymorphicEmbedTest do
     """
   end
 
+  defp liveview_form_component(assigns) do
+    ~H"""
+    <.form
+      :let={f}
+      for={@changeset}
+    >
+      <.polymorphic_embed_inputs_for field={f[@field]} :let={sms_form}>
+        <%= text_input sms_form, :number %>
+      </.polymorphic_embed_inputs_for>
+    </.form>
+    """
+  end
+
   defp polymorphic?(:polymorphic), do: true
   defp polymorphic?(:not_polymorphic), do: false
 end

From 41438422d1b732f45e45fcbdb2c616d45f9c3a5c Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 19:55:33 +0800
Subject: [PATCH 057/129] Fix traverse_errors

---
 lib/polymorphic_embed.ex | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 5d992a6..3f5c942 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -605,6 +605,23 @@ defmodule PolymorphicEmbed do
     Enum.reduce(types, map, &polymorphic_key_reducer(&1, &2, changes, msg_func))
   end
 
+  defp polymorphic_key_reducer(
+         {field, {rel, %{cardinality: :one}}},
+         acc,
+         changes,
+         msg_func
+       )
+       when rel in [:assoc, :embed] do
+    if changeset = Map.get(changes, field) do
+      case traverse_errors(changeset, msg_func) do
+        errors when errors == %{} -> acc
+        errors -> Map.put(acc, field, errors)
+      end
+    else
+      acc
+    end
+  end
+
   defp polymorphic_key_reducer(
          {field, {:parameterized, PolymorphicEmbed, _opts}},
          acc,
@@ -621,6 +638,29 @@ defmodule PolymorphicEmbed do
     end
   end
 
+  defp polymorphic_key_reducer(
+         {field, {rel, %{cardinality: :many}}},
+         acc,
+         changes,
+         msg_func
+       )
+       when rel in [:assoc, :embed] do
+    if changesets = Map.get(changes, field) do
+      {errors, all_empty?} =
+        Enum.map_reduce(changesets, true, fn changeset, all_empty? ->
+          errors = traverse_errors(changeset, msg_func)
+          {errors, all_empty? and errors == %{}}
+        end)
+
+      case all_empty? do
+        true -> acc
+        false -> Map.put(acc, field, errors)
+      end
+    else
+      acc
+    end
+  end
+
   defp polymorphic_key_reducer(
          {field, {:array, {:parameterized, PolymorphicEmbed, _opts}}},
          acc,

From 92cecb396e4fadf29ef01229644a8c4174f09913 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 20:12:10 +0800
Subject: [PATCH 058/129] Test travers_errors

---
 test/polymorphic_embed_test.exs              | 472 +++++++++++++++++++
 test/support/models/not_polymorphic/event.ex |  21 +
 test/support/models/not_polymorphic/todo.ex  |  21 +
 test/support/models/polymorphic/event.ex     |  21 +
 test/support/models/polymorphic/todo.ex      |  21 +
 5 files changed, 556 insertions(+)
 create mode 100644 test/support/models/not_polymorphic/event.ex
 create mode 100644 test/support/models/not_polymorphic/todo.ex
 create mode 100644 test/support/models/polymorphic/event.ex
 create mode 100644 test/support/models/polymorphic/todo.ex

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index c4f07b4..1da1bf0 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -294,6 +294,478 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "traverse_errors on nested *-to-many relations" do
+    for generator <- @generators do
+      event_module = get_module(Event, generator)
+
+      event_attrs = %{
+        reminders: [
+          %{
+            text: "This is an SMS reminder",
+            channel: %{
+              my_type_field: "sms"
+            },
+            contexts: [
+              %{
+                __type__: "location",
+                address: "hello",
+                country: %{
+                  name: ""
+                }
+              },
+              %{
+                __type__: "location",
+                address: ""
+              }
+            ]
+          }
+        ]
+      }
+
+      changeset =
+        struct(event_module)
+        |> event_module.changeset(event_attrs)
+
+      insert_result = Repo.insert(changeset)
+
+      assert {:error,
+              %Ecto.Changeset{
+                action: :insert,
+                valid?: false,
+                errors: errors,
+                changes: %{
+                  reminders: [
+                    %{
+                      action: :insert,
+                      valid?: false,
+                      errors: reminder_errors,
+                      changes: %{
+                        channel: %{
+                          action: :insert,
+                          valid?: false,
+                          errors: channel_errors
+                        },
+                        contexts: [
+                          %{
+                            action: :insert,
+                            valid?: false,
+                            errors: context1_errors,
+                            changes: %{
+                              country: %{
+                                action: :insert,
+                                valid?: false,
+                                errors: country_errors
+                              }
+                            }
+                          },
+                          %{
+                            action: :insert,
+                            valid?: false,
+                            errors: context2_errors
+                          }
+                        ]
+                      }
+                    }
+                  ]
+                }
+              }} = insert_result
+
+      assert [] = errors
+
+      assert [date: {"can't be blank", [validation: :required]}] = reminder_errors
+
+      assert %{
+               number: {"can't be blank", [validation: :required]},
+               country_code: {"can't be blank", [validation: :required]},
+               provider: {"can't be blank", [validation: :required]}
+             } = Map.new(channel_errors)
+
+      assert [] = context1_errors
+      assert %{address: {"can't be blank", [validation: :required]}} = Map.new(context2_errors)
+      assert %{name: {"can't be blank", [validation: :required]}} = Map.new(country_errors)
+
+      traverse_errors_fun =
+        if polymorphic?(generator) do
+          &PolymorphicEmbed.traverse_errors/2
+        else
+          &Ecto.Changeset.traverse_errors/2
+        end
+
+      %{
+        reminders: [
+          %{
+            channel: %{
+              country_code: ["can't be blank"],
+              number: ["can't be blank"],
+              provider: ["can't be blank"]
+            },
+            contexts: [%{country: %{name: ["can't be blank"]}}, %{address: ["can't be blank"]}],
+            date: ["can't be blank"]
+          }
+        ]
+      } =
+        traverse_errors_fun.(
+          changeset,
+          fn {msg, opts} ->
+            Enum.reduce(opts, msg, fn {key, value}, acc ->
+              String.replace(acc, "%{#{key}}", to_string(value))
+            end)
+          end
+        )
+    end
+  end
+
+  test "traverse_errors on nested embeds_many relations" do
+    for generator <- @generators do
+      event_module = get_module(Event, generator)
+
+      event_attrs = %{
+        embedded_reminders: [
+          %{
+            text: "This is an SMS reminder",
+            channel: %{
+              my_type_field: "sms"
+            },
+            contexts: [
+              %{
+                __type__: "location",
+                address: "hello",
+                country: %{
+                  name: ""
+                }
+              },
+              %{
+                __type__: "location",
+                address: ""
+              }
+            ]
+          }
+        ]
+      }
+
+      changeset =
+        struct(event_module)
+        |> event_module.changeset(event_attrs)
+
+      insert_result = Repo.insert(changeset)
+
+      assert {:error,
+              %Ecto.Changeset{
+                action: :insert,
+                valid?: false,
+                errors: errors,
+                changes: %{
+                  embedded_reminders: [
+                    %{
+                      action: :insert,
+                      valid?: false,
+                      errors: reminder_errors,
+                      changes: %{
+                        channel: %{
+                          action: :insert,
+                          valid?: false,
+                          errors: channel_errors
+                        },
+                        contexts: [
+                          %{
+                            action: :insert,
+                            valid?: false,
+                            errors: context1_errors,
+                            changes: %{
+                              country: %{
+                                action: :insert,
+                                valid?: false,
+                                errors: country_errors
+                              }
+                            }
+                          },
+                          %{
+                            action: :insert,
+                            valid?: false,
+                            errors: context2_errors
+                          }
+                        ]
+                      }
+                    }
+                  ]
+                }
+              }} = insert_result
+
+      assert [] = errors
+
+      assert [date: {"can't be blank", [validation: :required]}] = reminder_errors
+
+      assert %{
+               number: {"can't be blank", [validation: :required]},
+               country_code: {"can't be blank", [validation: :required]},
+               provider: {"can't be blank", [validation: :required]}
+             } = Map.new(channel_errors)
+
+      assert [] = context1_errors
+      assert %{address: {"can't be blank", [validation: :required]}} = Map.new(context2_errors)
+      assert %{name: {"can't be blank", [validation: :required]}} = Map.new(country_errors)
+
+      traverse_errors_fun =
+        if polymorphic?(generator) do
+          &PolymorphicEmbed.traverse_errors/2
+        else
+          &Ecto.Changeset.traverse_errors/2
+        end
+
+      %{
+        embedded_reminders: [
+          %{
+            channel: %{
+              country_code: ["can't be blank"],
+              number: ["can't be blank"],
+              provider: ["can't be blank"]
+            },
+            contexts: [%{country: %{name: ["can't be blank"]}}, %{address: ["can't be blank"]}],
+            date: ["can't be blank"]
+          }
+        ]
+      } =
+        traverse_errors_fun.(
+          changeset,
+          fn {msg, opts} ->
+            Enum.reduce(opts, msg, fn {key, value}, acc ->
+              String.replace(acc, "%{#{key}}", to_string(value))
+            end)
+          end
+        )
+    end
+  end
+
+  test "traverse_errors on nested *-to-one relations" do
+    for generator <- @generators do
+      todo_module = get_module(Todo, generator)
+
+      todo_attrs = %{
+        reminder: %{
+          text: "This is an SMS reminder",
+          channel: %{
+            my_type_field: "sms"
+          },
+          contexts: [
+            %{
+              __type__: "location",
+              address: "hello",
+              country: %{
+                name: ""
+              }
+            },
+            %{
+              __type__: "location",
+              address: ""
+            }
+          ]
+        }
+      }
+
+      changeset =
+        struct(todo_module)
+        |> todo_module.changeset(todo_attrs)
+
+      insert_result = Repo.insert(changeset)
+
+      assert {:error,
+              %Ecto.Changeset{
+                action: :insert,
+                valid?: false,
+                errors: errors,
+                changes: %{
+                  reminder: %{
+                    action: :insert,
+                    valid?: false,
+                    errors: reminder_errors,
+                    changes: %{
+                      channel: %{
+                        action: :insert,
+                        valid?: false,
+                        errors: channel_errors
+                      },
+                      contexts: [
+                        %{
+                          action: :insert,
+                          valid?: false,
+                          errors: context1_errors,
+                          changes: %{
+                            country: %{
+                              action: :insert,
+                              valid?: false,
+                              errors: country_errors
+                            }
+                          }
+                        },
+                        %{
+                          action: :insert,
+                          valid?: false,
+                          errors: context2_errors
+                        }
+                      ]
+                    }
+                  }
+                }
+              }} = insert_result
+
+      assert [] = errors
+
+      assert [date: {"can't be blank", [validation: :required]}] = reminder_errors
+
+      assert %{
+               number: {"can't be blank", [validation: :required]},
+               country_code: {"can't be blank", [validation: :required]},
+               provider: {"can't be blank", [validation: :required]}
+             } = Map.new(channel_errors)
+
+      assert [] = context1_errors
+      assert %{address: {"can't be blank", [validation: :required]}} = Map.new(context2_errors)
+      assert %{name: {"can't be blank", [validation: :required]}} = Map.new(country_errors)
+
+      traverse_errors_fun =
+        if polymorphic?(generator) do
+          &PolymorphicEmbed.traverse_errors/2
+        else
+          &Ecto.Changeset.traverse_errors/2
+        end
+
+      %{
+        reminder: %{
+          channel: %{
+            country_code: ["can't be blank"],
+            number: ["can't be blank"],
+            provider: ["can't be blank"]
+          },
+          contexts: [%{country: %{name: ["can't be blank"]}}, %{address: ["can't be blank"]}],
+          date: ["can't be blank"]
+        }
+      } =
+        traverse_errors_fun.(
+          changeset,
+          fn {msg, opts} ->
+            Enum.reduce(opts, msg, fn {key, value}, acc ->
+              String.replace(acc, "%{#{key}}", to_string(value))
+            end)
+          end
+        )
+    end
+  end
+
+  test "traverse_errors on nested embeds_one relations" do
+    for generator <- @generators do
+      todo_module = get_module(Todo, generator)
+
+      todo_attrs = %{
+        embedded_reminder: %{
+          text: "This is an SMS reminder",
+          channel: %{
+            my_type_field: "sms"
+          },
+          contexts: [
+            %{
+              __type__: "location",
+              address: "hello",
+              country: %{
+                name: ""
+              }
+            },
+            %{
+              __type__: "location",
+              address: ""
+            }
+          ]
+        }
+      }
+
+      changeset =
+        struct(todo_module)
+        |> todo_module.changeset(todo_attrs)
+
+      insert_result = Repo.insert(changeset)
+
+      assert {:error,
+              %Ecto.Changeset{
+                action: :insert,
+                valid?: false,
+                errors: errors,
+                changes: %{
+                  embedded_reminder: %{
+                    action: :insert,
+                    valid?: false,
+                    errors: reminder_errors,
+                    changes: %{
+                      channel: %{
+                        action: :insert,
+                        valid?: false,
+                        errors: channel_errors
+                      },
+                      contexts: [
+                        %{
+                          action: :insert,
+                          valid?: false,
+                          errors: context1_errors,
+                          changes: %{
+                            country: %{
+                              action: :insert,
+                              valid?: false,
+                              errors: country_errors
+                            }
+                          }
+                        },
+                        %{
+                          action: :insert,
+                          valid?: false,
+                          errors: context2_errors
+                        }
+                      ]
+                    }
+                  }
+                }
+              }} = insert_result
+
+      assert [] = errors
+
+      assert [date: {"can't be blank", [validation: :required]}] = reminder_errors
+
+      assert %{
+               number: {"can't be blank", [validation: :required]},
+               country_code: {"can't be blank", [validation: :required]},
+               provider: {"can't be blank", [validation: :required]}
+             } = Map.new(channel_errors)
+
+      assert [] = context1_errors
+      assert %{address: {"can't be blank", [validation: :required]}} = Map.new(context2_errors)
+      assert %{name: {"can't be blank", [validation: :required]}} = Map.new(country_errors)
+
+      traverse_errors_fun =
+        if polymorphic?(generator) do
+          &PolymorphicEmbed.traverse_errors/2
+        else
+          &Ecto.Changeset.traverse_errors/2
+        end
+
+      %{
+        embedded_reminder: %{
+          channel: %{
+            country_code: ["can't be blank"],
+            number: ["can't be blank"],
+            provider: ["can't be blank"]
+          },
+          contexts: [%{country: %{name: ["can't be blank"]}}, %{address: ["can't be blank"]}],
+          date: ["can't be blank"]
+        }
+      } =
+        traverse_errors_fun.(
+          changeset,
+          fn {msg, opts} ->
+            Enum.reduce(opts, msg, fn {key, value}, acc ->
+              String.replace(acc, "%{#{key}}", to_string(value))
+            end)
+          end
+        )
+    end
+  end
+
   test "traverse_errors on changesets with valid polymorphic structs" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
diff --git a/test/support/models/not_polymorphic/event.ex b/test/support/models/not_polymorphic/event.ex
new file mode 100644
index 0000000..b70fba8
--- /dev/null
+++ b/test/support/models/not_polymorphic/event.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Regular.Event do
+  @moduledoc """
+  An (calendar) event, which can optionally have multiple reminders.
+  """
+  use Ecto.Schema
+  import Ecto.Changeset
+  alias PolymorphicEmbed.Regular.Reminder
+
+  schema "events" do
+    has_many(:reminders, Reminder)
+    embeds_many(:embedded_reminders, Reminder)
+    timestamps()
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, [])
+    |> cast_assoc(:reminders)
+    |> cast_embed(:embedded_reminders)
+  end
+end
diff --git a/test/support/models/not_polymorphic/todo.ex b/test/support/models/not_polymorphic/todo.ex
new file mode 100644
index 0000000..ea0a103
--- /dev/null
+++ b/test/support/models/not_polymorphic/todo.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Regular.Todo do
+  @moduledoc """
+  A todo item, which can optionally have a single reminder.
+  """
+  use Ecto.Schema
+  import Ecto.Changeset
+  alias PolymorphicEmbed.Regular.Reminder
+
+  schema "todos" do
+    belongs_to(:reminder, Reminder)
+    embeds_one(:embedded_reminder, Reminder)
+    timestamps()
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, [])
+    |> cast_assoc(:reminder)
+    |> cast_embed(:embedded_reminder)
+  end
+end
diff --git a/test/support/models/polymorphic/event.ex b/test/support/models/polymorphic/event.ex
new file mode 100644
index 0000000..876036d
--- /dev/null
+++ b/test/support/models/polymorphic/event.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Event do
+  @moduledoc """
+  An (calendar) event, which can optionally have multiple reminders.
+  """
+  use Ecto.Schema
+  import Ecto.Changeset
+  alias PolymorphicEmbed.Reminder
+
+  schema "events" do
+    has_many(:reminders, Reminder)
+    embeds_many(:embedded_reminders, Reminder)
+    timestamps()
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, [])
+    |> cast_assoc(:reminders)
+    |> cast_embed(:embedded_reminders)
+  end
+end
diff --git a/test/support/models/polymorphic/todo.ex b/test/support/models/polymorphic/todo.ex
new file mode 100644
index 0000000..e7e074e
--- /dev/null
+++ b/test/support/models/polymorphic/todo.ex
@@ -0,0 +1,21 @@
+defmodule PolymorphicEmbed.Todo do
+  @moduledoc """
+  A todo item, which can optionally have a single reminder.
+  """
+  use Ecto.Schema
+  import Ecto.Changeset
+  alias PolymorphicEmbed.Reminder
+
+  schema "todos" do
+    belongs_to(:reminder, Reminder)
+    embeds_one(:embedded_reminder, Reminder)
+    timestamps()
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, [])
+    |> cast_assoc(:reminder)
+    |> cast_embed(:embedded_reminder)
+  end
+end

From 3487808f4a564e8b5d34e2d841953fba9bb35e66 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 20:59:55 +0800
Subject: [PATCH 059/129] Fix warnings

---
 .../migrations/20000101000000_create_tables.exs       | 11 +++++++++++
 test/support/models/not_polymorphic/reminder.ex       |  3 +++
 test/support/models/polymorphic/reminder.ex           |  3 +++
 3 files changed, 17 insertions(+)

diff --git a/test/support/migrations/20000101000000_create_tables.exs b/test/support/migrations/20000101000000_create_tables.exs
index c43cda7..d25232e 100644
--- a/test/support/migrations/20000101000000_create_tables.exs
+++ b/test/support/migrations/20000101000000_create_tables.exs
@@ -2,9 +2,15 @@ defmodule PolymorphicEmbed.CreateTables do
   use Ecto.Migration
 
   def change do
+    create table(:events) do
+      add(:embedded_reminders, :map)
+      timestamps()
+    end
+
     create table(:reminders) do
       add(:date, :utc_datetime, null: false)
       add(:text, :text, null: false)
+      add(:event_id, references(:events))
 
       add(:channel, :map)
       add(:channel2, :map)
@@ -15,5 +21,10 @@ defmodule PolymorphicEmbed.CreateTables do
 
       timestamps()
     end
+
+    create table(:todos) do
+      add(:reminder_id, references(:reminders), null: false)
+      add(:embedded_reminder, :map)
+    end
   end
 end
diff --git a/test/support/models/not_polymorphic/reminder.ex b/test/support/models/not_polymorphic/reminder.ex
index e7b4e69..7e94919 100644
--- a/test/support/models/not_polymorphic/reminder.ex
+++ b/test/support/models/not_polymorphic/reminder.ex
@@ -2,10 +2,13 @@ defmodule PolymorphicEmbed.Regular.Reminder do
   use Ecto.Schema
   use QueryBuilder
   import Ecto.Changeset
+  alias PolymorphicEmbed.Regular.{Todo, Event}
 
   schema "reminders" do
     field(:date, :utc_datetime)
     field(:text, :string)
+    has_one(:todo, Todo)
+    belongs_to(:event, Event)
 
     embeds_one(:channel, PolymorphicEmbed.Regular.Channel.SMS, on_replace: :update)
 
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index a7018bc..f79185d 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -3,10 +3,13 @@ defmodule PolymorphicEmbed.Reminder do
   use QueryBuilder
   import Ecto.Changeset
   import PolymorphicEmbed
+  alias PolymorphicEmbed.{Todo, Event}
 
   schema "reminders" do
     field(:date, :utc_datetime)
     field(:text, :string)
+    has_one(:todo, Todo)
+    belongs_to(:event, Event)
 
     polymorphic_embeds_one(:channel,
       types: [

From 51d88262fe0ccfe6ef358b7fd7f199a7a267b992 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 21:01:05 +0800
Subject: [PATCH 060/129] Update deps

---
 mix.exs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mix.exs b/mix.exs
index 9cdc05c..17c5e42 100644
--- a/mix.exs
+++ b/mix.exs
@@ -49,16 +49,16 @@ defmodule PolymorphicEmbed.MixProject do
     [
       {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
-      {:phoenix_html, "~> 4.0", optional: true},
+      {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:ex_doc, "~> 0.33", only: :dev},
       {:ecto_sql, "~> 3.11", only: :test},
-      {:postgrex, "~> 0.17", only: :test},
-      {:query_builder, "~> 1.0", only: :test},
+      {:postgrex, "~> 0.18", only: :test},
+      {:query_builder, "~> 1.4", only: :test},
       {:phoenix_ecto, "~> 4.6", only: :test},
       {:phoenix_live_view, "~> 0.20", only: :test},
       {:floki, "~> 0.36", only: :test},
-      {:dialyxir, "~> 1.0", only: [:dev, :test], runtime: false},
+      {:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
       {:excoveralls, "~> 0.18", only: :test},
       {:credo, "~> 1.7", only: [:dev, :test], runtime: false}
     ]

From c4295c62ac26a6586d2dc304e165fcb16f18156d Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 26 May 2024 21:24:17 +0800
Subject: [PATCH 061/129] Bump version to 4.0.0

---
 CHANGELOG.md | 13 ++++++++++++-
 README.md    |  6 +++---
 mix.exs      |  2 +-
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 35ed408..5baa016 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,11 +1,22 @@
 # Changelog
 
+## 4.0.x
+
+  * Support `sort_param` and `drop_param` for list of embeds
+  * Add `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`
+    (similar to `Phoenix.Component.inputs_for/1`)
+  * Support updating list of embeds while retaining ids
+  * Fix form input rendering for list of embeds
+  * Fix traverse_errors for nested embeds
+
+  **Breaking Change**: The form helper `get_polymorphic_type/3` has been updated to `get_polymorphic_type/2`.
+  The module name parameter (previously the second parameter) has been removed.
+
 ## 3.0.x
 
   * Default value for polymorphic list of embeds is `[]` instead of `nil` (following `embeds_many/3`)
   * Support Phoenix HTML 4.0
   * Avoid compile-time dependencies between parent and polymorphic embedded schemas
-  * Support updating list of embeds while retaining ids
 
 ### Migration from 2.x to 3.x
 
diff --git a/README.md b/README.md
index a1d064d..1d8b510 100644
--- a/README.md
+++ b/README.md
@@ -228,7 +228,7 @@ You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
   <%= for channel_form <- polymorphic_embed_inputs_for f, :channel do %>
     <%= hidden_inputs_for(channel_form) %>
 
-    <%= case get_polymorphic_type(f, Reminder, :channel) do %>
+    <%= case get_polymorphic_type(f, :channel) do %>
       <% :sms -> %>
         <%= label channel_form, :number %>
         <%= text_input channel_form, :number %>
@@ -246,7 +246,7 @@ Using this function, you have to render the necessary hidden inputs manually as
 ### Get the type of a polymorphic embed
 
 Sometimes you need to serialize the polymorphic embed and, once in the front-end, need to distinguish them.
-`get_polymorphic_type/3` returns the type of the polymorphic embed:
+`PolymorphicEmbed.get_polymorphic_type/3` returns the type of the polymorphic embed:
 
 ```elixir
 PolymorphicEmbed.get_polymorphic_type(Reminder, :channel, SMS) == :sms
@@ -272,7 +272,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 3.0.7"}
+    {:polymorphic_embed, "~> 4.0.0"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index 17c5e42..bccb50a 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "3.0.7"
+  @version "4.0.0"
 
   def project do
     [

From d7cc56c6599b7a4efdf0b7cd1f9f41774bee8905 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 12:24:15 +0800
Subject: [PATCH 062/129] Update gitignore

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 0993e91..63f4127 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,3 +30,4 @@ polymorphic_embed-*.tar
 .plts
 
 .elixir_ls
+.vscode

From 06a24253c51b8150493d9b56350d140546c18d4a Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 12:25:40 +0800
Subject: [PATCH 063/129] Add retain_unlisted_types_on_load and
 nilify_unlisted_types_on_load options

---
 lib/polymorphic_embed.ex                    | 33 +++++++++++++++++++--
 test/polymorphic_embed_test.exs             | 29 ++++++++++++++++++
 test/support/models/polymorphic/reminder.ex |  3 +-
 3 files changed, 61 insertions(+), 4 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 3f5c942..203eace 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -104,6 +104,8 @@ defmodule PolymorphicEmbed do
       default: Keyword.get(opts, :default, nil),
       on_replace: Keyword.fetch!(opts, :on_replace),
       on_type_not_found: Keyword.get(opts, :on_type_not_found, :changeset_error),
+      nilify_unlisted_types_on_load: Keyword.get(opts, :nilify_unlisted_types_on_load, []),
+      retain_unlisted_types_on_load: Keyword.get(opts, :retain_unlisted_types_on_load, []),
       type_field: type_field |> to_string(),
       type_field_atom: type_field,
       types_metadata: types_metadata
@@ -441,10 +443,35 @@ defmodule PolymorphicEmbed do
   def load(data, loader, params) when is_binary(data),
     do: do_load(Jason.decode!(data), loader, params)
 
-  def do_load(data, _loader, %{types_metadata: types_metadata, type_field: type_field}) do
+  def do_load(data, _loader, field_opts) do
+    %{
+      types_metadata: types_metadata,
+      type_field: type_field
+    } = field_opts
+
     case do_get_polymorphic_module_from_map(data, type_field, types_metadata) do
-      nil -> raise_cannot_infer_type_from_data(data)
-      module when is_atom(module) -> {:ok, Ecto.embedded_load(module, data, :json)}
+      nil ->
+        retain_type_list = Map.get(field_opts, :retain_unlisted_types_on_load, [])
+        nilify_type_list = Map.get(field_opts, :nilify_unlisted_types_on_load, [])
+
+        retain_type_list = Enum.map(retain_type_list, &to_string(&1))
+        nilify_type_list = Enum.map(nilify_type_list, &to_string(&1))
+
+        type = Map.get(data, type_field)
+
+        cond do
+          type in retain_type_list ->
+            {:ok, data}
+
+          type in nilify_type_list ->
+            {:ok, nil}
+
+          true ->
+            raise_cannot_infer_type_from_data(data)
+        end
+
+      module when is_atom(module) ->
+        {:ok, Ecto.embedded_load(module, data, :json)}
     end
   end
 
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 1da1bf0..1c7ed42 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1559,6 +1559,35 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "cannot load the right struct but don't raise exception" do
+    generator = :polymorphic
+    reminder_module = get_module(Reminder, generator)
+    sms_module = get_module(Channel.SMS, generator)
+
+    struct(reminder_module,
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an SMS reminder",
+      channel:
+        struct(sms_module,
+          country_code: 1,
+          number: "02/807.05.53"
+        )
+    )
+    |> reminder_module.changeset(%{})
+    |> Repo.insert()
+
+    Ecto.Adapters.SQL.query!(
+      Repo,
+      "UPDATE reminders SET channel = jsonb_set(channel, '{my_type_field}', '\"some_deprecated_type\"')",
+      []
+    )
+
+    assert %{channel: %{"my_type_field" => "some_deprecated_type"}} =
+             reminder_module
+             |> QueryBuilder.where(text: "This is an SMS reminder")
+             |> Repo.one()
+  end
+
   test "changing type" do
     generator = :polymorphic
     reminder_module = get_module(Reminder, generator)
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index f79185d..6c9d8a3 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -20,7 +20,8 @@ defmodule PolymorphicEmbed.Reminder do
         ]
       ],
       on_replace: :update,
-      type_field: :my_type_field
+      type_field: :my_type_field,
+      retain_unlisted_types_on_load: [:some_deprecated_type]
     )
 
     polymorphic_embeds_one(:channel2,

From cce0c496d83b238eab758144d6242e85adc17aea Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 12:26:17 +0800
Subject: [PATCH 064/129] Document options to prevent errors on loading unknown
 types

---
 README.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 1d8b510..c172aa0 100644
--- a/README.md
+++ b/README.md
@@ -173,12 +173,14 @@ polymorphic_embeds_many :contexts,
   By default, a changeset error "is invalid" is added.
 * `:on_replace` – mandatory option that can only be set to `:update` for a single embed and `:delete` for a list of
   embeds (we force a value as the default value of this option for `embeds_one` and `embeds_many` is `:raise`).
+* `:retain_unlisted_types_on_load`: allow the following unconfigured types to be loaded without raising an error. Useful for handling deprecated structs still present in the database.
+* `:nilify_unlisted_types_on_load`: same as `:retain_unlisted_types_on_load`, but nilify the struct on load.
 
 ### Displaying form inputs and errors in Phoenix templates
 
 The library comes with a form helper in order to build form inputs for polymorphic embeds and display changeset errors.
 
-In the entrypoint defining your web interface (`lib/your_app_web.ex` file), add the following import, change `view` to the one your component use, ex. `liew_view`:
+In the entrypoint defining your web interface (`lib/your_app_web.ex` file), add the following import, change `view` to the one your component use:
 
 ```elixir
 def view do

From c86b5b64bedd13b1b824d961944a686d4b7d824e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 12:28:23 +0800
Subject: [PATCH 065/129] Update Changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5baa016..8288af4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@
   * Add `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`
     (similar to `Phoenix.Component.inputs_for/1`)
   * Support updating list of embeds while retaining ids
+  * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
   * Fix form input rendering for list of embeds
   * Fix traverse_errors for nested embeds
 

From 2ec6292e56f9cae75f583c7d8f8c825db0f42c8e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 13:22:34 +0800
Subject: [PATCH 066/129] Fix for MongoDB

---
 lib/polymorphic_embed.ex | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 203eace..1355d9d 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -484,7 +484,10 @@ defmodule PolymorphicEmbed do
     dump(Ecto.Changeset.apply_changes(changeset), dumper, params)
   end
 
-  def dump(%module{} = struct, dumper, %{types_metadata: types_metadata, type_field: type_field}) do
+  def dump(%module{} = struct, dumper, %{
+        types_metadata: types_metadata,
+        type_field_atom: type_field_atom
+      }) do
     case module.__schema__(:autogenerate_id) do
       {key, _source, :binary_id} ->
         unless Map.get(struct, key) do
@@ -498,7 +501,8 @@ defmodule PolymorphicEmbed do
     map =
       struct
       |> map_from_struct()
-      |> Map.put(type_field, do_get_polymorphic_type(module, types_metadata))
+      # use the atom instead of string form for mongodb
+      |> Map.put(type_field_atom, do_get_polymorphic_type(module, types_metadata))
 
     dumper.(:map, map)
   end

From cc5ca33debe05905140cff998131f977dc54bf63 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 13:28:21 +0800
Subject: [PATCH 067/129] Update Changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8288af4..72c7b89 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@
   * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
   * Fix form input rendering for list of embeds
   * Fix traverse_errors for nested embeds
+  * MongoDB fix
 
   **Breaking Change**: The form helper `get_polymorphic_type/3` has been updated to `get_polymorphic_type/2`.
   The module name parameter (previously the second parameter) has been removed.

From 0cdcdd0d3211c289f03e76a9eb2cb77d880a4d81 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 13:52:37 +0800
Subject: [PATCH 068/129] Update license

---
 LICENSE | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/LICENSE b/LICENSE
index 246040d..d9a10c0 100644
--- a/LICENSE
+++ b/LICENSE
@@ -174,17 +174,3 @@
       of your accepting any such warranty or additional liability.
 
    END OF TERMS AND CONDITIONS
-
-   Copyright 2020 Mathieu Decaffmeyer
-
-   Licensed under the Apache License, Version 2.0 (the "License");
-   you may not use this file except in compliance with the License.
-   You may obtain a copy of the License at
-
-       http://www.apache.org/licenses/LICENSE-2.0
-
-   Unless required by applicable law or agreed to in writing, software
-   distributed under the License is distributed on an "AS IS" BASIS,
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-   See the License for the specific language governing permissions and
-   limitations under the License.

From 94a8ed2a981f98fb48e363d123c42cc6ae754704 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 13:55:08 +0800
Subject: [PATCH 069/129] Update readme

---
 README.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index c172aa0..36eed79 100644
--- a/README.md
+++ b/README.md
@@ -155,8 +155,9 @@ polymorphic_embeds_many :contexts,
     age: MyApp.Context.Age,
     device: MyApp.Context.Device
   ],
+  on_replace: :delete,
   on_type_not_found: :raise,
-  on_replace: :delete
+  nilify_unlisted_types_on_load: [:deprecated_type]
 ```
 
 #### Options
@@ -173,7 +174,7 @@ polymorphic_embeds_many :contexts,
   By default, a changeset error "is invalid" is added.
 * `:on_replace` – mandatory option that can only be set to `:update` for a single embed and `:delete` for a list of
   embeds (we force a value as the default value of this option for `embeds_one` and `embeds_many` is `:raise`).
-* `:retain_unlisted_types_on_load`: allow the following unconfigured types to be loaded without raising an error. Useful for handling deprecated structs still present in the database.
+* `:retain_unlisted_types_on_load`: allow unconfigured types to be loaded without raising an error. Useful for handling deprecated structs still present in the database.
 * `:nilify_unlisted_types_on_load`: same as `:retain_unlisted_types_on_load`, but nilify the struct on load.
 
 ### Displaying form inputs and errors in Phoenix templates

From 74d5cd9faa15bb35abf98eec60d958c377cf397f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 13:57:29 +0800
Subject: [PATCH 070/129] Update changelog

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 72c7b89..dd13773 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@
   * Support updating list of embeds while retaining ids
   * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
   * Fix form input rendering for list of embeds
-  * Fix traverse_errors for nested embeds
+  * Fix `traverse_errors` for nested embeds
   * MongoDB fix
 
   **Breaking Change**: The form helper `get_polymorphic_type/3` has been updated to `get_polymorphic_type/2`.

From 4bd7f1c9e1c139e94aaf407914b04b8ce59c788e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 14:40:12 +0800
Subject: [PATCH 071/129] Update readme

---
 README.md | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/README.md b/README.md
index 36eed79..86fb0d5 100644
--- a/README.md
+++ b/README.md
@@ -259,15 +259,6 @@ PolymorphicEmbed.get_polymorphic_type(Reminder, :channel, SMS) == :sms
 
 The function `Ecto.changeset.traverse_errors/2` won't include the errors of polymorphic embeds. You may instead use `PolymorphicEmbed.traverse_errors/2` when working with polymorphic embeds.
 
-## Features
-
-* Detect which types to use for the data being `cast`-ed, based on fields present in the data (no need for a *type* field in the data)
-* Run changeset validations when a `changeset/2` function is present (when absent, the library will introspect the fields to cast)
-* Support for nested polymorphic embeds
-* Support for nested `embeds_one`/`embeds_many` embeds
-* Display form inputs for polymorphic embeds in Phoenix templates
-* Tests to ensure code quality
-
 ## Installation
 
 Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:

From a7d84b93314810ddb22930c01385d0e401401d76 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 14:53:30 +0800
Subject: [PATCH 072/129] Document sort_param and drop_param

---
 README.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/README.md b/README.md
index 86fb0d5..247a2af 100644
--- a/README.md
+++ b/README.md
@@ -115,6 +115,12 @@ changeset
 )
 ```
 
+* `:drop_param` – see [sorting-and-deleting-from-many-collections](https://hexdocs.pm/ecto/3.11.2/Ecto.Changeset.html#cast_assoc/3-sorting-and-deleting-from-many-collections).
+
+* `:sort_param` – see [sorting-and-deleting-from-many-collections](https://hexdocs.pm/ecto/3.11.2/Ecto.Changeset.html#cast_assoc/3-sorting-and-deleting-from-many-collections).
+
+* `:default_type_on_sort_create` – in some cases, [`sort` creates a new entry](https://github.com/elixir-ecto/ecto/blob/v3.11/test/ecto/changeset/embedded_test.exs#L464); this option specifies which type to use by default for the entry.
+
 ### PolymorphicEmbed Ecto type
 
 The `:types` option for the `PolymorphicEmbed` custom type contains a keyword list mapping an atom representing the type

From 634c9cf0e6517d7b90e4f62d0f3bf4c227545231 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 27 May 2024 15:03:58 +0800
Subject: [PATCH 073/129] Document polymorphic_embed_inputs_for/1

---
 README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/README.md b/README.md
index 247a2af..1ae5dea 100644
--- a/README.md
+++ b/README.md
@@ -252,6 +252,8 @@ You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
 
 Using this function, you have to render the necessary hidden inputs manually as shown above.
 
+There is also `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`, which functions similarly to [`Phoenix.Component.inputs_for/1`](Phoenix.Component.inputs_for).
+
 ### Get the type of a polymorphic embed
 
 Sometimes you need to serialize the polymorphic embed and, once in the front-end, need to distinguish them.

From 39caf97a881368ae1d77ae9564f0298c79a5ffae Mon Sep 17 00:00:00 2001
From: Kirill Rogovoy <flash.kirill@gmail.com>
Date: Mon, 27 May 2024 10:52:30 +0300
Subject: [PATCH 074/129] Add @type t() :: any()

---
 lib/polymorphic_embed.ex | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 1355d9d..a7f855c 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -1,6 +1,8 @@
 defmodule PolymorphicEmbed do
   use Ecto.ParameterizedType
 
+  @type t() :: any()
+
   require Logger
 
   alias Ecto.Changeset

From 45b8236d62306b7f390cd043487f0af555b95b63 Mon Sep 17 00:00:00 2001
From: Steffen Deusch <steffen@deusch.me>
Date: Mon, 27 May 2024 13:58:38 +0200
Subject: [PATCH 075/129] add live_view as optional dependency

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index bccb50a..ba3a286 100644
--- a/mix.exs
+++ b/mix.exs
@@ -51,12 +51,12 @@ defmodule PolymorphicEmbed.MixProject do
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
+      {:phoenix_live_view, "~> 0.19", optional: true},
       {:ex_doc, "~> 0.33", only: :dev},
       {:ecto_sql, "~> 3.11", only: :test},
       {:postgrex, "~> 0.18", only: :test},
       {:query_builder, "~> 1.4", only: :test},
       {:phoenix_ecto, "~> 4.6", only: :test},
-      {:phoenix_live_view, "~> 0.20", only: :test},
       {:floki, "~> 0.36", only: :test},
       {:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
       {:excoveralls, "~> 0.18", only: :test},

From 1c2f3a58603fad30fc57fadf2592877be2ec40db Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Tue, 28 May 2024 11:59:37 +0800
Subject: [PATCH 076/129] Fix

---
 lib/polymorphic_embed/html/component.ex | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/polymorphic_embed/html/component.ex b/lib/polymorphic_embed/html/component.ex
index 454bcb3..1d3f708 100644
--- a/lib/polymorphic_embed/html/component.ex
+++ b/lib/polymorphic_embed/html/component.ex
@@ -66,14 +66,12 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
         |> Keyword.take([:multipart])
         |> Keyword.merge(options)
 
-      type = get_polymorphic_type(parent_form, field_name)
-
       forms =
         to_form(
           parent_form.source,
           parent_form,
           field_name,
-          [{:polymorphic_type, type} | options]
+          options
         )
 
       seen_ids = for f <- forms, vid = f.params[@persistent_id], into: %{}, do: {vid, true}

From 76aeaf2bfe6a7aebf327506add8cf11b74b6fc27 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Wed, 29 May 2024 00:20:22 +0800
Subject: [PATCH 077/129] Add missing casts in support schema

---
 test/support/models/polymorphic/reminder.ex | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 6c9d8a3..0797285 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -77,6 +77,8 @@ defmodule PolymorphicEmbed.Reminder do
     |> cast(values, [:date, :text])
     |> validate_required(:date)
     |> cast_polymorphic_embed(:channel)
+    |> cast_polymorphic_embed(:channel2)
+    |> cast_polymorphic_embed(:channel3)
     |> cast_polymorphic_embed(:contexts,
       sort_param: :contexts_sort,
       default_type_on_sort_create: :location,

From 605523b5f3dacc97dad5475a5dbf676ce02e8a22 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Fri, 31 May 2024 11:31:48 +0800
Subject: [PATCH 078/129] Update gitignore

---
 .gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitignore b/.gitignore
index 63f4127..66dbc82 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,3 +31,5 @@ polymorphic_embed-*.tar
 
 .elixir_ls
 .vscode
+
+tmp.*

From 41a23cc5b0b2433d244ca648298faf1d2019c5d3 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Fri, 31 May 2024 15:33:07 +0800
Subject: [PATCH 079/129] Add Form.source_data/1 and Form.source_module/1

---
 README.md                             | 24 +++++---------
 lib/polymorphic_embed/html/form.ex    |  6 ++++
 lib/polymorphic_embed/html/helpers.ex | 19 +++++++++++
 test/polymorphic_embed_test.exs       | 47 +++++++++++++++++++++++++++
 4 files changed, 80 insertions(+), 16 deletions(-)

diff --git a/README.md b/README.md
index 1ae5dea..db181fc 100644
--- a/README.md
+++ b/README.md
@@ -224,7 +224,7 @@ They both render a hidden input for the `"__type__"` field.
 
 ### Displaying form inputs and errors in LiveView
 
-You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
+You may use `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1` when working with LiveView, which functions similarly to [`Phoenix.Component.inputs_for/1`](Phoenix.Component.inputs_for).
 
 ```elixir
 <.form
@@ -234,26 +234,18 @@ You may use `polymorphic_embed_inputs_for/2` when working with LiveView.
   phx-change="validate"
   phx-submit="save"
 >
-  <%= for channel_form <- polymorphic_embed_inputs_for f, :channel do %>
-    <%= hidden_inputs_for(channel_form) %>
+  <.polymorphic_embed_inputs_for field={f[:channel]} :let={channel_form}>
+    <%= case source_module(channel_form) do %>
+      <% SMS -> %>
+        <.input field={channel_form[:number]} label="Number" />
 
-    <%= case get_polymorphic_type(f, :channel) do %>
-      <% :sms -> %>
-        <%= label channel_form, :number %>
-        <%= text_input channel_form, :number %>
-
-      <% :email -> %>
-        <%= label channel_form, :email_address %>
-        <%= text_input channel_form, :adress %>
+      <% Email -> %>
+        <.input field={channel_form[:address]} label="Email Address" />
     <% end %>
-  <% end %>
+  </.polymorphic_embed_inputs_for>
 </.form>
 ```
 
-Using this function, you have to render the necessary hidden inputs manually as shown above.
-
-There is also `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`, which functions similarly to [`Phoenix.Component.inputs_for/1`](Phoenix.Component.inputs_for).
-
 ### Get the type of a polymorphic embed
 
 Sometimes you need to serialize the polymorphic embed and, once in the front-end, need to distinguish them.
diff --git a/lib/polymorphic_embed/html/form.ex b/lib/polymorphic_embed/html/form.ex
index 0c6ef10..e2c1697 100644
--- a/lib/polymorphic_embed/html/form.ex
+++ b/lib/polymorphic_embed/html/form.ex
@@ -6,6 +6,12 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) &
 
     defdelegate get_polymorphic_type(form, field), to: PolymorphicEmbed.HTML.Helpers
 
+    defdelegate get_polymorphic_type(form_field), to: PolymorphicEmbed.HTML.Helpers
+
+    defdelegate source_data(form), to: PolymorphicEmbed.HTML.Helpers
+
+    defdelegate source_module(form), to: PolymorphicEmbed.HTML.Helpers
+
     defdelegate to_form(source_changeset, form, field, options),
       to: PolymorphicEmbed.HTML.Helpers
 
diff --git a/lib/polymorphic_embed/html/helpers.ex b/lib/polymorphic_embed/html/helpers.ex
index dd848ff..cd8b60e 100644
--- a/lib/polymorphic_embed/html/helpers.ex
+++ b/lib/polymorphic_embed/html/helpers.ex
@@ -30,6 +30,25 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
       end
     end
 
+    def get_polymorphic_type(%Phoenix.HTML.FormField{} = form_field) do
+      %{field: field_name, form: parent_form} = form_field
+      get_polymorphic_type(parent_form, field_name)
+    end
+
+    @doc """
+    Returns the source data structure
+    """
+    def source_data(%Phoenix.HTML.Form{} = form) do
+      form.source.data
+    end
+
+    @doc """
+    Returns the source data structure
+    """
+    def source_module(%Phoenix.HTML.Form{} = form) do
+      form.source.data.__struct__
+    end
+
     def to_form(%{action: parent_action} = source_changeset, form, field, options) do
       id = to_string(form.id <> "_#{field}")
       name = to_string(form.name <> "[#{field}]")
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 1c7ed42..3352644 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -3124,6 +3124,53 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "Form.source_data/1 and Form.source_module/1" do
+    reminder_module = get_module(Reminder, :polymorphic)
+
+    attrs = %{
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an Email reminder",
+      contexts: [
+        %{
+          __type__: "device",
+          ref: "12345",
+          type: "cellphone"
+        },
+        %{
+          __type__: "location",
+          age: "aquarius",
+          address: "some address"
+        }
+      ]
+    }
+
+    changeset =
+      reminder_module
+      |> struct()
+      |> reminder_module.changeset(attrs)
+
+    safe_form_for(changeset, fn _f ->
+      safe_inputs_for(changeset, :contexts, :email, :polymorphic_with_type, fn f ->
+        PolymorphicEmbed.HTML.Form.get_polymorphic_type(f[:contexts])
+
+        case PolymorphicEmbed.HTML.Form.source_data(f) do
+          %PolymorphicEmbed.Reminder.Context.Device{} ->
+            assert PolymorphicEmbed.Reminder.Context.Device == PolymorphicEmbed.HTML.Form.source_module(f)
+
+          %PolymorphicEmbed.Reminder.Context.Location{} ->
+            assert PolymorphicEmbed.Reminder.Context.Location == PolymorphicEmbed.HTML.Form.source_module(f)
+
+          _ ->
+            assert false
+        end
+
+        1
+      end)
+
+      1
+    end)
+  end
+
   describe "Form.get_polymorphic_type/3" do
     test "returns type from changeset via identify_by_fields" do
       reminder_module = get_module(Reminder, :polymorphic)

From a91ca555c9ba951c75508195415ed62af06e0817 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Fri, 31 May 2024 15:35:43 +0800
Subject: [PATCH 080/129] Run mix format

---
 test/polymorphic_embed_test.exs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 3352644..601143b 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -3155,10 +3155,12 @@ defmodule PolymorphicEmbedTest do
 
         case PolymorphicEmbed.HTML.Form.source_data(f) do
           %PolymorphicEmbed.Reminder.Context.Device{} ->
-            assert PolymorphicEmbed.Reminder.Context.Device == PolymorphicEmbed.HTML.Form.source_module(f)
+            assert PolymorphicEmbed.Reminder.Context.Device ==
+                     PolymorphicEmbed.HTML.Form.source_module(f)
 
           %PolymorphicEmbed.Reminder.Context.Location{} ->
-            assert PolymorphicEmbed.Reminder.Context.Location == PolymorphicEmbed.HTML.Form.source_module(f)
+            assert PolymorphicEmbed.Reminder.Context.Location ==
+                     PolymorphicEmbed.HTML.Form.source_module(f)
 
           _ ->
             assert false

From 619cf85d278df40d8c24922b29999ab7e7dc7f75 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Fri, 31 May 2024 15:42:31 +0800
Subject: [PATCH 081/129] Update deps

---
 mix.exs  | 2 +-
 mix.lock | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mix.exs b/mix.exs
index ba3a286..c884cd4 100644
--- a/mix.exs
+++ b/mix.exs
@@ -52,7 +52,7 @@ defmodule PolymorphicEmbed.MixProject do
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:phoenix_live_view, "~> 0.19", optional: true},
-      {:ex_doc, "~> 0.33", only: :dev},
+      {:ex_doc, "~> 0.34", only: :dev},
       {:ecto_sql, "~> 3.11", only: :test},
       {:postgrex, "~> 0.18", only: :test},
       {:query_builder, "~> 1.4", only: :test},
diff --git a/mix.lock b/mix.lock
index a833664..8cb2b5d 100644
--- a/mix.lock
+++ b/mix.lock
@@ -9,7 +9,7 @@
   "ecto": {:hex, :ecto, "3.11.2", "e1d26be989db350a633667c5cda9c3d115ae779b66da567c68c80cfb26a8c9ee", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "3c38bca2c6f8d8023f2145326cc8a80100c3ffe4dcbd9842ff867f7fc6156c65"},
   "ecto_sql": {:hex, :ecto_sql, "3.11.2", "c7cc7f812af571e50b80294dc2e535821b3b795ce8008d07aa5f336591a185a8", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "73c07f995ac17dbf89d3cfaaf688fcefabcd18b7b004ac63b0dc4ef39499ed6b"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
-  "ex_doc": {:hex, :ex_doc, "0.33.0", "690562b153153c7e4d455dc21dab86e445f66ceba718defe64b0ef6f0bd83ba0", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "3f69adc28274cb51be37d09b03e4565232862a4b10288a3894587b0131412124"},
+  "ex_doc": {:hex, :ex_doc, "0.34.0", "ab95e0775db3df71d30cf8d78728dd9261c355c81382bcd4cefdc74610bef13e", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "60734fb4c1353f270c3286df4a0d51e65a2c1d9fba66af3940847cc65a8066d7"},
   "excoveralls": {:hex, :excoveralls, "0.18.1", "a6f547570c6b24ec13f122a5634833a063aec49218f6fff27de9df693a15588c", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "d65f79db146bb20399f23046015974de0079668b9abb2f5aac074d078da60b8d"},
   "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
   "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},

From 76d22cf51ba7cc5e60ee36a26c1b4fae7865e5e0 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Fri, 31 May 2024 15:43:08 +0800
Subject: [PATCH 082/129] Bump version to 4.1.0

---
 CHANGELOG.md | 8 ++++++--
 README.md    | 2 +-
 mix.exs      | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index dd13773..543d26b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,15 +1,19 @@
 # Changelog
 
+## 4.1.x
+
+  * Add `Form.source_data/1` and `Form.source_module/1` (`get_polymorphic_type/2` doesn't work for list of embeds)
+  * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
+  * MongoDB fix
+
 ## 4.0.x
 
   * Support `sort_param` and `drop_param` for list of embeds
   * Add `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`
     (similar to `Phoenix.Component.inputs_for/1`)
   * Support updating list of embeds while retaining ids
-  * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
   * Fix form input rendering for list of embeds
   * Fix `traverse_errors` for nested embeds
-  * MongoDB fix
 
   **Breaking Change**: The form helper `get_polymorphic_type/3` has been updated to `get_polymorphic_type/2`.
   The module name parameter (previously the second parameter) has been removed.
diff --git a/README.md b/README.md
index db181fc..79e645e 100644
--- a/README.md
+++ b/README.md
@@ -266,7 +266,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 4.0.0"}
+    {:polymorphic_embed, "~> 4.1.0"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index c884cd4..3150a44 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "4.0.0"
+  @version "4.1.0"
 
   def project do
     [

From 58eedd4b44d815aa7ffcc6596b22475cf6f85d8a Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 2 Jun 2024 09:50:34 +0800
Subject: [PATCH 083/129] Renaming

---
 lib/polymorphic_embed.ex | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index a7f855c..b5cec65 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -336,7 +336,7 @@ defmodule PolymorphicEmbed do
   end
 
   defp action_and_struct(params, type_field, types_metadata, data_for_field) do
-    case do_get_polymorphic_module_from_map(params, type_field, types_metadata) do
+    case get_polymorphic_module_from_map(params, type_field, types_metadata) do
       nil ->
         if data_for_field do
           {:update, data_for_field}
@@ -367,7 +367,7 @@ defmodule PolymorphicEmbed do
 
     embeds =
       Enum.map(list_params, fn params ->
-        case do_get_polymorphic_module_from_map(params, type_field, types_metadata) do
+        case get_polymorphic_module_from_map(params, type_field, types_metadata) do
           nil when on_type_not_found == :raise ->
             raise_cannot_infer_type_from_data(params)
 
@@ -451,7 +451,7 @@ defmodule PolymorphicEmbed do
       type_field: type_field
     } = field_opts
 
-    case do_get_polymorphic_module_from_map(data, type_field, types_metadata) do
+    case get_polymorphic_module_from_map(data, type_field, types_metadata) do
       nil ->
         retain_type_list = Map.get(field_opts, :retain_unlisted_types_on_load, [])
         nilify_type_list = Map.get(field_opts, :nilify_unlisted_types_on_load, [])
@@ -520,20 +520,20 @@ defmodule PolymorphicEmbed do
 
     case type_or_data do
       map when is_map(map) ->
-        do_get_polymorphic_module_from_map(map, type_field, types_metadata)
+        get_polymorphic_module_from_map(map, type_field, types_metadata)
 
       type when is_atom(type) or is_binary(type) ->
-        do_get_polymorphic_module_for_type(type, types_metadata)
+        get_polymorphic_module_for_type(type, types_metadata)
     end
   end
 
-  defp do_get_polymorphic_module_from_map(%{} = attrs, type_field, types_metadata) do
+  defp get_polymorphic_module_from_map(%{} = attrs, type_field, types_metadata) do
     attrs = attrs |> convert_map_keys_to_string()
 
     type = Enum.find_value(attrs, fn {key, value} -> key == type_field && value end)
 
     if type do
-      do_get_polymorphic_module_for_type(type, types_metadata)
+      get_polymorphic_module_for_type(type, types_metadata)
     else
       # check if one list is contained in another
       # Enum.count(contained -- container) == 0
@@ -545,7 +545,7 @@ defmodule PolymorphicEmbed do
     end
   end
 
-  defp do_get_polymorphic_module_for_type(type, types_metadata) do
+  defp get_polymorphic_module_for_type(type, types_metadata) do
     get_metadata_for_type(type, types_metadata)
     |> (&(&1 && Map.fetch!(&1, :module))).()
   end

From 8b9ff8a509b2ecbb1b3af16111dff8162f0617db Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 2 Jun 2024 09:51:02 +0800
Subject: [PATCH 084/129] Document PolymorphicEmbed.get_polymorphic_module/3

---
 README.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 79e645e..61cc33e 100644
--- a/README.md
+++ b/README.md
@@ -246,7 +246,7 @@ You may use `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1` whe
 </.form>
 ```
 
-### Get the type of a polymorphic embed
+### Get the type and module of a polymorphic embed
 
 Sometimes you need to serialize the polymorphic embed and, once in the front-end, need to distinguish them.
 `PolymorphicEmbed.get_polymorphic_type/3` returns the type of the polymorphic embed:
@@ -255,6 +255,12 @@ Sometimes you need to serialize the polymorphic embed and, once in the front-end
 PolymorphicEmbed.get_polymorphic_type(Reminder, :channel, SMS) == :sms
 ```
 
+To get the module for a specific type, use:
+
+```elixir
+PolymorphicEmbed.get_polymorphic_module(Reminder, :channel, :sms) == SMS
+```
+
 ### `traverse_errors/2`
 
 The function `Ecto.changeset.traverse_errors/2` won't include the errors of polymorphic embeds. You may instead use `PolymorphicEmbed.traverse_errors/2` when working with polymorphic embeds.

From 945861d22b25f4d1c73b9b3c7aa0689b67612fb9 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 13:36:45 +0800
Subject: [PATCH 085/129] Rename :type_field to :type_field_name

---
 lib/polymorphic_embed.ex                    | 70 ++++++++++++---------
 lib/polymorphic_embed/html/helpers.ex       |  4 +-
 lib/polymorphic_embed/options_validator.ex  | 69 ++++++++++++++++++++
 test/support/models/polymorphic/reminder.ex |  2 +-
 4 files changed, 113 insertions(+), 32 deletions(-)
 create mode 100644 lib/polymorphic_embed/options_validator.ex

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index b5cec65..f1744d1 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -4,8 +4,10 @@ defmodule PolymorphicEmbed do
   @type t() :: any()
 
   require Logger
+  require PolymorphicEmbed.OptionsValidator
 
   alias Ecto.Changeset
+  alias PolymorphicEmbed.OptionsValidator
 
   defmacro polymorphic_embeds_one(field_name, opts) do
     opts = Keyword.update!(opts, :types, &expand_alias(&1, __CALLER__))
@@ -74,6 +76,16 @@ defmodule PolymorphicEmbed do
 
   @impl true
   def init(opts) do
+    opts = Keyword.put_new(opts, :on_replace, nil)
+    # opts = Keyword.put_new(opts, :type_field_name, :__type__)
+    # TODO remove in v5
+    opts = Keyword.put_new(opts, :type_field_name, Keyword.get(opts, :type_field, :__type__))
+    opts = Keyword.put_new(opts, :on_type_not_found, :changeset_error)
+    opts = Keyword.put_new(opts, :nilify_unlisted_types_on_load, [])
+    opts = Keyword.put_new(opts, :retain_unlisted_types_on_load, [])
+
+    OptionsValidator.validate!(opts)
+
     if Keyword.get(opts, :on_replace) not in [:update, :delete] do
       raise(
         "`:on_replace` option for polymorphic embed must be set to `:update` (single embed) or `:delete` (list of embeds)"
@@ -100,16 +112,13 @@ defmodule PolymorphicEmbed do
           }
       end)
 
-    type_field = Keyword.get(opts, :type_field, :__type__)
-
     %{
       default: Keyword.get(opts, :default, nil),
       on_replace: Keyword.fetch!(opts, :on_replace),
-      on_type_not_found: Keyword.get(opts, :on_type_not_found, :changeset_error),
-      nilify_unlisted_types_on_load: Keyword.get(opts, :nilify_unlisted_types_on_load, []),
-      retain_unlisted_types_on_load: Keyword.get(opts, :retain_unlisted_types_on_load, []),
-      type_field: type_field |> to_string(),
-      type_field_atom: type_field,
+      on_type_not_found: Keyword.fetch!(opts, :on_type_not_found),
+      nilify_unlisted_types_on_load: Keyword.fetch!(opts, :nilify_unlisted_types_on_load),
+      retain_unlisted_types_on_load: Keyword.fetch!(opts, :retain_unlisted_types_on_load),
+      type_field_name: Keyword.fetch!(opts, :type_field_name),
       types_metadata: types_metadata
     }
   end
@@ -201,7 +210,7 @@ defmodule PolymorphicEmbed do
 
   defp sort_create(%{sort_param: _} = cast_opts, field_opts) do
     default_type = Map.get(cast_opts, :default_type_on_sort_create)
-    type_field_atom = Map.fetch!(field_opts, :type_field_atom)
+    type_field_name = Map.fetch!(field_opts, :type_field_name)
     types_metadata = Map.fetch!(field_opts, :types_metadata)
 
     case default_type do
@@ -209,7 +218,7 @@ defmodule PolymorphicEmbed do
         # If type is not provided, use the first type from types_metadata
         [first_type_metadata | _] = types_metadata
         first_type = first_type_metadata.type
-        %{type_field_atom => first_type}
+        %{type_field_name => first_type}
 
       _ ->
         default_type =
@@ -223,7 +232,7 @@ defmodule PolymorphicEmbed do
           raise "Incorrect type atom #{inspect(default_type)}"
         end
 
-        %{type_field_atom => default_type}
+        %{type_field_name => default_type}
     end
   end
 
@@ -299,7 +308,7 @@ defmodule PolymorphicEmbed do
     %{
       types_metadata: types_metadata,
       on_type_not_found: on_type_not_found,
-      type_field: type_field
+      type_field_name: type_field_name
     } = field_opts
 
     data_for_field = Map.fetch!(changeset.data, field)
@@ -307,7 +316,7 @@ defmodule PolymorphicEmbed do
     # We support partial update of the embed. If the type cannot be inferred from the parameters, or if the found type
     # hasn't changed, pass the data to the changeset.
 
-    case action_and_struct(params, type_field, types_metadata, data_for_field) do
+    case action_and_struct(params, type_field_name, types_metadata, data_for_field) do
       :type_not_found when on_type_not_found == :raise ->
         raise_cannot_infer_type_from_data(params)
 
@@ -335,8 +344,8 @@ defmodule PolymorphicEmbed do
     end
   end
 
-  defp action_and_struct(params, type_field, types_metadata, data_for_field) do
-    case get_polymorphic_module_from_map(params, type_field, types_metadata) do
+  defp action_and_struct(params, type_field_name, types_metadata, data_for_field) do
+    case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
       nil ->
         if data_for_field do
           {:update, data_for_field}
@@ -360,14 +369,14 @@ defmodule PolymorphicEmbed do
     %{
       types_metadata: types_metadata,
       on_type_not_found: on_type_not_found,
-      type_field: type_field
+      type_field_name: type_field_name
     } = field_opts
 
     list_data_for_field = Map.fetch!(changeset.data, field)
 
     embeds =
       Enum.map(list_params, fn params ->
-        case get_polymorphic_module_from_map(params, type_field, types_metadata) do
+        case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
           nil when on_type_not_found == :raise ->
             raise_cannot_infer_type_from_data(params)
 
@@ -448,18 +457,18 @@ defmodule PolymorphicEmbed do
   def do_load(data, _loader, field_opts) do
     %{
       types_metadata: types_metadata,
-      type_field: type_field
+      type_field_name: type_field_name
     } = field_opts
 
-    case get_polymorphic_module_from_map(data, type_field, types_metadata) do
+    case get_polymorphic_module_from_map(data, type_field_name, types_metadata) do
       nil ->
-        retain_type_list = Map.get(field_opts, :retain_unlisted_types_on_load, [])
-        nilify_type_list = Map.get(field_opts, :nilify_unlisted_types_on_load, [])
+        retain_type_list =
+          Map.fetch!(field_opts, :retain_unlisted_types_on_load) |> Enum.map(&to_string(&1))
 
-        retain_type_list = Enum.map(retain_type_list, &to_string(&1))
-        nilify_type_list = Enum.map(nilify_type_list, &to_string(&1))
+        nilify_type_list =
+          Map.fetch!(field_opts, :nilify_unlisted_types_on_load) |> Enum.map(&to_string(&1))
 
-        type = Map.get(data, type_field)
+        type = Map.get(data, type_field_name |> to_string)
 
         cond do
           type in retain_type_list ->
@@ -488,7 +497,7 @@ defmodule PolymorphicEmbed do
 
   def dump(%module{} = struct, dumper, %{
         types_metadata: types_metadata,
-        type_field_atom: type_field_atom
+        type_field_name: type_field_name
       }) do
     case module.__schema__(:autogenerate_id) do
       {key, _source, :binary_id} ->
@@ -504,7 +513,7 @@ defmodule PolymorphicEmbed do
       struct
       |> map_from_struct()
       # use the atom instead of string form for mongodb
-      |> Map.put(type_field_atom, do_get_polymorphic_type(module, types_metadata))
+      |> Map.put(type_field_name, do_get_polymorphic_type(module, types_metadata))
 
     dumper.(:map, map)
   end
@@ -516,21 +525,24 @@ defmodule PolymorphicEmbed do
   end
 
   def get_polymorphic_module(schema, field, type_or_data) do
-    %{types_metadata: types_metadata, type_field: type_field} = get_field_opts(schema, field)
+    %{types_metadata: types_metadata, type_field_name: type_field_name} =
+      get_field_opts(schema, field)
 
     case type_or_data do
       map when is_map(map) ->
-        get_polymorphic_module_from_map(map, type_field, types_metadata)
+        get_polymorphic_module_from_map(map, type_field_name, types_metadata)
 
       type when is_atom(type) or is_binary(type) ->
         get_polymorphic_module_for_type(type, types_metadata)
     end
   end
 
-  defp get_polymorphic_module_from_map(%{} = attrs, type_field, types_metadata) do
+  defp get_polymorphic_module_from_map(%{} = attrs, type_field_name, types_metadata) do
     attrs = attrs |> convert_map_keys_to_string()
+    type_field_name_as_string = to_string(type_field_name)
 
-    type = Enum.find_value(attrs, fn {key, value} -> key == type_field && value end)
+    type =
+      Enum.find_value(attrs, fn {key, value} -> key == type_field_name_as_string && value end)
 
     if type do
       get_polymorphic_module_for_type(type, types_metadata)
diff --git a/lib/polymorphic_embed/html/helpers.ex b/lib/polymorphic_embed/html/helpers.ex
index cd8b60e..7822d46 100644
--- a/lib/polymorphic_embed/html/helpers.ex
+++ b/lib/polymorphic_embed/html/helpers.ex
@@ -91,7 +91,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
         %schema{} = source_changeset.data
 
         field_opts = PolymorphicEmbed.get_field_opts(schema, field)
-        type_field_atom = Map.get(field_opts, :type_field_atom, :__type__)
+        type_field_name = Map.fetch!(field_opts, :type_field_name)
         # correctly set id and name for embeds_many inputs
         array? = Map.get(field_opts, :array?, false)
 
@@ -108,7 +108,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
           errors: errors,
           data: data,
           params: params,
-          hidden: [{type_field_atom, to_string(type)}],
+          hidden: [{type_field_name, to_string(type)}],
           options: options
         }
       end)
diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
new file mode 100644
index 0000000..806433e
--- /dev/null
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -0,0 +1,69 @@
+defmodule PolymorphicEmbed.OptionsValidator do
+  require Logger
+
+  @known_options_names [
+    :types,
+    :on_replace,
+    :type_field,
+    :type_field_name,
+    :on_type_not_found,
+    :retain_unlisted_types_on_load,
+    :nilify_unlisted_types_on_load,
+    # Ecto
+    :field,
+    :schema,
+    :default
+  ]
+  @valid_on_replace_options [:update, :delete]
+  @valid_on_type_not_found_options [:raise, :changeset_error, :nilify, :ignore]
+
+  def validate!(options) do
+    keys = Keyword.keys(options)
+    key_count = keys |> Enum.count()
+    unique_key_count = Enum.uniq(keys) |> Enum.count()
+
+    if key_count != unique_key_count do
+      raise "Duplicate keys found in options for polymorphic embed."
+    end
+
+    unless Keyword.fetch!(options, :on_replace) in @valid_on_replace_options do
+      raise(
+        "`:on_replace` must be set to `:update` for a single polymorphic embed or `:delete` for a list of polymorphic embeds."
+      )
+    end
+
+    unless Keyword.fetch!(options, :on_type_not_found) in @valid_on_type_not_found_options do
+      raise(
+        "Invalid `:on_type_not_found` option. Valid options: #{@valid_on_type_not_found_options |> Enum.join(", ")}."
+      )
+    end
+
+    # TODO remove in v5
+    if Keyword.has_key?(options, :type_field) do
+      Logger.warning(
+        "`:type_field` option is deprecated and must be replaced with `:type_field_name`."
+      )
+    end
+
+    unless is_atom(Keyword.fetch!(options, :type_field_name)) do
+      raise "`:type_field_name` must be an atom."
+    end
+
+    retain_unlisted_types = Keyword.fetch!(options, :retain_unlisted_types_on_load)
+    nilify_unlisted_types = Keyword.fetch!(options, :nilify_unlisted_types_on_load)
+
+    unless is_list(retain_unlisted_types) and Enum.all?(retain_unlisted_types, &is_atom/1) do
+      raise "`:retain_unlisted_types_on_load` must be a list of types as atoms."
+    end
+
+    unless is_list(nilify_unlisted_types) and Enum.all?(nilify_unlisted_types, &is_atom/1) do
+      raise "`:retain_unlisted_types_on_load` must be a list of types as atoms."
+    end
+
+    unknown_options = Keyword.drop(options, @known_options_names)
+
+    if length(unknown_options) > 0 do
+      raise "Unknown options: #{unknown_options |> Keyword.keys() |> Enum.join(", ")}"
+    end
+  end
+end
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 0797285..384a65a 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -20,7 +20,7 @@ defmodule PolymorphicEmbed.Reminder do
         ]
       ],
       on_replace: :update,
-      type_field: :my_type_field,
+      type_field_name: :my_type_field,
       retain_unlisted_types_on_load: [:some_deprecated_type]
     )
 

From fe3becc879f85230cfe9561f2fef97ad018061d4 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 13:38:15 +0800
Subject: [PATCH 086/129] Bump version to 4.1.1

---
 CHANGELOG.md | 1 +
 README.md    | 2 +-
 mix.exs      | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 543d26b..b691afc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
   * Add `Form.source_data/1` and `Form.source_module/1` (`get_polymorphic_type/2` doesn't work for list of embeds)
   * Add `:retain_unlisted_types_on_load` and `:nilify_unlisted_types_on_load` options
   * MongoDB fix
+  * Deprecate `:type_field` in favor of `:type_field_name`
 
 ## 4.0.x
 
diff --git a/README.md b/README.md
index 61cc33e..cdf3ef2 100644
--- a/README.md
+++ b/README.md
@@ -272,7 +272,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 4.1.0"}
+    {:polymorphic_embed, "~> 4.1.1"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index 3150a44..35f358f 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "4.1.0"
+  @version "4.1.1"
 
   def project do
     [

From 6b74a279f303d52607372c8b3f28cf4a2d26e516 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 13:43:39 +0800
Subject: [PATCH 087/129] Update readme

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index cdf3ef2..8df916e 100644
--- a/README.md
+++ b/README.md
@@ -169,7 +169,7 @@ polymorphic_embeds_many :contexts,
 #### Options
 
 * `:types` – discussed above.
-* `:type_field` – specify a custom type field. Defaults to `:__type__`.
+* `:type_field_name` – specify a custom field name for the field holding the type. Defaults to `:__type__`.
 * `:on_type_not_found` – specify what to do if the embed's type cannot be inferred.
   Possible values are
   - `:raise`: raise an error

From 744912ec42bcf3655f1d311e8e108e8c22ef59b9 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 13:54:54 +0800
Subject: [PATCH 088/129] Replace :type_field by :type_field_name in tests

---
 test/polymorphic_embed_test.exs             | 2 +-
 test/support/models/polymorphic/reminder.ex | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 601143b..811d94c 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -3335,7 +3335,7 @@ defmodule PolymorphicEmbedTest do
           ]
         ],
         on_replace: :update,
-        type_field: :my_type_field
+        type_field_name: :my_type_field
       ]
 
       PolymorphicEmbed.init(opts)
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 384a65a..01fe64f 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -38,7 +38,7 @@ defmodule PolymorphicEmbed.Reminder do
         email: PolymorphicEmbed.Channel.Email
       ],
       on_replace: :update,
-      type_field: :my_type_field
+      type_field_name: :my_type_field
     )
 
     polymorphic_embeds_many(:contexts,

From 0339c867f30fbe827ab9f49e90812885da080d0f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 14:08:35 +0800
Subject: [PATCH 089/129] Clean

---
 lib/polymorphic_embed/options_validator.ex | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index 806433e..a787865 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -18,14 +18,6 @@ defmodule PolymorphicEmbed.OptionsValidator do
   @valid_on_type_not_found_options [:raise, :changeset_error, :nilify, :ignore]
 
   def validate!(options) do
-    keys = Keyword.keys(options)
-    key_count = keys |> Enum.count()
-    unique_key_count = Enum.uniq(keys) |> Enum.count()
-
-    if key_count != unique_key_count do
-      raise "Duplicate keys found in options for polymorphic embed."
-    end
-
     unless Keyword.fetch!(options, :on_replace) in @valid_on_replace_options do
       raise(
         "`:on_replace` must be set to `:update` for a single polymorphic embed or `:delete` for a list of polymorphic embeds."
@@ -60,6 +52,14 @@ defmodule PolymorphicEmbed.OptionsValidator do
       raise "`:retain_unlisted_types_on_load` must be a list of types as atoms."
     end
 
+    keys = Keyword.keys(options)
+    key_count = keys |> Enum.count()
+    unique_key_count = Enum.uniq(keys) |> Enum.count()
+
+    if key_count != unique_key_count do
+      raise "Duplicate keys found in options for polymorphic embed."
+    end
+
     unknown_options = Keyword.drop(options, @known_options_names)
 
     if length(unknown_options) > 0 do

From 7d1ee1452f6511acc8505332f7b2c1ead46fe533 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 3 Jun 2024 21:28:48 +0800
Subject: [PATCH 090/129] Update README.md

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 8df916e..f5a3949 100644
--- a/README.md
+++ b/README.md
@@ -272,7 +272,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 4.1.1"}
+    {:polymorphic_embed, "~> 4.1"}
   ]
 end
 ```

From d48d8bf0242882333544db0e24423dca9ef23e3b Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Wed, 5 Jun 2024 22:16:19 +0800
Subject: [PATCH 091/129] Improve options validation

---
 lib/polymorphic_embed/options_validator.ex | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index a787865..249c384 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -18,10 +18,16 @@ defmodule PolymorphicEmbed.OptionsValidator do
   @valid_on_type_not_found_options [:raise, :changeset_error, :nilify, :ignore]
 
   def validate!(options) do
-    unless Keyword.fetch!(options, :on_replace) in @valid_on_replace_options do
-      raise(
-        "`:on_replace` must be set to `:update` for a single polymorphic embed or `:delete` for a list of polymorphic embeds."
-      )
+    unless is_nil(options[:default]) or options[:default] == [] do
+      raise "`:default` expected to be `nil` or `[]`."
+    end
+
+    if is_nil(options[:default]) and options[:on_replace] != :update do
+      raise "`:on_replace` must be set to `:update` for a single polymorphic embed."
+    end
+
+    if is_list(options[:default]) and options[:on_replace] != :delete do
+      raise "`:on_replace` must be set to `:delete` for a list of polymorphic embeds."
     end
 
     unless Keyword.fetch!(options, :on_type_not_found) in @valid_on_type_not_found_options do

From c57a335e2918b4d5e97af61d030f92dc44255fae Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Wed, 5 Jun 2024 22:17:28 +0800
Subject: [PATCH 092/129] Remove unused attribute

---
 lib/polymorphic_embed/options_validator.ex | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index 249c384..afa540f 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -14,7 +14,6 @@ defmodule PolymorphicEmbed.OptionsValidator do
     :schema,
     :default
   ]
-  @valid_on_replace_options [:update, :delete]
   @valid_on_type_not_found_options [:raise, :changeset_error, :nilify, :ignore]
 
   def validate!(options) do

From e022fadf6d81dd4684f5be197ff1980ea0231957 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 8 Jun 2024 16:56:46 +0800
Subject: [PATCH 093/129] Add :use_parent_field_for_type option

---
 README.md                                     |  1 +
 lib/polymorphic_embed.ex                      | 74 +++++++++++------
 lib/polymorphic_embed/options_validator.ex    | 17 +++-
 mix.exs                                       |  1 +
 mix.lock                                      |  1 +
 test/polymorphic_embed_test.exs               | 79 +++++++++++++++++++
 .../20000101000000_create_tables.exs          |  2 +
 test/support/models/polymorphic/reminder.ex   | 13 ++-
 8 files changed, 158 insertions(+), 30 deletions(-)

diff --git a/README.md b/README.md
index f5a3949..ab735b7 100644
--- a/README.md
+++ b/README.md
@@ -170,6 +170,7 @@ polymorphic_embeds_many :contexts,
 
 * `:types` – discussed above.
 * `:type_field_name` – specify a custom field name for the field holding the type. Defaults to `:__type__`.
+* `:use_parent_field_for_type` – fetch the type from a specified field in the parent schema (the schema holding the embed).
 * `:on_type_not_found` – specify what to do if the embed's type cannot be inferred.
   Possible values are
   - `:raise`: raise an error
diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index f1744d1..73d38f5 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -113,7 +113,8 @@ defmodule PolymorphicEmbed do
       end)
 
     %{
-      default: Keyword.get(opts, :default, nil),
+      default: Keyword.get(opts, :default),
+      use_parent_field_for_type: Keyword.get(opts, :use_parent_field_for_type),
       on_replace: Keyword.fetch!(opts, :on_replace),
       on_type_not_found: Keyword.fetch!(opts, :on_type_not_found),
       nilify_unlisted_types_on_load: Keyword.fetch!(opts, :nilify_unlisted_types_on_load),
@@ -229,7 +230,7 @@ defmodule PolymorphicEmbed do
 
         # If type is provided, ensure it exists in types_metadata
         unless Enum.find(types_metadata, &(&1.type === default_type)) do
-          raise "Incorrect type atom #{inspect(default_type)}"
+          raise "incorrect type atom #{inspect(default_type)}"
         end
 
         %{type_field_name => default_type}
@@ -305,18 +306,14 @@ defmodule PolymorphicEmbed do
   end
 
   defp cast_polymorphic_embeds_one(changeset, field, changeset_fun, params, field_opts) do
-    %{
-      types_metadata: types_metadata,
-      on_type_not_found: on_type_not_found,
-      type_field_name: type_field_name
-    } = field_opts
+    %{on_type_not_found: on_type_not_found} = field_opts
 
     data_for_field = Map.fetch!(changeset.data, field)
 
     # We support partial update of the embed. If the type cannot be inferred from the parameters, or if the found type
     # hasn't changed, pass the data to the changeset.
 
-    case action_and_struct(params, type_field_name, types_metadata, data_for_field) do
+    case action_and_struct(changeset, params, field_opts, data_for_field) do
       :type_not_found when on_type_not_found == :raise ->
         raise_cannot_infer_type_from_data(params)
 
@@ -344,24 +341,52 @@ defmodule PolymorphicEmbed do
     end
   end
 
-  defp action_and_struct(params, type_field_name, types_metadata, data_for_field) do
-    case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
-      nil ->
-        if data_for_field do
-          {:update, data_for_field}
-        else
+  defp action_and_struct(changeset, params, field_opts, data_for_field) do
+    %{
+      types_metadata: types_metadata,
+      type_field_name: type_field_name,
+      use_parent_field_for_type: parent_field_for_type
+    } = field_opts
+
+    if parent_field_for_type != nil do
+      type_from_map = Attrs.get(params, type_field_name)
+      type_from_parent_field = Ecto.Changeset.fetch_field!(changeset, parent_field_for_type)
+
+      cond do
+        is_nil(type_from_parent_field) ->
           :type_not_found
-        end
 
-      module when is_nil(data_for_field) ->
-        {:insert, struct(module)}
+        is_nil(type_from_map) ->
+          module = get_polymorphic_module_for_type(type_from_parent_field, types_metadata)
 
-      module ->
-        if data_for_field.__struct__ != module do
+          if is_nil(data_for_field) or data_for_field.__struct__ != module do
+            {:insert, struct(module)}
+          else
+            {:update, data_for_field}
+          end
+
+        to_string(type_from_parent_field) != to_string(type_from_map) ->
+          raise "type specified in the parent field \"#{type_from_parent_field}\" does not match the type in the embedded map \"#{type_from_map}\""
+      end
+    else
+      case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
+        nil ->
+          if data_for_field do
+            {:update, data_for_field}
+          else
+            :type_not_found
+          end
+
+        module when is_nil(data_for_field) ->
           {:insert, struct(module)}
-        else
-          {:update, data_for_field}
-        end
+
+        module ->
+          if data_for_field.__struct__ != module do
+            {:insert, struct(module)}
+          else
+            {:update, data_for_field}
+          end
+      end
     end
   end
 
@@ -541,10 +566,7 @@ defmodule PolymorphicEmbed do
     attrs = attrs |> convert_map_keys_to_string()
     type_field_name_as_string = to_string(type_field_name)
 
-    type =
-      Enum.find_value(attrs, fn {key, value} -> key == type_field_name_as_string && value end)
-
-    if type do
+    if type = Map.get(attrs, type_field_name_as_string) do
       get_polymorphic_module_for_type(type, types_metadata)
     else
       # check if one list is contained in another
diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index afa540f..1a1d289 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -7,6 +7,7 @@ defmodule PolymorphicEmbed.OptionsValidator do
     :type_field,
     :type_field_name,
     :on_type_not_found,
+    :use_parent_field_for_type,
     :retain_unlisted_types_on_load,
     :nilify_unlisted_types_on_load,
     # Ecto
@@ -35,6 +36,16 @@ defmodule PolymorphicEmbed.OptionsValidator do
       )
     end
 
+    if use_parent_field_for_type = options[:use_parent_field_for_type] do
+      unless is_atom(use_parent_field_for_type) do
+        raise "`:use_parent_field_for_type` must be an atom."
+      end
+
+      if options[:default] == [] do
+        raise "`:use_parent_field_for_type` option cannot be used for a list of polymorphic embeds."
+      end
+    end
+
     # TODO remove in v5
     if Keyword.has_key?(options, :type_field) do
       Logger.warning(
@@ -43,18 +54,18 @@ defmodule PolymorphicEmbed.OptionsValidator do
     end
 
     unless is_atom(Keyword.fetch!(options, :type_field_name)) do
-      raise "`:type_field_name` must be an atom."
+      raise "`:type_field_name` option must be an atom."
     end
 
     retain_unlisted_types = Keyword.fetch!(options, :retain_unlisted_types_on_load)
     nilify_unlisted_types = Keyword.fetch!(options, :nilify_unlisted_types_on_load)
 
     unless is_list(retain_unlisted_types) and Enum.all?(retain_unlisted_types, &is_atom/1) do
-      raise "`:retain_unlisted_types_on_load` must be a list of types as atoms."
+      raise "`:retain_unlisted_types_on_load` option must be a list of types as atoms."
     end
 
     unless is_list(nilify_unlisted_types) and Enum.all?(nilify_unlisted_types, &is_atom/1) do
-      raise "`:retain_unlisted_types_on_load` must be a list of types as atoms."
+      raise "`:retain_unlisted_types_on_load` option must be a list of types as atoms."
     end
 
     keys = Keyword.keys(options)
diff --git a/mix.exs b/mix.exs
index 35f358f..64a0636 100644
--- a/mix.exs
+++ b/mix.exs
@@ -49,6 +49,7 @@ defmodule PolymorphicEmbed.MixProject do
     [
       {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
+      {:attrs, "~> 0.5.0"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:phoenix_live_view, "~> 0.19", optional: true},
diff --git a/mix.lock b/mix.lock
index 8cb2b5d..304b49e 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,4 +1,5 @@
 %{
+  "attrs": {:hex, :attrs, "0.5.0", "d28e67921ffa0b1a9ff2234a9f4614d3727a1ff884f5dd603bab83498999925e", [:mix], [], "hexpm", "b866979346edc4e161ce1499ebbb800eb48ecb8cd58fa6b92700405b5cb5f28d"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
   "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"},
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 811d94c..3671d71 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -120,6 +120,85 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "infer type from parent field via :use_parent_field_for_type option" do
+    generator = :polymorphic
+    reminder_module = get_module(Reminder, generator)
+
+    sms_reminder_attrs = %{
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an SMS reminder #{generator}",
+      type: "sms",
+      channel4: %{
+        number: "02/807.05.53",
+        country_code: 1,
+        provider: %{
+          __type__: "twilio",
+          api_key: "foo"
+        }
+      }
+    }
+
+    insert_result =
+      struct(reminder_module)
+      |> reminder_module.changeset(sms_reminder_attrs)
+      |> Repo.insert()
+
+    assert {:ok, %{}} = insert_result
+  end
+
+  test "infer type from parent field but type is also present in embed map and it is different" do
+    generator = :polymorphic
+    reminder_module = get_module(Reminder, generator)
+
+    sms_reminder_attrs = %{
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an SMS reminder #{generator}",
+      type: "sms",
+      channel4: %{
+        __type__: "email",
+        number: "02/807.05.53",
+        country_code: 1,
+        provider: %{
+          __type__: "twilio",
+          api_key: "foo"
+        }
+      }
+    }
+
+    assert_raise RuntimeError,
+                 ~r"does not match",
+                 fn ->
+                   struct(reminder_module)
+                   |> reminder_module.changeset(sms_reminder_attrs)
+                 end
+  end
+
+  test "infer type from parent field but type is nil" do
+    generator = :polymorphic
+    reminder_module = get_module(Reminder, generator)
+
+    sms_reminder_attrs = %{
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an SMS reminder #{generator}",
+      channel4: %{
+        __type__: "sms",
+        number: "02/807.05.53",
+        country_code: 1,
+        provider: %{
+          __type__: "twilio",
+          api_key: "foo"
+        }
+      }
+    }
+
+    insert_result =
+      struct(reminder_module)
+      |> reminder_module.changeset(sms_reminder_attrs)
+      |> Repo.insert()
+
+    assert {:error, %Ecto.Changeset{}} = insert_result
+  end
+
   test "validations before casting polymorphic embed still work" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)
diff --git a/test/support/migrations/20000101000000_create_tables.exs b/test/support/migrations/20000101000000_create_tables.exs
index d25232e..846c1c4 100644
--- a/test/support/migrations/20000101000000_create_tables.exs
+++ b/test/support/migrations/20000101000000_create_tables.exs
@@ -10,11 +10,13 @@ defmodule PolymorphicEmbed.CreateTables do
     create table(:reminders) do
       add(:date, :utc_datetime, null: false)
       add(:text, :text, null: false)
+      add(:type, :text, null: true)
       add(:event_id, references(:events))
 
       add(:channel, :map)
       add(:channel2, :map)
       add(:channel3, :map)
+      add(:channel4, :map)
       add(:contexts, :map)
       add(:contexts2, :map)
       add(:contexts3, :map)
diff --git a/test/support/models/polymorphic/reminder.ex b/test/support/models/polymorphic/reminder.ex
index 01fe64f..73e42e8 100644
--- a/test/support/models/polymorphic/reminder.ex
+++ b/test/support/models/polymorphic/reminder.ex
@@ -8,6 +8,7 @@ defmodule PolymorphicEmbed.Reminder do
   schema "reminders" do
     field(:date, :utc_datetime)
     field(:text, :string)
+    field(:type, :string)
     has_one(:todo, Todo)
     belongs_to(:event, Event)
 
@@ -41,6 +42,15 @@ defmodule PolymorphicEmbed.Reminder do
       type_field_name: :my_type_field
     )
 
+    polymorphic_embeds_one(:channel4,
+      types: [
+        sms: PolymorphicEmbed.Channel.SMS,
+        email: PolymorphicEmbed.Channel.Email
+      ],
+      on_replace: :update,
+      use_parent_field_for_type: :type
+    )
+
     polymorphic_embeds_many(:contexts,
       types: [
         location: PolymorphicEmbed.Reminder.Context.Location,
@@ -74,11 +84,12 @@ defmodule PolymorphicEmbed.Reminder do
 
   def changeset(struct, values) do
     struct
-    |> cast(values, [:date, :text])
+    |> cast(values, [:date, :text, :type])
     |> validate_required(:date)
     |> cast_polymorphic_embed(:channel)
     |> cast_polymorphic_embed(:channel2)
     |> cast_polymorphic_embed(:channel3)
+    |> cast_polymorphic_embed(:channel4)
     |> cast_polymorphic_embed(:contexts,
       sort_param: :contexts_sort,
       default_type_on_sort_create: :location,

From 75b7d84e9e46a9678fd79dd73a5221d482489b46 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 8 Jun 2024 17:37:57 +0800
Subject: [PATCH 094/129] Use Attrs

---
 lib/polymorphic_embed.ex | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 73d38f5..c6a5f6b 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -108,7 +108,7 @@ defmodule PolymorphicEmbed do
             type: type_name,
             module: Keyword.fetch!(type_opts, :module),
             identify_by_fields:
-              type_opts |> Keyword.get(:identify_by_fields, []) |> Enum.map(&to_string/1)
+              Keyword.get(type_opts, :identify_by_fields, []) |> Enum.map(&to_string/1)
           }
       end)
 
@@ -563,19 +563,26 @@ defmodule PolymorphicEmbed do
   end
 
   defp get_polymorphic_module_from_map(%{} = attrs, type_field_name, types_metadata) do
-    attrs = attrs |> convert_map_keys_to_string()
-    type_field_name_as_string = to_string(type_field_name)
-
-    if type = Map.get(attrs, type_field_name_as_string) do
+    if type = Attrs.get(attrs, type_field_name) do
       get_polymorphic_module_for_type(type, types_metadata)
     else
       # check if one list is contained in another
       # Enum.count(contained -- container) == 0
       # contained -- container == []
-      types_metadata
-      |> Enum.filter(&([] != &1.identify_by_fields))
-      |> Enum.find(&([] == &1.identify_by_fields -- Map.keys(attrs)))
-      |> (&(&1 && Map.fetch!(&1, :module))).()
+
+      types_metadata =
+        types_metadata
+        |> Enum.filter(&([] != &1.identify_by_fields))
+
+      if types_metadata != [] do
+        keys = Map.keys(attrs) |> Enum.map(&to_string/1)
+
+        types_metadata
+        |> Enum.find(&([] == &1.identify_by_fields -- keys))
+        |> (&(&1 && Map.fetch!(&1, :module))).()
+      else
+        nil
+      end
     end
   end
 
@@ -647,9 +654,6 @@ defmodule PolymorphicEmbed do
     end
   end
 
-  defp convert_map_keys_to_string(%{} = map),
-    do: for({key, val} <- map, into: %{}, do: {to_string(key), val})
-
   defp raise_cannot_infer_type_from_data(data),
     do: raise("could not infer polymorphic embed from data #{inspect(data)}")
 

From a74f12f0336b946dd2aaef22f78382f6e94c740e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 8 Jun 2024 18:21:09 +0800
Subject: [PATCH 095/129] Simplify get_field_opts

---
 lib/polymorphic_embed.ex                   | 16 +++++++++++-----
 lib/polymorphic_embed/options_validator.ex |  1 +
 test/polymorphic_embed_test.exs            |  4 +++-
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index c6a5f6b..f5b6d80 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -10,7 +10,11 @@ defmodule PolymorphicEmbed do
   alias PolymorphicEmbed.OptionsValidator
 
   defmacro polymorphic_embeds_one(field_name, opts) do
-    opts = Keyword.update!(opts, :types, &expand_alias(&1, __CALLER__))
+    opts =
+      opts
+      |> Keyword.put_new(:array?, false)
+      |> Keyword.put_new(:default,nil)
+      |> Keyword.update!(:types, &expand_alias(&1, __CALLER__))
 
     quote do
       field(unquote(field_name), PolymorphicEmbed, unquote(opts))
@@ -20,6 +24,7 @@ defmodule PolymorphicEmbed do
   defmacro polymorphic_embeds_many(field_name, opts) do
     opts =
       opts
+      |> Keyword.put_new(:array?, true)
       |> Keyword.put_new(:default, [])
       |> Keyword.update!(:types, &expand_alias(&1, __CALLER__))
 
@@ -113,7 +118,8 @@ defmodule PolymorphicEmbed do
       end)
 
     %{
-      default: Keyword.get(opts, :default),
+      array?: Keyword.fetch!(opts, :array?),
+      default: Keyword.fetch!(opts, :default),
       use_parent_field_for_type: Keyword.get(opts, :use_parent_field_for_type),
       on_replace: Keyword.fetch!(opts, :on_replace),
       on_type_not_found: Keyword.fetch!(opts, :on_type_not_found),
@@ -633,9 +639,9 @@ defmodule PolymorphicEmbed do
       _ in UndefinedFunctionError ->
         reraise ArgumentError, "#{inspect(schema)} is not an Ecto schema", __STACKTRACE__
     else
-      {:parameterized, PolymorphicEmbed, options} -> Map.put(options, :array?, false)
-      {:array, {:parameterized, PolymorphicEmbed, options}} -> Map.put(options, :array?, true)
-      {_, {:parameterized, PolymorphicEmbed, options}} -> Map.put(options, :array?, false)
+      {:parameterized, PolymorphicEmbed, options} -> options
+      {:array, {:parameterized, PolymorphicEmbed, options}} -> options
+      {_, {:parameterized, PolymorphicEmbed, options}} -> options
       nil -> raise ArgumentError, "#{field} is not a polymorphic embed"
     end
   end
diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index 1a1d289..6777018 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -10,6 +10,7 @@ defmodule PolymorphicEmbed.OptionsValidator do
     :use_parent_field_for_type,
     :retain_unlisted_types_on_load,
     :nilify_unlisted_types_on_load,
+    :array?,
     # Ecto
     :field,
     :schema,
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 3671d71..6b1e996 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -3414,7 +3414,9 @@ defmodule PolymorphicEmbedTest do
           ]
         ],
         on_replace: :update,
-        type_field_name: :my_type_field
+        type_field_name: :my_type_field,
+        array?: false,
+        default: nil
       ]
 
       PolymorphicEmbed.init(opts)

From cac49d7aebc7176f54aad290258666f9b0ca9997 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sat, 8 Jun 2024 23:35:55 +0800
Subject: [PATCH 096/129] Update Attrs

---
 mix.exs  | 2 +-
 mix.lock | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mix.exs b/mix.exs
index 64a0636..2692e56 100644
--- a/mix.exs
+++ b/mix.exs
@@ -49,7 +49,7 @@ defmodule PolymorphicEmbed.MixProject do
     [
       {:ecto, "~> 3.11"},
       {:jason, "~> 1.4"},
-      {:attrs, "~> 0.5.0"},
+      {:attrs, "~> 0.6"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:phoenix_live_view, "~> 0.19", optional: true},
diff --git a/mix.lock b/mix.lock
index 304b49e..94e2269 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,5 +1,5 @@
 %{
-  "attrs": {:hex, :attrs, "0.5.0", "d28e67921ffa0b1a9ff2234a9f4614d3727a1ff884f5dd603bab83498999925e", [:mix], [], "hexpm", "b866979346edc4e161ce1499ebbb800eb48ecb8cd58fa6b92700405b5cb5f28d"},
+  "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
   "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"},

From b9b314559b6e9713664f3d67d355bde33f868ae9 Mon Sep 17 00:00:00 2001
From: John Cline <2057878+clinejj@users.noreply.github.com>
Date: Wed, 17 Jul 2024 17:19:01 -0400
Subject: [PATCH 097/129] Add nil check to cast_polymorphic_embeds_many

---
 lib/polymorphic_embed.ex | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index f1744d1..a672438 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -388,13 +388,17 @@ defmodule PolymorphicEmbed do
 
           module ->
             data_for_field =
-              Enum.find(list_data_for_field, fn
-                %{id: id} = datum when not is_nil(id) ->
-                  id == params[:id] and datum.__struct__ == module
-
-                _ ->
-                  nil
-              end)
+              if list_data_for_field do
+                Enum.find(list_data_for_field, fn
+                  %{id: id} = datum when not is_nil(id) ->
+                    id == params[:id] and datum.__struct__ == module
+
+                  _ ->
+                    nil
+                end)
+              else
+                nil
+              end
 
             embed_changeset =
               if data_for_field do

From 6c4c08086557aae87c229fe604b67bbb95c11a31 Mon Sep 17 00:00:00 2001
From: John Cline <2057878+clinejj@users.noreply.github.com>
Date: Wed, 17 Jul 2024 17:27:20 -0400
Subject: [PATCH 098/129] Add test

---
 test/polymorphic_embed_test.exs | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 811d94c..171048b 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1669,6 +1669,7 @@ defmodule PolymorphicEmbedTest do
             address: "address"
           }
         ],
+        contexts2: nil,
         contexts3: [
           %{
             __type__: "device",
@@ -1784,6 +1785,27 @@ defmodule PolymorphicEmbedTest do
         ]
       }
 
+      assert {:ok, _} =
+               reminder
+               |> reminder_module.changeset(attrs)
+               |> Repo.update()
+
+      # Make sure it works for embeds with nil entries
+      attrs = %{
+        contexts2: [
+          %{
+            __type__: "device",
+            ref: "12345",
+            type: "cellphone"
+          },
+          %{
+            __type__: "device",
+            ref: "56789",
+            type: "laptop"
+          }
+        ]
+      }
+
       assert {:ok, _} =
                reminder
                |> reminder_module.changeset(attrs)

From cef782eca8b2df3a9cabc5a15e3834c28019d9cd Mon Sep 17 00:00:00 2001
From: John Cline <2057878+clinejj@users.noreply.github.com>
Date: Thu, 18 Jul 2024 09:27:53 -0400
Subject: [PATCH 099/129] optional set list_data_for_field

---
 lib/polymorphic_embed.ex | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index a672438..438d634 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -372,7 +372,7 @@ defmodule PolymorphicEmbed do
       type_field_name: type_field_name
     } = field_opts
 
-    list_data_for_field = Map.fetch!(changeset.data, field)
+    list_data_for_field = Map.fetch!(changeset.data, field) || []
 
     embeds =
       Enum.map(list_params, fn params ->
@@ -388,17 +388,13 @@ defmodule PolymorphicEmbed do
 
           module ->
             data_for_field =
-              if list_data_for_field do
-                Enum.find(list_data_for_field, fn
-                  %{id: id} = datum when not is_nil(id) ->
-                    id == params[:id] and datum.__struct__ == module
-
-                  _ ->
-                    nil
-                end)
-              else
-                nil
-              end
+              Enum.find(list_data_for_field, fn
+                %{id: id} = datum when not is_nil(id) ->
+                  id == params[:id] and datum.__struct__ == module
+
+                _ ->
+                  nil
+              end)
 
             embed_changeset =
               if data_for_field do

From 996d40c3cc9384b8a185cd3a7a83ba0f041be7d2 Mon Sep 17 00:00:00 2001
From: Enzo <enzo.baldisserri@aworldforus.com>
Date: Tue, 13 Aug 2024 12:30:34 +0200
Subject: [PATCH 100/129] update Ecto to 3.12

---
 mix.exs  |  6 +++---
 mix.lock | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/mix.exs b/mix.exs
index 35f358f..99c4666 100644
--- a/mix.exs
+++ b/mix.exs
@@ -47,14 +47,14 @@ defmodule PolymorphicEmbed.MixProject do
 
   defp deps do
     [
-      {:ecto, "~> 3.11"},
+      {:ecto, "~> 3.12"},
       {:jason, "~> 1.4"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
       {:phoenix_live_view, "~> 0.19", optional: true},
       {:ex_doc, "~> 0.34", only: :dev},
-      {:ecto_sql, "~> 3.11", only: :test},
-      {:postgrex, "~> 0.18", only: :test},
+      {:ecto_sql, "~> 3.12", only: :test},
+      {:postgrex, "~> 0.18 or ~> 0.19", only: :test},
       {:query_builder, "~> 1.4", only: :test},
       {:phoenix_ecto, "~> 4.6", only: :test},
       {:floki, "~> 0.36", only: :test},
diff --git a/mix.lock b/mix.lock
index 8cb2b5d..b7d4ebe 100644
--- a/mix.lock
+++ b/mix.lock
@@ -2,18 +2,18 @@
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
   "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"},
-  "db_connection": {:hex, :db_connection, "2.6.0", "77d835c472b5b67fc4f29556dee74bf511bbafecdcaf98c27d27fa5918152086", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c2f992d15725e721ec7fbc1189d4ecdb8afef76648c746a8e1cad35e3b8a35f3"},
+  "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.39", "424642f8335b05bb9eb611aa1564c148a8ee35c9c8a8bba6e129d51a3e3c6769", [:mix], [], "hexpm", "06553a88d1f1846da9ef066b87b57c6f605552cfbe40d20bd8d59cc6bde41944"},
-  "ecto": {:hex, :ecto, "3.11.2", "e1d26be989db350a633667c5cda9c3d115ae779b66da567c68c80cfb26a8c9ee", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "3c38bca2c6f8d8023f2145326cc8a80100c3ffe4dcbd9842ff867f7fc6156c65"},
-  "ecto_sql": {:hex, :ecto_sql, "3.11.2", "c7cc7f812af571e50b80294dc2e535821b3b795ce8008d07aa5f336591a185a8", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "73c07f995ac17dbf89d3cfaaf688fcefabcd18b7b004ac63b0dc4ef39499ed6b"},
+  "ecto": {:hex, :ecto, "3.12.1", "626765f7066589de6fa09e0876a253ff60c3d00870dd3a1cd696e2ba67bfceea", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "df0045ab9d87be947228e05a8d153f3e06e0d05ab10c3b3cc557d2f7243d1940"},
+  "ecto_sql": {:hex, :ecto_sql, "3.12.0", "73cea17edfa54bde76ee8561b30d29ea08f630959685006d9c6e7d1e59113b7d", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.12", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.7", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.19 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dc9e4d206f274f3947e96142a8fdc5f69a2a6a9abb4649ef5c882323b6d512f0"},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "ex_doc": {:hex, :ex_doc, "0.34.0", "ab95e0775db3df71d30cf8d78728dd9261c355c81382bcd4cefdc74610bef13e", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "60734fb4c1353f270c3286df4a0d51e65a2c1d9fba66af3940847cc65a8066d7"},
   "excoveralls": {:hex, :excoveralls, "0.18.1", "a6f547570c6b24ec13f122a5634833a063aec49218f6fff27de9df693a15588c", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "d65f79db146bb20399f23046015974de0079668b9abb2f5aac074d078da60b8d"},
   "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
   "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},
-  "jason": {:hex, :jason, "1.4.1", "af1504e35f629ddcdd6addb3513c3853991f694921b1b9368b0bd32beb9f1b63", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "fbb01ecdfd565b56261302f7e1fcc27c4fb8f32d56eab74db621fc154604a7a1"},
+  "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},
   "makeup_elixir": {:hex, :makeup_elixir, "0.16.2", "627e84b8e8bf22e60a2579dad15067c755531fea049ae26ef1020cad58fe9578", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "41193978704763f6bbe6cc2758b84909e62984c7752b3784bd3c218bb341706b"},
   "makeup_erlang": {:hex, :makeup_erlang, "1.0.0", "6f0eff9c9c489f26b69b61440bf1b238d95badae49adac77973cbacae87e3c2e", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "ea7a9307de9d1548d2a72d299058d1fd2339e3d398560a0e46c27dab4891e4d2"},
@@ -28,7 +28,7 @@
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
   "plug": {:hex, :plug, "1.16.0", "1d07d50cb9bb05097fdf187b31cf087c7297aafc3fed8299aac79c128a707e47", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cbf53aa1f5c4d758a7559c0bd6d59e286c2be0c6a1fac8cc3eee2f638243b93e"},
   "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
-  "postgrex": {:hex, :postgrex, "0.18.0", "f34664101eaca11ff24481ed4c378492fed2ff416cd9b06c399e90f321867d7e", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "a042989ba1bc1cca7383ebb9e461398e3f89f868c92ce6671feb7ef132a252d1"},
+  "postgrex": {:hex, :postgrex, "0.19.1", "73b498508b69aded53907fe48a1fee811be34cc720e69ef4ccd568c8715495ea", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "8bac7885a18f381e091ec6caf41bda7bb8c77912bb0e9285212829afe5d8a8f8"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},

From a92bea891996073d28d4ec40d78ee1dd08ab82f8 Mon Sep 17 00:00:00 2001
From: Enzo <enzo.baldisserri@aworldforus.com>
Date: Tue, 13 Aug 2024 12:31:55 +0200
Subject: [PATCH 101/129] use Ecto's new `:parametrized` representation

---
 lib/polymorphic_embed.ex | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 438d634..6ae9ef5 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -604,9 +604,9 @@ defmodule PolymorphicEmbed do
       _ in UndefinedFunctionError ->
         reraise ArgumentError, "#{inspect(schema)} is not an Ecto schema", __STACKTRACE__
     else
-      {:parameterized, PolymorphicEmbed, options} -> Map.put(options, :array?, false)
-      {:array, {:parameterized, PolymorphicEmbed, options}} -> Map.put(options, :array?, true)
-      {_, {:parameterized, PolymorphicEmbed, options}} -> Map.put(options, :array?, false)
+      {:parameterized, {PolymorphicEmbed, options}} -> Map.put(options, :array?, false)
+      {:array, {:parameterized, {PolymorphicEmbed, options}}} -> Map.put(options, :array?, true)
+      {_, {:parameterized, {PolymorphicEmbed, options}}} -> Map.put(options, :array?, false)
       nil -> raise ArgumentError, "#{field} is not a polymorphic embed"
     end
   end
@@ -668,7 +668,7 @@ defmodule PolymorphicEmbed do
   end
 
   defp polymorphic_key_reducer(
-         {field, {:parameterized, PolymorphicEmbed, _opts}},
+         {field, {:parameterized, {PolymorphicEmbed, _opts}}},
          acc,
          changes,
          msg_func
@@ -707,7 +707,7 @@ defmodule PolymorphicEmbed do
   end
 
   defp polymorphic_key_reducer(
-         {field, {:array, {:parameterized, PolymorphicEmbed, _opts}}},
+         {field, {:array, {:parameterized, {PolymorphicEmbed, _opts}}}},
          acc,
          changes,
          msg_func

From 793aece67eda84cba2fbb70cd9aab638757452d4 Mon Sep 17 00:00:00 2001
From: Enzo <enzo.baldisserri@aworldforus.com>
Date: Tue, 13 Aug 2024 12:35:26 +0200
Subject: [PATCH 102/129] update changelog

---
 CHANGELOG.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b691afc..6181559 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Next release
+
+  * Fix usage with Ecto 3.12. Require Ecto 3.12 or later
+
 ## 4.1.x
 
   * Add `Form.source_data/1` and `Form.source_module/1` (`get_polymorphic_type/2` doesn't work for list of embeds)

From 8c874fea1e656c392cbae65953ed2703811a6f5f Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 19 Aug 2024 11:10:35 +0800
Subject: [PATCH 103/129] Run mix format

---
 lib/polymorphic_embed.ex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index e5e86f1..85387f4 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -13,7 +13,7 @@ defmodule PolymorphicEmbed do
     opts =
       opts
       |> Keyword.put_new(:array?, false)
-      |> Keyword.put_new(:default,nil)
+      |> Keyword.put_new(:default, nil)
       |> Keyword.update!(:types, &expand_alias(&1, __CALLER__))
 
     quote do

From 26d44217eb9c79874cfc1b4cb31ab48557033427 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 19 Aug 2024 11:16:57 +0800
Subject: [PATCH 104/129] Update deps

---
 mix.exs  |  2 +-
 mix.lock | 28 ++++++++++++++--------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/mix.exs b/mix.exs
index 85e6116..a566bff 100644
--- a/mix.exs
+++ b/mix.exs
@@ -52,7 +52,7 @@ defmodule PolymorphicEmbed.MixProject do
       {:attrs, "~> 0.6"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
-      {:phoenix_live_view, "~> 0.19", optional: true},
+      {:phoenix_live_view, "~> 0.20", optional: true},
       {:ex_doc, "~> 0.34", only: :dev},
       {:ecto_sql, "~> 3.12", only: :test},
       {:postgrex, "~> 0.18 or ~> 0.19", only: :test},
diff --git a/mix.lock b/mix.lock
index c5041b7..7794091 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,37 +1,37 @@
 %{
   "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
-  "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
-  "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"},
+  "castore": {:hex, :castore, "1.0.8", "dedcf20ea746694647f883590b82d9e96014057aff1d44d03ec90f36a5c0dc6e", [:mix], [], "hexpm", "0b2b66d2ee742cb1d9cb8c8be3b43c3a70ee8651f37b75a8b982e036752983f1"},
+  "credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
   "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
-  "earmark_parser": {:hex, :earmark_parser, "1.4.39", "424642f8335b05bb9eb611aa1564c148a8ee35c9c8a8bba6e129d51a3e3c6769", [:mix], [], "hexpm", "06553a88d1f1846da9ef066b87b57c6f605552cfbe40d20bd8d59cc6bde41944"},
+  "earmark_parser": {:hex, :earmark_parser, "1.4.41", "ab34711c9dc6212dda44fcd20ecb87ac3f3fce6f0ca2f28d4a00e4154f8cd599", [:mix], [], "hexpm", "a81a04c7e34b6617c2792e291b5a2e57ab316365c2644ddc553bb9ed863ebefa"},
   "ecto": {:hex, :ecto, "3.12.1", "626765f7066589de6fa09e0876a253ff60c3d00870dd3a1cd696e2ba67bfceea", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "df0045ab9d87be947228e05a8d153f3e06e0d05ab10c3b3cc557d2f7243d1940"},
   "ecto_sql": {:hex, :ecto_sql, "3.12.0", "73cea17edfa54bde76ee8561b30d29ea08f630959685006d9c6e7d1e59113b7d", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.12", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.7", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.19 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dc9e4d206f274f3947e96142a8fdc5f69a2a6a9abb4649ef5c882323b6d512f0"},
-  "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
-  "ex_doc": {:hex, :ex_doc, "0.34.0", "ab95e0775db3df71d30cf8d78728dd9261c355c81382bcd4cefdc74610bef13e", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "60734fb4c1353f270c3286df4a0d51e65a2c1d9fba66af3940847cc65a8066d7"},
-  "excoveralls": {:hex, :excoveralls, "0.18.1", "a6f547570c6b24ec13f122a5634833a063aec49218f6fff27de9df693a15588c", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "d65f79db146bb20399f23046015974de0079668b9abb2f5aac074d078da60b8d"},
-  "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
+  "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
+  "ex_doc": {:hex, :ex_doc, "0.34.2", "13eedf3844ccdce25cfd837b99bea9ad92c4e511233199440488d217c92571e8", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "5ce5f16b41208a50106afed3de6a2ed34f4acfd65715b82a0b84b49d995f95c1"},
+  "excoveralls": {:hex, :excoveralls, "0.18.2", "86efd87a0676a3198ff50b8c77620ea2f445e7d414afa9ec6c4ba84c9f8bdcc2", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "230262c418f0de64077626a498bd4fdf1126d5c2559bb0e6b43deac3005225a4"},
+  "file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
   "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},
   "makeup_elixir": {:hex, :makeup_elixir, "0.16.2", "627e84b8e8bf22e60a2579dad15067c755531fea049ae26ef1020cad58fe9578", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "41193978704763f6bbe6cc2758b84909e62984c7752b3784bd3c218bb341706b"},
-  "makeup_erlang": {:hex, :makeup_erlang, "1.0.0", "6f0eff9c9c489f26b69b61440bf1b238d95badae49adac77973cbacae87e3c2e", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "ea7a9307de9d1548d2a72d299058d1fd2339e3d398560a0e46c27dab4891e4d2"},
-  "mime": {:hex, :mime, "2.0.5", "dc34c8efd439abe6ae0343edbb8556f4d63f178594894720607772a041b04b02", [:mix], [], "hexpm", "da0d64a365c45bc9935cc5c8a7fc5e49a0e0f9932a761c55d6c52b142780a05c"},
+  "makeup_erlang": {:hex, :makeup_erlang, "1.0.1", "c7f58c120b2b5aa5fd80d540a89fdf866ed42f1f3994e4fe189abebeab610839", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "8a89a1eeccc2d798d6ea15496a6e4870b75e014d1af514b1b71fa33134f57814"},
+  "mime": {:hex, :mime, "2.0.6", "8f18486773d9b15f95f4f4f1e39b710045fa1de891fada4516559967276e4dc2", [:mix], [], "hexpm", "c9945363a6b26d747389aac3643f8e0e09d30499a138ad64fe8fd1d13d9b153e"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
-  "phoenix": {:hex, :phoenix, "1.7.12", "1cc589e0eab99f593a8aa38ec45f15d25297dd6187ee801c8de8947090b5a9d3", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "d646192fbade9f485b01bc9920c139bfdd19d0f8df3d73fd8eaf2dfbe0d2837c"},
-  "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.1", "96798325fab2fed5a824ca204e877b81f9afd2e480f581e81f7b4b64a5a477f2", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.17", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "0ae544ff99f3c482b0807c5cec2c8289e810ecacabc04959d82c3337f4703391"},
+  "phoenix": {:hex, :phoenix, "1.7.14", "a7d0b3f1bc95987044ddada111e77bd7f75646a08518942c72a8440278ae7825", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "c7859bc56cc5dfef19ecfc240775dae358cbaa530231118a9e014df392ace61a"},
+  "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.2", "3b83b24ab5a2eb071a20372f740d7118767c272db386831b2e77638c4dcc606d", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "3f94d025f59de86be00f5f8c5dd7b5965a3298458d21ab1c328488be3b5fcd59"},
   "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
   "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
-  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.14", "70fa101aa0539e81bed4238777498f6215e9dda3461bdaa067cad6908110c364", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "82f6d006c5264f979ed5eb75593d808bbe39020f20df2e78426f4f2d570e2402"},
+  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.17", "f396bbdaf4ba227b82251eb75ac0afa6b3da5e509bc0d030206374237dfc9450", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a61d741ffb78c85fdbca0de084da6a48f8ceb5261a79165b5a0b59e5f65ce98b"},
   "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
-  "plug": {:hex, :plug, "1.16.0", "1d07d50cb9bb05097fdf187b31cf087c7297aafc3fed8299aac79c128a707e47", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "cbf53aa1f5c4d758a7559c0bd6d59e286c2be0c6a1fac8cc3eee2f638243b93e"},
+  "plug": {:hex, :plug, "1.16.1", "40c74619c12f82736d2214557dedec2e9762029b2438d6d175c5074c933edc9d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a13ff6b9006b03d7e33874945b2755253841b238c34071ed85b0e86057f8cddc"},
   "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
   "postgrex": {:hex, :postgrex, "0.19.1", "73b498508b69aded53907fe48a1fee811be34cc720e69ef4ccd568c8715495ea", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "8bac7885a18f381e091ec6caf41bda7bb8c77912bb0e9285212829afe5d8a8f8"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
-  "websock_adapter": {:hex, :websock_adapter, "0.5.6", "0437fe56e093fd4ac422de33bf8fc89f7bc1416a3f2d732d8b2c8fd54792fe60", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "e04378d26b0af627817ae84c92083b7e97aca3121196679b73c73b99d0d133ea"},
+  "websock_adapter": {:hex, :websock_adapter, "0.5.7", "65fa74042530064ef0570b75b43f5c49bb8b235d6515671b3d250022cb8a1f9e", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "d0f478ee64deddfec64b800673fd6e0c8888b079d9f3444dd96d2a98383bdbd1"},
 }

From 324b73108320442cbc34eea2736833e1c5b37e4e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Mon, 19 Aug 2024 11:20:17 +0800
Subject: [PATCH 105/129] Bump version to 5.0.0

---
 CHANGELOG.md | 3 ++-
 README.md    | 2 +-
 mix.exs      | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6181559..cef0fa2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,8 +1,9 @@
 # Changelog
 
-## Next release
+## 5.0.x
 
   * Fix usage with Ecto 3.12. Require Ecto 3.12 or later
+  * Allow inferring type from parent field via new :use_parent_field_for_type option
 
 ## 4.1.x
 
diff --git a/README.md b/README.md
index ab735b7..28c7bfc 100644
--- a/README.md
+++ b/README.md
@@ -273,7 +273,7 @@ Add `polymorphic_embed` for Elixir as a dependency in your `mix.exs` file:
 ```elixir
 def deps do
   [
-    {:polymorphic_embed, "~> 4.1"}
+    {:polymorphic_embed, "~> 5.0"}
   ]
 end
 ```
diff --git a/mix.exs b/mix.exs
index a566bff..06f2d60 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "4.1.1"
+  @version "5.0.0"
 
   def project do
     [

From 864347588e0c985bd2476906fd26ac9808360bd3 Mon Sep 17 00:00:00 2001
From: Nick <nick.duitz@9elements.com>
Date: Thu, 5 Dec 2024 16:50:55 +0100
Subject: [PATCH 106/129] implement failing test

---
 test/polymorphic_embed_test.exs               | 55 +++++++++++++++++++
 .../polymorphic/reminder/context/device.ex    |  5 +-
 .../reminder/context/device_no_id.ex          |  4 +-
 .../polymorphic/reminder/context/extra.ex     | 14 +++++
 4 files changed, 72 insertions(+), 6 deletions(-)
 create mode 100644 test/support/models/polymorphic/reminder/context/extra.ex

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 7dced00..bf98a63 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -2503,6 +2503,43 @@ defmodule PolymorphicEmbedTest do
   end
 
   describe "polymorphic_embed_inputs_for/1" do
+    test "errors in form for polymorphic embed and nested embed" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      sms_reminder_attrs = %{
+        text: "This is an SMS reminder",
+        contexts: [
+          %{
+            __type__: "device",
+            extra: %{}
+          }
+        ]
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(sms_reminder_attrs)
+
+      changeset = %{changeset | action: :insert}
+
+      html_string =
+        render_component(
+          &liveview_form_with_inputs_for/1,
+          %{changeset: changeset, field: :contexts}
+        )
+
+      assert String.contains?(
+               html_string,
+               "[type: {&quot;can&#39;t be blank&quot;, [validation: :required]}]"
+             )
+
+      assert String.contains?(
+               html_string,
+               "[imei: {&quot;can&#39;t be blank&quot;, [validation: :required]}]"
+             )
+    end
+
     test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
 
@@ -3520,6 +3557,24 @@ defmodule PolymorphicEmbedTest do
     """
   end
 
+  defp liveview_form_with_inputs_for(assigns) do
+    ~H"""
+    <.form
+      :let={f}
+      for={@changeset}
+    >
+      <.polymorphic_embed_inputs_for field={f[@field]} :let={sms_form}>
+        <%= text_input sms_form, :number %>
+        <%= sms_form.errors |> inspect() %>
+        <.inputs_for field={sms_form[:extra]} :let={channel_form}>
+          <%= text_input channel_form, :imei %>
+          <%= channel_form.errors |> inspect() %>
+        </.inputs_for>
+      </.polymorphic_embed_inputs_for>
+    </.form>
+    """
+  end
+
   defp polymorphic?(:polymorphic), do: true
   defp polymorphic?(:not_polymorphic), do: false
 end
diff --git a/test/support/models/polymorphic/reminder/context/device.ex b/test/support/models/polymorphic/reminder/context/device.ex
index 31684f8..9ea491d 100644
--- a/test/support/models/polymorphic/reminder/context/device.ex
+++ b/test/support/models/polymorphic/reminder/context/device.ex
@@ -6,14 +6,13 @@ defmodule PolymorphicEmbed.Reminder.Context.Device do
     field :ref, :string
     field :type, :string
 
-    embeds_one :extra, Extra do
-      field :imei, :string
-    end
+    embeds_one :extra, PolymorphicEmbed.Reminder.Context.Extra
   end
 
   def changeset(struct, params) do
     struct
     |> cast(params, ~w(ref type)a)
     |> validate_required(~w(type)a)
+    |> cast_embed(:extra)
   end
 end
diff --git a/test/support/models/polymorphic/reminder/context/device_no_id.ex b/test/support/models/polymorphic/reminder/context/device_no_id.ex
index 3f6f9a5..37b8292 100644
--- a/test/support/models/polymorphic/reminder/context/device_no_id.ex
+++ b/test/support/models/polymorphic/reminder/context/device_no_id.ex
@@ -8,9 +8,7 @@ defmodule PolymorphicEmbed.Reminder.Context.DeviceNoId do
     field :ref, :string
     field :type, :string
 
-    embeds_one :extra, Extra do
-      field :imei, :string
-    end
+    embeds_one :extra, PolymorphicEmbed.Reminder.Context
   end
 
   def changeset(struct, params) do
diff --git a/test/support/models/polymorphic/reminder/context/extra.ex b/test/support/models/polymorphic/reminder/context/extra.ex
new file mode 100644
index 0000000..e054c1d
--- /dev/null
+++ b/test/support/models/polymorphic/reminder/context/extra.ex
@@ -0,0 +1,14 @@
+defmodule PolymorphicEmbed.Reminder.Context.Extra do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  embedded_schema do
+    field :imei, :string
+  end
+
+  def changeset(extra, attrs) do
+    extra
+    |> cast(attrs, [:imei])
+    |> validate_required([:imei])
+  end
+end

From 16c5b55c174ee25685ba48fe2dbf3cfecf4b3033 Mon Sep 17 00:00:00 2001
From: Nick <nick.duitz@9elements.com>
Date: Thu, 5 Dec 2024 16:51:08 +0100
Subject: [PATCH 107/129] fix

---
 lib/polymorphic_embed/html/helpers.ex | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/polymorphic_embed/html/helpers.ex b/lib/polymorphic_embed/html/helpers.ex
index 7822d46..a91c7f4 100644
--- a/lib/polymorphic_embed/html/helpers.ex
+++ b/lib/polymorphic_embed/html/helpers.ex
@@ -107,6 +107,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
           index: if(array?, do: i),
           errors: errors,
           data: data,
+          action: parent_action,
           params: params,
           hidden: [{type_field_name, to_string(type)}],
           options: options

From c9ce38cdcd56ee58fe738f66c130873c9ee4935f Mon Sep 17 00:00:00 2001
From: alinmarsh <alimarsh@live.com>
Date: Thu, 19 Dec 2024 08:24:41 -0600
Subject: [PATCH 108/129] bump liveview version

---
 mix.exs  |  2 +-
 mix.lock | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/mix.exs b/mix.exs
index 06f2d60..9806747 100644
--- a/mix.exs
+++ b/mix.exs
@@ -52,7 +52,7 @@ defmodule PolymorphicEmbed.MixProject do
       {:attrs, "~> 0.6"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
-      {:phoenix_live_view, "~> 0.20", optional: true},
+      {:phoenix_live_view, "~> 1.0.0", optional: true},
       {:ex_doc, "~> 0.34", only: :dev},
       {:ecto_sql, "~> 3.12", only: :test},
       {:postgrex, "~> 0.18 or ~> 0.19", only: :test},
diff --git a/mix.lock b/mix.lock
index 7794091..7a0929c 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,10 +1,10 @@
 %{
   "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
-  "castore": {:hex, :castore, "1.0.8", "dedcf20ea746694647f883590b82d9e96014057aff1d44d03ec90f36a5c0dc6e", [:mix], [], "hexpm", "0b2b66d2ee742cb1d9cb8c8be3b43c3a70ee8651f37b75a8b982e036752983f1"},
+  "castore": {:hex, :castore, "1.0.10", "43bbeeac820f16c89f79721af1b3e092399b3a1ecc8df1a472738fd853574911", [:mix], [], "hexpm", "1b0b7ea14d889d9ea21202c43a4fa015eb913021cb535e8ed91946f4b77a8848"},
   "credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
   "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
-  "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
+  "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.41", "ab34711c9dc6212dda44fcd20ecb87ac3f3fce6f0ca2f28d4a00e4154f8cd599", [:mix], [], "hexpm", "a81a04c7e34b6617c2792e291b5a2e57ab316365c2644ddc553bb9ed863ebefa"},
   "ecto": {:hex, :ecto, "3.12.1", "626765f7066589de6fa09e0876a253ff60c3d00870dd3a1cd696e2ba67bfceea", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "df0045ab9d87be947228e05a8d153f3e06e0d05ab10c3b3cc557d2f7243d1940"},
@@ -13,25 +13,25 @@
   "ex_doc": {:hex, :ex_doc, "0.34.2", "13eedf3844ccdce25cfd837b99bea9ad92c4e511233199440488d217c92571e8", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "5ce5f16b41208a50106afed3de6a2ed34f4acfd65715b82a0b84b49d995f95c1"},
   "excoveralls": {:hex, :excoveralls, "0.18.2", "86efd87a0676a3198ff50b8c77620ea2f445e7d414afa9ec6c4ba84c9f8bdcc2", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "230262c418f0de64077626a498bd4fdf1126d5c2559bb0e6b43deac3005225a4"},
   "file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
-  "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},
+  "floki": {:hex, :floki, "0.37.0", "b83e0280bbc6372f2a403b2848013650b16640cd2470aea6701f0632223d719e", [:mix], [], "hexpm", "516a0c15a69f78c47dc8e0b9b3724b29608aa6619379f91b1ffa47109b5d0dd3"},
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},
   "makeup_elixir": {:hex, :makeup_elixir, "0.16.2", "627e84b8e8bf22e60a2579dad15067c755531fea049ae26ef1020cad58fe9578", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "41193978704763f6bbe6cc2758b84909e62984c7752b3784bd3c218bb341706b"},
   "makeup_erlang": {:hex, :makeup_erlang, "1.0.1", "c7f58c120b2b5aa5fd80d540a89fdf866ed42f1f3994e4fe189abebeab610839", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "8a89a1eeccc2d798d6ea15496a6e4870b75e014d1af514b1b71fa33134f57814"},
   "mime": {:hex, :mime, "2.0.6", "8f18486773d9b15f95f4f4f1e39b710045fa1de891fada4516559967276e4dc2", [:mix], [], "hexpm", "c9945363a6b26d747389aac3643f8e0e09d30499a138ad64fe8fd1d13d9b153e"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
-  "phoenix": {:hex, :phoenix, "1.7.14", "a7d0b3f1bc95987044ddada111e77bd7f75646a08518942c72a8440278ae7825", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "c7859bc56cc5dfef19ecfc240775dae358cbaa530231118a9e014df392ace61a"},
+  "phoenix": {:hex, :phoenix, "1.7.18", "5310c21443514be44ed93c422e15870aef254cf1b3619e4f91538e7529d2b2e4", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "1797fcc82108442a66f2c77a643a62980f342bfeb63d6c9a515ab8294870004e"},
   "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.2", "3b83b24ab5a2eb071a20372f740d7118767c272db386831b2e77638c4dcc606d", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "3f94d025f59de86be00f5f8c5dd7b5965a3298458d21ab1c328488be3b5fcd59"},
   "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
   "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
-  "phoenix_live_view": {:hex, :phoenix_live_view, "0.20.17", "f396bbdaf4ba227b82251eb75ac0afa6b3da5e509bc0d030206374237dfc9450", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a61d741ffb78c85fdbca0de084da6a48f8ceb5261a79165b5a0b59e5f65ce98b"},
+  "phoenix_live_view": {:hex, :phoenix_live_view, "1.0.1", "5389a30658176c0de816636ce276567478bffd063c082515a6e8368b8fc9a0db", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c0f517e6f290f10dbb94343ac22e0109437fb1fa6f0696e7c73967b789c1c285"},
   "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
   "plug": {:hex, :plug, "1.16.1", "40c74619c12f82736d2214557dedec2e9762029b2438d6d175c5074c933edc9d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a13ff6b9006b03d7e33874945b2755253841b238c34071ed85b0e86057f8cddc"},
   "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
   "postgrex": {:hex, :postgrex, "0.19.1", "73b498508b69aded53907fe48a1fee811be34cc720e69ef4ccd568c8715495ea", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "8bac7885a18f381e091ec6caf41bda7bb8c77912bb0e9285212829afe5d8a8f8"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
-  "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
+  "telemetry": {:hex, :telemetry, "1.3.0", "fedebbae410d715cf8e7062c96a1ef32ec22e764197f70cda73d82778d61e7a2", [:rebar3], [], "hexpm", "7015fc8919dbe63764f4b4b87a95b7c0996bd539e0d499be6ec9d7f3875b79e6"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
-  "websock_adapter": {:hex, :websock_adapter, "0.5.7", "65fa74042530064ef0570b75b43f5c49bb8b235d6515671b3d250022cb8a1f9e", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "d0f478ee64deddfec64b800673fd6e0c8888b079d9f3444dd96d2a98383bdbd1"},
+  "websock_adapter": {:hex, :websock_adapter, "0.5.8", "3b97dc94e407e2d1fc666b2fb9acf6be81a1798a2602294aac000260a7c4a47d", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "315b9a1865552212b5f35140ad194e67ce31af45bcee443d4ecb96b5fd3f3782"},
 }

From 2bbfe912446402c1be1a9e875d591699683aea72 Mon Sep 17 00:00:00 2001
From: Theodor Fiedler <tfiedlerdejanze@blvd.co>
Date: Mon, 17 Feb 2025 20:53:56 +0100
Subject: [PATCH 109/129] relax phoenix_live_view version constraint

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index 9806747..897dee4 100644
--- a/mix.exs
+++ b/mix.exs
@@ -52,7 +52,7 @@ defmodule PolymorphicEmbed.MixProject do
       {:attrs, "~> 0.6"},
       {:phoenix_html, "~> 4.1", optional: true},
       {:phoenix_html_helpers, "~> 1.0", optional: true},
-      {:phoenix_live_view, "~> 1.0.0", optional: true},
+      {:phoenix_live_view, "~> 0.20 or ~> 1.0", optional: true},
       {:ex_doc, "~> 0.34", only: :dev},
       {:ecto_sql, "~> 3.12", only: :test},
       {:postgrex, "~> 0.18 or ~> 0.19", only: :test},

From cf655e5c113ae79fb252db2d82e856c780941436 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Tue, 18 Feb 2025 13:24:11 +0800
Subject: [PATCH 110/129] Bump version to 5.0.1

---
 lib/polymorphic_embed.ex                   | 2 +-
 lib/polymorphic_embed/options_validator.ex | 2 +-
 mix.exs                                    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 85387f4..de27694 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -83,7 +83,7 @@ defmodule PolymorphicEmbed do
   def init(opts) do
     opts = Keyword.put_new(opts, :on_replace, nil)
     # opts = Keyword.put_new(opts, :type_field_name, :__type__)
-    # TODO remove in v5
+    # TODO remove in v6
     opts = Keyword.put_new(opts, :type_field_name, Keyword.get(opts, :type_field, :__type__))
     opts = Keyword.put_new(opts, :on_type_not_found, :changeset_error)
     opts = Keyword.put_new(opts, :nilify_unlisted_types_on_load, [])
diff --git a/lib/polymorphic_embed/options_validator.ex b/lib/polymorphic_embed/options_validator.ex
index 6777018..8ef81db 100644
--- a/lib/polymorphic_embed/options_validator.ex
+++ b/lib/polymorphic_embed/options_validator.ex
@@ -47,7 +47,7 @@ defmodule PolymorphicEmbed.OptionsValidator do
       end
     end
 
-    # TODO remove in v5
+    # TODO remove in v6
     if Keyword.has_key?(options, :type_field) do
       Logger.warning(
         "`:type_field` option is deprecated and must be replaced with `:type_field_name`."
diff --git a/mix.exs b/mix.exs
index 897dee4..052ba9e 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.0"
+  @version "5.0.1"
 
   def project do
     [

From a13ba900e6547ec3371ae752db6f55c2f69d908f Mon Sep 17 00:00:00 2001
From: Andrea Leopardi <an.leopardi@gmail.com>
Date: Tue, 18 Feb 2025 08:21:51 +0100
Subject: [PATCH 111/129] Make "mix test" completely quiet

---
 mix.exs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/mix.exs b/mix.exs
index 052ba9e..ee84c74 100644
--- a/mix.exs
+++ b/mix.exs
@@ -69,8 +69,12 @@ defmodule PolymorphicEmbed.MixProject do
     [
       test: [
         "ecto.create --quiet",
-        "ecto.rollback --all",
-        "ecto.migrate",
+        "ecto.rollback --all --quiet",
+        fn _args ->
+          :code.delete(PolymorphicEmbed.CreateTables)
+          :code.purge(PolymorphicEmbed.CreateTables)
+        end,
+        "ecto.migrate --quiet",
         "test"
       ]
     ]

From 222163f205c6c02dda2540a463b9d6e52035a5f1 Mon Sep 17 00:00:00 2001
From: Alex Naser <alex.naser@remote.com>
Date: Wed, 5 Mar 2025 15:23:49 +0100
Subject: [PATCH 112/129] Remove warning when aliases cannot be expanded

---
 lib/polymorphic_embed.ex | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index de27694..77a8226 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -3,7 +3,6 @@ defmodule PolymorphicEmbed do
 
   @type t() :: any()
 
-  require Logger
   require PolymorphicEmbed.OptionsValidator
 
   alias Ecto.Changeset
@@ -52,19 +51,7 @@ defmodule PolymorphicEmbed do
   # # ...
   #   polymorphic_embeds_one(:fallback_provider, types: @types)
   # which means we can't expand aliases
-  defp expand_alias(types, env) do
-    Logger.warning("""
-    Aliases could not be expanded for the given types in #{inspect(env.module)}.
-
-    This likely means the types are defined using a module attribute or another reference
-    that cannot be expanded at compile time. As a result, this may lead to unnecessary
-    compile-time dependencies, causing longer compilation times and unnecessary
-    re-compilation of modules (the parent defining the embedded types).
-
-    Ensure that the types are specified directly within the macro call to avoid these issues,
-    or refactor your code to eliminate references that cannot be expanded.
-    """)
-
+  defp expand_alias(types, _env) do
     types
   end
 

From 8e2163c6d8ab02a1be3e83dff746a3cdd332ea8e Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Thu, 6 Mar 2025 17:26:00 +0700
Subject: [PATCH 113/129] Bump version to 5.0.2

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index ee84c74..065db4e 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.1"
+  @version "5.0.2"
 
   def project do
     [

From d7f307b7459d4f356af3c97f947840dd14b0f495 Mon Sep 17 00:00:00 2001
From: Andrea Leopardi <an.leopardi@gmail.com>
Date: Thu, 6 Mar 2025 11:31:23 +0100
Subject: [PATCH 114/129] Update CHANGELOG

---
 CHANGELOG.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cef0fa2..bf62aa2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Changelog
 
+## 5.0.2
+
+  * Remove warning when aliases cannot be expanded (#123).
+
+## 5.0.1
+
+  * Relax `phoenix_live_view` constraint to allow 1.0.
+
 ## 5.0.x
 
   * Fix usage with Ecto 3.12. Require Ecto 3.12 or later

From 13f816a02300ffe5830152d06dde9073d134b138 Mon Sep 17 00:00:00 2001
From: Andrea Leopardi <an.leopardi@gmail.com>
Date: Mon, 10 Mar 2025 20:13:51 +0100
Subject: [PATCH 115/129] Update Elixir requirement to 1.13+

---
 .github/workflows/ci.yml | 1 +
 mix.exs                  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6ed6d59..9a4ccc4 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -25,6 +25,7 @@ jobs:
           - { elixir: 1.16, otp: 24 }
           - { elixir: 1.16, otp: 25 }
           - { elixir: 1.16, otp: 26 }
+          - { elixir: "1.18", otp: "27" }
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
diff --git a/mix.exs b/mix.exs
index 065db4e..b21c096 100644
--- a/mix.exs
+++ b/mix.exs
@@ -6,7 +6,7 @@ defmodule PolymorphicEmbed.MixProject do
   def project do
     [
       app: :polymorphic_embed,
-      elixir: "~> 1.9",
+      elixir: "~> 1.13",
       deps: deps(),
       aliases: aliases(),
       elixirc_paths: elixirc_paths(Mix.env()),

From 18a506dbb9f3ea2c17c203bb5791b252b120f9ba Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 30 Mar 2025 20:21:55 +0700
Subject: [PATCH 116/129] Bump version to 5.0.3

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index b21c096..a168346 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.2"
+  @version "5.0.3"
 
   def project do
     [

From d83658364eb218367a1a22a2b6f4366bf04c1707 Mon Sep 17 00:00:00 2001
From: Santiago Ferreira <san650@gmail.com>
Date: Wed, 3 Dec 2025 11:49:40 -0300
Subject: [PATCH 117/129] Remove :preferred_cli_env deprecation in Elixir v1.19

---
 mix.exs | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/mix.exs b/mix.exs
index a168346..6a35e56 100644
--- a/mix.exs
+++ b/mix.exs
@@ -28,14 +28,7 @@ defmodule PolymorphicEmbed.MixProject do
       ],
 
       # ExCoveralls
-      test_coverage: [tool: ExCoveralls],
-      preferred_cli_env: [
-        coveralls: :test,
-        "coveralls.detail": :test,
-        "coveralls.post": :test,
-        "coveralls.html": :test,
-        "coveralls.github": :test
-      ]
+      test_coverage: [tool: ExCoveralls]
     ]
   end
 
@@ -45,6 +38,18 @@ defmodule PolymorphicEmbed.MixProject do
     ]
   end
 
+  def cli do
+    [
+      preferred_envs: [
+        coveralls: :test,
+        "coveralls.detail": :test,
+        "coveralls.post": :test,
+        "coveralls.html": :test,
+        "coveralls.github": :test
+      ]
+    ]
+  end
+
   defp deps do
     [
       {:ecto, "~> 3.12"},

From 7a47ca99cb791c47a2ac019f71633991e654bf01 Mon Sep 17 00:00:00 2001
From: Santiago Ferreira <san650@gmail.com>
Date: Wed, 3 Dec 2025 11:50:07 -0300
Subject: [PATCH 118/129] Update credo from v1.0.1 to v1.1.1

---
 mix.lock | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mix.lock b/mix.lock
index 7a0929c..8657ccc 100644
--- a/mix.lock
+++ b/mix.lock
@@ -2,7 +2,7 @@
   "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.10", "43bbeeac820f16c89f79721af1b3e092399b3a1ecc8df1a472738fd853574911", [:mix], [], "hexpm", "1b0b7ea14d889d9ea21202c43a4fa015eb913021cb535e8ed91946f4b77a8848"},
-  "credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
+  "credo": {:hex, :credo, "1.7.14", "c7e75216cea8d978ba8c60ed9dede4cc79a1c99a266c34b3600dd2c33b96bc92", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "12a97d6bb98c277e4fb1dff45aaf5c137287416009d214fb46e68147bd9e0203"},
   "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
   "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
@@ -12,7 +12,7 @@
   "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
   "ex_doc": {:hex, :ex_doc, "0.34.2", "13eedf3844ccdce25cfd837b99bea9ad92c4e511233199440488d217c92571e8", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "5ce5f16b41208a50106afed3de6a2ed34f4acfd65715b82a0b84b49d995f95c1"},
   "excoveralls": {:hex, :excoveralls, "0.18.2", "86efd87a0676a3198ff50b8c77620ea2f445e7d414afa9ec6c4ba84c9f8bdcc2", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "230262c418f0de64077626a498bd4fdf1126d5c2559bb0e6b43deac3005225a4"},
-  "file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
+  "file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
   "floki": {:hex, :floki, "0.37.0", "b83e0280bbc6372f2a403b2848013650b16640cd2470aea6701f0632223d719e", [:mix], [], "hexpm", "516a0c15a69f78c47dc8e0b9b3724b29608aa6619379f91b1ffa47109b5d0dd3"},
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},

From 78828fa536f7a076594198e51d8e05a645420662 Mon Sep 17 00:00:00 2001
From: Santiago Ferreira <san650@gmail.com>
Date: Wed, 3 Dec 2025 12:52:14 -0300
Subject: [PATCH 119/129] Add elixir 1.19 to CI matrix

---
 .github/workflows/ci.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9a4ccc4..1ac2f2d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -25,7 +25,8 @@ jobs:
           - { elixir: 1.16, otp: 24 }
           - { elixir: 1.16, otp: 25 }
           - { elixir: 1.16, otp: 26 }
-          - { elixir: "1.18", otp: "27" }
+          - { elixir: 1.18, otp: 27 }
+          - { elixir: 1.19, otp: 27 }
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

From bde243b7813ee27129ac4e1a658450ec9bf1e439 Mon Sep 17 00:00:00 2001
From: Zack Siri <me@zacksiri.com>
Date: Thu, 18 Dec 2025 22:47:44 +0700
Subject: [PATCH 120/129] Fix CondClauseError when using
 use_parent_field_for_type with matching types

When using `use_parent_field_for_type` option in `polymorphic_embeds_one`,
the `action_and_struct/4` function's cond block was missing a clause to
handle the case when both `type_from_parent_field` and `type_from_map`
are present and match.

The existing cond only handled:
1. type_from_parent_field is nil -> :type_not_found
2. type_from_map is nil -> get module and return action/struct
3. types don't match -> raise error

This caused a CondClauseError when form params included the `__type__`
field matching the parent field type (e.g., during form validation).

Added a `true` clause to handle the matching types case, which behaves
the same as when type_from_map is nil - it uses the parent field type
to determine the module and returns the appropriate action/struct tuple.
---
 lib/polymorphic_embed.ex | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 77a8226..47e8ad9 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -360,6 +360,16 @@ defmodule PolymorphicEmbed do
 
         to_string(type_from_parent_field) != to_string(type_from_map) ->
           raise "type specified in the parent field \"#{type_from_parent_field}\" does not match the type in the embedded map \"#{type_from_map}\""
+
+        true ->
+          # type_from_parent_field and type_from_map match
+          module = get_polymorphic_module_for_type(type_from_parent_field, types_metadata)
+
+          if is_nil(data_for_field) or data_for_field.__struct__ != module do
+            {:insert, struct(module)}
+          else
+            {:update, data_for_field}
+          end
       end
     else
       case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do

From f39df200091bfb4e3f91b6541d9f93bc54bb9813 Mon Sep 17 00:00:00 2001
From: Zack Siri <me@zacksiri.com>
Date: Thu, 18 Dec 2025 22:48:01 +0700
Subject: [PATCH 121/129] Add test case

---
 test/polymorphic_embed_test.exs | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 7dced00..fd8a19e 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -199,6 +199,35 @@ defmodule PolymorphicEmbedTest do
     assert {:error, %Ecto.Changeset{}} = insert_result
   end
 
+  test "infer type from parent field when type in embed map matches parent field type" do
+    generator = :polymorphic
+    reminder_module = get_module(Reminder, generator)
+
+    # Both parent field type and embed __type__ are "sms" - they match
+    sms_reminder_attrs = %{
+      date: ~U[2020-05-28 02:57:19Z],
+      text: "This is an SMS reminder #{generator}",
+      type: "sms",
+      channel4: %{
+        __type__: "sms",
+        number: "02/807.05.53",
+        country_code: 1,
+        provider: %{
+          __type__: "twilio",
+          api_key: "foo"
+        }
+      }
+    }
+
+    insert_result =
+      struct(reminder_module)
+      |> reminder_module.changeset(sms_reminder_attrs)
+      |> Repo.insert()
+
+    assert {:ok, %{channel4: %PolymorphicEmbed.Channel.SMS{number: "02/807.05.53"}}} =
+             insert_result
+  end
+
   test "validations before casting polymorphic embed still work" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)

From e7bf5f09a94be5c718ca48b7f0923300a9077c48 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 21 Dec 2025 19:54:25 +0700
Subject: [PATCH 122/129] Bump version to 5.0.4

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index a168346..c2b9bd4 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.3"
+  @version "5.0.4"
 
   def project do
     [

From 875d948579d117b6fe26aac88119d99476bcad91 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 21 Dec 2025 19:55:16 +0700
Subject: [PATCH 123/129] Bump version to 5.0.5

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index c2b9bd4..0344d02 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.4"
+  @version "5.0.5"
 
   def project do
     [

From 2eefcfd5c96ee7a8e3f7c19d1831888184594236 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Sun, 21 Dec 2025 19:58:55 +0700
Subject: [PATCH 124/129] Update credo

---
 mix.lock | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mix.lock b/mix.lock
index 7a0929c..8657ccc 100644
--- a/mix.lock
+++ b/mix.lock
@@ -2,7 +2,7 @@
   "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.10", "43bbeeac820f16c89f79721af1b3e092399b3a1ecc8df1a472738fd853574911", [:mix], [], "hexpm", "1b0b7ea14d889d9ea21202c43a4fa015eb913021cb535e8ed91946f4b77a8848"},
-  "credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
+  "credo": {:hex, :credo, "1.7.14", "c7e75216cea8d978ba8c60ed9dede4cc79a1c99a266c34b3600dd2c33b96bc92", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "12a97d6bb98c277e4fb1dff45aaf5c137287416009d214fb46e68147bd9e0203"},
   "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
   "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
@@ -12,7 +12,7 @@
   "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
   "ex_doc": {:hex, :ex_doc, "0.34.2", "13eedf3844ccdce25cfd837b99bea9ad92c4e511233199440488d217c92571e8", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "5ce5f16b41208a50106afed3de6a2ed34f4acfd65715b82a0b84b49d995f95c1"},
   "excoveralls": {:hex, :excoveralls, "0.18.2", "86efd87a0676a3198ff50b8c77620ea2f445e7d414afa9ec6c4ba84c9f8bdcc2", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "230262c418f0de64077626a498bd4fdf1126d5c2559bb0e6b43deac3005225a4"},
-  "file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
+  "file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
   "floki": {:hex, :floki, "0.37.0", "b83e0280bbc6372f2a403b2848013650b16640cd2470aea6701f0632223d719e", [:mix], [], "hexpm", "516a0c15a69f78c47dc8e0b9b3724b29608aa6619379f91b1ffa47109b5d0dd3"},
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},

From ebe5ef0a22737e3b000ea256383255c9591cfa49 Mon Sep 17 00:00:00 2001
From: woylie <13847569+woylie@users.noreply.github.com>
Date: Tue, 6 Jan 2026 14:04:01 +0100
Subject: [PATCH 125/129] fix warning

---
 lib/polymorphic_embed/html/helpers.ex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/polymorphic_embed/html/helpers.ex b/lib/polymorphic_embed/html/helpers.ex
index 7822d46..a809fb2 100644
--- a/lib/polymorphic_embed/html/helpers.ex
+++ b/lib/polymorphic_embed/html/helpers.ex
@@ -73,7 +73,8 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
       |> Enum.map(fn {data, i} ->
         params = Enum.at(params, i) || %{}
 
-        changeset =
+        %Ecto.Changeset{} =
+          changeset =
           data
           |> Ecto.Changeset.change()
           |> apply_action(parent_action)

From 2c7b9d47bcd84bd5745fe1d97a900e6d991b37f3 Mon Sep 17 00:00:00 2001
From: Mathieu Decaffmeyer <5883963+mathieuprog@users.noreply.github.com>
Date: Tue, 6 Jan 2026 20:15:08 +0700
Subject: [PATCH 126/129] Bump version to 5.0.6

---
 mix.exs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mix.exs b/mix.exs
index 59d8a55..942dc1b 100644
--- a/mix.exs
+++ b/mix.exs
@@ -1,7 +1,7 @@
 defmodule PolymorphicEmbed.MixProject do
   use Mix.Project
 
-  @version "5.0.5"
+  @version "5.0.6"
 
   def project do
     [

From de0f6cb7bdb75ceeb64593196e92928c1d63026f Mon Sep 17 00:00:00 2001
From: Majd Sehwail <56893463+MajdSehwail@users.noreply.github.com>
Date: Tue, 4 Aug 2026 13:26:10 +0300
Subject: [PATCH 127/129] Add the traverse_errors/4 hook for parameterized
 types

- traverse_errors/2 collects errors from any parameterized type that defines traverse_errors/4.
- This is a fork-specific change with no upstream equivalent.
---
 lib/polymorphic_embed.ex        | 16 +++++++++
 test/polymorphic_embed_test.exs | 57 +++++++++++++++++++++++++++++++++
 2 files changed, 73 insertions(+)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index 47e8ad9..d67882b 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -712,6 +712,22 @@ defmodule PolymorphicEmbed do
     end
   end
 
+  # Userpilot fork extension: any other parameterized type may take part in
+  # error traversal by exporting traverse_errors/4 (field, changes, msg_func, acc).
+  defp polymorphic_key_reducer(
+         {field, {:parameterized, {module, _opts}}},
+         acc,
+         changes,
+         msg_func
+       )
+       when module != PolymorphicEmbed do
+    if function_exported?(module, :traverse_errors, 4) do
+      module.traverse_errors(field, changes, msg_func, acc)
+    else
+      acc
+    end
+  end
+
   defp polymorphic_key_reducer(
          {field, {rel, %{cardinality: :many}}},
          acc,
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index ba50279..4194188 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -1,3 +1,46 @@
+defmodule PolymorphicEmbedTest.CustomParameterizedType do
+  use Ecto.ParameterizedType
+
+  @impl true
+  def type(_params), do: :map
+
+  @impl true
+  def init(opts), do: Enum.into(opts, %{})
+
+  @impl true
+  def cast(data, _params), do: {:ok, data}
+
+  @impl true
+  def load(data, _loader, _params), do: {:ok, data}
+
+  @impl true
+  def dump(data, _dumper, _params), do: {:ok, data}
+
+  def traverse_errors(field, changes, _msg_func, acc) do
+    if Map.has_key?(changes, field) do
+      Map.put(acc, field, ["custom traversal"])
+    else
+      acc
+    end
+  end
+end
+
+defmodule PolymorphicEmbedTest.SchemaWithCustomParameterizedType do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  embedded_schema do
+    field(:name, :string)
+    field(:settings, PolymorphicEmbedTest.CustomParameterizedType)
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, [:name, :settings])
+    |> validate_required(:name)
+  end
+end
+
 defmodule PolymorphicEmbedTest do
   use ExUnit.Case
 
@@ -299,6 +342,20 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "traverse_errors delegates to traverse_errors/4 of other parameterized types" do
+    changeset =
+      PolymorphicEmbedTest.SchemaWithCustomParameterizedType.changeset(
+        %PolymorphicEmbedTest.SchemaWithCustomParameterizedType{},
+        %{"settings" => %{"foo" => "bar"}}
+      )
+
+    refute changeset.valid?
+
+    errors = PolymorphicEmbed.traverse_errors(changeset, fn {msg, _opts} -> msg end)
+
+    assert %{name: ["can't be blank"], settings: ["custom traversal"]} == errors
+  end
+
   test "traverse_errors" do
     for generator <- @generators do
       reminder_module = get_module(Reminder, generator)

From 64bffc2aed42d6607238caebb7c7b69e86e835ab Mon Sep 17 00:00:00 2001
From: Majd Sehwail <56893463+MajdSehwail@users.noreply.github.com>
Date: Tue, 4 Aug 2026 13:26:10 +0300
Subject: [PATCH 128/129] Add a guard for wrong-shaped cast params

- cast_polymorphic_embed adds an "is invalid" changeset error for params with an invalid shape, instead of raising.
- This is a fork-specific change with no upstream equivalent.
---
 lib/polymorphic_embed.ex        | 73 +++++++++++++++++++--------------
 test/polymorphic_embed_test.exs | 29 +++++++++++++
 2 files changed, 71 insertions(+), 31 deletions(-)

diff --git a/lib/polymorphic_embed.ex b/lib/polymorphic_embed.ex
index d67882b..9952a27 100644
--- a/lib/polymorphic_embed.ex
+++ b/lib/polymorphic_embed.ex
@@ -175,7 +175,8 @@ defmodule PolymorphicEmbed do
       {:ok, map} when map == %{} and not array? ->
         changeset
 
-      {:ok, params_for_field} when array? ->
+      {:ok, params_for_field}
+      when array? and (is_map(params_for_field) or is_list(params_for_field)) ->
         create_sort_default = fn -> sort_create(Enum.into(cast_opts, %{}), field_opts) end
         params_for_field = apply_sort_drop(params_for_field, sort, drop, create_sort_default)
 
@@ -195,6 +196,11 @@ defmodule PolymorphicEmbed do
           params_for_field,
           field_opts
         )
+
+      # Params of the wrong shape (a scalar, a list for a single embed, a
+      # scalar for a list of embeds) are a client error, never a crash.
+      {:ok, _params_for_field} ->
+        Ecto.Changeset.add_error(changeset, field, "is invalid")
     end
   end
 
@@ -403,36 +409,41 @@ defmodule PolymorphicEmbed do
     list_data_for_field = Map.fetch!(changeset.data, field) || []
 
     embeds =
-      Enum.map(list_params, fn params ->
-        case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
-          nil when on_type_not_found == :raise ->
-            raise_cannot_infer_type_from_data(params)
-
-          nil when on_type_not_found == :changeset_error ->
-            :error
-
-          nil when on_type_not_found == :ignore ->
-            :ignore
-
-          module ->
-            data_for_field =
-              Enum.find(list_data_for_field, fn
-                %{id: id} = datum when not is_nil(id) ->
-                  id == params[:id] and datum.__struct__ == module
-
-                _ ->
-                  nil
-              end)
-
-            embed_changeset =
-              if data_for_field do
-                %{changeset_fun.(data_for_field, params) | action: :update}
-              else
-                %{changeset_fun.(struct(module), params) | action: :insert}
-              end
-
-            maybe_apply_changes(embed_changeset)
-        end
+      Enum.map(list_params, fn
+        # A non-map element cannot carry a type or fields; reject the list.
+        params when not is_map(params) ->
+          :error
+
+        params ->
+          case get_polymorphic_module_from_map(params, type_field_name, types_metadata) do
+            nil when on_type_not_found == :raise ->
+              raise_cannot_infer_type_from_data(params)
+
+            nil when on_type_not_found == :changeset_error ->
+              :error
+
+            nil when on_type_not_found == :ignore ->
+              :ignore
+
+            module ->
+              data_for_field =
+                Enum.find(list_data_for_field, fn
+                  %{id: id} = datum when not is_nil(id) ->
+                    id == params[:id] and datum.__struct__ == module
+
+                  _ ->
+                    nil
+                end)
+
+              embed_changeset =
+                if data_for_field do
+                  %{changeset_fun.(data_for_field, params) | action: :update}
+                else
+                  %{changeset_fun.(struct(module), params) | action: :insert}
+                end
+
+              maybe_apply_changes(embed_changeset)
+          end
       end)
 
     if Enum.any?(embeds, &(&1 == :error)) do
diff --git a/test/polymorphic_embed_test.exs b/test/polymorphic_embed_test.exs
index 4194188..488eb9a 100644
--- a/test/polymorphic_embed_test.exs
+++ b/test/polymorphic_embed_test.exs
@@ -342,6 +342,35 @@ defmodule PolymorphicEmbedTest do
     end
   end
 
+  test "wrong-shaped embed params produce a changeset error" do
+    for generator <- @generators do
+      reminder_module = get_module(Reminder, generator)
+
+      base_attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an SMS reminder"
+      }
+
+      wrong_shapes = [
+        channel: "sms",
+        channel: 5,
+        channel: ["sms"],
+        contexts: "device",
+        contexts: %{"my_type_field" => "device"},
+        contexts: ["device"]
+      ]
+
+      for {field, params} <- wrong_shapes do
+        changeset =
+          struct(reminder_module)
+          |> reminder_module.changeset(Map.put(base_attrs, field, params))
+
+        refute changeset.valid?
+        assert {"is invalid", _} = changeset.errors[field]
+      end
+    end
+  end
+
   test "traverse_errors delegates to traverse_errors/4 of other parameterized types" do
     changeset =
       PolymorphicEmbedTest.SchemaWithCustomParameterizedType.changeset(

From 83ff505fed691331025263ffb132ce9e6f2fbbb0 Mon Sep 17 00:00:00 2001
From: Majd Sehwail <56893463+MajdSehwail@users.noreply.github.com>
Date: Tue, 4 Aug 2026 14:39:43 +0300
Subject: [PATCH 129/129] Update locked dependencies to pass the Hex audit

- Update phoenix, plug, and postgrex to versions without known advisories.
- Ignore the decimal advisory CVE-2026-32686. The fix exists only in
  decimal 3.x, and ecto 3.12 requires decimal 2.x. The exposure is
  test-only for this library.
---
 mix.exs  |  5 +++++
 mix.lock | 26 +++++++++++++-------------
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/mix.exs b/mix.exs
index 942dc1b..a177994 100644
--- a/mix.exs
+++ b/mix.exs
@@ -15,6 +15,11 @@ defmodule PolymorphicEmbed.MixProject do
       version: @version,
       package: package(),
       description: "Polymorphic embeds in Ecto",
+      hex: [
+        # The fix for this decimal advisory is only released in decimal 3.x,
+        # and ecto 3.12 requires decimal ~> 2.0. Test-only exposure here.
+        ignore_advisories: ["CVE-2026-32686"]
+      ],
 
       # ExDoc
       name: "Polymorphic Embed",
diff --git a/mix.lock b/mix.lock
index 8657ccc..25d36cb 100644
--- a/mix.lock
+++ b/mix.lock
@@ -1,10 +1,10 @@
 %{
   "attrs": {:hex, :attrs, "0.6.0", "25d738b47829f964a786ef73897d2550b66f3e7d1d7c49a83bc8fd81c71bed93", [:mix], [], "hexpm", "9c30ac15255c2ba8399263db55ba32c2f4e5ec267b654ce23df99168b405c82e"},
   "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
-  "castore": {:hex, :castore, "1.0.10", "43bbeeac820f16c89f79721af1b3e092399b3a1ecc8df1a472738fd853574911", [:mix], [], "hexpm", "1b0b7ea14d889d9ea21202c43a4fa015eb913021cb535e8ed91946f4b77a8848"},
+  "castore": {:hex, :castore, "1.0.20", "455e48f7115eca98c9f2b0e7a152b5a2e8f2a8a4f964c96e95bd31645ee5fa59", [:mix], [], "hexpm", "940eafbfd8b14bee649f083bc11b3b54ec555b54c3e4ea8213351ff6fee39c10"},
   "credo": {:hex, :credo, "1.7.14", "c7e75216cea8d978ba8c60ed9dede4cc79a1c99a266c34b3600dd2c33b96bc92", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "12a97d6bb98c277e4fb1dff45aaf5c137287416009d214fb46e68147bd9e0203"},
-  "db_connection": {:hex, :db_connection, "2.7.0", "b99faa9291bb09892c7da373bb82cba59aefa9b36300f6145c5f201c7adf48ec", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "dcf08f31b2701f857dfc787fbad78223d61a32204f217f15e881dd93e4bdd3ff"},
-  "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
+  "db_connection": {:hex, :db_connection, "2.10.2", "ae391e803a5adff104da913c2fc1c0c14a37f8b10001dcef568796e1fb7bf95c", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "510b14482330f1af6490a2fa0efd8d4f1435d1529b165647df22ac0f2df0fa93"},
+  "decimal": {:hex, :decimal, "2.4.1", "6c0fbede12fb122ba685e9ab41c6a40c129e322b3aa192f9e072e61f3a6ffaf2", [:mix], [], "hexpm", "7e618897933a8455f19a727d7c5e50a2c071a544b700e5e724298ecb4340187f"},
   "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.41", "ab34711c9dc6212dda44fcd20ecb87ac3f3fce6f0ca2f28d4a00e4154f8cd599", [:mix], [], "hexpm", "a81a04c7e34b6617c2792e291b5a2e57ab316365c2644ddc553bb9ed863ebefa"},
   "ecto": {:hex, :ecto, "3.12.1", "626765f7066589de6fa09e0876a253ff60c3d00870dd3a1cd696e2ba67bfceea", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "df0045ab9d87be947228e05a8d153f3e06e0d05ab10c3b3cc557d2f7243d1940"},
@@ -14,24 +14,24 @@
   "excoveralls": {:hex, :excoveralls, "0.18.2", "86efd87a0676a3198ff50b8c77620ea2f445e7d414afa9ec6c4ba84c9f8bdcc2", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "230262c418f0de64077626a498bd4fdf1126d5c2559bb0e6b43deac3005225a4"},
   "file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
   "floki": {:hex, :floki, "0.37.0", "b83e0280bbc6372f2a403b2848013650b16640cd2470aea6701f0632223d719e", [:mix], [], "hexpm", "516a0c15a69f78c47dc8e0b9b3724b29608aa6619379f91b1ffa47109b5d0dd3"},
-  "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
+  "jason": {:hex, :jason, "1.4.5", "2e3a008590b0b8d7388c20293e9dcc9cf3e5d642fd2a114e4cbbb52e595d940a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "b0c823996102bcd0239b3c2444eb00409b72f6a140c1950bc8b457d836b30684"},
   "makeup": {:hex, :makeup, "1.1.2", "9ba8837913bdf757787e71c1581c21f9d2455f4dd04cfca785c70bbfff1a76a3", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cce1566b81fbcbd21eca8ffe808f33b221f9eee2cbc7a1706fc3da9ff18e6cac"},
   "makeup_elixir": {:hex, :makeup_elixir, "0.16.2", "627e84b8e8bf22e60a2579dad15067c755531fea049ae26ef1020cad58fe9578", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "41193978704763f6bbe6cc2758b84909e62984c7752b3784bd3c218bb341706b"},
   "makeup_erlang": {:hex, :makeup_erlang, "1.0.1", "c7f58c120b2b5aa5fd80d540a89fdf866ed42f1f3994e4fe189abebeab610839", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "8a89a1eeccc2d798d6ea15496a6e4870b75e014d1af514b1b71fa33134f57814"},
-  "mime": {:hex, :mime, "2.0.6", "8f18486773d9b15f95f4f4f1e39b710045fa1de891fada4516559967276e4dc2", [:mix], [], "hexpm", "c9945363a6b26d747389aac3643f8e0e09d30499a138ad64fe8fd1d13d9b153e"},
+  "mime": {:hex, :mime, "2.0.7", "b8d739037be7cd402aee1ba0306edfdef982687ee7e9859bee6198c1e7e2f128", [:mix], [], "hexpm", "6171188e399ee16023ffc5b76ce445eb6d9672e2e241d2df6050f3c771e80ccd"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
-  "phoenix": {:hex, :phoenix, "1.7.18", "5310c21443514be44ed93c422e15870aef254cf1b3619e4f91538e7529d2b2e4", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "1797fcc82108442a66f2c77a643a62980f342bfeb63d6c9a515ab8294870004e"},
+  "phoenix": {:hex, :phoenix, "1.7.24", "4cb76aed6d3f03878893769020e97c4394ee95b62b2b2d6313c20f66d7d37baa", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "a283a9d91517116166244fdd8ed8b405c142774dc39b4a4047d179cecca9c09f"},
   "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.2", "3b83b24ab5a2eb071a20372f740d7118767c272db386831b2e77638c4dcc606d", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "3f94d025f59de86be00f5f8c5dd7b5965a3298458d21ab1c328488be3b5fcd59"},
-  "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
+  "phoenix_html": {:hex, :phoenix_html, "4.3.0", "d3577a5df4b6954cd7890c84d955c470b5310bb49647f0a114a6eeecc850f7ad", [:mix], [], "hexpm", "3eaa290a78bab0f075f791a46a981bbe769d94bc776869f4f3063a14f30497ad"},
   "phoenix_html_helpers": {:hex, :phoenix_html_helpers, "1.0.1", "7eed85c52eff80a179391036931791ee5d2f713d76a81d0d2c6ebafe1e11e5ec", [:mix], [{:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.5", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cffd2385d1fa4f78b04432df69ab8da63dc5cf63e07b713a4dcf36a3740e3090"},
   "phoenix_live_view": {:hex, :phoenix_live_view, "1.0.1", "5389a30658176c0de816636ce276567478bffd063c082515a6e8368b8fc9a0db", [:mix], [{:floki, "~> 0.36", [hex: :floki, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.6.15 or ~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 3.3 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c0f517e6f290f10dbb94343ac22e0109437fb1fa6f0696e7c73967b789c1c285"},
-  "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.1.3", "3168d78ba41835aecad272d5e8cd51aa87a7ac9eb836eabc42f6e57538e3731d", [:mix], [], "hexpm", "bba06bc1dcfd8cb086759f0edc94a8ba2bc8896d5331a1e2c2902bf8e36ee502"},
+  "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.2.0", "ff3a5616e1bed6804de7773b92cbccfc0b0f473faf1f63d7daf1206c7aeaaa6f", [:mix], [], "hexpm", "adc313a5bf7136039f63cfd9668fde73bba0765e0614cba80c06ac9460ff3e96"},
   "phoenix_template": {:hex, :phoenix_template, "1.0.4", "e2092c132f3b5e5b2d49c96695342eb36d0ed514c5b252a77048d5969330d639", [:mix], [{:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: true]}], "hexpm", "2c0c81f0e5c6753faf5cca2f229c9709919aba34fab866d3bc05060c9c444206"},
-  "plug": {:hex, :plug, "1.16.1", "40c74619c12f82736d2214557dedec2e9762029b2438d6d175c5074c933edc9d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "a13ff6b9006b03d7e33874945b2755253841b238c34071ed85b0e86057f8cddc"},
-  "plug_crypto": {:hex, :plug_crypto, "2.1.0", "f44309c2b06d249c27c8d3f65cfe08158ade08418cf540fd4f72d4d6863abb7b", [:mix], [], "hexpm", "131216a4b030b8f8ce0f26038bc4421ae60e4bb95c5cf5395e1421437824c4fa"},
-  "postgrex": {:hex, :postgrex, "0.19.1", "73b498508b69aded53907fe48a1fee811be34cc720e69ef4ccd568c8715495ea", [:mix], [{:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "8bac7885a18f381e091ec6caf41bda7bb8c77912bb0e9285212829afe5d8a8f8"},
+  "plug": {:hex, :plug, "1.20.3", "56c480c633ec2ce10140e236e15233bf576e1d323887d7c96711bd02ab5160db", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "be266aee1b8536ef6409d58cf39a3121319f0ec47cfa1b24024485aa0e76ad76"},
+  "plug_crypto": {:hex, :plug_crypto, "2.2.0", "144014737daaf485407f5ed77daeaad74d651b216a28c87543f8cc7043f8efc8", [:mix], [], "hexpm", "83a95744ab1c75876542b6fab135fcc176280e0f301a111c1f757fddcec95d2c"},
+  "postgrex": {:hex, :postgrex, "0.22.3", "bf65941737ee7a9adbe4a64c91080310d11703da343e8ac9188aacb9eb9f6f02", [:mix], [{:db_connection, "~> 2.9", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "f018c13752b2b46e8d35d7e2d84c3276557cbfd880769109021a1d0ee36c1cfe"},
   "query_builder": {:hex, :query_builder, "1.4.2", "5a61c63e5ea7093d110589aacf081362e2fe8ae0188644732edd02b1230a7be5", [:mix], [{:ecto, "~> 3.10", [hex: :ecto, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "abffaf756a5fdfd37bd594455e00083649a4f01e436279865592ccb8115dd739"},
-  "telemetry": {:hex, :telemetry, "1.3.0", "fedebbae410d715cf8e7062c96a1ef32ec22e764197f70cda73d82778d61e7a2", [:rebar3], [], "hexpm", "7015fc8919dbe63764f4b4b87a95b7c0996bd539e0d499be6ec9d7f3875b79e6"},
+  "telemetry": {:hex, :telemetry, "1.4.2", "a0cb522801dffb1c49fe6e30561badffc7b6d0e180db1300df759faa22062855", [:rebar3], [], "hexpm", "928f6495066506077862c0d1646609eed891a4326bee3126ba54b60af61febb1"},
   "websock": {:hex, :websock, "0.5.3", "2f69a6ebe810328555b6fe5c831a851f485e303a7c8ce6c5f675abeb20ebdadc", [:mix], [], "hexpm", "6105453d7fac22c712ad66fab1d45abdf049868f253cf719b625151460b8b453"},
-  "websock_adapter": {:hex, :websock_adapter, "0.5.8", "3b97dc94e407e2d1fc666b2fb9acf6be81a1798a2602294aac000260a7c4a47d", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "315b9a1865552212b5f35140ad194e67ce31af45bcee443d4ecb96b5fd3f3782"},
+  "websock_adapter": {:hex, :websock_adapter, "0.5.9", "43dc3ba6d89ef5dec5b1d0a39698436a1e856d000d84bf31a3149862b01a287f", [:mix], [{:bandit, ">= 0.6.0", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.6", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "5534d5c9adad3c18a0f58a9371220d75a803bf0b9a3d87e6fe072faaeed76a08"},
 }