From bc68342b81cfb4517356aee17d5d4d77326086f7 Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Tue, 14 Jul 2026 12:19:48 +0200 Subject: [PATCH 1/3] docs(ui5-toolbar): clarify default slot accepts any component via ToolbarItem --- packages/main/src/Toolbar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/Toolbar.ts b/packages/main/src/Toolbar.ts index e631640780dc8..e5e2ce5b401a4 100644 --- a/packages/main/src/Toolbar.ts +++ b/packages/main/src/Toolbar.ts @@ -160,7 +160,7 @@ class Toolbar extends UI5Element { /** * Defines the items of the component. * - * **Note:** Currently only `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` are allowed here. + * **Note:** Use `ToolbarButton`, `ToolbarSelect`, `ToolbarSeparator` and `ToolbarSpacer` for the most common toolbar actions. To place any other UI5 Web Component into the toolbar and have it participate in overflow handling, wrap it in a `ToolbarItem`. * @public */ @slot({ From cd4acce4a7c4b6c37152faf4a43dd8771e862326 Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Tue, 14 Jul 2026 12:22:11 +0200 Subject: [PATCH 2/3] use custom element names instead of module names --- packages/main/src/Toolbar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/Toolbar.ts b/packages/main/src/Toolbar.ts index e5e2ce5b401a4..f9c0a4764a158 100644 --- a/packages/main/src/Toolbar.ts +++ b/packages/main/src/Toolbar.ts @@ -160,7 +160,7 @@ class Toolbar extends UI5Element { /** * Defines the items of the component. * - * **Note:** Use `ToolbarButton`, `ToolbarSelect`, `ToolbarSeparator` and `ToolbarSpacer` for the most common toolbar actions. To place any other UI5 Web Component into the toolbar and have it participate in overflow handling, wrap it in a `ToolbarItem`. + * **Note:** **Note:** Use `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` for the most common toolbar actions. To place any other UI5 Web Component into the toolbar and have it participate in overflow handling, wrap it in a `ui5-toolbar-item`. * @public */ @slot({ From 41e5d6b9a04ef23153b84471d13dd18dde0a9cef Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Tue, 14 Jul 2026 12:31:14 +0200 Subject: [PATCH 3/3] remove duplicate Note --- packages/main/src/Toolbar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/Toolbar.ts b/packages/main/src/Toolbar.ts index f9c0a4764a158..d4b210f9bd843 100644 --- a/packages/main/src/Toolbar.ts +++ b/packages/main/src/Toolbar.ts @@ -160,7 +160,7 @@ class Toolbar extends UI5Element { /** * Defines the items of the component. * - * **Note:** **Note:** Use `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` for the most common toolbar actions. To place any other UI5 Web Component into the toolbar and have it participate in overflow handling, wrap it in a `ui5-toolbar-item`. + * **Note:** Use `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` for the most common toolbar actions. To place any other UI5 Web Component into the toolbar and have it participate in overflow handling, wrap it in a `ui5-toolbar-item`. * @public */ @slot({