Skip to content

Remove std::atomic_ref polyfill from v8config.h when NDK supports it #2

Description

@Towartz

NDK r27c's libc++ lacks std::atomic_ref on Android. We added a polyfill in deps/v8/include/v8config.h using __atomic_* GCC/Clang builtins (guard: !defined(__cpp_lib_atomic_ref)).

When NDK is upgraded to a version that defines __cpp_lib_atomic_ref for Android, this polyfill becomes dead code and should be removed.

Check: grep -r __cpp_lib_atomic_ref $NDK/sources/cxx-stl/llvm-libc++

See commit 29d285a for the polyfill block.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions