PR_26172_CHARLIE_040-controls-game-journey-api-client-resolution

Author: ToolboxAid

account/user-controls-page.js

@@ -1,4 +1,4 @@
-import { createControlsToolApiRepository } from "../toolbox/controls/controls-api-client.js";
+import { createControlsToolApiRepository } from "../assets/js/shared/controls-api-client.js";
 import { getSessionCurrent } from "../src/api/session-api-client.js";
 import InputService from "../src/engine/input/InputService.js";
 import InputCaptureService from "../src/engine/input/InputCaptureService.js";

toolbox/controls/controls-api-client.js assets/js/shared/controls-api-client.jstoolbox/controls/controls-api-client.js renamed to assets/js/shared/controls-api-client.js

@@ -2,7 +2,7 @@ import {
   createServerRepositoryClient,
   readServerToolConstants,
   requireServerConstant,
-} from "../../src/api/server-api-client.js";
+} from "../../../src/api/server-api-client.js";
 
 const constants = readServerToolConstants("controls");
 

…/game-journey/game-journey-api-client.js …ets/js/shared/game-journey-api-client.jstoolbox/game-journey/game-journey-api-client.js renamed to assets/js/shared/game-journey-api-client.js toolbox/game-journey/game-journey-api-client.js renamed to assets/js/shared/game-journey-api-client.js

@@ -2,11 +2,11 @@ import {
   createServerRepositoryClient,
   readServerToolConstants,
   requireServerConstant,
-} from "../../src/api/server-api-client.js";
+} from "../../../src/api/server-api-client.js";
 export {
   readGameJourneyCompletionMetrics,
   updateGameJourneyCompletionMetric,
-} from "../../src/api/game-journey-completion-api-client.js";
+} from "../../../src/api/game-journey-completion-api-client.js";
 
 const constants = readServerToolConstants("game-journey");
 

assets/toolbox/controls/js/index.js

@@ -5,7 +5,7 @@ import {
   GAME_CONTROL_NORMALIZED_INPUTS,
   NORMALIZED_USAGE_LABELS,
   createControlsToolApiRepository,
-} from "../../../../toolbox/controls/controls-api-client.js";
+} from "../../../js/shared/controls-api-client.js";
 import {
   normalizeNormalizedInput,
   normalizedInputOptions,

assets/toolbox/game-journey/js/index.js

@@ -6,7 +6,7 @@ import {
   GAME_JOURNEY_SUGGESTED_TOOLS,
   createGameJourneyApiRepository,
   readGameJourneyCompletionMetrics,
-} from "../../../../toolbox/game-journey/game-journey-api-client.js";
+} from "../../../js/shared/game-journey-api-client.js";
 import {
   getActiveToolRegistry,
   getToolRegistryApiDiagnostic,

docs_build/dev/reports/PR_26172_CHARLIE_040-controls-game-journey-api-client-resolution.md

@@ -0,0 +1,111 @@
+# PR_26172_CHARLIE_040-controls-game-journey-api-client-resolution
+
+## Summary
+
+Status: PASS.
+
+Resolved two retained API-client exceptions by moving them to canonical shared JavaScript:
+
+- `toolbox/controls/controls-api-client.js` -> `assets/js/shared/controls-api-client.js`
+- `toolbox/game-journey/game-journey-api-client.js` -> `assets/js/shared/game-journey-api-client.js`
+
+No feature behavior was changed.
+
+## Files Changed
+
+- `assets/js/shared/controls-api-client.js`
+- `assets/js/shared/game-journey-api-client.js`
+- `assets/toolbox/controls/js/index.js`
+- `assets/toolbox/game-journey/js/index.js`
+- `account/user-controls-page.js`
+- `scripts/validate-canonical-repository-structure.mjs`
+- `scripts/validate-browser-env-agnostic.mjs`
+- `tests/dev-runtime/ProductDataProviderContractHardening.test.mjs`
+- `tests/regression/CanonicalRepositoryStructureGuardrail.test.mjs`
+- `docs_build/dev/reports/PR_26172_CHARLIE_040-controls-game-journey-api-client-resolution.md`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+
+## Controls API Client Resolution
+
+Decision: migrated to shared.
+
+Reason:
+
+- The client is used by the Controls tool and the account User Controls page.
+- `assets/js/shared/` is canonical for reusable browser helpers.
+- Consumers validated through direct browser page-load probe.
+
+Updated consumers:
+
+- `assets/toolbox/controls/js/index.js`
+- `account/user-controls-page.js`
+
+## Game Journey API Client Resolution
+
+Decision: migrated to shared.
+
+Reason:
+
+- The canonical structure allows shared JS under `assets/js/shared/`.
+- Moving to shared avoids creating an unapproved secondary tool-local JS file beside `index.js`.
+- Targeted Game Journey browser probe validated the moved client and completion-metrics rendering with the existing Postgres stub.
+
+Updated consumer:
+
+- `assets/toolbox/game-journey/js/index.js`
+
+## Validation Lane Report
+
+- `node --check assets/js/shared/controls-api-client.js`
+  - Result: PASS
+- `node --check assets/js/shared/game-journey-api-client.js`
+  - Result: PASS
+- `node --check assets/toolbox/controls/js/index.js`
+  - Result: PASS
+- `node --check assets/toolbox/game-journey/js/index.js`
+  - Result: PASS
+- `node --check account/user-controls-page.js`
+  - Result: PASS
+- Active stale reference check for old Controls/Game Journey client paths
+  - Result: PASS
+  - No active non-report references remain.
+- `git diff --check`
+  - Result: PASS
+- `npm run validate:canonical-structure`
+  - Result: PASS
+  - Blocking violations: 0
+  - Approved legacy exceptions: 478
+- `node --test tests/regression/CanonicalRepositoryStructureGuardrail.test.mjs`
+  - Result: PASS
+- Direct browser page-load probe:
+  - Controls: PASS, heading rendered and `assets/js/shared/controls-api-client.js` returned HTTP 200.
+  - Game Journey: PASS, heading rendered, shared client returned HTTP 200, completion metrics rendered.
+  - Account User Controls: PASS, heading rendered and shared Controls client returned HTTP 200.
+- `node --test tests/dev-runtime/ProductDataProviderContractHardening.test.mjs`
+  - Result: FAIL
+  - Existing unrelated failures:
+    - Public config request order expectation.
+    - Admin/tool votes import expectation.
+  - The moved Controls and Game Journey client path list was updated in this test; the remaining failures are outside this PR scope.
+
+## Branch Validation
+
+- Current branch: `PR_26172_CHARLIE_repository-compliance-stack`
+- Expected branch: `PR_26172_CHARLIE_repository-compliance-stack`
+- Local/origin sync before PR: `0 0`
+- Branch validation: PASS
+
+## Requirement Checklist
+
+- Resolve `controls-api-client.js`: PASS
+- Resolve `game-journey-api-client.js`: PASS
+- Migrate if safe: PASS
+- Otherwise document exceptions: PASS, no exception retained for these two files.
+- Preserve behavior: PASS
+- No feature changes: PASS
+- Produce ZIP artifact: PASS after artifact creation.
+
+## Manual Validation Notes
+
+Controls and Game Journey API-client exceptions are resolved. The only remaining target-area exception after this PR is the Assets upload worker.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,9 +1,10 @@
-R095	toolbox/assets/assets-api-client.js	assets/js/shared/assets-api-client.js
-M	assets/toolbox/assets/js/index.js
-M	assets/toolbox/objects/js/index.js
-A	docs_build/dev/reports/PR_26172_CHARLIE_039-assets-api-worker-exception-resolution.md
-M	docs_build/dev/reports/codex_changed_files.txt
-M	docs_build/dev/reports/codex_review.diff
+M	account/user-controls-page.js
+R096	toolbox/controls/controls-api-client.js	assets/js/shared/controls-api-client.js
+R091	toolbox/game-journey/game-journey-api-client.js	assets/js/shared/game-journey-api-client.js
+M	assets/toolbox/controls/js/index.js
+M	assets/toolbox/game-journey/js/index.js
+A	docs_build/dev/reports/PR_26172_CHARLIE_040-controls-game-journey-api-client-resolution.md
 M	scripts/validate-browser-env-agnostic.mjs
 M	scripts/validate-canonical-repository-structure.mjs
 M	tests/dev-runtime/ProductDataProviderContractHardening.test.mjs
+M	tests/regression/CanonicalRepositoryStructureGuardrail.test.mjs