Polish Asset library selection import layout and metadata display - PR_26156_151-153-asset-library-polish

Author: ToolboxAid

assets/theme-v2/css/tables.css

@@ -41,13 +41,15 @@ td {
 }
 
 .tool-form-table th[scope="row"] {
+  padding: var(--space-4) var(--space-6);
   width: 1%;
   white-space: nowrap;
   text-align: right;
   vertical-align: top
 }
 
 .tool-form-table td {
+  padding: var(--space-4) var(--space-6);
   min-width: 12rem;
   width: auto
 }
@@ -62,3 +64,8 @@ td {
   box-sizing: border-box;
   width: 100%
 }
+
+.data-table tr.is-selected td {
+  background: var(--orange-soft);
+  box-shadow: inset var(--space-3) 0 0 var(--orange)
+}

docs_build/dev/codex_commands.md

@@ -1070,3 +1070,34 @@ Required reports:
 - `docs_build/dev/reports/testing_lane_execution_report.md`
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
+
+
+## PR_26156_151-153
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Updated Project Assets > Library Records so the selected record receives a reusable selected-row state.
+- Preserved existing record click behavior and metadata/preview updates.
+- Ensured only one library record is highlighted at a time through snapshot-driven table rendering.
+- Added a selected filename row directly under the File picker in Import Asset.
+- Kept Storage Path read-only.
+- Reduced shared Theme V2 tool form table cell padding to improve narrow panel input space.
+- Replaced semicolon-separated metadata formatting with separate readable metadata lines.
+- Updated targeted Asset Tool Playwright coverage for selected-row state, selected filename row, read-only Storage Path, compact table spacing, and no-semicolon metadata.
+- Added refreshed Playwright V8 coverage artifacts for changed runtime JavaScript.
+- Did not modify archived V1/V2 files.
+- Did not modify `start_of_day`.
+
+Validation:
+- `node --check toolbox/assets/assets.js`
+- `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `node --check toolbox/assets/assets-mock-repository.js`
+- `node ./scripts/run-targeted-test-lanes.mjs --lane asset-tool`
+- `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
+- Full samples smoke: skipped by request and because samples were not changed.
+
+Required reports:
+- `docs_build/dev/reports/asset-library-selection-layout-metadata-report.md`
+- `docs_build/dev/reports/testing_lane_execution_report.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Fix Asset import role dropdown and form layout - PR_26156_148-150
+Polish Asset library selection, import layout, and metadata - PR_26156_151-153

docs_build/dev/reports/asset-library-selection-layout-metadata-report.md

@@ -0,0 +1,99 @@
+# Asset Library Selection, Layout, and Metadata Report
+
+PR bundle:
+- PR_26156_151-asset-library-selection-state
+- PR_26156_152-asset-import-field-layout-polish
+- PR_26156_153-asset-metadata-formatting
+
+## Scope
+
+Updated the active Asset Tool only:
+- `toolbox/assets/index.html`
+- `toolbox/assets/assets.js`
+- `assets/theme-v2/css/tables.css`
+- `tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+
+No archived V1/V2 files were modified.
+No `start_of_day` folders were modified.
+No archive/reference code was copied.
+
+## PR_26156_151 Selection State
+
+Implemented selected library-record highlighting in Project Assets > Library Records.
+
+Behavior:
+- The selected asset row receives `class="is-selected"`.
+- Rows expose `aria-selected="true"` or `aria-selected="false"`.
+- The selected row button exposes `aria-pressed="true"`.
+- Re-rendering the table from the selected repository snapshot guarantees only one selected row is highlighted at a time.
+- Existing record click behavior is preserved; selecting a record still updates preview, metadata, output, and log state.
+
+Theme V2 gap:
+- Existing shared table styling had no reusable selected-row state.
+- Added the reusable `.data-table tr.is-selected td` pattern in `assets/theme-v2/css/tables.css`.
+
+## PR_26156_152 Import Field Layout
+
+Updated Import Asset form layout while preserving the reusable tool form table pattern.
+
+Changes:
+- Reduced shared tool form table header/value cell padding using Theme V2 spacing tokens.
+- Confirmed Storage Path remains read-only.
+- Preserved File label and native Choose file control in the existing row.
+- Added a selected filename row directly under File.
+- The selected filename row spans both table columns.
+- Native file picker behavior remains unchanged.
+
+Theme V2 gap:
+- Existing shared `tool-form-table` spacing was still too wide for the narrow left panel after the Asset Tool import workflow grew.
+- The adjustment was made in the reusable Theme V2 table stylesheet instead of page-local or tool-local CSS.
+
+## PR_26156_153 Metadata Formatting
+
+Removed semicolon-separated metadata from Project Assets > Metadata and Library Records.
+
+Metadata now renders as separate lines:
+- `<filename> <mime type>`
+- `<byte size> bytes`
+- `<checksum>`
+
+Example:
+- `forge-bot-single.png image/png`
+- `2596257 bytes`
+- `mock-sha256-b12c5f4e`
+
+Internal project/path details remain available below those user-facing lines.
+No raw JSON output was introduced.
+
+## Validation
+
+Impacted lane:
+- `asset-tool`
+
+Commands run:
+- `node --check toolbox/assets/assets.js`
+- `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `node --check toolbox/assets/assets-mock-repository.js`
+- `node ./scripts/run-targeted-test-lanes.mjs --lane asset-tool`
+- `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
+
+Results:
+- Asset Tool lane passed: 5/5 Playwright tests.
+- Direct Asset Tool Playwright run passed: 5/5 Playwright tests.
+- V8 coverage refreshed for changed runtime JavaScript; no changed runtime JS guardrail warnings.
+
+Skipped lanes:
+- Workspace, Project Workspace, Game Design, Game Configuration, Build Path, Tools Progress, Tool Navigation, Tool Display Mode, Tool Images, Tool Runtime, Game Runtime, Integration, Engine Src, and Samples.
+
+Skipped-lane rationale:
+- The change is limited to the active Asset Tool import form, library rendering, metadata rendering, shared Theme V2 table styling, and the targeted Asset Tool test file.
+- No shared launch/navigation behavior changed.
+- No sample JSON or sample loader/framework behavior changed.
+
+Manual test notes:
+- Open `toolbox/assets/index.html`.
+- Confirm Library Records highlights the selected row.
+- Click another library record and confirm the previous row loses highlight while metadata updates.
+- Confirm Storage Path is read-only.
+- Choose a file and confirm the selected filename appears in the row directly under File.
+- Confirm metadata renders on separate lines without semicolons.

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,8 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(81%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 26/32
-(90%) toolbox/tools-page-accordions.js - executed lines 1934/1934; executed functions 70/78
+(95%) toolbox/assets/assets-mock-repository.js - executed lines 661/661; executed functions 62/65
+(96%) toolbox/assets/assets.js - executed lines 370/370; executed functions 43/45
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,30 +12,28 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(85%) Toolbox Index - exercised 5 runtime JS files
+(88%) Toolbox Index - exercised 6 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(81%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 26/32
-(90%) toolbox/tools-page-accordions.js - executed lines 1934/1934; executed functions 70/78
+(95%) toolbox/assets/assets-mock-repository.js - executed lines 661/661; executed functions 62/65
+(96%) toolbox/assets/assets.js - executed lines 370/370; executed functions 43/45
 
 Files with executed line/function counts where available:
-(67%) assets/theme-v2/js/tool-display-mode.js - executed lines 172/172; executed functions 10/15
-(73%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 384/384; executed functions 24/33
+(67%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 10/15
+(75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
+(76%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 26/34
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
-(81%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 26/32
-(83%) toolbox/game-design/game-design-mock-repository.js - executed lines 310/310; executed functions 30/36
-(90%) toolbox/game-design/game-design.js - executed lines 224/224; executed functions 19/21
-(90%) toolbox/tools-page-accordions.js - executed lines 1934/1934; executed functions 70/78
-(100%) admin/tools-progress.js - executed lines 106/106; executed functions 11/11
+(88%) toolbox/game-configuration/game-configuration-mock-repository.js - executed lines 290/290; executed functions 30/34
+(92%) toolbox/game-design/game-design-mock-repository.js - executed lines 310/310; executed functions 34/37
+(95%) toolbox/assets/assets-mock-repository.js - executed lines 661/661; executed functions 62/65
+(96%) toolbox/assets/assets.js - executed lines 370/370; executed functions 43/45
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
-(0%) tests/playwright/tools/BuildPathProgressSimplification.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolImageRegistry.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolNavigationPrevNext.spec.mjs - changed JS file not collected as browser runtime coverage
-(81%) toolbox/toolRegistry.js - changed JS file with browser V8 coverage
-(90%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
+(0%) tests/playwright/tools/AssetToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
+(95%) toolbox/assets/assets-mock-repository.js - changed JS file with browser V8 coverage
+(96%) toolbox/assets/assets.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,6 +1,6 @@
 # Testing Lane Execution Report
 
-Generated: 2026-06-05T18:27:22.138Z
+Generated: 2026-06-05T18:45:52.119Z
 Dry run: No
 
 ## Summary
@@ -9,7 +9,7 @@ PASS: 1
 WARN: 0
 FAIL: 0
 SKIP: 14
-Total lane elapsed time: 14.98s
+Total lane elapsed time: 15.29s
 Actual browser launches: 1
 
 ## Full Samples Smoke
@@ -34,11 +34,11 @@ Reason: No deterministic dependency failures before runtime.
 Status: PASS
 Scheduled lane order: asset-tool
 Reused runtime sessions: 0
-Reused lane snapshots: 1
-Reused warm-start lanes: 1
-Reused dependency hydration: 1
-Prevented graph rebuilds: 1
-Prevented redundant initialization: 1
+Reused lane snapshots: 0
+Reused warm-start lanes: 0
+Reused dependency hydration: 0
+Prevented graph rebuilds: 0
+Prevented redundant initialization: 0
 Prevented redundant browser launches: 0
 Prevented redundant lane execution: 14
 
@@ -64,7 +64,7 @@ Status: PASS
 Target files: tests/playwright/tools/AssetToolMockRepository.spec.mjs
 Required shared helpers: tests/helpers/playwrightRepoServer.mjs, tests/helpers/playwrightStorageIsolation.mjs, tests/helpers/playwrightV8CoverageReporter.mjs, tests/helpers/workspaceV2CoverageReporter.mjs
 Required fixtures: none
-Targeted file/helper reads: 0
+Targeted file/helper reads: 5
 Cached discovery reuse: Yes
 Prevented fallback expansion: Yes; no ownership or scope blocker widened into broad discovery.
 
@@ -73,27 +73,27 @@ Prevented fallback expansion: Yes; no ownership or scope blocker widened into br
 Status: PASS
 Generated manifests: asset-tool:PASS
 Prevented discovery expansion: Yes
-Prevented redundant scans: 0
-Persistent manifest events: asset-tool:REUSED
+Prevented redundant scans: 4
+Persistent manifest events: asset-tool:GENERATED
 
 ## Warm-Start Reuse
 
 Status: PASS
-Warm-start events: asset-tool:REUSED
-Dependency hydration events: asset-tool:REUSED
-Prevented redundant initialization: 1
-Prevented helper resolution passes: 4
+Warm-start events: asset-tool:GENERATED
+Dependency hydration events: asset-tool:GENERATED
+Prevented redundant initialization: 0
+Prevented helper resolution passes: 0
 Prevented fixture ownership traversal: 0
 
 ## Lane Snapshots
 
 Status: PASS
-Snapshot events: asset-tool:REUSED
-Reused snapshots: 1
+Snapshot events: asset-tool:GENERATED
+Reused snapshots: 0
 Invalidated snapshots: 0
-Prevented graph rebuilds: 1
-Prevented redundant dependency traversal: 1
-Prevented fixture/helper graph assembly: 4
+Prevented graph rebuilds: 0
+Prevented redundant dependency traversal: 0
+Prevented fixture/helper graph assembly: 0
 
 ## Lane Deduplication
 
@@ -109,7 +109,7 @@ Prevented Workspace lane reruns: 0
 | project-workspace | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Project Workspace mock repository, Project Workspace UI, and Toolbox Progress/Build Path project-state bridge | repo-served Project Workspace page; repo-served Toolbox page with role simulation; in-memory SQL-shaped mock project repository |
 | game-design | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Design mock repository, project purpose flow, validation overlay, capability demo authoring, and Toolbox progress handoff | repo-served Game Design page; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Design mock repository; Project Workspace mock project context |
 | game-configuration | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | repo-served Game Configuration page; repo-served Game Design page for handoff checks; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Configuration mock repository; Game Design mock repository handoff |
-| asset-tool | PASS | 14.98s | 1 | Asset Tool rebuild slice validates SQL-shaped asset tables, ready Game Configuration handoff, import/preview workflow, and visible validation errors without exercising unrelated toolbox routes. | Asset Tool mock repository, Game Configuration readiness handoff, library records, import preview, and visible failure handling | repo-served Assets page; in-memory SQL-shaped Asset Tool mock repository; Game Configuration mock repository handoff; file-name/path-based import preview |
+| asset-tool | PASS | 15.29s | 1 | Asset Tool rebuild slice validates SQL-shaped asset tables, ready Game Configuration handoff, import/preview workflow, and visible validation errors without exercising unrelated toolbox routes. | Asset Tool mock repository, Game Configuration readiness handoff, library records, import preview, and visible failure handling | repo-served Assets page; in-memory SQL-shaped Asset Tool mock repository; Game Configuration mock repository handoff; file-name/path-based import preview |
 | build-path | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | repo-served Toolbox page; repo-served Admin Tools Progress page; Project Workspace mock project context; Toolbox role simulation |
 | tools-progress | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | repo-served Admin Tools Progress page; repo-served Toolbox Group view; Toolbox registry build sequence; Project Build Path workflow table |
 | tool-navigation | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | repo-served Admin Tools Progress page; repo-served Project Workspace, Game Design, and Game Configuration tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata |
@@ -125,11 +125,11 @@ Prevented Workspace lane reruns: 0
 
 | Lane | Duration | Test |
 | --- | --- | --- |
-| asset-tool | 2.80s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:250:1 > Asset upload failures are visible and project context is required |
-| asset-tool | 2.30s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:196:1 > Image, video, and audio uploads create project-owned metadata and previews |
-| asset-tool | 1.90s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:161:1 > Asset Role changes update Usage options and import form layout stays usable |
-| asset-tool | 1.70s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:119:1 > Assets page lists all asset roles and starts from active project context |
-| asset-tool | 485ms | tests\playwright\tools\AssetToolMockRepository.spec.mjs:75:1 > Asset Tool repository exposes SQL-shaped role, storage, and metadata ownership |
+| asset-tool | 2.80s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:272:1 > Asset upload failures are visible and project context is required |
+| asset-tool | 2.40s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:206:1 > Image, video, and audio uploads create project-owned metadata and previews |
+| asset-tool | 2.00s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:163:1 > Asset Role changes update Usage options and import form layout stays usable |
+| asset-tool | 1.80s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:119:1 > Assets page lists all asset roles and starts from active project context |
+| asset-tool | 363ms | tests\playwright\tools\AssetToolMockRepository.spec.mjs:75:1 > Asset Tool repository exposes SQL-shaped role, storage, and metadata ownership |
 
 ## Commands
 
@@ -146,7 +146,7 @@ Prevented Workspace lane reruns: 0
 - SKIP
 
 ### asset-tool
-- PASS 14.97s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
+- PASS 15.29s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
 
 ### build-path
 - SKIP