Relocate object catalog selector and promote Objects to beta - PR_26161_014-objects-beta-promotion-and-catalog-relocation

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,18 +1,18 @@
 # git status --short
 M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
+ M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
  M tests/playwright/tools/ObjectsTool.spec.mjs
  M toolbox/objects/index.html
- M toolbox/objects/objects.js
-?? docs_build/dev/reports/objects-action-spacing-cleanup-report.md
+?? docs_build/dev/reports/objects-beta-promotion-and-catalog-relocation-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/objects-action-spacing-cleanup-report.md
+docs_build/dev/reports/objects-beta-promotion-and-catalog-relocation-report.md
 
 # git diff --stat
-.../dev/reports/coverage_changed_js_guardrail.txt  | 10 +---
- .../dev/reports/playwright_v8_coverage_report.txt  | 16 +-----
- tests/playwright/tools/ObjectsTool.spec.mjs        | 64 +++++++++++++++-------
- toolbox/objects/index.html                         |  1 -
- toolbox/objects/objects.js                         | 50 ++++++-----------
- 5 files changed, 66 insertions(+), 75 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |  3 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |  4 +-
+ .../guest-seeds/tool-metadata-inventory.js         | 21 +++++-----
+ tests/playwright/tools/ObjectsTool.spec.mjs        | 45 ++++++++++++++++++----
+ toolbox/objects/index.html                         | 22 +++++++----
+ 5 files changed, 70 insertions(+), 25 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -6,7 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
 
 Guardrail warnings:
-(100%) none - no changed runtime JS coverage warnings
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,86 @@
+# PR_26161_014 Objects Beta Promotion And Catalog Relocation Report
+
+## Branch Validation
+
+PASS
+
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches observed: `* main`
+
+## Scope
+
+- Impacted lane: Objects tool UI/runtime plus Toolbox tool metadata registry.
+- Playwright impacted: Yes.
+- Runtime engine behavior changed: No.
+- Samples validation: Skipped as requested. No sample JSON, auth behavior, production DB behavior, engine runtime behavior, or unrelated tool behavior changed.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Verified current git branch was `main` before edits.
+- PASS: Moved the Object Type Catalog selector into the Objects Table footer.
+- PASS: Placed the selector in the right-side footer group.
+- PASS: Kept `Add Object` and `Reset Table` in the left-side footer group.
+- PASS: Kept Object Type Catalog display limited to `Template` and `Capability`.
+- PASS: Preserved object creation workflows, including template-prefilled row creation.
+- PASS: Preserved DB/mock-adapter persistence after reload.
+- PASS: Preserved Sprite asset linking after reload.
+- PASS: Preserved row action buttons: `Edit`, `Edit Sprite`, `Open Hitboxes`, `Open Events`, and `Trash`.
+- PASS: Preserved Missing/Complete button highlighting through existing Theme V2 button classes.
+- PASS: Updated Objects tool metadata/status registry to `status = beta`.
+- PASS: Removed remaining Objects wireframe-only messaging from the displayed Objects tool surface.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only and preserved HTML restrictions.
+
+## Testing Performed
+
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: `node --check src/dev-runtime/guest-seeds/tool-metadata-inventory.js`
+- PASS: `rg --pcre2 -n '<script(?![^>]*\bsrc=)|<style\b|\son[a-z]+\s*=' toolbox/objects/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `rg -n 'Wireframe|wireframe|Static wireframe|not wired|Not implemented yet|Role|Traits|Not connected yet' toolbox/objects/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `node --input-type=module -e "...getToolById('objects')..."`
+  - Result: Objects registry seed reports `status: "beta"`, `releaseChannel: "beta"`, and `releaseChannelLabel: "Beta"`.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line`
+  - Result: 6 passed.
+- PASS: `git diff --check`
+  - Result: PASS. Git reported line-ending normalization warnings only.
+
+## Playwright Behavior Covered
+
+- PASS: Object Type Catalog selector appears inside the Objects Table footer.
+- PASS: Footer selector is in the right-side catalog group.
+- PASS: `Add Object` and `Reset Table` remain in the left-side footer group.
+- PASS: Selecting a footer template before adding an object still prefills Type, State, Render, and Capabilities.
+- PASS: Add, cancel, save, edit, trash, reset, and DB persistence after reload still work.
+- PASS: Sprite asset creation/resolution and linked sprite asset display persist after reload.
+- PASS: Row actions and Missing/Complete visual classes remain intact.
+- PASS: Toolbox displays Objects as `Beta`, not `Wireframe`.
+- PASS: Toolbox registry API reports Objects as `status: "beta"`.
+
+## Playwright V8 Coverage
+
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Changed runtime JavaScript coverage notes:
+  - `(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105`
+  - `(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only`
+- The warning is safe for this PR because `tool-metadata-inventory.js` is a dev-runtime seed module validated by syntax check and by the targeted Playwright registry/API status assertion.
+
+## Manual Validation Steps
+
+1. Open `/toolbox/objects/index.html`.
+2. Confirm the Objects Table footer has `Add Object` and `Reset Table` on the left.
+3. Confirm the Object Type Catalog selector is in the right side of the table footer.
+4. Select `Hero` in the footer selector, click `Add Object`, and confirm the active row is prefilled.
+5. Save a Sprite object, reload the page, and confirm the row and linked sprite asset remain.
+6. Open `/toolbox/index.html` and confirm the Objects card displays `Beta`.
+
+## Skipped Lanes
+
+- Full samples validation: SKIP, explicitly requested and no samples changed.
+- Broad workspace/project suite: SKIP, no shared Project Workspace contract, engine runtime behavior, public navigation behavior, auth behavior, production DB behavior, or sample behavior changed.
+- Full registry suite: SKIP, registry impact is scoped to the Objects metadata seed and covered by targeted Objects Playwright plus direct seed inspection.
+

docs_build/dev/reports/objects-beta-promotion-and-catalog-relocation-report.md

@@ -17,6 +17,7 @@ Exercised tool entry points detected:
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
 
 Files with executed line/function counts where available:
@@ -37,8 +38,9 @@ Files with executed line/function counts where available:
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(100%) none - no low-coverage changed runtime JS files
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
 (94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -6,7 +6,8 @@ export const TOOL_STATUS_MODEL = Object.freeze([
   "Under Construction",
   "Planned",
   "Hidden",
-  "Deprecated"
+  "Deprecated",
+  "beta"
 ]);
 
 export const TOOL_RELEASE_CHANNELS = Object.freeze([
@@ -52,7 +53,8 @@ const READINESS_BY_STATUS = Object.freeze({
   "Under Construction": "No",
   Planned: "No",
   Hidden: "No",
-  Deprecated: "No"
+  Deprecated: "No",
+  beta: "Yes"
 });
 
 const RELEASE_CHANNEL_BY_STATUS = Object.freeze({
@@ -61,7 +63,8 @@ const RELEASE_CHANNEL_BY_STATUS = Object.freeze({
   "Under Construction": "beta",
   Planned: "planned",
   Hidden: "planned",
-  Deprecated: "deprecated"
+  Deprecated: "deprecated",
+  beta: "beta"
 });
 
 export const TOOL_REGISTRY = Object.freeze([
@@ -150,7 +153,7 @@ export const TOOL_REGISTRY = Object.freeze([
     "requires": [
       "project-workspace"
     ],
-    "status": "Ready",
+    "status": "beta",
     "releaseChannel": "beta",
     "progressChecklist": [
       "Open Project Workspace",
@@ -410,14 +413,14 @@ export const TOOL_REGISTRY = Object.freeze([
     "id": "objects",
     "name": "Objects",
     "displayName": "Objects",
-    "shortDescription": "Create game objects with roles, state, and sprite assets.",
+    "shortDescription": "Create game objects with types, state, and sprite assets.",
     "shortLabel": "Objects",
     "path": "objects",
     "folderName": "objects",
     "entryPoint": "objects/index.html",
     "badge": "/assets/theme-v2/images/badges/objects.png",
     "tool": "/assets/theme-v2/images/tools/objects.png",
-    "description": "Create game objects with roles, state, and sprite assets.",
+    "description": "Create game objects with types, state, and sprite assets.",
     "category": "Design",
     "colorGroup": "tool-group-design",
     "active": true,
@@ -426,8 +429,8 @@ export const TOOL_REGISTRY = Object.freeze([
     "requiredForTestable": true,
     "requiredForPublish": true,
     "requires": [],
-    "status": "Wireframe",
-    "releaseChannel": "wireframe",
+    "status": "beta",
+    "releaseChannel": "beta",
     "progressChecklist": [
       "Editable object table available",
       "Inline row add, save, cancel, edit, and trash actions available",
@@ -438,7 +441,7 @@ export const TOOL_REGISTRY = Object.freeze([
     "adminOnly": false,
     "visibleInToolsList": true,
     "toolboxGroup": "Create",
-    "capabilityLabel": "Object role types",
+    "capabilityLabel": "Object types",
     "childCapabilities": [
       "Static",
       "Dynamic",

src/dev-runtime/guest-seeds/tool-metadata-inventory.js

@@ -111,6 +111,14 @@ async function objectDefinitionRecords(page) {
   });
 }
 
+async function objectsRegistryEntry(page) {
+  return page.evaluate(async () => {
+    const response = await fetch("/api/toolbox/registry/snapshot");
+    const payload = await response.json();
+    return payload.data.tools.find((tool) => tool.id === "objects") || null;
+  });
+}
+
 test("Objects exposes production copy, setup status, and broad table input", async ({ page }) => {
   const failures = await openObjectsPage(page);
 
@@ -126,7 +134,20 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("main")).not.toContainText(["Not", "connected", "yet"].join(" "));
     await expect(page.getByRole("heading", { level: 2, name: "Object Builder" })).toBeVisible();
     await expect(page.getByText("Object Type Catalog", { exact: true })).toBeVisible();
-    await expect(page.locator("[data-objects-template-select] option")).toHaveText(["Select template", ...TYPE_OPTIONS]);
+    await expect(page.locator("[data-objects-template-select]")).toHaveCount(1);
+    await expect(page.locator("[data-objects-list-table] tfoot [data-objects-template-select] option")).toHaveText(["Select template", ...TYPE_OPTIONS]);
+    await expect(page.locator("[data-objects-table-footer-actions] [data-objects-add-row]")).toBeVisible();
+    await expect(page.locator("[data-objects-table-footer-actions] [data-objects-reset-table]")).toBeVisible();
+    await expect(page.locator("[data-objects-table-footer-catalog] [data-objects-template-select]")).toBeVisible();
+    const footerPositions = await page.locator("[data-objects-table-footer]").evaluate((footer) => {
+      const actions = footer.querySelector("[data-objects-table-footer-actions]");
+      const catalog = footer.querySelector("[data-objects-table-footer-catalog]");
+      return {
+        actionsLeft: actions.getBoundingClientRect().left,
+        catalogLeft: catalog.getBoundingClientRect().left,
+      };
+    });
+    expect(footerPositions.catalogLeft).toBeGreaterThan(footerPositions.actionsLeft);
     await expect(page.locator("[aria-label='Object type catalog'] th")).toHaveText(["Template", "Capability"]);
     await expect(page.locator("[aria-label='Object type catalog'] thead")).not.toContainText("State");
     await expect(page.locator("[aria-label='Object type catalog'] thead")).not.toContainText("Render");
@@ -168,10 +189,8 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("[data-objects-capability-basics]")).toContainText("Takes Damage");
     await expect(page.locator("[data-objects-capability-basics]")).not.toContainText("bounces");
 
-    const addAfterTable = await page.locator("[data-objects-list-table]").evaluate((table) => (
-      Boolean(table.compareDocumentPosition(document.querySelector("[data-objects-add-row]")) & Node.DOCUMENT_POSITION_FOLLOWING)
-    ));
-    expect(addAfterTable).toBe(true);
+    await expect(page.locator("[data-objects-list-table] tfoot [data-objects-add-row]")).toBeVisible();
+    await expect(page.locator("[data-objects-list-table] tfoot [data-objects-reset-table]")).toBeVisible();
 
     await page.getByRole("button", { name: "Seed Starter Objects" }).click();
     await expect(page.locator("[data-objects-log]")).toHaveText("Seeded starter objects: Hero, Projectile, and Wall.");
@@ -382,6 +401,7 @@ test("Object Type Catalog selection prefills active table rows", async ({ page }
   const failures = await openObjectsPage(page);
 
   try {
+    await expect(page.locator("[data-objects-list-table] tfoot [data-objects-template-select]")).toBeVisible();
     await page.locator("[data-objects-template-select]").selectOption("Hazard");
     await expect(page.locator("[data-objects-log]")).toHaveText("Hazard template selected for the next object row.");
 
@@ -588,14 +608,25 @@ test("Objects table save preserves linked sprite asset create and resolve behavi
   }
 });
 
-test("Objects is a clickable wireframe tool from Toolbox", async ({ page }) => {
+test("Objects is a clickable beta tool from Toolbox", async ({ page }) => {
   const failures = await openToolboxPage(page);
 
   try {
     const objectsCard = page.locator("[data-toolbox-tool-card='Objects']");
     await expect(objectsCard).toBeVisible();
-    await expect(objectsCard.locator("[data-toolbox-kicker]")).toHaveText("Wireframe");
+    await expect(objectsCard).toHaveAttribute("data-toolbox-release-channel", "beta");
+    await expect(objectsCard.locator("[data-toolbox-kicker]")).toHaveText("Beta");
+    await expect(objectsCard.locator("[data-toolbox-plan-details]")).toHaveCount(0);
+    await expect(objectsCard).not.toContainText("Wireframe details");
     await expect(objectsCard.locator("[data-toolbox-tool-name-link='Objects']")).toHaveAttribute("href", "/toolbox/objects/index.html");
+    const registryEntry = await objectsRegistryEntry(page);
+    expect(registryEntry).toEqual(expect.objectContaining({
+      releaseChannel: "beta",
+      releaseChannelLabel: "Beta",
+      status: "beta",
+    }));
+    expect(registryEntry.shortDescription).toContain("types");
+    expect(registryEntry.shortDescription).not.toMatch(/\broles\b/i);
     await objectsCard.locator("[data-toolbox-tool-name-link='Objects']").click();
     await expect(page.getByRole("heading", { level: 1, name: "Objects" })).toBeVisible();
 

tests/playwright/tools/ObjectsTool.spec.mjs

@@ -42,9 +42,6 @@ <h2>Objects</h2>
                             <details class="vertical-accordion" open>
                                 <summary>Object Type Catalog</summary>
                                 <div class="accordion-body content-stack">
-                                    <div class="content-cluster" aria-label="Object type catalog selection">
-                                        <select aria-label="Object Type Catalog" data-objects-template-select></select>
-                                    </div>
                                     <div class="table-wrapper">
                                         <table class="data-table" aria-label="Object type catalog">
                                             <thead>
@@ -96,12 +93,23 @@ <h3>Objects Table</h3>
                                             </tr>
                                         </thead>
                                         <tbody data-objects-list></tbody>
+                                        <tfoot>
+                                            <tr>
+                                                <td colspan="7">
+                                                    <div class="content-split" data-objects-table-footer>
+                                                        <div class="content-cluster" aria-label="Objects table actions" data-objects-table-footer-actions>
+                                                            <button class="btn" type="button" data-objects-add-row>Add Object</button>
+                                                            <button class="btn" type="button" data-objects-reset-table>Reset Table</button>
+                                                        </div>
+                                                        <div class="action-group action-group--end" aria-label="Object type catalog selection" data-objects-table-footer-catalog>
+                                                            <select aria-label="Object Type Catalog" data-objects-template-select></select>
+                                                        </div>
+                                                    </div>
+                                                </td>
+                                            </tr>
+                                        </tfoot>
                                     </table>
                                 </div>
-                                <div class="content-cluster" aria-label="Objects table actions">
-                                    <button class="btn" type="button" data-objects-add-row>Add Object</button>
-                                    <button class="btn" type="button" data-objects-reset-table>Reset Table</button>
-                                </div>
                             </div>
                         </article>
                     </section>