Fix emotion preview parent voice inheritance

Author: ToolboxAid

assets/toolbox/text-to-speech/js/index.js

@@ -347,7 +347,29 @@ function createDefaultTextToSpeechProfiles(voiceOptions = []) {
   ];
 }
 
+function isDefaultBrowserVoice(value) {
+  return ["browser default", "default", "default browser voice"].includes(String(value || "").trim().toLowerCase());
+}
+
+function previewVoiceForProfile({ language = "", voice = "", voiceOptions = [] } = {}) {
+  const normalizedVoice = String(voice || "").trim();
+  const selectedVoice = voiceOptions.find((option) => String(option.value) === normalizedVoice
+    || String(option.name) === normalizedVoice
+    || String(option.label) === normalizedVoice);
+  if (selectedVoice) {
+    return { defaultBrowserVoice: false, voice: selectedVoice };
+  }
+  if (!isDefaultBrowserVoice(normalizedVoice)) {
+    return { defaultBrowserVoice: false, voice: null };
+  }
+  const selectedDefault = voiceOptions.find((option) => !language || option.language === language)
+    || voiceOptions[0]
+    || null;
+  return { defaultBrowserVoice: true, voice: selectedDefault };
+}
+
 function createSpeechPreviewRequest({
+  language = TEXT_TO_SPEECH_DEFAULTS.language,
   pitch = TEXT_TO_SPEECH_DEFAULTS.pitch,
   rate = TEXT_TO_SPEECH_DEFAULTS.rate,
   text = "",
@@ -360,21 +382,22 @@ function createSpeechPreviewRequest({
     return { ok: false, message: "Speech text is required before preview." };
   }
 
-  const selectedVoice = voiceOptions.find((option) => String(option.value) === String(voice)) || null;
+  const previewVoice = previewVoiceForProfile({ language, voice, voiceOptions });
+  const selectedVoice = previewVoice.voice;
   if (!selectedVoice) {
     return { ok: false, message: "Select an available browser voice before preview." };
   }
 
   return {
-    language: selectedVoice.language || TEXT_TO_SPEECH_DEFAULTS.language,
+    language: language || selectedVoice.language || TEXT_TO_SPEECH_DEFAULTS.language,
     ok: true,
     pitch: boundedNumber(pitch, TEXT_TO_SPEECH_RANGE_DEFAULTS.pitch),
     rate: boundedNumber(rate, TEXT_TO_SPEECH_RANGE_DEFAULTS.rate),
     speechItemId: "browser-preview",
     speechItemName: "Browser Preview",
     text: normalizedText,
     voice: selectedVoice.value,
-    voiceName: selectedVoice.name || selectedVoice.label || "selected voice",
+    voiceName: previewVoice.defaultBrowserVoice ? "Default browser voice" : selectedVoice.name || selectedVoice.label || "selected voice",
     volume: boundedNumber(volume, TEXT_TO_SPEECH_RANGE_DEFAULTS.volume)
   };
 }
@@ -1150,6 +1173,7 @@ function initializeTextToSpeechTool(root = document, { engine = new TextToSpeech
       return;
     }
     const result = engine.speak({
+      gender: profile.gender,
       language: request.language,
       pitch: request.pitch,
       rate: request.rate,

docs_build/dev/reports/PR_26177_BRAVO_004-fix-emotion-preview-parent-voice.md

@@ -0,0 +1,71 @@
+# PR_26177_BRAVO_004 Fix Emotion Preview Parent Voice
+
+## Branch Validation
+
+| Check | Result | Notes |
+| --- | --- | --- |
+| Active branch | PASS | `bravo/26177-text-to-speech` |
+| Did not switch to main | PASS | Work stayed on the active Bravo branch. |
+| Scope | PASS | Changed only Text To Speech emotion preview behavior and targeted tests. |
+| No governance changes | PASS | No governance docs or process files were edited. |
+| No `start_of_day` changes | PASS | `git status --short -- docs_build/dev/start_of_day start_of_day` returned no changed files. |
+
+## Requirement Checklist
+
+| Requirement | Result | Notes |
+| --- | --- | --- |
+| 1. Emotion Play inherits parent profile voice settings | PASS | Emotion preview now passes parent language, voice, gender, and age controls through the preview request/engine flow. |
+| 2. Default browser voice is valid for preview | PASS | `Default browser voice`, `default`, and `browser default` resolve to an available browser voice, preferring the parent profile language. |
+| 3. No separate emotion-row voice selection | PASS | Emotion rows still use pitch/rate/volume only; no emotion voice selector was added. |
+| 4. Preserve emotion settings | PASS | Pitch, rate, and volume remain sourced from the selected Emotion row. |
+| 5. Scope to Text To Speech V2 | PASS | The change is contained to `assets/toolbox/text-to-speech/js/index.js` and its tests. |
+| 6. Targeted tests | PASS | Added unit coverage for parent-profile default browser voice inheritance and Playwright coverage for the API-backed default profile Neutral play action. |
+| 7. No governance changes | PASS | No governance files changed. |
+| 8. No unrelated cleanup | PASS | Generated coverage report artifacts from the Playwright attempt were restored and not included. |
+| 9. No repo-wide refactors | PASS | No shared engine/core refactor was introduced. |
+
+## File Inventory
+
+| File | Purpose |
+| --- | --- |
+| `assets/toolbox/text-to-speech/js/index.js` | Resolves parent profile `Default browser voice` to an available browser voice for preview while keeping parent language/gender/age and emotion pitch/rate/volume. |
+| `tests/tools/Text2SpeechShell.test.mjs` | Adds a focused unit test proving default browser voice resolves by parent language and preserves emotion audio values. |
+| `tests/playwright/tools/TextToSpeechFunctional.spec.mjs` | Updates the impacted API-backed TTS profile/emotion assertions and adds a parent-default-voice Emotion Play assertion. |
+| `docs_build/dev/reports/codex_review.diff` | Required scoped diff report. |
+| `docs_build/dev/reports/codex_changed_files.txt` | Required changed-file inventory. |
+| `docs_build/dev/reports/PR_26177_BRAVO_004-fix-emotion-preview-parent-voice.md` | This PR-specific implementation report. |
+
+## Validation Lane Report
+
+| Command | Result | Notes |
+| --- | --- | --- |
+| `node --check assets/toolbox/text-to-speech/js/index.js` | PASS | Syntax check passed. |
+| `node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs` | PASS | Syntax check passed. |
+| `node --test tests/tools/Text2SpeechShell.test.mjs` | PASS | 6/6 tests passed. |
+| `git diff --check` | PASS | No whitespace errors. Git warned that touched test files may be normalized from LF to CRLF when Git writes them. |
+| `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright` | BLOCKED/FAIL | Browser launch failed before page runtime because Chromium is missing at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`. |
+
+## Playwright Impacted Assessment
+
+- Impacted spec: `tests/playwright/tools/TextToSpeechFunctional.spec.mjs`.
+- The spec now covers the exact issue path: expanded Default Balanced Profile, Neutral Emotion Play, parent `Default browser voice`, parent `en-US`, and no row-level voice selector.
+- Local execution is blocked by the missing configured Chromium binary, so browser runtime validation remains pending in an environment with Playwright browsers installed.
+
+## Manual Validation Notes
+
+- Manual browser validation was not completed because the configured Playwright Chromium executable is missing locally.
+- Source inspection confirmed Emotion rows do not add voice controls.
+- Source inspection confirmed the preview path does not introduce browser-owned product data, hidden defaults, or `imageDataUrl`.
+- Source inspection confirmed no `start_of_day` files changed.
+
+## Known Issues
+
+- Local Playwright browser validation remains blocked until Chromium is installed for the configured Playwright version.
+- No remaining implementation issue is known from focused source and unit validation for the parent-profile default voice inheritance fix.
+
+## Output Files
+
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/PR_26177_BRAVO_004-fix-emotion-preview-parent-voice.md`
+- `tmp/PR_26177_BRAVO_004-fix-emotion-preview-parent-voice_delta.zip`

docs_build/dev/reports/codex_changed_files.txt

@@ -1,13 +1,6 @@
 assets/toolbox/text-to-speech/js/index.js
-docs_build/database/ddl/messages.sql
-docs_build/dev/reports/PR_26177_BRAVO_002-complete-text-to-speech-gap-fixes.md
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
-src/dev-runtime/messages/messages-postgres-service.mjs
-tests/dev-runtime/MessagesPublishValidation.test.mjs
-tests/playwright/tools/MessagesTool.spec.mjs
-tests/tools/MessagesPlaybackSource.test.mjs
+docs_build/dev/reports/PR_26177_BRAVO_004-fix-emotion-preview-parent-voice.md
+tests/playwright/tools/TextToSpeechFunctional.spec.mjs
 tests/tools/Text2SpeechShell.test.mjs
-toolbox/messages/messages-api-client.js
-toolbox/messages/messages.js
-toolbox/text-to-speech/index.html