Restore DB source palettes and remove user colors on unpin - PR_26156_173-palette-source-list-and-unpin-delete

Author: ToolboxAid

assets/theme-v2/css/forms.css

@@ -179,7 +179,8 @@ input[type="color"][data-palette-swatch-size="large"] {
   border-radius: var(--radius-pill);
   background: var(--red);
   box-shadow: var(--shadow-sm);
-  pointer-events: none
+  cursor: pointer;
+  pointer-events: auto
 }
 
 .palette-swatch-tile[data-palette-pinned="true"] .palette-swatch-pin {

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,8 +6,9 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 102/118
-(93%) toolbox/colors/colors.js - executed lines 717/717; executed functions 71/76
+(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
+(95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
+(100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/palette-source-list-and-unpin-delete-report.md

@@ -0,0 +1,44 @@
+# PR_26156_173 Palette Source List And Unpin Delete Report
+
+## Result
+PASS
+
+## Scope Completed
+- Restored Palette Tool source palette records through mock DB rows only.
+- Added DB-backed source groups for 8, 16, 24, 32, 48, 64, 96, 120, 150, W3C, and JavaScript palettes.
+- Kept `DEFAULT_SOURCE_PALETTES` removed and did not restore a default palette source.
+- Added a visible diagnostic for the case where source records exist but no valid dropdown option can render.
+- Updated active Palette Colors pin click behavior to remove the clicked color from the active user palette.
+- Ensured active user palette removal updates the mock DB `palette_colors` table, count, and selected state.
+- Ensured active user palette removal does not remove source palette records.
+- Kept source pinning duplicate-safe.
+
+## Implementation Notes
+- Source palette records are provided by `toolbox/colors/palette-source-mock-db.js` and loaded by `createPaletteToolMockDbTables()`.
+- Source labels come from mock DB records, so dropdown labels render as `8-color set`, `16-color set`, `32-color set`, `W3C`, and `JavaScript`.
+- Palette options sort by label with numeric-aware ordering.
+- `repository.removeSwatch(symbol)` removes a specific active palette color and clears selection when the removed color was selected.
+- The active palette pin indicator now receives pointer events through the existing reusable Theme V2 swatch pin pattern.
+
+## Validation
+- Targeted Palette Tool runtime/UI lane: PASS.
+- Changed-file JavaScript syntax checks: PASS.
+- Static validation lane: PASS.
+- `DEFAULT_SOURCE_PALETTES` active target check: PASS, no matches.
+- Playwright V8 coverage artifact refreshed: PASS.
+- Full samples smoke: SKIP per BUILD instruction.
+
+## Manual Validation Steps
+1. Open `toolbox/colors/index.html`.
+2. Confirm Source Palette Browser dropdown lists DB-backed `8-color set`, `16-color set`, `32-color set`, larger sets, `W3C`, and `JavaScript`.
+3. Select `8-color set`, filter for `black`, and click `Pin All`.
+4. Confirm Palette Colors count becomes `1` and Black appears once.
+5. Click `Pin All` again and confirm the count stays `1`.
+6. Click the pin indicator on the active Black swatch.
+7. Confirm Black is removed from Palette Colors, count returns to `0`, selected summary shows `None`, and source swatches still render.
+8. Open `toolbox/colors/index.html?source=invalid` and confirm the visible source-record diagnostic appears.
+
+## Out Of Scope
+- Full samples smoke was not run.
+- Archived V1/V2 files were not modified.
+- `start_of_day` folders were not modified.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,26 +12,29 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(84%) Toolbox Index - exercised 4 runtime JS files
+(85%) Toolbox Index - exercised 5 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 102/118
-(93%) toolbox/colors/colors.js - executed lines 717/717; executed functions 71/76
+(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
+(95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
+(100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 102/118
+(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
-(93%) toolbox/colors/colors.js - executed lines 717/717; executed functions 71/76
+(95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
+(100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
 (86%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
-(93%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(95%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(100%) toolbox/colors/palette-source-mock-db.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,18 +1,22 @@
-# PR_26156_172 Testing Lane Execution Report
+# PR_26156_173 Testing Lane Execution Report
 
 ## Result
 PASS
 
 ## Commands Run
-- `node --check toolbox\colors\palette-workspace-repository.js`
+- `node --check toolbox/colors/palette-source-mock-db.js`
   - PASS
-- `node --check toolbox\colors\colors.js`
+- `node --check toolbox/colors/palette-workspace-repository.js`
   - PASS
-- `node --check tests\playwright\tools\PaletteToolMockRepository.spec.mjs`
+- `node --check toolbox/colors/colors.js`
   - PASS
-- `rg -n "DEFAULT_SOURCE_PALETTES|DEFAULT_SOURCE_PALETTE_LABELS|SOURCE_PALETTES|paletteList" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+- `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS
+- `rg "DEFAULT_SOURCE_PALETTES" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
   - PASS, no matches
-- `node .\node_modules\@playwright\test\cli.js test --project=playwright --workers=1 --reporter=list --grep "Palette (repository|Tool)"`
+- `node --input-type=module -e "import('./toolbox/colors/palette-workspace-repository.js').then(({createProjectWorkspacePaletteRepository})=>{ const repo=createProjectWorkspacePaletteRepository(); console.log(repo.sourcePaletteOptions().map((option)=>option.label + ' (' + option.swatchCount + ')').join('|')); })"`
+  - PASS, source options include `8-color set`, `16-color set`, `24-color set`, `32-color set`, `48-color set`, `64-color set`, `96-color set`, `120-color set`, `150-color set`, `JavaScript`, and `W3C`
+- `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
   - PASS, 3 tests
 - `npm run test:playwright:static`
   - PASS
@@ -22,24 +26,24 @@ PASS
 - Changed-file/static validation: PASS.
 
 ## Playwright Coverage
-- Selected Palette Colors swatch is visibly indicated: PASS.
-- Selected state is separate from pinned state: PASS.
-- Selected swatch does not rely only on color because it uses a ring/border and glow treatment: PASS.
-- Harmony results render as swatches: PASS.
-- Harmony results do not render as text-only `Scheme N: #HEX (Source)` lines: PASS.
-- Harmony swatches expose scheme and generated hex through title and accessible label: PASS.
-- Add Selected works after choosing a harmony swatch: PASS.
-- Add All still works from rendered harmony swatches: PASS.
-- Swatch-only list rendering, upper-right pin, hover glow, and native browser `title` tooltip remain covered: PASS.
-- Harmony controls and Add Selected action remain covered: PASS.
+- DB-backed source palette dropdown lists required mock DB palettes: PASS.
+- Source palette records render visible swatches: PASS.
+- Empty source table shows `No source palette`: PASS.
+- Invalid source records with no dropdown options show visible diagnostic: PASS.
+- Pin from Source Palette Browser adds to active Palette Colors: PASS.
+- Repeat pinning does not duplicate an existing active palette color: PASS.
+- Clicking the active Palette Colors pin indicator removes that color only from the active user palette: PASS.
+- Palette Colors count updates after add/remove: PASS.
+- Selected state clears when selected color is removed: PASS.
+- Source palette records remain available after active color removal: PASS.
 
 ## Impacted Lane
 - Palette Tool runtime/UI lane.
-- Theme V2 static validation for reusable swatch selected-state styling.
+- Theme V2 static validation for the reusable swatch pin interaction target.
 
 ## Skipped Lanes
 - Full samples smoke was skipped by BUILD instruction.
-- Broader tool lanes were skipped because the Theme V2 change is a swatch modifier covered in the Palette Tool consumer lane plus static validation.
+- Broader tool lanes were skipped because changes are confined to Palette Tool runtime/mock DB behavior, one reusable Theme V2 swatch pin interaction, and the targeted Palette Tool spec.
 
 ## Not Run
 - Full samples smoke was not run, per BUILD instruction.