Skip to content

Commit 237eee8

Browse files
committed
Correct Bravo team branch governance
1 parent 9f2aadf commit 237eee8

4 files changed

Lines changed: 252 additions & 174 deletions

File tree

docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ Rules:
145145
- Each PR must be committed, pushed, and opened as a draft PR.
146146
- Each PR starts at PR Open after the branch and PR identity are named.
147147
- Each PR plans and builds on the same source branch after PR Open.
148-
- Each PR reaches Closed only after main-return, clean-worktree, local/origin `0/0`, no-untracked-files, required-report, required-ZIP, backlog, applicable tool-state, and retained-branch-disposition gates pass.
148+
- During assigned team-day work, sequential PRs must remain on the assigned team branch until EOD or an owner-approved merge checkpoint.
149+
- Returning to `main` between sequential team PRs is prohibited.
150+
- Each PR reaches Closed only after clean-worktree, local/origin sync for the active source branch, no-untracked-files, required-report, required-ZIP, backlog, applicable tool-state, retained-branch-disposition gates, and the applicable EOD/main-verification gate pass.
149151
- A team must not begin another PR until its previous PR is Closed unless OWNER documented an explicit stacked PR chain.
150152
- Do not commit directly to main.
151153
- Do not merge without explicit owner approval.
@@ -174,6 +176,7 @@ Rules:
174176
- Each PR may be committed and pushed during active work.
175177
- Each PR may be opened as a draft PR during active work.
176178
- Each PR must move through PR Open, Plan, Build, Validation, Approved, Merged, Main Verified, and Closed in order.
179+
- For assigned team-day work, Main Verified occurs only at EOD or an owner-approved merge checkpoint; it is not permission to return to `main` between sequential PRs.
177180
- Plan, Build, validation, reports, ZIP packaging, and closeout must stay tied to the same PR identity and source branch.
178181
- Source branches are retained by default after merge and closeout.
179182
- A team must not begin another PR until its previous PR is Closed unless OWNER documented an explicit stacked PR chain.
@@ -188,6 +191,7 @@ Rules:
188191
Conflict note:
189192
- Older wording that says each PR must create its own branch remains preserved.
190193
- This all-team clarification allows an approved existing team, OWNER, or scoped PR branch when the owner assigns that dependency model.
194+
- The Day Work / EOD Merge Rule below overrides older main-return wording during assigned team-day sequences.
191195
- If a branch model is unclear, owner approval is required before continuing.
192196

193197
## Day Work / EOD Merge Rule
@@ -198,7 +202,11 @@ During active work:
198202
- Pushes are allowed and expected.
199203
- Draft PRs are allowed and expected.
200204
- Direct commits to main are prohibited.
205+
- Codex must stay on the assigned team branch until EOD or an owner-approved merge checkpoint.
206+
- Returning to `main` between sequential PRs in the same assigned team-day workstream is prohibited.
201207
- Merges to main are prohibited unless explicitly approved by the owner.
208+
- Any staged changes, unstaged changes, unmerged state, or direct commit on `main` during team work is a governance failure.
209+
- If that failure occurs, Codex must hard-stop, move the scoped work to the active team branch, restore `main` to a clean state, document the correction, and continue only from the team branch.
202210

203211
At end of day:
204212
- Owner reviews ready PRs.
Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
# PR_26177_BRAVO_002 Correct Team Branch Governance
2+
3+
## Scope
4+
5+
Correction-only governance PR. No feature implementation and no unrelated cleanup.
6+
7+
Repo-structured ZIP path: `tmp/PR_26177_BRAVO_002-correct-team-branch-governance_delta.zip`
8+
9+
## Initial Branch/Status
10+
11+
- Initial branch: `main`
12+
- Initial status: `main...origin/main [ahead 1, behind 120]`
13+
- Initial finding: governance failure.
14+
- Details:
15+
- Prior Bravo audit commit `cda216906 Add Bravo TTS profiles audit report` was on local `main`.
16+
- `main` also had an in-progress merge with `MERGE_HEAD` present.
17+
- `docs_build/dev/reports/codex_changed_files.txt` and `docs_build/dev/reports/codex_review.diff` were conflicted.
18+
- `main` had staged merge changes from non-Bravo work.
19+
20+
## Correction Steps Taken
21+
22+
1. Reported branch/status before making correction changes.
23+
2. Confirmed the repository was on `main` and not clean.
24+
3. Did not commit on `main`.
25+
4. Aborted the interrupted merge on `main`.
26+
5. Created `bravo/26177-text-to-speech` from `origin/main`.
27+
6. Cherry-picked the prior scoped Bravo audit commit onto the Bravo branch.
28+
7. Resolved only the Codex artifact conflicts from that cherry-pick.
29+
8. Moved local `main` back to `origin/main` while staying on the Bravo branch.
30+
9. Added team-branch governance documentation in `docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md`.
31+
10. Regenerated the required Codex report artifacts for this correction.
32+
11. Packaged the correction ZIP under `tmp/`.
33+
34+
## Final Branch/Status
35+
36+
- Final working branch: `bravo/26177-text-to-speech`
37+
- Final branch status after commit: `## bravo/26177-text-to-speech...origin/main [ahead 2]`
38+
- Final branch clean status: PASS, no staged or unstaged file entries were reported.
39+
- Local `main` ref: reset to `origin/main`.
40+
- Codex must remain on `bravo/26177-text-to-speech` after this correction.
41+
42+
## Main Clean Check
43+
44+
| Check | Result | Evidence |
45+
| --- | --- | --- |
46+
| Local `main` equals `origin/main` | PASS | `git diff --quiet main origin/main` returned success after correction. |
47+
| Bravo audit changes removed from local `main` | PASS | `main` ref was moved back to `origin/main`; Bravo audit commit is retained on `bravo/26177-text-to-speech`. |
48+
| No commit performed on dirty `main` | PASS | Correction commit is made only on `bravo/26177-text-to-speech`. |
49+
50+
## Bravo Branch Clean Check
51+
52+
| Check | Result | Evidence |
53+
| --- | --- | --- |
54+
| Current branch is Bravo branch | PASS | `git status --short --branch` reports `bravo/26177-text-to-speech`. |
55+
| Bravo branch contains PR_26177_BRAVO_001 audit report | PASS | `docs_build/dev/reports/PR_26177_BRAVO_001-audit-text-to-speech-profiles-emotions.md` is present on the Bravo branch. |
56+
| Bravo branch contains PR_26177_BRAVO_002 governance correction report | PASS | This report is present on the Bravo branch. |
57+
| Bravo branch clean after commit | PASS | `git status --short --branch` reported only the branch header and no staged/unstaged file entries. |
58+
59+
## Requirement Checklist
60+
61+
| Requirement | Result | Notes |
62+
| --- | --- | --- |
63+
| Inspect current branch and git status | PASS | Initial branch/status captured before correction. |
64+
| If current branch is main and dirty, do not commit on main | PASS | No commit was made on `main`. |
65+
| Create or switch to `bravo/26177-text-to-speech` | PASS | Branch created from `origin/main`; final work remains there. |
66+
| Preserve current Bravo audit changes and commit on Bravo only | PASS | Prior audit commit was cherry-picked to the Bravo branch. |
67+
| Ensure main has no staged or unstaged changes after correction | PASS | Local `main` ref equals `origin/main`; correction worktree remains on Bravo. |
68+
| Do not switch back to main except validation | PASS | Correction stayed on Bravo after branch creation; main clean check used ref comparison. |
69+
| Stay on `bravo/26177-text-to-speech` after correction | PASS | Final branch remains Bravo. |
70+
| Keep PR_26177_BRAVO_001 changes on Bravo branch | PASS | Audit report commit is on Bravo branch. |
71+
| Add/adjust governance documentation for staying on team branch until EOD | PASS | `TEAM_ASSIGNMENTS.md` now requires staying on the assigned team branch until EOD or owner-approved merge checkpoint. |
72+
| Document returning to main between sequential PRs is prohibited | PASS | Added explicit prohibition in `TEAM_ASSIGNMENTS.md`. |
73+
| Document staged/unstaged changes on main during team work is a governance failure | PASS | Added explicit governance-failure language and correction path. |
74+
| No feature implementation | PASS | Only governance docs and reports changed. |
75+
| No unrelated cleanup | PASS | No unrelated cleanup performed. |
76+
| Do not modify `start_of_day` folders | PASS | No `start_of_day` paths modified. |
77+
| Required reports present | PASS | Codex diff, changed-files report, and this PR report are included. |
78+
| Repo-structured ZIP under `tmp/` | PASS | ZIP path listed above. |
79+
80+
## Validation Lane Report
81+
82+
| Command | Result |
83+
| --- | --- |
84+
| `git status --short --branch` | PASS, initial status captured on `main`; post-correction status captured on Bravo. |
85+
| `git rev-parse --verify MERGE_HEAD` | PASS, confirmed interrupted merge before correction. |
86+
| `git merge --abort` | PASS, cleared the interrupted merge on `main`. |
87+
| `git switch -c bravo/26177-text-to-speech origin/main` | PASS, created active Bravo branch from `origin/main`. |
88+
| `git cherry-pick cda216906` | PARTIAL, expected Codex artifact conflicts resolved with the cherry-picked audit versions. |
89+
| `git branch -f main origin/main` | PASS, restored local `main` ref to `origin/main`. |
90+
| `git diff --quiet main origin/main` | PASS, local `main` equals `origin/main`. |
91+
| `rg -n "Returning to \`main\` between sequential|governance failure|stay on the assigned team branch" docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md` | PASS, governance wording present. |
92+
| `git diff --check -- docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md docs_build/dev/reports/PR_26177_BRAVO_002-correct-team-branch-governance.md docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/codex_review.diff` | PASS, no whitespace errors expected before commit. |
93+
94+
## Manual Validation Notes
95+
96+
- The correction intentionally did not commit or stage new work on `main`.
97+
- The prior PR_26177_BRAVO_001 audit report is now retained on the Bravo branch.
98+
- Local `main` was validated by ref comparison instead of switching back to `main`.
99+
- The governance doc now says team-day Codex work stays on the assigned team branch until EOD or explicit owner-approved merge checkpoint.
100+
- The governance doc now says returning to `main` between sequential team PRs is prohibited.
101+
- The governance doc now says staged changes, unstaged changes, unmerged state, or direct commit on `main` during team work is a governance failure.
102+
103+
## Changed Files
104+
105+
- `docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md`
106+
- `docs_build/dev/reports/codex_review.diff`
107+
- `docs_build/dev/reports/codex_changed_files.txt`
108+
- `docs_build/dev/reports/PR_26177_BRAVO_002-correct-team-branch-governance.md`
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
# Scoped changed files
2+
M docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md
23
M docs_build/dev/reports/codex_changed_files.txt
34
M docs_build/dev/reports/codex_review.diff
5+
A docs_build/dev/reports/PR_26177_BRAVO_002-correct-team-branch-governance.md
6+
7+
# Branch correction preserved from prior commit on Bravo branch
48
A docs_build/dev/reports/PR_26177_BRAVO_001-audit-text-to-speech-profiles-emotions.md
59

610
# Notes
7-
- `codex_review.diff` captures the reviewable audit-report addition and intentionally avoids recursive self-diff expansion.
811
- No implementation files were modified.
12+
- Local `main` was restored to `origin/main`.
13+
- Current work remains on `bravo/26177-text-to-speech`.
914
- Required delta ZIP is generated under `tmp/` and must not be staged.

0 commit comments

Comments
 (0)