Skip to content

Commit 221eac0

Browse files
committed
Set primary navigation order and polish role banner - PR_26155_038-040-header-navigation
1 parent d920035 commit 221eac0

12 files changed

Lines changed: 322 additions & 55 deletions

File tree

account/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<head>
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<title>Account Home - Game Foundry Studio</title>
8-
<meta name="description" content="Plan the personal account workspace for Game Foundry Studio creators.">
7+
<title>Account Home - GameFoundryStudio</title>
8+
<meta name="description" content="Plan the personal account workspace for GameFoundryStudio creators.">
99
<link rel="icon" href="/favicon.svg">
1010
<link rel="stylesheet" href="../assets/theme-v2/css/theme.css">
1111
</head>

admin/site-settings.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<head>
44
<meta charset="utf-8">
55
<meta name="viewport" content="width=device-width, initial-scale=1">
6-
<title>Site Settings - Game Foundry Studio</title>
7-
<meta name="description" content="Plan global site settings for Game Foundry Studio.">
6+
<title>Site Settings - GameFoundryStudio</title>
7+
<meta name="description" content="Plan global site settings for GameFoundryStudio.">
88
<link rel="icon" href="/favicon.svg">
99
<link rel="stylesheet" href="../assets/theme-v2/css/theme.css">
1010
</head>

assets/theme-v2/partials/header-nav.html

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -5,35 +5,6 @@
55
<span>GameFoundryStudio</span>
66
</a>
77
<nav class="nav-links" aria-label="Main navigation">
8-
<div class="nav-item">
9-
<a data-nav-link data-route="account" href="account/index.html">Account &#9662;</a>
10-
<div class="sub-menu">
11-
<a data-nav-link data-route="account" href="account/index.html">Account Home</a>
12-
<a data-nav-link data-route="account-achievements" href="account/achievements.html">Achievements</a>
13-
<a data-nav-link data-route="account-preferences" href="account/preferences.html">Preferences</a>
14-
<a data-nav-link data-route="account-profile" href="account/profile.html">Profile</a>
15-
<a data-nav-link data-route="account-security" href="account/security.html">Security</a>
16-
</div>
17-
</div>
18-
<div class="nav-item">
19-
<a data-nav-link data-route="admin" href="admin/site-settings.html">Admin &#9662;</a>
20-
<div class="sub-menu">
21-
<a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
22-
<a data-nav-link data-route="admin-branding" href="admin/branding.html">Branding</a>
23-
<a data-nav-link data-route="admin-controls" href="admin/controls.html">Controls</a>
24-
<a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
25-
<a data-nav-link data-route="environments" href="toolbox/environments/index.html">Environments</a>
26-
<a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
27-
<a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
28-
<a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
29-
<a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
30-
<a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
31-
<a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
32-
<a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
33-
<a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
34-
<a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
35-
</div>
36-
</div>
378
<div class="nav-item">
389
<a data-nav-link data-route="games" href="games/index.html">Games &#9662;</a>
3910
<div class="sub-menu">
@@ -46,8 +17,6 @@
4617
<a data-nav-link data-route="game-strategy" href="games/strategy/index.html">Strategy</a>
4718
</div>
4819
</div>
49-
<a data-nav-link data-route="learn" href="learn/index.html">Learn</a>
50-
<a data-nav-link data-route="marketplace" href="marketplace/index.html">Marketplace</a>
5120
<div class="nav-item">
5221
<a data-nav-link data-route="toolbox" href="toolbox/index.html">Toolbox &#9662;</a>
5322
<div class="sub-menu sub-menu--toolbox" data-toolbox-menu aria-label="Toolbox menu">
@@ -125,6 +94,37 @@
12594
</div>
12695
</div>
12796
</div>
97+
<a data-nav-link data-route="marketplace" href="marketplace/index.html">Marketplace</a>
98+
<a data-nav-link data-route="learn" href="learn/index.html">Learn</a>
99+
<div class="nav-item">
100+
<a data-nav-link data-route="account" href="account/index.html">Account &#9662;</a>
101+
<div class="sub-menu">
102+
<a data-nav-link data-route="account" href="account/index.html">Account Home</a>
103+
<a data-nav-link data-route="account-achievements" href="account/achievements.html">Achievements</a>
104+
<a data-nav-link data-route="account-preferences" href="account/preferences.html">Preferences</a>
105+
<a data-nav-link data-route="account-profile" href="account/profile.html">Profile</a>
106+
<a data-nav-link data-route="account-security" href="account/security.html">Security</a>
107+
</div>
108+
</div>
109+
<div class="nav-item">
110+
<a data-nav-link data-route="admin" href="admin/site-settings.html">Admin &#9662;</a>
111+
<div class="sub-menu">
112+
<a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
113+
<a data-nav-link data-route="admin-branding" href="admin/branding.html">Branding</a>
114+
<a data-nav-link data-route="admin-controls" href="admin/controls.html">Controls</a>
115+
<a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
116+
<a data-nav-link data-route="environments" href="toolbox/environments/index.html">Environments</a>
117+
<a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
118+
<a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
119+
<a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
120+
<a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
121+
<a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
122+
<a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
123+
<a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
124+
<a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
125+
<a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
126+
</div>
127+
</div>
128128
</nav>
129129
<div class="nav-actions">
130130
<a class="btn" data-route="games" href="games/index.html">Play Games</a>

docs_build/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,16 @@ Future guidance:
136136

137137
Navigation menus, submenus, nested submenus, and user-facing lists must be alphabetically sorted when they are presented as browseable choices.
138138

139+
Primary top-level header navigation is an explicit product IA exception and must remain:
140+
- Games
141+
- Toolbox
142+
- Marketplace
143+
- Learn
144+
- Account
145+
- Admin
146+
139147
Allowed intentional-order exceptions:
148+
- primary top-level header navigation
140149
- workflow paths
141150
- Build Path
142151
- dependency paths
Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# PR_26155_040 Header Navigation Validation Report
2+
3+
## Scope
4+
5+
Validated common header rendering on:
6+
- `root/index.html`
7+
- `toolbox/index.html`
8+
- `games/index.html`
9+
- `marketplace/index.html`
10+
- `learn/index.html`
11+
- `account/index.html`
12+
- `admin/site-settings.html`
13+
14+
## Primary Navigation
15+
16+
Expected and verified top-level order:
17+
- Games
18+
- Toolbox
19+
- Marketplace
20+
- Learn
21+
- Account
22+
- Admin
23+
24+
This is an explicit documented exception to alphabetical navigation sorting.
25+
26+
## Submenu And List Sorting
27+
28+
Verified alphabetical sorting for:
29+
- Toolbox group labels.
30+
- Toolbox nested submenu labels.
31+
- Account submenu labels.
32+
- Admin submenu labels.
33+
- Games submenu labels.
34+
- Footer link lists.
35+
- Learn hub cards and tool links.
36+
37+
Documented exceptions:
38+
- Primary top-level header navigation follows product information architecture order.
39+
- Build Path remains dependency ordered.
40+
- Project Progress and Publishing Progress remain progress ordered.
41+
- Guided Learn tool page sections remain intentionally ordered.
42+
43+
## Role Banner
44+
45+
Verified for `toolbox/index.html`:
46+
- Banner is after the shared header partial and before `main`.
47+
- Banner is a single clickable status row.
48+
- Guest, creator, and admin role modes remain supported.
49+
- Banner uses existing Theme V2 `callout` and `status` classes.
50+
51+
## Skipped Changes
52+
53+
- No Project Workspace implementation was started.
54+
- No DB, auth, persistence, or save/load behavior was added.
55+
- No new tools were added.
56+
- No CSS was added or modified.
57+
58+
## Validation Notes
59+
60+
- First validation run exposed two issues:
61+
- The partial loader keeps the header inside its placeholder wrapper, so the role-banner position assertion was adjusted to match the actual Theme V2 partial structure.
62+
- Old standalone brand-suffix copy existed on common pages; those text-only labels were updated.
63+
- Final validation:
64+
- `npm run test:workspace-v2` passed with 4 Playwright tests.
65+
- Common header pages had no page errors or console errors.
66+
- `git diff --check` passed.
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# PR_26155_039 Header Role Banner Polish
2+
3+
## Summary
4+
5+
Verified the Toolbox role banner remains a single-line row directly after the shared header partial and before the Toolbox main content.
6+
7+
Supported role modes remain:
8+
- `?role=guest`
9+
- `?role=user`
10+
- `?role=admin`
11+
12+
## Behavior
13+
14+
The existing clickable role switch behavior is preserved:
15+
- Guest view links to creator view.
16+
- Creator view links to admin view.
17+
- Admin view links back to creator view.
18+
19+
The banner continues to use existing Theme V2 styling only:
20+
- container row: `container callout`
21+
- clickable banner: `status`
22+
23+
No page-local CSS, inline styles, style blocks, DB, auth, persistence, or new tools were added.
24+
25+
## Manual Test Notes
26+
27+
- Guest banner text: `GUEST VIEW • Preview only • Sign in to create`.
28+
- Creator banner text: `CREATOR VIEW • Project tools enabled • Switch to Admin View`.
29+
- Admin banner text: `ADMIN VIEW • Planned tools visible • Switch to Creator View`.
30+
- Banner remains the final header row for `toolbox/index.html`.
31+
- Banner background/status styling is present through existing Theme V2 classes.
32+
33+
## Validation Notes
34+
35+
- `npm run test:workspace-v2` passed with 4 Playwright tests.
36+
- The test lane verifies role switching, banner position, banner styling classes, and no console errors on the common header pages.
37+
- No CSS was added or modified.

docs_build/dev/reports/navigation-and-list-sorting-rule.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
Added governance requiring navigation menus, submenus, nested submenus, and browseable user-facing lists to sort alphabetically.
66

77
Normalized safe active surfaces:
8-
- Header top-level navigation.
98
- Header Games submenu.
109
- Header Toolbox group order.
1110
- Header Toolbox nested tool submenus.
@@ -17,6 +16,7 @@ Normalized safe active surfaces:
1716
## Sorting Exceptions
1817

1918
Documented intentional-order exceptions:
19+
- Header top-level navigation is intentionally ordered by product IA: Games, Toolbox, Marketplace, Learn, Account, Admin.
2020
- Build Path remains dependency ordered: Project Workspace, Game Design, Game Configuration, Required Tool Path, Build Game, Game Testing, Publish.
2121
- Project Progress and Publishing Progress remain progress/workflow ordered.
2222
- Individual Learn tool page section order remains a guided documentation sequence: Overview, Quick Start, Common Tasks, Related Documentation, Related Videos, Examples.
Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
# PR_26155_038 Primary Navigation Order
2+
3+
## Summary
4+
5+
Set the primary top-level header navigation order exactly:
6+
- Games
7+
- Toolbox
8+
- Marketplace
9+
- Learn
10+
- Account
11+
- Admin
12+
13+
This order is now documented in `docs_build/dev/PROJECT_INSTRUCTIONS.md` as an explicit product information architecture exception to the alphabetical navigation rule.
14+
15+
## Sorting Rule Impact
16+
17+
Alphabetical sorting still applies to:
18+
- Header submenus.
19+
- Toolbox nested submenus.
20+
- Account menu links.
21+
- Admin menu links.
22+
- Games menu links.
23+
- Footer link lists.
24+
- Browseable Learn lists.
25+
- Browseable Toolbox group mode.
26+
27+
Documented intentional-order exceptions:
28+
- Primary top-level header navigation.
29+
- Workflow paths.
30+
- Build Path.
31+
- Dependency paths.
32+
- Project Progress.
33+
- Publishing Progress.
34+
- Guided creator steps.
35+
36+
## Additional Text Cleanup
37+
38+
The common header validation found old standalone brand-suffix copy on the exact active pages under test. These labels were updated to `GameFoundryStudio` or current creator-facing names:
39+
- `index.html`
40+
- `games/index.html`
41+
- `marketplace/index.html`
42+
- `account/index.html`
43+
- `admin/site-settings.html`
44+
45+
## Manual Test Notes
46+
47+
- Header order is Games, Toolbox, Marketplace, Learn, Account, Admin.
48+
- Toolbox submenu groups remain alphabetical.
49+
- Toolbox nested menu items remain alphabetical.
50+
- Account, Admin, and Games submenu links remain alphabetical.
51+
- Admin is not duplicated under Toolbox.
52+
- Arcade remains a Games menu item only and is absent from Toolbox.
53+
54+
## Validation Notes
55+
56+
- `npm run test:workspace-v2` passed with 4 Playwright tests.
57+
- `git diff --check` passed.
58+
- No CSS was added or modified.

games/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<head>
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<title>Games - Game Foundry Studio</title>
8-
<meta name="description" content="Browse Game Foundry Studio game types and playable game folders.">
7+
<title>Games - GameFoundryStudio</title>
8+
<meta name="description" content="Browse GameFoundryStudio game types and playable game folders.">
99
<link rel="icon" href="/favicon.svg">
1010
<link rel="stylesheet" href="../assets/theme-v2/css/theme.css">
1111
</head>

index.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<head>
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<title>Game Foundry Studio - Build. Play. Share.</title>
8-
<meta name="description" content="Build, play, publish, and share browser games with Game Foundry Studio.">
7+
<title>GameFoundryStudio - Build. Play. Share.</title>
8+
<meta name="description" content="Build, play, publish, and share browser games with GameFoundryStudio.">
99
<link rel="icon" href="/favicon.svg">
1010
<link rel="stylesheet" href="assets/theme-v2/css/theme.css">
1111
</head>
@@ -19,19 +19,19 @@
1919
<div class="kicker">Browser-native creator platform</div>
2020
<h1>Build. Play. Share.</h1>
2121
<p class="lede">Create browser games with visual tools, reusable assets, manifest-driven configuration, and
22-
publishing workflows that make Game Foundry Studio feel like a destination, not just an engine.</p>
22+
publishing workflows that make GameFoundryStudio feel like a destination, not just an engine.</p>
2323
<div class="hero-cta"><a class="btn primary" href="toolbox/index.html">Start Building</a><a class="btn"
2424
href="games/index.html">Explore Games</a></div>
2525
<div class="dual-entry" aria-label="Primary entry points">
2626
<a class="entry-card" href="toolbox/index.html"><span>Build</span><strong>Create Games</strong><small>Open the
27-
Studio</small></a>
27+
Toolbox</small></a>
2828
<a class="entry-card" href="games/index.html"><span>Play</span><strong>Play Games</strong><small>Browse the
2929
Arcade</small></a>
3030
</div>
3131
</div>
32-
<aside class="hero-art" aria-label="Game Foundry Studio logo artwork">
32+
<aside class="hero-art" aria-label="GameFoundryStudio logo artwork">
3333
<img src="assets/theme-v2/images/game-foundry-studio-logo.png"
34-
alt="Game Foundry Studio forged logo with anvil, sword, die, and gear">
34+
alt="GameFoundryStudio forged logo with anvil, sword, die, and gear">
3535
</aside>
3636
</div>
3737
</section>
@@ -93,7 +93,7 @@ <h3>Staff Picks</h3>
9393
<section class="section" id="what">
9494
<div class="container split">
9595
<div>
96-
<div class="kicker">What is Game Foundry Studio?</div>
96+
<div class="kicker">What is GameFoundryStudio?</div>
9797
<h2>A complete place to create, test, publish, and play.</h2>
9898
<p class="lede small">No engine setup. No complicated installs. Create directly in the browser with clear
9999
tools, friendly guardrails, and reusable game-building pieces.</p>
@@ -121,19 +121,19 @@ <h2>Creator tools with guardrails.</h2>
121121
<div class="card-grid">
122122
<article class="card">
123123
<div class="card-body">
124-
<h3>Asset Studio</h3>
124+
<h3>Assets</h3>
125125
<p>Create sprites, animations, vectors, palettes, previews, and reusable game assets.</p>
126126
</div>
127127
</article>
128128
<article class="card">
129129
<div class="card-body">
130-
<h3>World Studio</h3>
130+
<h3>Worlds</h3>
131131
<p>Build maps, layers, object placement, world bounds, collisions, and camera rules.</p>
132132
</div>
133133
</article>
134134
<article class="card">
135135
<div class="card-body">
136-
<h3>Input Studio</h3>
136+
<h3>Controls</h3>
137137
<p>Configure keyboard, mouse, gamepads, touch, pen, wheel, and custom controls.</p>
138138
</div>
139139
</article>
@@ -155,7 +155,7 @@ <h2>ForgeBot, Spark, Pixel Smith, and Foundry Bot.</h2>
155155
<section class="section">
156156
<div class="container cta">
157157
<h2>Forge games for the open web.</h2>
158-
<p class="lede small">Game Foundry Studio can grow into Studio, Arcade, Marketplace, Cloud, and Learn without
158+
<p class="lede small">GameFoundryStudio can grow into Toolbox, Games, Marketplace, Cloud, and Learn without
159159
changing the core brand.</p><a class="btn primary" href="admin/branding.html">Open Brand Kit</a>
160160
</div>
161161
</section>

0 commit comments

Comments
 (0)