Skip to content

Commit fbba883

Browse files
authored
fix: green socket-cli main 🔎 Check (script paths, citations, action port map, coverage badge) (#1437)
* fix: repoint moved fleet script paths and wire lockstep:emit-mirror-globs The scripts/repo migration moved check.mts and update.mts into scripts/fleet/, but packages/cli/package.json still pointed its "check" and "update" scripts at the old ../../scripts/*.mts paths, failing check-script-paths-resolve. The lockstep-emit-mirror-globs.mts script cascaded in (and its sibling lockstep:emit-schema is wired), but the root package.json never got the matching lockstep:emit-mirror-globs alias, so the updating-lockstep skill docs cited a pnpm script that did not resolve, failing check-pnpm-run-citations-resolve. - packages/cli/package.json: check -> ../../scripts/fleet/check.mts - packages/cli/package.json: update -> ../../scripts/fleet/update.mts - package.json: add lockstep:emit-mirror-globs pointing at the existing scripts/fleet/lockstep-emit-mirror-globs.mts shim * fix: green remaining 🔎 Check residuals (action port map + coverage badge) Two fleet-drift 🔎 Check failures on main, independent of the script-path/citation fix: - action-ports-are-lock-stepped: the setup-go-toolchain composite had no port-map entry. Its action.yml states it is "written inline so we don't depend on a third-party action" and only borrows actions/setup-go's generic fallback ordering, porting neither its input surface nor its go.dev/dl download algorithm — so it is Socket-original (`[]`), not a lock-stepped port. - coverage-badge-is-current: the README carried a shields.io badge with a decimal percent (coverage-75.08%25) that the migrator's integer-only matcher could not recognize, tripping the unrecognized-form gate. Repointed to the canonical repo-local asset badges/coverage.svg (the generated placeholder SVG already exists and is tracked).
1 parent d93a2b4 commit fbba883

4 files changed

Lines changed: 11 additions & 3 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Socket CLI
22

33
[![Socket Badge](https://socket.dev/api/badge/npm/package/socket)](https://socket.dev/npm/package/socket)
4-
![Coverage](https://img.shields.io/badge/coverage-75.08%25-brightgreen)
4+
![Coverage](assets/repo/badges/coverage.svg)
55

66
[![Follow @SocketSecurity](https://img.shields.io/twitter/follow/SocketSecurity?style=social)](https://twitter.com/SocketSecurity)
77
[![Follow @socket.dev on Bluesky](https://img.shields.io/badge/Follow-@socket.dev-1DA1F2?style=social&logo=bluesky)](https://bsky.app/profile/socket.dev)

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"// lockstep": "",
4343
"lockstep": "node scripts/fleet/lockstep.mts",
4444
"lockstep:emit-schema": "node scripts/fleet/lockstep-emit-schema.mts",
45+
"lockstep:emit-mirror-globs": "node scripts/fleet/lockstep-emit-mirror-globs.mts",
4546
"// Setup": "",
4647
"setup": "node scripts/repo/setup.mts",
4748
"postinstall": "node scripts/repo/setup.mts --install --quiet",

‎packages/cli/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"build:sea": "node --max-old-space-size=8192 --import=./scripts/load.mts scripts/build-sea.mts",
3636
"build:js": "node scripts/build-js.mts",
3737
"dev:watch": "pnpm run build:watch",
38-
"check": "node ../../scripts/check.mts",
38+
"check": "node ../../scripts/fleet/check.mts",
3939
"check-ci": "pnpm run check",
4040
"lint": "oxlint -c ../../.config/oxlintrc.json",
4141
"lint-ci": "pnpm run lint",
@@ -71,7 +71,7 @@
7171
"test:validate": "node --import=./scripts/load.mts scripts/validate-tests.mts",
7272
"test-ci": "run-s test:prepare test:unit test:validate",
7373
"test-pre-commit": "cross-env PRE_COMMIT=1 pnpm test",
74-
"update": "node ../../scripts/update.mts",
74+
"update": "node ../../scripts/fleet/update.mts",
7575
"verify": "node scripts/verify-package.mts",
7676
"wasm": "node scripts/wasm.mts",
7777
"wasm:build": "node scripts/wasm.mts --build",

‎scripts/fleet/_shared/action-port-map.mts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,13 @@ export const COMPOSITE_ACTION_PORTS: Readonly<
7878
'setup-git-signing': [
7979
{ portedAt: 'v7.0.0', upstream: 'crazy-max/ghaction-import-gpg' },
8080
],
81+
// Socket-original inline Go-toolchain locator: its header states it is
82+
// "written inline so we don't depend on a third-party action". It only takes
83+
// inspiration from actions/setup-go's generic fallback ordering (PATH →
84+
// hosted toolcache → distro package manager → bail); it ports neither that
85+
// action's input surface nor its go.dev/dl download algorithm, so there is no
86+
// upstream release to lock-step against.
87+
'setup-go-toolchain': [],
8188
}
8289

8390
// Split an `<owner>/<repo>` slug; undefined when the shape is wrong. Pure.

0 commit comments

Comments
 (0)