Skip to content

Remove ts-ignore suppressions from payload store tests#8105

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/payload-store-test-types
Open

Remove ts-ignore suppressions from payload store tests#8105
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/payload-store-test-types

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes none.

The payload store tests used @ts-ignore to assert test-only merged payload fields, which made the assertions less type-safe than necessary.

WHAT is this pull request doing?

Removes the @ts-ignore suppressions by asserting the updated extension payload with toMatchObject instead of accessing ad-hoc fields directly.

How to test your changes?

  • pnpm --filter @shopify/app vitest run src/cli/services/dev/extension/payload/store.test.ts
  • pnpm --filter @shopify/app lint

Note: pnpm --filter @shopify/app type-check was attempted locally but failed on existing @shopify/organizations resolution/type errors unrelated to this test-only diff.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/992f9535-2b53-46c8-a775-0fc7a7bc2eb5

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alfonso-noriega alfonso-noriega changed the title Tighten store list BP test types Remove ts-ignore suppressions from payload store tests Jul 16, 2026
@alfonso-noriega
alfonso-noriega marked this pull request as ready for review July 16, 2026 09:24
@alfonso-noriega
alfonso-noriega requested a review from a team as a code owner July 16, 2026 09:24
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant