[Tests] Remove filesystem mocks in extension.test.ts#7681
[Tests] Remove filesystem mocks in extension.test.ts#7681gonzaloriestra wants to merge 1 commit into
Conversation
This PR refactors the unit tests for `buildFunctionExtension` in `packages/app/src/cli/services/build/extension.test.ts` to eliminate filesystem mocks. Following our updated testing standards, it now uses real temporary directories and filesystem operations via `@shopify/cli-kit/node/fs` utilities.
Changes:
- Removed global `vi.mock('@shopify/cli-kit/node/fs')`.
- Wrapped tests in `inTemporaryDirectory`.
- Updated test setup to create real files and directories.
- Refined assertions to verify actual state on disk where appropriate.
- Ensured proper type-safety for mocks by casting to `Writable` or `any` where needed.
- Fixed mock rejection to use `Error` objects instead of strings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
WHY are these changes introduced?
Following the testing standards to avoid mocking the filesystem and use real temporary directories instead. This makes tests more robust and less coupled to implementation details.
WHAT is this pull request doing?
Refactors
packages/app/src/cli/services/build/extension.test.tsto removevi.mock('@shopify/cli-kit/node/fs'). It now usesinTemporaryDirectoryand real filesystem operations for setup and assertions.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 2100486209806891838 started by @gonzaloriestra