Skip to content

Stop converting null string arguments into empty strings #334

@ChrisThrasher

Description

@ChrisThrasher

Some APIs check will convert null const char* arguments to an empty string. I propose CSFML stop doing this except where the API actually promises that the behavior of null arguments is defined.

For example:

sfFtpResponse* sfFtp_login(sfFtp* ftp, const char* name, const char* password)
{
assert(ftp);
return new sfFtpResponse{ftp->This.login(name ? name : "", password ? password : "")};
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions