refactor(aicore): rename AICORE_PROXY_VIRTUAL_KEY → AICORE_PROXY_API_KEY

The previous name was misleading — the SDK reads the LiteLLM proxy master
API key, not a virtual (per-user/per-team) key. AICORE_PROXY_API_KEY is
accurate for both master key and virtual key usage.

Aligned with Sam Garland (CAD) feedback on ADR 0039 review.

Author: tiagoek

src/sap_cloud_sdk/aicore/__init__.py

@@ -38,7 +38,7 @@
 # Option 3 — transparent proxy routing.
 # Deployer injects these; agent code is identical in all environments.
 _PROXY_URL_ENV = "AICORE_PROXY_URL"
-_PROXY_VIRTUAL_KEY_ENV = "AICORE_PROXY_VIRTUAL_KEY"
+_PROXY_API_KEY_ENV = "AICORE_PROXY_API_KEY"
 _DESTINATION_NAME_ENV = "AICORE_DESTINATION_NAME"
 
 
@@ -186,10 +186,10 @@ def _configure_proxy_mode(proxy_url: str) -> None:
     """
     import litellm as _litellm
 
-    virtual_key = os.environ.get(_PROXY_VIRTUAL_KEY_ENV, "")
+    api_key = os.environ.get(_PROXY_API_KEY_ENV, "")
     _litellm.api_base = proxy_url
-    if virtual_key:
-        _litellm.api_key = virtual_key
+    if api_key:
+        _litellm.api_key = api_key
     logger.info("AI Core proxy mode active — routing via %s", proxy_url)
 
 

tests/aicore/unit/test_aicore.py

@@ -865,7 +865,7 @@ def test_proxy_mode_sets_litellm_api_key_when_virtual_key_present(self):
             patch("sap_cloud_sdk.aicore.set_filtering"),
             patch.dict(
                 "os.environ",
-                self._base_proxy_env(AICORE_PROXY_VIRTUAL_KEY="sk-virt-123"),
+                self._base_proxy_env(AICORE_PROXY_API_KEY="sk-virt-123"),
                 clear=True,
             ),
         ):