Skip to content

Filemin doesn't log any action in Webmin action log - May be enhancement #137

Description

@eldk

Hello,

File Manager was registering action on file save. This allowed to trace all files edited and changed.

Try to find it by modifying files with Filemin : no logs and action logs are registered.

The Webmin Action Log has been checked, "Log changes made to files by each action?" is set to yes.

Am I missing something ?

Should it be implemented ?

Thanks,

Eric

https://github.com/webmin/webmin/blob/b335a0dce27c0b1b705f9d190d454e69c245dd8d/web-lib-funcs.pl#L5665

https://github.com/webmin/webmin/blob/b335a0dce27c0b1b705f9d190d454e69c245dd8d/file/save.cgi#L37

https://github.com/webmin/webmin/blob/master/file/file-lib.pl

https://github.com/Real-Gecko/Filemin/blob/master/save_file.cgi

Where were action logs in java file manager :
chmod.cgi:&webmin_log($in{'linkto'} ? "relink" : "chmod", undef, $in{'path'}, \%in);
copy.cgi:&webmin_log("copy", undef, $in{'from'}, \%in);
delete.cgi:&webmin_log("delete", undef, $in{'file'}, \%in);
extract.cgi:&webmin_log("extract", undef, $in{'file'});
makelink.cgi:&webmin_log("link", undef, $in{'from'}, \%in);
mkdir.cgi:&webmin_log("mkdir", undef, $in{'dir'}, \%in);
move.cgi:&webmin_log("move", undef, $in{'from'}, \%in);
rename.cgi:&webmin_log("rename", undef, $in{'old'}, \%in);
save.cgi:&webmin_log("save", undef, $p) if ($access{'uid'});
save.cgi: &webmin_log("save", undef, $p) if (!$access{'uid'});
save_export.cgi: &webmin_log($in{'delete'} ? 'delete' : $in{'new'} ? 'create' : 'modify',
save_export.cgi: &webmin_log($in{'delete'} ? 'delete' : $in{'new'} ? 'create' : 'modify',
save_share.cgi:&webmin_log($in{'delete'} ? 'delete' : $in{'new'} ? 'create' : 'modify',
setattrs.cgi:&webmin_log("attr", undef, $in{'file'}, \%in);
setfacl.cgi:&webmin_log("acl", undef, $in{'file'}, \%in);
upload2.cgi: &webmin_log("upload", undef, $in{'path'});
upload.cgi: &webmin_log("upload", undef, $path);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions