feat(audience): print job link when assigning to audience#648
Merged
Conversation
assign_job now prints the job's dashboard link, mirroring how RapidataOrder.run() prints the order link. This completes the parallel with orders: creating a job definition already prints the preview QR + dashboard link (like creating an order), and assigning the job to an audience now surfaces the live job link (like running an order). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: lino <lino@rapidata.ai>
ReviewSmall, well-scoped change: Verified correct:
No correctness, security, or performance issues found. Minor note (pre-existing gap, not introduced by this PR): there's no test coverage for Nothing else to flag — this looks good to merge. |
LinoGiger
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RapidataAudienceBase.assign_job()now prints the job's dashboard link after creating the job, mirroring howRapidataOrder.run()prints the order link.Why
Orders already give you two nudges: creating an order prints a preview QR + dashboard link, and
run()prints the live order link. Job definitions already had the first half (creating a definition prints the preview QR + dashboard link via_qr_preview), but assigning a job to an audience — the analog of running an order — printed nothing. This closes that gap so the job flow matches the order flow.create_*_order→ QR + linkcreate_*_job_definition→ QR + linkrun()→ order linkassign_job()→ job link (new)Change
One line (plus a
managed_printimport) inaudience/_audience_base.py:Wording matches
run()verbatim, andmanaged_printrespectssilent_mode.Checks
uv run black src/rapidata/rapidata_client— cleanuv run pyright src/rapidata/rapidata_client— 0 errors, 0 warnings🔗 Session: https://session-e5579afc.poseidon.rapidata.internal/