Open
Conversation
lkdvos
previously approved these changes
Apr 17, 2026
Member
Author
|
I'm running this locally to see if the failures for CUDA are related or not. We'll also need a TO tag first. |
Member
Author
|
Can't repro the factorization failures, annoying... |
Member
Author
|
Now needs the MAK bump which itself needs the Mooncake and Enzyme ones |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
added 2 commits
April 25, 2026 08:17
Member
Author
|
OK I think this is good to go now that things are passing |
Member
Author
|
... or not. These chainrules failures are suprising to me, it seems it should be unrelated as this PR doesn't touch that code. Could it maybe be related to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.