Skip to content

Use a test setup matrix like TensorKit#215

Open
kshyatt wants to merge 7 commits intomainfrom
ksh/test_setup
Open

Use a test setup matrix like TensorKit#215
kshyatt wants to merge 7 commits intomainfrom
ksh/test_setup

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented Apr 22, 2026

Should give us some benefit from draft PRs and splitting the tests into smaller chunks

@kshyatt kshyatt requested a review from lkdvos April 22, 2026 14:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Apr 22, 2026

Probably need a way to turn off the Mac + Enzyme combo which is known to be bad due to underpowered mac mini runners

Comment thread .github/workflows/Tests.yml Outdated
Comment thread .github/workflows/Tests.yml Outdated
Comment thread .github/workflows/Tests.yml
Copy link
Copy Markdown
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree that we should start using similar setups in many places, but it could be nice if we could uniformize this and use a shared action/test setup, to keep this maintainable in the future?

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Apr 23, 2026

it could be nice if we could uniformize this and use a shared action/test setup, to keep this maintainable in the future?

Sure. I set this up here because the Enzyme tests are impacting other people. If someone wants to set up the shared workflow now, I don't see a problem, otherwise we can do this now and then remove it in another PR later once the shared one is set up?

@kshyatt kshyatt force-pushed the ksh/test_setup branch 4 times, most recently from 6674cec to 4be46d6 Compare April 24, 2026 06:19
Comment thread test/common/utilities.jl
Comment thread test/common/codequality.jl
Comment thread .github/workflows/Tests.yml Outdated
Comment thread .github/workflows/Tests.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants