Fix VM ?: merge blocks and pre/post inc compliance (#137)#1149
Merged
Conversation
CFG join blocks (ternary, branch merges) use sparse scope slot indices. Variadic Frame construction reindexed those slots, so echo after ?: printed empty output and setcookie return values were lost. Preserve slot indices on merge blocks only; resolve merge operands via findSlot on the merge block. Add compliance PHPTs for ++/-- and a unit gate. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/cfg-merge-ternary-scope
branch
from
ae26580 to
b0f9ca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?:, branch joins) where sparse scope slot indices were corrupted by variadicFrameconstruction (emptyechoafter ternary, brokensetcookie()return in expressions).$frame->scopewithout reindexing and resolve operands viafindSloton the merge block.FrameScopeSlotTest.Test plan
tar … | docker run … ./script/ci-fast.sh(22 failures vs 41 on master with same harness tar path; RealWorld 71→1 failure)MiniWebAppVmCliTest,web_setcookieRealWorld case,echo true ? "1" : "0"manual VM checkCloses #137
Made with Cursor