From 521f6b89d7d29b58e5eff9ee38089e8d86c0aea6 Mon Sep 17 00:00:00 2001
From: Sertug17 <srhtsrht17@gmail.com>
Date: Fri, 24 Jul 2026 23:22:44 +0300
Subject: [PATCH] fix: cancelOrder now returns transaction hash like
 cancelOrders

cancelOrder computed transactionHash via cancelSeaportOrders() but never
returned it, leaving callers with no way to obtain the hash. cancelOrders
has always returned it. This aligns the singular method with its plural
counterpart and matches the documented intent ('// Transact and get the
transaction hash' comment was already there).

- cancellation.ts: add return transactionHash + Promise<string> type
- base.ts: add Promise<string> type + @returns JSDoc tag

Fixes #1981
---
 src/sdk/base.ts         | 7 +++++--
 src/sdk/cancellation.ts | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/sdk/base.ts b/src/sdk/base.ts
index 51ae66083..077dc2a07 100644
--- a/src/sdk/base.ts
+++ b/src/sdk/base.ts
@@ -478,14 +478,17 @@ export class BaseOpenSeaSDK {
     return this._cancellationManager.cancelOrders(options)
   }
 
-  /** Cancel an order onchain, preventing it from ever being fulfilled. */
+  /**
+   * Cancel an order onchain, preventing it from ever being fulfilled.
+   * @returns Transaction hash of the cancellation.
+   */
   public async cancelOrder(options: {
     order?: OrderV2
     orderHash?: string
     accountAddress: string
     protocolAddress?: string
     domain?: string
-  }) {
+  }): Promise<string> {
     return this._cancellationManager.cancelOrder(options)
   }
 
diff --git a/src/sdk/cancellation.ts b/src/sdk/cancellation.ts
index fc9b24870..9babe8ddb 100644
--- a/src/sdk/cancellation.ts
+++ b/src/sdk/cancellation.ts
@@ -44,7 +44,7 @@ export class CancellationManager {
     accountAddress: string
     protocolAddress?: string
     domain?: string
-  }) {
+  }): Promise<string> {
     // Validate input
     if (!order && !orderHash) {
       throw new Error(
@@ -106,6 +106,7 @@ export class CancellationManager {
       EventType.CancelOrder,
       "Cancelling order",
     )
+    return transactionHash
   }
 
   /**