Skip to content

Commit 8b56f0d

Browse files
more fixes
1 parent 330db67 commit 8b56f0d

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

asap-planner-rs/src/planner/cleanup.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,11 @@ pub fn get_cleanup_param(
2828
} else {
2929
match_result
3030
.get_range_duration()
31-
.map(|d| d.num_milliseconds() as u64)
31+
.map(|d| {
32+
let ms = d.num_milliseconds();
33+
debug_assert!(ms >= 0, "PromQL range duration should never be negative");
34+
ms as u64
35+
})
3236
.ok_or_else(|| "No range_vector token found".to_string())?
3337
};
3438

asap-planner-rs/src/planner/elastic_dsl.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,16 @@ impl ElasticSingleQueryProcessor {
135135
})
136136
.and_then(|p| range_query_to_time_range(p, 0));
137137
let t_lookback = match time_range {
138-
Some(tr) => tr.duration_ms().unwrap_or(self.t_repeat),
139-
None => self.t_repeat, // Default to repetition delay if no time range found
138+
Some(tr) => tr.duration_ms().unwrap_or(t_repeat_ms),
139+
None => t_repeat_ms,
140140
};
141141

142142
// Calculate cleanup param based on query's time window
143143
let cleanup_param = if self.cleanup_policy == CleanupPolicy::NoCleanup {
144144
None
145145
} else {
146146
Some(
147-
get_sql_cleanup_param(self.cleanup_policy, t_lookback, self.t_repeat)
147+
get_sql_cleanup_param(self.cleanup_policy, t_lookback, t_repeat_ms)
148148
.map_err(ControllerError::PlannerError)?,
149149
)
150150
};

0 commit comments

Comments
 (0)