Skip to content

feat(friend-comparison): add dedicated comparison page and enhanced the component#1663

Open
narang24 wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
narang24:feat/friend-comparison-enhancement
Open

feat(friend-comparison): add dedicated comparison page and enhanced the component#1663
narang24 wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
narang24:feat/friend-comparison-enhancement

Conversation

@narang24
Copy link
Copy Markdown

Summary

Enhanced the Friend Comparison functionality by introducing a dedicated comparison page (endpoint - /friend-compare) and improved UI/UX.

Closes #871

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / code cleanup

Changes Made

  • Since, Friend Comparison functionality deserves a broader and extended display, I have given it a dedicated route /friend-compare
  • The FriendComparison component, as a whole, was hidden, unhighlighted and crowded among the other existing dashboard components, So, A button indicating the functionality is added alongside the quick button links like "Year in Code".
  • I enhanced the metrics comparison display portion, github username + avatar for better UI.
  • I replaced the 'View Commit activity' button with the 'contribution-activity' component(chart) rendering on clicking on compare. Also, added a Clear button in red color for a cleaner and improved overall functionality of the component.

How to Test

Steps for the reviewer to verify this works:

  1. Create a new pull request
  2. Verify the updated PR template appears automatically
  3. Check that all checklist sections render properly
  4. Ensure markdown formatting works correctly

Screenshots (if UI change)

Added a dedicated button and endpoint
Screenshot 2026-05-30 201922
Screenshot 2026-05-30 202131

Improved UI/UX
Screenshot 2026-05-30 202152

Replaced View Commit Activity with the contribution-activity component and added red Clear button
Screenshot 2026-05-30 202207


Checklist

  • Linked issue in summary
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Self-reviewed the diff
  • Added/updated tests if applicable

Accessibility Checklist

  • Proper keyboard navigation tested
  • Responsive UI verified
  • Accessibility labels added where needed

Additional Notes

This update standardizes pull request submissions and helps maintain consistent review quality across contributions.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@narang24 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:feature GSSoC type bonus: new feature labels May 30, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR on DevTrack! 🎉

A maintainer will review it within 48 hours. While you wait:

  • Make sure CI is passing (type-check + lint)
  • Double-check the PR description is filled out and the issue is linked
  • Feel free to ask questions in Discussions if you need help

If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

This PR has merge conflicts with main. Please rebase your branch against the latest main and force-push to resolve. Run: git fetch upstream && git rebase upstream/main

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level2 GSSoC Level 2 - Medium complexity (25 points) labels May 31, 2026
@narang24 narang24 force-pushed the feat/friend-comparison-enhancement branch from de2f112 to 963529b Compare May 31, 2026 06:27
@narang24
Copy link
Copy Markdown
Author

@Priyanshu-byte-coder please review

@Karanjot786
Copy link
Copy Markdown

Hey @narang24! Saw your work on GSSoC 2026.

We are building TermUI, a TypeScript terminal UI framework with React-style hooks and JSX, rendered entirely in the terminal.

We have 67 unassigned GSSoC issues open. 19 are marked good first issue. Your TypeScript background transfers directly.

Karanjot, TermUI maintainer

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

This PR has developed merge conflicts after recent merges to main. Please rebase onto the latest main branch, resolve all conflicts, and force-push. Once the PR is conflict-free it will be reviewed for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level2 GSSoC Level 2 - Medium complexity (25 points) type:feature GSSoC type bonus: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Enhance Friend Comparison with search dropdown, dedicated route, and improved UI

3 participants