Skip to content

Commit b62f3ea

Browse files
authored
Remove .required-coverage check (#244)
A metric as a goal is a poor metric
1 parent 03e4696 commit b62f3ea

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

.github/workflows/python-tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,8 @@ jobs:
7676

7777
- name: "Post summary to step summary"
7878
run: |
79-
export COVERAGE_REQUIRED=$(<.required-coverage)
8079
export TOTAL=$(python -c "import json;print(json.load(open('coverage.json'))['totals']['percent_covered_display'])")
81-
echo "TOTAL=$TOTAL" >> $GITHUB_ENV
82-
echo "### Minimum coverage required: ${COVERAGE_REQUIRED}%" >> $GITHUB_STEP_SUMMARY
83-
echo "### Total coverage: ${TOTAL}%" >> $GITHUB_STEP_SUMMARY
84-
if [ ${COVERAGE_REQUIRED} -gt $TOTAL ]; then
85-
exit 1
86-
fi
80+
echo "COVERAGE-TOTAL=$TOTAL" >> $GITHUB_ENV
8781
8882
linters-and-formatters:
8983
name: "linters and formatters"

.required-coverage

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)