From 3ad1d2cdc0afffbeee7d9b3b4bb7a2cb9a84ba6d Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Jul 2026 16:54:23 +0000
Subject: [PATCH 1/3] Initial plan


From bce5c0a17b84bc57834ffe16adf72fff076f52a2 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Jul 2026 16:58:03 +0000
Subject: [PATCH 2/3] Fix CI: don't upload coverage/tar if build fails

Remove `continue-on-error: true` and `if: always()` guards from
post-build steps (coverage upload, prepare artifact, upload artifact)
in linux-build, macos-build, and windows-build jobs.

Also remove the now-redundant "Fail if rust tests failed" step.
When rust-tests fails, the job now stops naturally without
attempting to package or upload artifacts.
---
 .github/workflows/rust.yml | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index d03853709..0f6d1fd49 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -54,27 +54,20 @@ jobs:
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
         id: rust-tests
-        continue-on-error: true
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: linux-coverage
           path: lcov.info
           if-no-files-found: ignore
       - name:  Prepare build artifact
-        if: always()
         run:   tar -cvf bin.tar bin/
       - name: Upload build artifact
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: linux-bin
           path: bin.tar
-      - name: Fail if rust tests failed
-        if: steps.rust-tests.outcome == 'failure'
-        run: exit 1
   linux-pester:
     needs: linux-build
     strategy:
@@ -146,27 +139,20 @@ jobs:
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
         id: rust-tests
-        continue-on-error: true
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: macos-coverage
           path: lcov.info
           if-no-files-found: ignore
       - name:  Prepare build artifact
-        if: always()
         run:   tar -cvf bin.tar bin/
       - name: Upload build artifact
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: macos-bin
           path: bin.tar
-      - name: Fail if rust tests failed
-        if: steps.rust-tests.outcome == 'failure'
-        run: exit 1
   macos-pester:
     needs: macos-build
     strategy:
@@ -242,30 +228,22 @@ jobs:
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
         id: rust-tests
-        continue-on-error: true
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: windows-coverage
           path: lcov.info
           if-no-files-found: ignore
       - name: List bin folder files
-        if: always()
         run:  Get-ChildItem bin
       - name:  Prepare build artifact
-        if: always()
         run:   tar -cvf bin.tar bin
       - name: Upload build artifact
-        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: windows-bin
           path: bin.tar
-      - name: Fail if rust tests failed
-        if: steps.rust-tests.outcome == 'failure'
-        run: exit 1
   windows-pester:
     needs: windows-build
     strategy:

From 0160bd622782cb07f3ec246cdb11c05048d82b39 Mon Sep 17 00:00:00 2001
From: Steve Lee <slee@microsoft.com>
Date: Fri, 10 Jul 2026 10:50:53 -0700
Subject: [PATCH 3/3] remove used id

---
 .github/workflows/rust.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 0f6d1fd49..bc40ac391 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -53,7 +53,6 @@ jobs:
       - name: Install prerequisites
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
-        id: rust-tests
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
         uses: actions/upload-artifact@v4
@@ -138,7 +137,6 @@ jobs:
       - name: Install prerequisites
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
-        id: rust-tests
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
         uses: actions/upload-artifact@v4
@@ -227,7 +225,6 @@ jobs:
       - name: Install prerequisites
         run: ./build.ps1 -SkipBuild -Clippy  -Verbose
       - name: Build and test with code coverage
-        id: rust-tests
         run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
       - name: Upload coverage data
         uses: actions/upload-artifact@v4