From 553d1f5d69b4a9f1903403ee23eb1fdf71250715 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 18 Aug 2026 02:08:19 +0000 Subject: [PATCH 1/2] Initial plan From 1ccae372a1660ed2640e3c6d5e36d9c1ef585cb7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 18 Aug 2026 02:11:21 +0000 Subject: [PATCH 2/2] Fix: throw on non-2xx responses in RequestHelper instead of returning undefined Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> --- src/helpers/requestHelper.ts | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/helpers/requestHelper.ts b/src/helpers/requestHelper.ts index 2d7ab2a..992cfff 100644 --- a/src/helpers/requestHelper.ts +++ b/src/helpers/requestHelper.ts @@ -1,5 +1,5 @@ import * as vscode from "vscode"; -import fetch from "node-fetch"; +import fetch, { Response } from "node-fetch"; import { v4 as uuid } from "uuid"; import { apiPartUrl, connectionCurrentStoreKey, customDataverseClientId, LoginTypes, maxRetries } from "../utils/Constants"; import { IConnection } from "../utils/Interfaces"; @@ -46,7 +46,7 @@ export class RequestHelper { throw new Error("Unable to finish the requested query"); } } else { - return undefined; + await this.raiseResponseError(response); } } } catch (err) { @@ -88,7 +88,7 @@ export class RequestHelper { throw new Error("Unable to finish the requested query"); } } else { - return undefined; + await this.raiseResponseError(response); } } } catch (err) { @@ -129,7 +129,7 @@ export class RequestHelper { throw new Error("Unable to finish the requested query"); } } else { - return undefined; + await this.raiseResponseError(response); } } } catch (err) { @@ -137,6 +137,19 @@ export class RequestHelper { throw err; } } -} -async function redirectTimeout(): Promise {} + private async raiseResponseError(response: Response): Promise { + let message = `Request failed with status ${response.status}`; + try { + const body = (await response.json()) as { error?: { code?: string; message?: string } }; + if (body?.error?.message) { + message = body.error.message; + } else if (body?.error?.code) { + message = `Error code: ${body.error.code}`; + } + } catch { + // ignore JSON parse errors; use the default message + } + throw new Error(message); + } +}