[BUG]: Windows CloseHandle called twice in cthreads_thread_join

[TCWORLD]

CThreads commit

c225bf9

Description

When joining threads on Windows, the process crashes in the final call to cthreads_thread_detach with exception that the thread handle has already been closed.

Looking at the code, it seems a call to CloseHandle was recently added to cthreads_thread_join:

CThreads/cthreads.c

Lines 126 to 130 in c225bf9

	CloseHandle(handle);
	if (code) *(void **)code = (void *)(uintptr_t)exit_code;
	return cthreads_thread_detach(thread);

However on the final return call through cthreads_thread_detach, the CloseHandle function is called a second time.

Removing line 126 above fixes the problem.

Steps to reproduce

1. Compile for windows.
2. Create a thread using cthreads_thread_create with default attributes.
3. Have the thread function simply return
4. Call cthreads_thread_join from the main thread.
5. Exception occurs.

Example code

No response

Confirmations

• My environment meets the minimum requirements.
• I have verified that this is not a duplicate issue.

[ThePedroo]

Thanks for the report. I'll take a better look soon, but I should be checking if (opened) before CloseHandle, since if so, it has been copied.

[TCWORLD]

• cthreads_thread_detach doesn't check if opened, it just calls CloseHandle.
• cthreads_thread_join does check if opened, and then if open calls CloseHandle before calling cthreads_thread_detach which closes the handle a second time.