Cache radius jewel tooltip outputs

Reuse full radius jewel comparison outputs while the build output
revision is unchanged. This reduces repeated Compare-tab hover work for
slotOnlyTooltips=OFF without caching cloned specs or changing comparison
behavior.

Author: mcagnion

spec/System/TestRadiusJewelStatDiff_spec.lua

@@ -753,4 +753,54 @@ describe("TestRadiusJewelStatDiff", function()
 			"temporary tooltip specs should still refresh jewel socket distances used by calc")
 	end)
 
+	it("AddItemTooltip reuses full radius jewel comparison outputs until output changes", function()
+		local spec, sockets = setupAllocatedSockets(2)
+
+		local item = newCustomLeapJewel("Cached Full Leap")
+		local slot = equipJewelInSocket(item, sockets[1])
+		spec:BuildAllDependsAndPaths()
+		runCallback("OnFrame")
+
+		local originalSlotOnlyTooltips = main.slotOnlyTooltips
+		main.slotOnlyTooltips = false
+		build.itemsTab.jewelComparisonOutputCache = nil
+		build.itemsTab.targetedJewelComparisonSpecCache = nil
+
+		local originalGetMiscCalculator = build.calcsTab.GetMiscCalculator
+		local calcCalls = 0
+		build.calcsTab.GetMiscCalculator = function(self, ...)
+			local calcFunc, calcBase = originalGetMiscCalculator(self, ...)
+			return function(...)
+				calcCalls = calcCalls + 1
+				return calcFunc(...)
+			end, calcBase
+		end
+
+		local ok, err = pcall(function()
+			local tooltip = new("Tooltip")
+			build.itemsTab:AddItemTooltip(tooltip, item, slot)
+			local firstPassCalcCalls = calcCalls
+			assert.is_true(firstPassCalcCalls > 0,
+				"full radius jewel tooltip should calculate outputs on first pass")
+
+			tooltip = new("Tooltip")
+			build.itemsTab:AddItemTooltip(tooltip, item, slot)
+			local secondPassCalcCalls = calcCalls - firstPassCalcCalls
+			assert.is_true(secondPassCalcCalls < firstPassCalcCalls,
+				"full radius jewel tooltip should reuse cached radius outputs on second pass")
+
+			build.outputRevision = build.outputRevision + 1
+			local beforeInvalidationCalcCalls = calcCalls
+			tooltip = new("Tooltip")
+			build.itemsTab:AddItemTooltip(tooltip, item, slot)
+			assert.is_true(calcCalls - beforeInvalidationCalcCalls > secondPassCalcCalls,
+				"full radius jewel output cache should reset when output changes")
+		end)
+		build.calcsTab.GetMiscCalculator = originalGetMiscCalculator
+		main.slotOnlyTooltips = originalSlotOnlyTooltips
+		if not ok then
+			error(err)
+		end
+	end)
+
 end)

src/Classes/ItemsTab.lua

@@ -4228,6 +4228,37 @@ local function itemChangesPassiveTree(item)
 			and (item.jewelData.intuitiveLeapLike or item.jewelData.impossibleEscapeKeystone)))
 end
 
+local function getStoredItemId(itemsTab, item)
+	if not item then
+		return ""
+	end
+	local itemId = item.id
+	if itemId and itemsTab.items[itemId] == item then
+		return tostring(itemId)
+	end
+end
+
+local function getJewelComparisonOutputCache(itemsTab)
+	local outputRevision = itemsTab.build and itemsTab.build.outputRevision or 0
+	local cache = itemsTab.jewelComparisonOutputCache
+	if not cache or cache.outputRevision ~= outputRevision then
+		cache = {
+			outputRevision = outputRevision,
+			outputs = { },
+		}
+		itemsTab.jewelComparisonOutputCache = cache
+	end
+	return cache
+end
+
+local function getJewelComparisonOutputCacheKey(itemsTab, compareSlot, replacementItem)
+	local replacementItemId = getStoredItemId(itemsTab, replacementItem)
+	if not replacementItemId then
+		return
+	end
+	return tostring(compareSlot.slotName) .. ":" .. tostring(compareSlot.nodeId or "") .. ":" .. tostring(compareSlot.selItemId or "") .. ":" .. replacementItemId
+end
+
 -- These jewels can replace passive nodes or disconnect allocated passives, so
 -- rebuild the passive tree before comparing their stats.
 -- Keep this list in sync with PassiveSpec's constructor, Init, and Select*
@@ -5079,13 +5110,27 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode, maxWidth)
 
 		tooltip:AddLine(14, colorCodes.TIP .. "Tip: Press Ctrl+D"..itemTabHint.." to disable the display of stat differences.")
 
-		local function getReplacedItemAndOutput(compareSlot, selItem, useJewelComparisonSpecCache)
+		local function getReplacedItemAndOutput(compareSlot, selItem, useJewelComparisonSpecCache, useJewelComparisonOutputCache)
 			selItem = selItem or self.items[compareSlot.selItemId]
 			local override = { repSlotName = compareSlot.slotName, repItem = item ~= selItem and item or nil }
+			local outputCache
+			local outputCacheKey
 			if compareSlot.nodeId and (itemChangesPassiveTree(selItem) or itemChangesPassiveTree(item)) then
+				if useJewelComparisonOutputCache then
+					outputCacheKey = getJewelComparisonOutputCacheKey(self, compareSlot, override.repItem)
+					if outputCacheKey then
+						outputCache = getJewelComparisonOutputCache(self)
+						if outputCache.outputs[outputCacheKey] then
+							return selItem, outputCache.outputs[outputCacheKey]
+						end
+					end
+				end
 				override.spec = buildSpecForJewelComparison(self, compareSlot, override.repItem, useJewelComparisonSpecCache)
 			end
 			local output = calcFunc(override)
+			if outputCacheKey then
+				outputCache.outputs[outputCacheKey] = output
+			end
 			return selItem, output
 		end
 		local function addCompareForSlot(compareSlot, selItem, output, useJewelComparisonSpecCache)
@@ -5127,7 +5172,7 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode, maxWidth)
 		local slots = {}
 		for _, slotEntry in ipairs(slotCandidates) do
 			if not isLimitedUniqueAtLimit or slotEntry.isSameUnique then
-				local _, output = getReplacedItemAndOutput(slotEntry.compareSlot, slotEntry.selItem)
+				local _, output = getReplacedItemAndOutput(slotEntry.compareSlot, slotEntry.selItem, nil, true)
 				slotEntry.output = output
 				table.insert(slots, slotEntry)
 			end