From 3c74b9daf052a15324a45016ce6f3d65ab51b0da Mon Sep 17 00:00:00 2001
From: prql-bot <107324867+prql-bot@users.noreply.github.com>
Date: Sun, 2 Aug 2026 17:15:37 +0000
Subject: [PATCH] ci: remove nightly-failure issue creation, let tend-ci-fix
 handle it
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The create-issue-on-nightly-failure job opens a triage issue (via the
prql-bot PAT so it cascades) on every nightly tests failure. That fires
tend-triage on issues:opened while tend-ci-fix independently fires on the
failed tests workflow_run — two workflows racing on the same root cause,
which produced duplicate fix PRs (#5959 / #5960).

tend-ci-fix already triggers on the failed tests run and, when it can't
produce a fix, now opens a deduplicated tracking issue itself, so the
nightly-health signal is preserved without the duplicate trigger.

Refs max-sixty/tend#627
---
 .github/nightly-failure.md   |  6 ------
 .github/workflows/tests.yaml | 28 ----------------------------
 2 files changed, 34 deletions(-)
 delete mode 100644 .github/nightly-failure.md

diff --git a/.github/nightly-failure.md b/.github/nightly-failure.md
deleted file mode 100644
index e8f38cfa58b3..000000000000
--- a/.github/nightly-failure.md
+++ /dev/null
@@ -1,6 +0,0 @@
----
-title: Nightly tests failed
-labels: github_actions
----
-
-Nightly tests [failed on {{ date | date('YYYY-MM-DD') }}]({{ env.LINK }})
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
index 75caaeb2d71b..9afee0405504 100644
--- a/.github/workflows/tests.yaml
+++ b/.github/workflows/tests.yaml
@@ -775,34 +775,6 @@ jobs:
       RUSTFLAGS: "-C debuginfo=0"
       RUSTDOCFLAGS: "-Dwarnings"
 
-  create-issue-on-nightly-failure:
-    runs-on: ubuntu-24.04
-    needs:
-      - check-ok-to-merge
-      - rules
-    if:
-      ${{ always() && contains(needs.*.result, 'failure') &&
-      needs.rules.outputs.nightly-upstream == 'true' }}
-    permissions:
-      contents: read
-      issues: write
-    steps:
-      - name: 📂 Checkout code
-        uses: actions/checkout@v7
-      - uses: JasonEtco/create-an-issue@v2
-        env:
-          # Use prql-bot PAT so that opening the issue triggers downstream
-          # workflows (notably tend-triage). Events from the default
-          # GITHUB_TOKEN do not cascade to other workflows.
-          GITHUB_TOKEN: ${{ secrets.TEND_BOT_TOKEN }}
-          LINK:
-            ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{
-            github.run_id }}
-        with:
-          filename: .github/nightly-failure.md
-          update_existing: true
-          search_existing: open
-
   update-rust-toolchain:
     runs-on: ubuntu-24.04
     needs: rules