Skip to content

Commit d4ffc06

Browse files
committed
revert mapping table fixes that should be implemented in the other pr
1 parent 7ae71de commit d4ffc06

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

petab/v2/lint.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1057,15 +1057,11 @@ def get_valid_parameters_for_parameter_table(
10571057
# aliases an invalid PEtab ID? See
10581058
# https://github.com/PEtab-dev/libpetab-python/pull/482#discussion_r3420762034
10591059
for mapping in problem.mappings:
1060-
if mapping.petab_id not in invalid:
1060+
if mapping.model_id and mapping.model_id in parameter_ids.keys():
10611061
parameter_ids[mapping.petab_id] = None
1062-
# An aliased model id is not a valid parameter id
1063-
if (
1064-
mapping.model_id
1065-
and mapping.model_id != mapping.petab_id
1066-
and mapping.model_id in parameter_ids
1067-
):
1068-
del parameter_ids[mapping.model_id]
1062+
# An aliased model id is not a valid parameter id
1063+
if mapping.model_id in parameter_ids:
1064+
del parameter_ids[mapping.model_id]
10691065

10701066
# add output parameters from observable table
10711067
output_parameters = problem.get_output_parameters()

0 commit comments

Comments
 (0)