"MaterialSystem Funny"

[ThisAMJ]

There are common crashes in sourcemods (or any mods really) with especially large/complex maps due to the default memory allocation to the material system being only 2MB of memory. I made a plugin a while back that patches this and am willing for it to be added here

Read more at the plugin's repo

Motivation (TWP discord)

[OrsellGit]

Hi @ThisAMJ, I recall seeing your messages in TWP and had planned to ask if I could implement what you did in P2SM. I'm glad to know that you're interested in helping me.

[OrsellGit]

Question @ThisAMJ, if I understand what your plugin does correctly:

1. Plugin checks if the memory value has been patched. If it hasn't, plugin virtual protects replacing the value.
2. The plugin must assume CMatRenderContextBase has been initialized already, so it shuts it down and reinitalizes it so it uses the new value.

Is this correct?

[ThisAMJ]

That's correct on both counts.

1. It does this so that other plugins (which may load sooner) that perform the same patch (e.g. SAR, SMSM) don't cause it to break.

2. Yes, it assumes sm_RenderData is already initialised. In my testing this was always true no matter how you load the plugin. If it weren't, we'd probably fail earlier by not finding the MaterialSystem module. But if you want to be extra safe you could also find sm_nInitializeCount and check it before doing anything.

[OrsellGit]

In code, Valve does check sm_nInitializeCount already when the functions are called, so I believe it should be handled fine. But I do need to account for stuff SAR does if this ever gets used along with SAR. I was also gonna pull a lot of the fixes SAR does anyway. Does SAR have proper checks in case a plugin has already patched something SAR intends to patch? Because this plugin gets loaded before SAR does, because it has to be loaded not through VDFs.

[ThisAMJ]

SAR does have checks in place for all its patches, of which there arent too many (this, uncap chat time, allow chat when dead, portals through portals, checkstuck, aircontrol, floor reportals, portal colors, and some demo stuff)

Worst case, some functionality might go missing if the sigs arent found.